ah, right. perhaps that's not exactly something I can help them with
2020-05-21 14250, 2020
alastairp
oh, I remember the beginning of that discussion 👍
2020-05-21 14254, 2020
alastairp
(good morning)
2020-05-21 14202, 2020
yvanzo
mo’’in’ :)
2020-05-21 14202, 2020
v6lur has quit
2020-05-21 14222, 2020
yvanzo
it's mostly a navigation issue: their website classify artists by genre and only shows content associated with one genre, without option to see content associated to other genres.
2020-05-21 14207, 2020
shivam-kapila
After thinking about the classes throughout the night I think that I can clean up the code like this:
2020-05-21 14207, 2020
shivam-kapila
1. Keep the formatting part totally away from the db/feedback.py. Standardize the response from DV using the dict and fetchall()
2020-05-21 14207, 2020
shivam-kapila
2. Make a class Feedback inspired from Listen class to standardize what does into the DB.
2020-05-21 14216, 2020
shivam-kapila
3. Make separate APIResponse classes for the two type of responses.
2020-05-21 14216, 2020
shivam-kapila
This is what I have in mind till now. alastairp: ruaok: iliekcomputers: How does this sound ^^.
2020-05-21 14213, 2020
shivam-kapila
Things were getting messy I believe
2020-05-21 14224, 2020
alastairp
I think iliekcomputers was right when he suggested opening a PR with a more end-to-end process, including an API endpoint or web view. it's still not 100% clear exactly what data you need at which point
2020-05-21 14241, 2020
shivam-kapila
Exactly
2020-05-21 14248, 2020
alastairp
I don't have time this morning to look into this in more detail, but I think you might not need 3
2020-05-21 14205, 2020
shivam-kapila
I will not do all of this in one PR
2020-05-21 14221, 2020
alastairp
my idea is that db.feedback methods will return a specific Feedback class, or a dictionary
2020-05-21 14231, 2020
shivam-kapila
Just implement 1. in current PR.
2020-05-21 14242, 2020
alastairp
the api view can format that into the correct json structure for the API
2020-05-21 14247, 2020
alastairp
I think this is all that's needed
2020-05-21 14254, 2020
shivam-kapila
Yeah same in my mind
2020-05-21 14233, 2020
shivam-kapila
Format for API in the API pr and keep that separate from the current one
2020-05-21 14244, 2020
alastairp
also, be careful about 2. "inspired from Listen class". this should be inspired only in that "we have a class"
pristine__: hey, I'm reading your PR. remind me, how do we calculate candidate sets right now? Using artist relations, yes?
2020-05-21 14244, 2020
pristine__
Yes.
2020-05-21 14246, 2020
ruaok
ok, cool. I have a feeling that the recommendation toolkit will evolve that process and find other ways to create candidate sets. but, that doesn't change anything in your PR right now.
2020-05-21 14210, 2020
pristine__
The idea of having many ways to create candidate sets and issue commands accordingly sounds good :)
2020-05-21 14229, 2020
pristine__
the recommendation engine will be deployed this week hopefully.
2020-05-21 14235, 2020
ruaok
good. I think that will be really useful for doing so in the toolkit.
2020-05-21 14238, 2020
ruaok
exciting!!
2020-05-21 14248, 2020
ruaok
next week might be really interesting. :)
2020-05-21 14237, 2020
pristine__
ruaok: Are we working on incremental artist relations and mapping?
2020-05-21 14258, 2020
ruaok
incremental? as in incremental updates?
2020-05-21 14227, 2020
pristine__
Yeah
2020-05-21 14245, 2020
ruaok
No. Those will be generated wholly new each time.
2020-05-21 14213, 2020
pristine__
Right.
2020-05-21 14226, 2020
pristine__
I understand that for artist relations since similarity should be recomputed each time, scores may change.
2020-05-21 14227, 2020
pristine__
But why to generate wholly for mapping? Will the exist mapping change? ( just thinking out loud)
2020-05-21 14227, 2020
ruaok
both the MSB mapping the the artist relations are just easier to calculate wholly new than to figure out incremental changes.
2020-05-21 14230, 2020
pristine__
existing*
2020-05-21 14243, 2020
ruaok
doing it incrementally would be much more work, so just re-generate.
