Mr_Monkey is working on brainzplayer. how does that interact with the user profile and the embedded player there?
2020-05-22 14325, 2020
ruaok
thanks ishaanshah
2020-05-22 14300, 2020
alastairp
merçi
2020-05-22 14347, 2020
ruaok
so, here is one thing I didn't originally hear about the patent case against Gnome being settled:
2020-05-22 14308, 2020
ruaok
They filed a counter suit against the troll and like us, kept up the pressure.
2020-05-22 14324, 2020
ruaok
when the other side wanted bail, they still had to content with the counter suit.
2020-05-22 14303, 2020
ruaok
the only way that gnome would agree to drop the suit was that the troll had to agree to not sue projects using open source lisences.
2020-05-22 14333, 2020
ruaok
the troll agreed and open source is now safe from that troll.
2020-05-22 14336, 2020
ruaok
how cool is that?
2020-05-22 14329, 2020
ruaok starts breaking up the virtual chocolate
2020-05-22 14346, 2020
iliekcomputers puts on Radiohead to get ready
2020-05-22 14349, 2020
iliekcomputers
🤣
2020-05-22 14356, 2020
ruaok
🔫
2020-05-22 14339, 2020
ruaok
aight. ishaanshah, shivam-kapila you folks here?
2020-05-22 14344, 2020
shivam-kapila
Yo
2020-05-22 14359, 2020
ishaanshah
Hi!
2020-05-22 14304, 2020
ruaok
Mr_Monkey: ?
2020-05-22 14307, 2020
Mr_Monkey
Yup
2020-05-22 14326, 2020
ruaok
aight. alastairp will likely read the notes after we close, because that is how he rolls.
2020-05-22 14353, 2020
ruaok
if you have things you wish to discuss about, add them there.
2020-05-22 14316, 2020
ruaok
and maybe there are no questions, so we'll have a short meeting. :)
2020-05-22 14335, 2020
alastairp
...
2020-05-22 14347, 2020
ruaok
🤣
2020-05-22 14308, 2020
alastairp
gotta keep up my reputation. I guess I'll just go and do something else during the meeting
2020-05-22 14320, 2020
ruaok
in particular, if you look at shivam-kapila's proposal...
2020-05-22 14328, 2020
Mr_Monkey
So both projects seem pretty clear to me, both in their intent and the UI mockups
2020-05-22 14332, 2020
ruaok
page 5.
2020-05-22 14348, 2020
ruaok
yes, we made sure they were before accepting them. :)
2020-05-22 14303, 2020
ruaok
my question that is unclear right now, is this:
2020-05-22 14324, 2020
ruaok
the graphs shown on the profile page -- are the API endpoints being finished right now sufficient for this task?
2020-05-22 14348, 2020
ruaok
how can we share components? are react components usable by shivam-kapila part of ishaanshah's project?
2020-05-22 14334, 2020
iliekcomputers
The React components are definitely reusable
2020-05-22 14356, 2020
alastairp
is this specifically the "you listened to x songs" and "your listening trends" ?
2020-05-22 14307, 2020
Mr_Monkey
And that's likely the best way to go: make separate graph components that can be integrated in various pages. Same goes for the BrainzPlayer
2020-05-22 14311, 2020
ruaok
are there any action items on shivam-kapila's plate relating to this, other than including said components on the page?
2020-05-22 14319, 2020
ruaok
alastairp: yes.
2020-05-22 14327, 2020
ruaok
and whatever else we want there, I suppose.
2020-05-22 14324, 2020
ruaok
and if shivam-kapila finds that something is not fully suitable for the page, how do we go about resolving that?
2020-05-22 14343, 2020
iliekcomputers
There probably will have to be some tweaks to make the components fit well, but I think it'll be a very small piece of work eventually.
2020-05-22 14304, 2020
alastairp
does it seem like there are 2 categories of stats? (shivam-kapila: overview, ishaanshah: detailed)?
2020-05-22 14317, 2020
iliekcomputers
alastairp: I think so, yeah.
2020-05-22 14322, 2020
shivam-kapila
yes
2020-05-22 14327, 2020
ruaok
ok, then from shivam-kapila's side there isn't much to do, except for the integration and follow up in case things need tweaking, is that right?
2020-05-22 14330, 2020
Mr_Monkey
Graph components should be a separate PR so that both can collaborate on it, and once merged they can be tweaked independently of the other projects
2020-05-22 14344, 2020
alastairp
in which case, maybe the specific details of "who makes stat x" isn't as important
2020-05-22 14307, 2020
alastairp
but perhaps making sure they're working with the same components (graphing library, api format) is enough
2020-05-22 14320, 2020
ruaok
alastairp: well, I don't want shivam-kapila to have to dive into graphs and I don't want ishaanshah to have to drive into profile design stuff.
2020-05-22 14340, 2020
alastairp
ah, right
2020-05-22 14355, 2020
ruaok
each team working to their strengths will get us there faster.
2020-05-22 14357, 2020
iliekcomputers
Mr_Monkey: we're doing separate PRs for Graphs already, and I agree it's a good idea.
2020-05-22 14330, 2020
ruaok
ishaanshah: when reviewing these graph PRs can you please request reviews from Mr_Monkey and myself as well?
2020-05-22 14339, 2020
ruaok
that way we can stay in the loop on what is going on.
2020-05-22 14345, 2020
ishaanshah
Yeah sure
2020-05-22 14355, 2020
ishaanshah
One, thing that I would like to say is that I designed the Mock UI in my proposal with the current UI in mind.
2020-05-22 14315, 2020
ruaok
"current UI" meaning the current profile pages?
2020-05-22 14319, 2020
Mr_Monkey
Perhaps the graph components should have extra options to be determined (for example to allow overview or details), but that complicates them (and the process) a bit.
2020-05-22 14324, 2020
ishaanshah
yeah
2020-05-22 14337, 2020
iliekcomputers
Can we also agree that all major frontend changes should have screenshots / videos so that they're easy to review.
2020-05-22 14345, 2020
Mr_Monkey
+1
2020-05-22 14346, 2020
ruaok
ishaanshah: ah, good. this meeting is perfect for addressing that.
2020-05-22 14351, 2020
ruaok
+1
2020-05-22 14306, 2020
diru1100
Leo_Verto: Hey, I was checking out your data generation code. Shouldn't the website_domain use a different tokenzer in preprocess_editor funciton if am not wrong?
2020-05-22 14307, 2020
ruaok
ishaanshah: how do you see the profile page redesign impacting the stats pages?
2020-05-22 14329, 2020
shivam-kapila
ruaok: Inconsistency in UI across website
2020-05-22 14347, 2020
Leo_Verto
diru1100: yeah, I noticed that typo too. changing that will require retraining though
2020-05-22 14348, 2020
shivam-kapila
Some page having totally different designs than the other
2020-05-22 14357, 2020
ishaanshah
That and width considerations
2020-05-22 14311, 2020
ruaok
shivam-kapila: ok, makes sense. I think we should address that issue next.
2020-05-22 14319, 2020
ishaanshah
the side bar takes up considerable amount of screen real estate
2020-05-22 14357, 2020
ruaok
shall we move on to talk about the profile UI?
2020-05-22 14302, 2020
Mr_Monkey
For width considerations, I think graph components should fit their parent container, so that the page that uses them can define dimensions.
2020-05-22 14304, 2020
ruaok
2.b then.
2020-05-22 14314, 2020
ruaok
Mr_Monkey: +1
2020-05-22 14326, 2020
diru1100
Leo_Verto: That's ok ig, since I have to retrain the model with synthetic data anyway :)
2020-05-22 14352, 2020
ruaok
page 5 of shivam-kapila's proposal shows the propose new UI.
ishaanshah: Are you worried about screen real estate?
2020-05-22 14353, 2020
iliekcomputers
That sounds good to me.
2020-05-22 14302, 2020
ishaanshah
No, not worried
2020-05-22 14321, 2020
Leo_Verto
diru1100: what do you think about online training so far? do you you reckon it's possible with keras?
2020-05-22 14334, 2020
ishaanshah
Just wanted to mention that the mock UI that I provided would have to be tweaked a bit
2020-05-22 14343, 2020
ishaanshah
I will do that next week
2020-05-22 14355, 2020
Mr_Monkey
Something to keep in mind, I agree. But I think your mockup will work fine with the new stats page design
2020-05-22 14302, 2020
iliekcomputers
We'll work on the stats page individually and the profile page redesign should take care of the sidebar.
2020-05-22 14306, 2020
ruaok
diru1100: Leo_Verto: can you please let us have the channel for a moment?
2020-05-22 14306, 2020
Mr_Monkey
👍
2020-05-22 14313, 2020
iliekcomputers
Is that an acceptable way forward?
2020-05-22 14322, 2020
ruaok
happy with that.
2020-05-22 14327, 2020
ishaanshah
Yep
2020-05-22 14351, 2020
Leo_Verto
sorry, of course
2020-05-22 14352, 2020
iliekcomputers
Sgtm.
2020-05-22 14357, 2020
ruaok
I guess that closes how we deal with stats, which takes care of the right column of the mock-up.
2020-05-22 14309, 2020
ruaok
lets talbk about the UI in general.
2020-05-22 14314, 2020
ruaok
talk, even.
2020-05-22 14323, 2020
ruaok
who here HATES it?
2020-05-22 14333, 2020
ruaok
anyone dislike it?
2020-05-22 14339, 2020
Mr_Monkey
I think it's a huge improvement
2020-05-22 14343, 2020
ruaok
if you like it, what do you dislike about it?
2020-05-22 14312, 2020
ruaok
I don't necessarily want to engage in a complete review/redesign right now, but if Mr_Monkey hates it, we have a problem.
2020-05-22 14321, 2020
shivam-kapila
> if you like it, what do you dislike about it?
2020-05-22 14321, 2020
shivam-kapila
Not dislike but I am a lil worried about the sidebar responsiveness
2020-05-22 14322, 2020
ruaok
this is supposed to be more of a sanity check than anything else.
2020-05-22 14333, 2020
Mr_Monkey
I think we'll definitely want a toned-down version of the graphs (overview, very limited details) in order not to have the dashboard be too busy
2020-05-22 14359, 2020
ruaok
Mr_Monkey: ah, thats the sort of thing I am worried about.
2020-05-22 14324, 2020
ruaok
so far we've said that we can just shrink down ishaanshah's graphs, now we are already steering towards modifications.
2020-05-22 14342, 2020
ruaok
not that I disagree with your sentiment.
2020-05-22 14350, 2020
ishaanshah
ig there is only one graph on the dashboard right
2020-05-22 14354, 2020
Mr_Monkey
Well, I did suggest earlier an option to have overview or detailed graphs
2020-05-22 14305, 2020
ruaok
I think the graphs that ishaanshah is proposing are sexy, but that would be too much on the profile page. maybe.
2020-05-22 14326, 2020
ishaanshah
So making another one for the profile one would be acceptable
2020-05-22 14336, 2020
Mr_Monkey
But I also think they'll be easily tweakable if that's the case, so not a blocker
2020-05-22 14350, 2020
ruaok
ishaanshah: I have a feeling that users will want to choose what to show there. maybe not right away, but before to olong.
2020-05-22 14307, 2020
shivam-kapila
+1 to that
2020-05-22 14312, 2020
iliekcomputers
Show on the profile page?
2020-05-22 14316, 2020
ishaanshah
Oh :D
2020-05-22 14336, 2020
ruaok
iliekcomputers: yes.
2020-05-22 14359, 2020
ruaok
would it be too much to ask to have each graph come in two forms? detailed and simple?
2020-05-22 14307, 2020
iliekcomputers
I'd say that that is a huge enough project to do right that we shouldn't worry too much about it right this second.
2020-05-22 14309, 2020
iliekcomputers
Yes.
2020-05-22 14332, 2020
iliekcomputers
I don't think we'll have capacity for maintaining two of each.
2020-05-22 14340, 2020
ruaok
so then we should say that ishaanshah will provide one less detailed version for now.
2020-05-22 14354, 2020
ruaok
and once we get user feedback we can figure out next steps.
2020-05-22 14306, 2020
ishaanshah
ruaok: I added a topic on the agenda, not very important rn but worth discussing
2020-05-22 14327, 2020
ruaok
but we can't do that after virtual chocolate!
2020-05-22 14332, 2020
ruaok
thanks Mr_Monkey
2020-05-22 14336, 2020
iliekcomputers
Yeah, that sounds good to me. We also have the API endpoints, so people can technically build their own dashboards as well. ;)
2020-05-22 14357, 2020
ruaok
yes, I suspect that people will dive in and help.
2020-05-22 14309, 2020
ishaanshah
Sounds like a task for next summer :D
2020-05-22 14310, 2020
ruaok
ok, lets move on to the next part.
2020-05-22 14321, 2020
ruaok
brainzplayer UI.
2020-05-22 14350, 2020
ruaok
Mr_Monkey: tell us, please, what your plan for the UI for the player is and how you see it interacting with the profile pages.
2020-05-22 14320, 2020
Mr_Monkey
So the stuff I've been working on doesn't really change the UI of the player compared to what's deployed
2020-05-22 14336, 2020
ruaok
it is all UI less?
2020-05-22 14352, 2020
Mr_Monkey
I do like the toned-down version in the dashboard mockup, I think it would fit better than the existing one
2020-05-22 14301, 2020
ruaok
+1
2020-05-22 14327, 2020
Mr_Monkey
I did like the size of the album art in the existing page, but it'll be really busy for the dashboard.
2020-05-22 14342, 2020
ruaok
how does the brainzplayer work right now? lets say I a page and want to use brainzplayer. what must I do?
2020-05-22 14315, 2020
Mr_Monkey
Can you rephrase please?
2020-05-22 14345, 2020
ruaok
let's say that alastairp wants to embed the brainzplayer into AB.
2020-05-22 14301, 2020
ruaok
what UI elements are necessary in order to make the BrainzPlayer work?
2020-05-22 14301, 2020
alastairp
that was exactly the example I was going to give!
2020-05-22 14306, 2020
Mr_Monkey
OK. That's another story. I'm not 100% certain of how this will work. I think it would be great if we could just POST to listtenbrainz and get returned a page with just the player, pop that into an iframe on your website, and voilà.
2020-05-22 14331, 2020
Mr_Monkey
I haven't tried that, so I'm not 100% confident, but I think it's a good way to go.
2020-05-22 14300, 2020
Mr_Monkey
That does suggest we might want to show the "playlist" along with the player.
2020-05-22 14312, 2020
ruaok
this is what i am getting at, I suppose.
2020-05-22 14315, 2020
alastairp
and what about return(<BrainzPlayer tracks=[tracklist]>) in react?
