I'm going to try and make a more user friendly version now
2020-05-26 14746, 2020
ZaphodBeeblebrox
<3<3
2020-05-26 14759, 2020
ZaphodBeeblebrox
deff think we need this before it goes to prod
2020-05-26 14704, 2020
sumedh joined the channel
2020-05-26 14704, 2020
Mr_Monkey
For the amount of work it should make it before pushing to prod I think
2020-05-26 14712, 2020
ZaphodBeeblebrox
(if oyu really want my opinion on this)
2020-05-26 14714, 2020
BrainzGit
[listenbrainz-server] ishaanshah opened pull request #876 (master…artist_time_range): [WIP]LB-596, LB-593: Update frontend to show different time ranges for artist stats https://github.com/metabrainz/listenbrainz-server…
And I was looking at showing th efull history for merged entities; might not be as tricky as I thought, but it won't necessarily be super clear which entity was which.. I'll try that out
2020-05-26 14716, 2020
ZaphodBeeblebrox
hmm there is a n unreleased fix version "september 2016" probably shoudl be "released" ?
2020-05-26 14742, 2020
Mr_Monkey must admit he hasn't looked into that
2020-05-26 14746, 2020
ZaphodBeeblebrox
aha
2020-05-26 14703, 2020
ZaphodBeeblebrox
for isnt i use fix versions to group tickets that are "activly gonig ot be worked on"
2020-05-26 14710, 2020
ZaphodBeeblebrox
fo *INST*
2020-05-26 14707, 2020
Leftmost
Trying to build the BB docker image and getting a persistent npm error. The official recommendation seems to be to use a newer npm, which presumably requires a newer base image.
2020-05-26 14740, 2020
ZaphodBeeblebrox
for example we could have a "out of beta" fix version for tickets that *must* be doen before it's .. that finished producti thingy or what it was claled
2020-05-26 14749, 2020
Mr_Monkey
Leftmost: Could you post the error log please?
2020-05-26 14719, 2020
ZaphodBeeblebrox
we have a component "merging2 we could have a component version for tickets that are related to the merging tool that we *should* finish before prod (for example)
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews, Sockpuppet/system gaming MeB CoC clause [ORG-40] (Freso), JIRA date format stuff (CatCat) OTHER-360 / OTHER-361,
2020-05-26 14712, 2020
Leftmost
Mr_Monkey, all I get from docker output is "npm ERR! cb() never called!" and I can't find an npm log in the workdir of the container.
2020-05-26 14733, 2020
Mr_Monkey
Hmm. I'll try to built the image from scratch
2020-05-26 14743, 2020
ruaok waves at Leftmost
2020-05-26 14752, 2020
Leftmost waves at ruaok
2020-05-26 14752, 2020
ZaphodBeeblebrox waves leftmost
2020-05-26 14708, 2020
Leftmost waves ZaphodBeeblebrox
2020-05-26 14715, 2020
ZaphodBeeblebrox
...
2020-05-26 14713, 2020
ZaphodBeeblebrox
see that's not a pun 🧐
2020-05-26 14734, 2020
Leftmost
I know, but it lines up nicely in a monospace font.
2020-05-26 14721, 2020
Leftmost
If I commit the failed container to an image, attach to it, and run the install, it works fine. That's fun.
2020-05-26 14743, 2020
ruaok
Freso: exporting listens from test.lb.org works now
2020-05-26 14753, 2020
Mr_Monkey
Welp ZaphodBeeblebrox looks like it's actually super easy to show the history of all merged entities. I'll create a PR now and soon push to beta.
I was getting error. `user_collection_collaborator.id` do not exist
2020-05-26 14720, 2020
Mr_Monkey
Let me look at how the tables are defined
2020-05-26 14746, 2020
Mr_Monkey
Right, I see what's missing.
2020-05-26 14708, 2020
prabal
If you wish to create a belongsToMany association where the joining table has a primary key and extra attributes in the model, you may create a belongsToMany through relation:
2020-05-26 14714, 2020
prabal
This is there in bookshelf documentation
2020-05-26 14724, 2020
prabal
yeah?
2020-05-26 14707, 2020
prabal
joining table do not have a primary key in case of `UserCollectionCollaborator`. is the error because of this?
2020-05-26 14717, 2020
Mr_Monkey
I totally missed that. Her's an example of a table that has two foreig keys. What's missing for the collection items and collaborators tables is the PRIMARY KEY part
I'm very happy to see collections on the docket, especially since NGS collections was my GSoC project back in the day.
2020-05-26 14706, 2020
ZaphodBeeblebrox
ngs? you mena mb
2020-05-26 14721, 2020
ZaphodBeeblebrox
but yay
2020-05-26 14740, 2020
ZaphodBeeblebrox
book cllection is something that will *really* make people want ot use and add data to bb
2020-05-26 14740, 2020
Leftmost
MB had collections before I came around. Just that NGS didn't.
2020-05-26 14753, 2020
ZaphodBeeblebrox
... oohh that *ngs* i forgot what it stood for :P
2020-05-26 14719, 2020
ZaphodBeeblebrox
.. oh oh yea. it was pretty sucky. i thinkg it only had *one* collection and you couldn't subscribe
2020-05-26 14741, 2020
Mr_Monkey
What do you all think about having some pre-existing collections for each user, like "Want to read", "Have read"/ "My bookshelf" ?
2020-05-26 14721, 2020
ZaphodBeeblebrox
hm...
2020-05-26 14730, 2020
ZaphodBeeblebrox
personally i think those are annoying :D
2020-05-26 14735, 2020
ZaphodBeeblebrox
but i guess??
2020-05-26 14748, 2020
ZaphodBeeblebrox
as long as you can custmise/rename/delete them
2020-05-26 14711, 2020
Mr_Monkey
I see no reason why not
2020-05-26 14758, 2020
ZaphodBeeblebrox
looking forward to testing this ! 👍
2020-05-26 14720, 2020
Leftmost
I think at least starting out with one that can be renamed is a good choice. That lets people just start adding things and, if they want to do more sorting later, they can create more.
2020-05-26 14731, 2020
ZaphodBeeblebrox
+1 to that idea
2020-05-26 14753, 2020
ZaphodBeeblebrox
just name it "my booklist" or osmething
2020-05-26 14759, 2020
ZaphodBeeblebrox
or "owned books"
2020-05-26 14714, 2020
Mr_Monkey
"Hey, I have that!"
2020-05-26 14716, 2020
Mr_Monkey
:p
2020-05-26 14739, 2020
ZaphodBeeblebrox
I'm just going to name mine "owned" anyway (and then have one for deicman library)
2020-05-26 14743, 2020
ZaphodBeeblebrox
oh! i liek that :DDD
2020-05-26 14705, 2020
ZaphodBeeblebrox
hm. oh what about this are colelctinos public or private? you should be able to chose
2020-05-26 14729, 2020
ZaphodBeeblebrox
"Hey! I have this!"
2020-05-26 14737, 2020
ZaphodBeeblebrox
i might rename mine that :D
2020-05-26 14758, 2020
Mr_Monkey
Yes, you'll be able to choose public or private.
2020-05-26 14702, 2020
ZaphodBeeblebrox
sweet
2020-05-26 14742, 2020
Mr_Monkey
prabal: Some early user feedback about that idea we talked about ^
2020-05-26 14756, 2020
prabal
yeah :)
2020-05-26 14703, 2020
ZaphodBeeblebrox
what idea? ;*
2020-05-26 14724, 2020
Leftmost
Tried `--no-package-lock` as a wild shot but still no luck. npm is not fond of being run via dockerfile, it seems.
2020-05-26 14752, 2020
iliekcomputers
ishaanshah: hey, i'm around
2020-05-26 14711, 2020
ishaanshah
hi
2020-05-26 14754, 2020
iliekcomputers
How are you?
2020-05-26 14759, 2020
ishaanshah
Nice
2020-05-26 14711, 2020
ishaanshah
What about you?
2020-05-26 14717, 2020
iliekcomputers
can't complain.
2020-05-26 14729, 2020
iliekcomputers
how was the hackathon?
2020-05-26 14738, 2020
ishaanshah
Was really fun
2020-05-26 14750, 2020
ishaanshah
The last minute rush was awesome
2020-05-26 14756, 2020
Chinmay3199 has quit
2020-05-26 14728, 2020
ishaanshah
Learnt about hooks api in the process
2020-05-26 14737, 2020
ZaphodBeeblebrox
heh. amusingly yesterday while testing merging and whatnot. i came across an HP edition without an edition group. srsly!
2020-05-26 14757, 2020
ishaanshah
Found them pretty interesting
2020-05-26 14713, 2020
iliekcomputers
ooh nice
2020-05-26 14717, 2020
iliekcomputers
what'd you build?
2020-05-26 14712, 2020
ishaanshah
There's a street food centre near my college, so an app for people to post requests for food from their
2020-05-26 14733, 2020
ishaanshah
Nothing much, redis+flask for backend and react for frontend
2020-05-26 14702, 2020
iliekcomputers
cool cool cool
2020-05-26 14705, 2020
ishaanshah
LB docker-compose files helped :D
2020-05-26 14714, 2020
iliekcomputers
heh, i do that a lot too
2020-05-26 14751, 2020
iliekcomputers
ok, so about planning, i think this week will be fairly straightforward.
2020-05-26 14722, 2020
iliekcomputers
let's try to add the graphs to the frontend this week.
