#metabrainz

/

      • ishaanshah
        iliekcomputers: it seems that beta-api is the issue
      • 2020-06-01 15328, 2020

      • ishaanshah
      • 2020-06-01 15353, 2020

      • ishaanshah
        Even this doesn't return access-origin-control header
      • 2020-06-01 15300, 2020

      • iliekcomputers
        oh. ok. that means that this should be fixed in prod
      • 2020-06-01 15311, 2020

      • ishaanshah
        Yep
      • 2020-06-01 15313, 2020

      • iliekcomputers
        can you comment this to the ticket? I'll deploy it then
      • 2020-06-01 15326, 2020

      • ishaanshah
        Ok will do
      • 2020-06-01 15354, 2020

      • ishaanshah
        Should I close the issue too?
      • 2020-06-01 15323, 2020

      • iliekcomputers
        i would keep it open, because we'll have to fix it in beta eventually
      • 2020-06-01 15349, 2020

      • shivam-kapila
        ruaok: 13 failing. Mostly 1!=5 errors as it fetched only 1 listen in 3 week window
      • 2020-06-01 15356, 2020

      • ruaok
        as I suspected.
      • 2020-06-01 15300, 2020

      • ishaanshah
        iliekcomputers: Done
      • 2020-06-01 15336, 2020

      • shivam-kapila
        ruaok: Do we need to adapt the tests or keep the old setup?
      • 2020-06-01 15307, 2020

      • CatQuest has left the channel
      • 2020-06-01 15328, 2020

      • ruaok
        I would much prefer to adapt tests. we've introduced a very low level requirement and we should test for it.
      • 2020-06-01 15342, 2020

      • CatQuest joined the channel
      • 2020-06-01 15342, 2020

      • CatQuest has quit
      • 2020-06-01 15342, 2020

      • CatQuest joined the channel
      • 2020-06-01 15356, 2020

      • shivam-kapila
        A simple fix can be to set time_range = -1 for tests.
      • 2020-06-01 15331, 2020

      • CatQuest has quit
      • 2020-06-01 15341, 2020

      • CatQuest joined the channel
      • 2020-06-01 15324, 2020

      • shivam-kapila
        Another one could be to add a new test. Keep the old ones as it is and add a new test for largely spaced listens.
      • 2020-06-01 15346, 2020

      • shivam-kapila
        This sounds better to me though
      • 2020-06-01 15308, 2020

      • Nyanko-sensei has quit
      • 2020-06-01 15318, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 opened pull request #41 (master…circleci-project-setup): Setup CircleCI https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15339, 2020

      • Nyanko-sensei joined the channel
      • 2020-06-01 15357, 2020

      • jmp_music joined the channel
      • 2020-06-01 15340, 2020

      • iliekcomputers
        ishaanshah: question
      • 2020-06-01 15352, 2020

      • iliekcomputers
        if we return an iterator
      • 2020-06-01 15358, 2020

      • iliekcomputers
        shouldn't request consumer code just work
      • 2020-06-01 15311, 2020

      • iliekcomputers
      • 2020-06-01 15318, 2020

      • iliekcomputers
        this loop would still work
      • 2020-06-01 15310, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #886 (master…rec-docs): Documentation for generating recommendations. https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15327, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #887 (master…dependabot/pip/numpy-1.18.4): Bump numpy from 1.18.3 to 1.18.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15343, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #888 (master…dependabot/pip/flask-sqlalchemy-2.4.3): Bump flask-sqlalchemy from 2.4.1 to 2.4.3 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15301, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #889 (master…dependabot/pip/six-1.15.0): Bump six from 1.10.0 to 1.15.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15328, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #890 (master…dependabot/pip/pytest-5.4.2): Bump pytest from 5.4.1 to 5.4.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15303, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #891 (master…dependabot/pip/google-api-python-client-1.8.4): Bump google-api-python-client from 1.8.2 to 1.8.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15312, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #892 (master…dependabot/pip/fabric-2.5.0): Bump fabric from 1.10.2 to 2.5.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15332, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #893 (master…dependabot/pip/pytest-cov-2.9.0): Bump pytest-cov from 2.8.1 to 2.9.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15348, 2020

      • ruaok
        oh dependabot, how I didn't miss you.
      • 2020-06-01 15301, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #894 (master…dependabot/pip/sphinx-3.0.4): Bump sphinx from 3.0.3 to 3.0.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15317, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #895 (master…dependabot/pip/redis-3.5.2): Bump redis from 3.5.0 to 3.5.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15335, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 merged pull request #41 (master…circleci-project-setup): Setup CircleCI https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15339, 2020

      • yvanzo
        Hi Leo_Verto: Any idea why BrainzBot is silent since yesterday?
      • 2020-06-01 15352, 2020

      • Leo_Verto
        Hm, I didn't touch nomo in the last week. Checking right now.
      • 2020-06-01 15342, 2020

      • Leo_Verto
        !ping
      • 2020-06-01 15355, 2020

      • Leo_Verto
        BrainzBot: ping
      • 2020-06-01 15356, 2020

      • BrainzBot
        Are you in need of my services, Leo_Verto?
      • 2020-06-01 15313, 2020

      • ruaok
        you're a slacker, BrainzBot
      • 2020-06-01 15317, 2020

      • ruaok
        just like reosarevok
      • 2020-06-01 15336, 2020

      • Leo_Verto
        MBS-10870
      • 2020-06-01 15307, 2020

      • Leo_Verto
        Jira plugin might be broken, will investigate after lunch.
      • 2020-06-01 15330, 2020

      • Leo_Verto
        Looks like one of the certificate trust paths for tickets.meb.org failed https://www.ssllabs.com/ssltest/analyze.html?d=ti…
      • 2020-06-01 15305, 2020

      • Leo_Verto
        nomo still running on Ubuntu 14.04 probably doesn't have the other roots in its trust store
      • 2020-06-01 15306, 2020

      • Leo_Verto
        MBS-10870
      • 2020-06-01 15307, 2020

      • BrainzBot
        MBS-10870: Beta: Banner warning can't be hidden https://tickets.metabrainz.org/browse/MBS-10870
      • 2020-06-01 15303, 2020

      • Leo_Verto
        I temporarily disabled certificate verification in the jira plugin but this should be properly solved with the Impending Dockerization™
      • 2020-06-01 15339, 2020

      • ishaanshah
        iliekcomputers: We add some info to each message
      • 2020-06-01 15346, 2020

      • yvanzo
        Thank you!
      • 2020-06-01 15346, 2020

      • ishaanshah
        Not sure how we would do that
      • 2020-06-01 15308, 2020

      • ishaanshah
        Otherwise yes the loop will work
      • 2020-06-01 15321, 2020

      • iliekcomputers
        We could create a iterator over the spark iterator
      • 2020-06-01 15330, 2020

      • iliekcomputers
        Do you know about `yeild`
      • 2020-06-01 15352, 2020

      • ishaanshah
        no
      • 2020-06-01 15357, 2020

      • iliekcomputers
      • 2020-06-01 15329, 2020

      • iliekcomputers
        I think we could create a generator over the spark iterator and then return that
      • 2020-06-01 15348, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 opened pull request #42 (master…unit-tests): Add unit and instrumentation tests https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15313, 2020

      • ishaanshah
        Hmm, so in the create messages functions we `yeild` instead of `return`?
      • 2020-06-01 15359, 2020

      • iliekcomputers
        The yield should just return one message, not a list
      • 2020-06-01 15305, 2020

      • iliekcomputers
        But essentially, yes
      • 2020-06-01 15337, 2020

      • iliekcomputers
        Basically, get the spark iterator, get one message from it, yield it
      • 2020-06-01 15341, 2020

      • iliekcomputers
        And so on
      • 2020-06-01 15356, 2020

      • ishaanshah
      • 2020-06-01 15316, 2020

      • ishaanshah
        data is the spark iterator
      • 2020-06-01 15336, 2020

      • iliekcomputers
        Right, yep, something like that
      • 2020-06-01 15354, 2020

      • ishaanshah
        Cool, thanks, I will test this out
      • 2020-06-01 15300, 2020

      • ishaanshah
        Python is amazing :D
      • 2020-06-01 15310, 2020

      • rdswift
        <yvanzo> rdswift: Even if intentional, the current behavior might just need to be documented at least? That would help. Thanks.
      • 2020-06-01 15308, 2020

      • iliekcomputers
      • 2020-06-01 15328, 2020

      • iliekcomputers
        Now that I have to write lots of Ruby, I agree :D
      • 2020-06-01 15354, 2020

      • ishaanshah
        lol 🤣
      • 2020-06-01 15302, 2020

      • ruaok
        heh
      • 2020-06-01 15343, 2020

      • ishaanshah
        Agreed
      • 2020-06-01 15349, 2020

      • iliekcomputers
        Ah kids
      • 2020-06-01 15359, 2020

      • iliekcomputers
        Wait until you write code in a codebase without tests
      • 2020-06-01 15337, 2020

      • shivam-kapila
        Well tests are good if someone else writes them😌
      • 2020-06-01 15307, 2020

      • djwhitey has quit
      • 2020-06-01 15332, 2020

      • v6lur_ has quit
      • 2020-06-01 15314, 2020

      • iliekcomputers
      • 2020-06-01 15350, 2020

      • ishaanshah
        Hmm, still cors
      • 2020-06-01 15358, 2020

      • iliekcomputers
        yep
      • 2020-06-01 15339, 2020

      • iliekcomputers
        i have a feeling it's a regression from when we started using `APINoContent`
      • 2020-06-01 15358, 2020

      • ishaanshah
        Yeah, that makes sense
      • 2020-06-01 15327, 2020

      • ishaanshah
        I will look into it
      • 2020-06-01 15341, 2020

      • ishaanshah
        Btw the generator worked
      • 2020-06-01 15302, 2020

      • BrainzGit
        [listenbrainz-server] release v-2020-06-01.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15338, 2020

      • iliekcomputers
        ishaanshah: yay!
      • 2020-06-01 15306, 2020

      • ishaanshah
        I will update the tests, open a PR
      • 2020-06-01 15321, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #887 (master…dependabot/pip/numpy-1.18.4): Bump numpy from 1.18.3 to 1.18.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15311, 2020

      • shivam-kapila
        ruaok: iliekcomputers: PR 869 is now ready. Please review when free
      • 2020-06-01 15315, 2020

      • iliekcomputers
        ishaanshah: can you make it a seperate command too? that way it'd be easier to test
      • 2020-06-01 15328, 2020

      • ishaanshah
        Yep, will do
      • 2020-06-01 15331, 2020

      • iliekcomputers
        thanks
      • 2020-06-01 15357, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #888 (master…dependabot/pip/flask-sqlalchemy-2.4.3): Bump flask-sqlalchemy from 2.4.1 to 2.4.3 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15307, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #889 (master…dependabot/pip/six-1.15.0): Bump six from 1.10.0 to 1.15.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15330, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #891 (master…dependabot/pip/google-api-python-client-1.8.4): Bump google-api-python-client from 1.8.2 to 1.8.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15339, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #892 (master…dependabot/pip/fabric-2.5.0): Bump fabric from 1.10.2 to 2.5.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15348, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #894 (master…dependabot/pip/sphinx-3.0.4): Bump sphinx from 3.0.3 to 3.0.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15353, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #895 (master…dependabot/pip/redis-3.5.2): Bump redis from 3.5.0 to 3.5.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15306, 2020

      • ishaanshah
        iliekcomputers: that reminds me, can we have dependabot for JS too?
      • 2020-06-01 15314, 2020

      • iliekcomputers
        we do
      • 2020-06-01 15324, 2020

      • iliekcomputers
        it looks at package.json too, i think
      • 2020-06-01 15336, 2020

      • ishaanshah
        It didn't upgrade react
      • 2020-06-01 15301, 2020

      • iliekcomputers
        hmm, lemme look, maybe i didn't configure it correctly
      • 2020-06-01 15303, 2020

      • iliekcomputers
        ishaanshah: i've sent you an invite to our sentry
      • 2020-06-01 15325, 2020

      • iliekcomputers
        so that it's easier for you to track errors in production
      • 2020-06-01 15307, 2020

      • ishaanshah
        Cool, thanks a lot :)
      • 2020-06-01 15318, 2020

      • iliekcomputers
        dependabot says "checking now, hold tight!" for package.json
      • 2020-06-01 15331, 2020

      • iliekcomputers
        i'll take a look again tomorrow if we don't have PRs
      • 2020-06-01 15352, 2020

      • ishaanshah
        thanks :)
      • 2020-06-01 15302, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #890 (master…dependabot/pip/pytest-5.4.2): Bump pytest from 5.4.1 to 5.4.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15311, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #893 (master…dependabot/pip/pytest-cov-2.9.0): Bump pytest-cov from 2.8.1 to 2.9.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15340, 2020

      • ruaok
        hey ho linux heads!
      • 2020-06-01 15310, 2020

      • ruaok
        I ordered new mac mini last year and it kept being flaky on me, so I finally got motivated to exit planet mac.
      • 2020-06-01 15339, 2020

      • ruaok
        I got myself a gamer NUC, which has been a great pleasure to put linux on -- there has been so much progress on the desktop.
      • 2020-06-01 15356, 2020

      • ruaok
        I'm running Mint with Cinnamon and its pretty close to OSX -- I'm rather impressed.
      • 2020-06-01 15332, 2020

      • ruaok
        however, the greatest weak point seems to be keyboard issues (cut and paste is drama) and accented characters is a complete disaster.
      • 2020-06-01 15357, 2020

      • ruaok
        <compose> ' a for an accented a? 🔫
      • 2020-06-01 15304, 2020

      • ruaok
        does anyone know of a better solution for getting accented characters on the linux desktop? switching keyboard layout isn't really an option, since there isn't a good keyboard for me. I need german and spanish accented characters and as well as all the ASCII characters for programming better be where they are supposed to be.
      • 2020-06-01 15317, 2020

      • ruaok
      • 2020-06-01 15327, 2020

      • ruaok
        complete with silly gamer bling.
      • 2020-06-01 15351, 2020

      • shivam-kapila
        Nice!!
      • 2020-06-01 15319, 2020

      • ruaok
        4 cores/ 8 threads / 32GB of ram and some decent video performance and I'm a happy camper.
      • 2020-06-01 15340, 2020

      • ruaok
        plus all open source and less of a reliance on docker. moving in the right direction.
      • 2020-06-01 15353, 2020

      • Zastai
        I kinda want an i9 with 64GB for my next laptop, so that I can run 1 or 2 VMs with decent specs without making the host slow to crawl
      • 2020-06-01 15325, 2020

      • Zastai
        but that + lotsa storage + recent high end gfx seems to be a big ask for a laptop
      • 2020-06-01 15335, 2020

      • Zastai
        *shrug*
      • 2020-06-01 15339, 2020

      • ruaok
        yeah, but wait another 12 months and you'll get it.
      • 2020-06-01 15316, 2020

      • ruaok
        ok, 16:45 and I can finally get some technical work done. sigh. mondays the first of the month are the worst.
      • 2020-06-01 15313, 2020

      • yvanzo
        ruaok: I use xmodmap to customize keyboard layout.
      • 2020-06-01 15316, 2020

      • ruaok
        would you be willing to share you config file for that?
      • 2020-06-01 15333, 2020

      • yvanzo
        xmodmap -pk will list current codes
      • 2020-06-01 15311, 2020

      • yvanzo
        xmodmap -e "keycode 59 = semicolon period semicolon period ellipsis multiply ellipsis multiply semicolon period ellipsis multiply"
      • 2020-06-01 15345, 2020

      • ruaok
        which of course makes complete intuitive sense.
      • 2020-06-01 15300, 2020

      • yvanzo
        The above sets the … character where I will recall it.
      • 2020-06-01 15332, 2020

      • djwhitey joined the channel
      • 2020-06-01 15344, 2020

      • Chinmay3199 has quit
      • 2020-06-01 15343, 2020

      • yvanzo
        This is run at X session startup (that is .icewm/startup for IceWM).
      • 2020-06-01 15324, 2020

      • yvanzo
        ruaok: xmodmap -pke is more helpful: just copy a line, replace the character(s) you want to and use it with xmodmap -e ""