personally I'm not a fan of that. it means that we don't have a reference to this information in the server (because the server only gets the path and query paramter, not hash values)
2020-06-02 15427, 2020
ruaok
what does the number in the bar mean?
2020-06-02 15449, 2020
ishaanshah
Number of listens
2020-06-02 15454, 2020
ruaok
oh, I see the hover text says listens.
2020-06-02 15416, 2020
ruaok
that is also unclear. I thought it meant I listened to that album 72 times last month.
2020-06-02 15417, 2020
alastairp
I understand that client-side routing libraries like react-router will enable us to do routing/back/forward button with a query parameter or a URL, is that right?
2020-06-02 15417, 2020
ishaanshah
I didnt put listens on the bar as it would overflow on smaller devices
2020-06-02 15427, 2020
ruaok
ergo, twice a day for a month. ehrm, no.
2020-06-02 15417, 2020
ishaanshah
ruaok: I didnt get you
2020-06-02 15417, 2020
alastairp
is the only way of doing this with the URL to use a routing library? (I understand that you switched to the hash in this case because it's easy to do without having to include another library and rewrite a bunch of code, is that right?)
2020-06-02 15403, 2020
ishaanshah
alastairp: Even before we were not using the query params to get data from server
2020-06-02 15429, 2020
ishaanshah
All the data is obtained through API
2020-06-02 15456, 2020
ishaanshah
the server only saw till the history part
2020-06-02 15416, 2020
alastairp
this now means that the way that we load data on the listens page is completely different from the way that we load data on the history/stats page
2020-06-02 15426, 2020
ishaanshah
Yes
2020-06-02 15445, 2020
ishaanshah
The page loading in recent listens is kinda inefficient
2020-06-02 15446, 2020
alastairp
as I discussed with Mr_Monkey yesterday, I think it'd be good if we took a step back and decided how we wanted to do this, and make sure we do it the same in all places
2020-06-02 15454, 2020
alastairp
what do you mean inefficient?
2020-06-02 15420, 2020
alastairp
Mr_Monkey: maybe you and I could sit down this week and decide how we think that this should work, so that we know what pattern to use from now-on?
oh right, I think we're talking about slightly different things here. this is why I want to clarify it
2020-06-02 15422, 2020
alastairp
yes, to go to another page on the listens page will load the whole page again, but in the grand scheme of things, I don't think that this is inefficient
2020-06-02 15444, 2020
alastairp
it's true that we can improve the usability of this page by using an API query from the frontend to request the next or previous page
2020-06-02 15401, 2020
alastairp
however in this case we should also make sure that the back/forward buttons work as expected
2020-06-02 15438, 2020
ishaanshah
The back button works in hash routing solution
2020-06-02 15401, 2020
alastairp
to be blunt here: I don't like hash routing
2020-06-02 15407, 2020
alastairp
it's using the wrong tool
2020-06-02 15418, 2020
ruaok
+100
2020-06-02 15423, 2020
alastairp
personally I would prefer that we continue to use query parameters, or nicely structured URLs
2020-06-02 15455, 2020
alastairp
which means that we need to find a solution to do this. I don't know about frontend libraries, so I have no idea what the solution to this is. I understand that react-router can help here but I don't know if that is the correct tool to use
2020-06-02 15423, 2020
Mr_Monkey also needs to investigate
2020-06-02 15435, 2020
alastairp
Mr_Monkey: maybe thursday we could spend some time on it?
