Mr_Monkey: hi! remind me, what was the use of picking a specific entity? Like, what difference does it make which one I pick? Just the ID I end up with?
2020-06-03 15524, 2020
Mr_Monkey
And also the data of the entity you select will be the default in the dropdowns on the merge page, if there's conflicts
2020-06-03 15506, 2020
Mr_Monkey
Meaning if you know one entity's data is clean and others not so much, it's easier to just merge into the clean one than have to select the valid data in each dropdown.
2020-06-03 15546, 2020
reosarevok
I like the radio buttons (unsurprisingly) but I'm not sure the BBID helps much at all. I can get the ID by checking the link, anyway, and more importantly that doesn't actually help me figure out if it has better data
2020-06-03 15550, 2020
reosarevok
Unless I open the links
2020-06-03 15500, 2020
reosarevok
(and if I do open the links, then I really don't need the BBID)
2020-06-03 15530, 2020
reosarevok
So, if the idea is "pick the one with the best data as a starting point" I'd show some more data to allow the user to make a decision from this page
2020-06-03 15559, 2020
reosarevok
(and as I've said before, my alternative to "more data" is just "default to oldest entity since they can pick and choose from the fields")
2020-06-03 15514, 2020
reosarevok
IMO currently it's a somewhere-in-between which doesn't have the benefits of either :)
2020-06-03 15527, 2020
Mr_Monkey
It's more a convenience of "if you know of the entities that you selected you want to merge into, here's an option to do so"
2020-06-03 15540, 2020
Mr_Monkey
if you know which*
2020-06-03 15547, 2020
reosarevok
For an MB user migrating, more data would probably be the simplest. For a new user, just having one picked out for them would be
2020-06-03 15509, 2020
Mr_Monkey
OK. So you suggest auto-selecting a default option then?
2020-06-03 15512, 2020
reosarevok
Sure, I get that, but in most cases, in my MB experience at least, what I know is "I want to merge it into the one with an artist type"
2020-06-03 15523, 2020
reosarevok
Or "into the one with the date X"
2020-06-03 15534, 2020
reosarevok
Very rarely "into the one with the ID starting with b3" :)
2020-06-03 15543, 2020
Mr_Monkey
Sure, I totally get that
2020-06-03 15532, 2020
Mr_Monkey
Thanks for the input !
2020-06-03 15534, 2020
reosarevok
If you feel a choice is worth it (and it might be - I guess it depends on how many values I'd need to look through - if 3 or 4 it's probably fine, if 30 probably a huge pain)
2020-06-03 15541, 2020
reosarevok
Then show a bit more data to help them pick :)
2020-06-03 15510, 2020
reosarevok
I suspect by far the most common will be "one with only a bit of data vs one with a ton of data", in which case I guess if one has no data it'll pick the other by default?
2020-06-03 15520, 2020
reosarevok
And "two with very little data" in which case it's easy either way :)
2020-06-03 15524, 2020
reosarevok
But that's just a gut feeling
2020-06-03 15543, 2020
reosarevok
Oh, one quick question that I just thought of
2020-06-03 15549, 2020
reosarevok
Is there a way to pick "none of the above"?
2020-06-03 15556, 2020
reosarevok
For the data, not the entity :D
2020-06-03 15514, 2020
reosarevok
Say, "one says it's born 1909 and one born 1910 and I can't find a proper source for either, just don't set any"
2020-06-03 15544, 2020
reosarevok
(although I guess merges are instant, so it's not a big deal, right? because you could just remove it after the merge, since you don't need to wait 7 days)
2020-06-03 15502, 2020
Gazooo has quit
2020-06-03 15510, 2020
reosarevok
(so if that's the case, ignore, that'd make it complex for little benefit)
2020-06-03 15547, 2020
Gazooo joined the channel
2020-06-03 15545, 2020
Mr_Monkey
It is indeed instant, and recommended in doc and help text to edit before or after the merge.
But I'll first have to figure out how how that will affect reverting merges
2020-06-03 15508, 2020
Mr_Monkey
I feel like I could show a little bit more data in the merge queue. It's a question of how to keep it light and looking nice. I'll add a ticket for that as an improvement, as I feel it's releasable as-is, and will take a bit of fiddling around until I find the right solution.
2020-06-03 15527, 2020
Mr_Monkey
We've discussed in before having popover cards when one hovers over an entity name, with some of the entity's basic information. That would solve the issue.
2020-06-03 15551, 2020
yvanzo
Hi diru1100: How are you doing? Can we schedule a meeting when you have time?
2020-06-03 15513, 2020
diru1100
Hey yvanzo: I am fine, hope you are doing well. Yes, I am free. Kindly schedule a time slot when you are available.
2020-06-03 15542, 2020
yvanzo
diru1100: now? just for a short update
2020-06-03 15536, 2020
diru1100
yvanzo: sure
2020-06-03 15538, 2020
yvanzo
Is the data generation code available somewhere for review or for use?
2020-06-03 15521, 2020
diru1100
I have completed generating all the parameters, but I am trying to group them together and then upload it on GitHub. I can just upload the file I have now, it just won't be presentable.
2020-06-03 15511, 2020
yvanzo
Cool, is it something you can make presentable so that we can discuss it next time?
Yes absolutely, everything is done and I will upload it by today and give you an update .
2020-06-03 15539, 2020
ruaok
when I looked at copying the mappings to the FTP site I took a look at how the files are being stored and it is much too complicated as it stands.
2020-06-03 15503, 2020
ruaok
the above method is what I am going to settle on -- can you please adapt the spark code that downloads mapping to reflect this?
2020-06-03 15515, 2020
yvanzo
Thanks diru1100, what time works for you today? (or tomorrow?)
2020-06-03 15528, 2020
diru1100
yvanzo: One thing I am thinking about is, currently I am generating each parameter seperately, and grouping them at the end. Is that the right approach to generate?
2020-06-03 15557, 2020
diru1100
Tomorrow anytime after 2pm IST, we can review the code
2020-06-03 15526, 2020
yvanzo
Ok for tomorrow 2pm IST, which is 8:30 UTC right?
2020-06-03 15509, 2020
yvanzo
diru1100: This approach is probably right, just keep it simple, it's only for test purpose.
2020-06-03 15526, 2020
diru1100
Yes
2020-06-03 15500, 2020
ishaanshah
Mr_Monkey, iliekcomputers, alastairp: I figured out the issue with `pushState`, the back button is now working with query parameters too
2020-06-03 15517, 2020
Mr_Monkey
Hey ! Good news !
2020-06-03 15537, 2020
ishaanshah
I misunderstood when `popstate` event was called
2020-06-03 15541, 2020
Mr_Monkey
Nicely done. For my general knowledge, what was the issue?
2020-06-03 15511, 2020
diru1100
Alright, I may be thinking too much. Will give you an update by tomorrow
2020-06-03 15550, 2020
v6lur_ joined the channel
2020-06-03 15551, 2020
ishaanshah
I though that calling pushState triggers the event too
2020-06-03 15500, 2020
ishaanshah
iliekcomputers: Should I start with top recordings now?
2020-06-03 15509, 2020
iliekcomputers
there's two things we should do first
2020-06-03 15517, 2020
iliekcomputers
ruaok opened tickets, they should be in the epic
2020-06-03 15523, 2020
pristine__
ruaok: but isn't it easy to navigate to required mapping with current method?
2020-06-03 15536, 2020
ishaanshah
yes doing that right now
2020-06-03 15540, 2020
ruaok
pristine__: not really.
2020-06-03 15540, 2020
iliekcomputers
first one: it's not obvious to users that the artists link is a dropdown
2020-06-03 15550, 2020
iliekcomputers
and that a releases graph exists
2020-06-03 15556, 2020
iliekcomputers
Mr_Monkey: can you help ishaanshah with that?
2020-06-03 15500, 2020
ruaok
first, there is a sequence/schema number we do not need. this is not a replication stream. a date is sufficient.
2020-06-03 15510, 2020
ruaok
then all the dumps for one date should all be in the same directory.
2020-06-03 15528, 2020
ruaok
right now there are far too many directories for this setup
2020-06-03 15553, 2020
pristine__
ruaok: at any point in time, we will have only three mapping tars (mapping, mapping-with-text, mapping-matchable) with latest changes?
2020-06-03 15520, 2020
pristine__
> then all the dumps for one date should all be in the same directory.
2020-06-03 15522, 2020
pristine__
Right
2020-06-03 15523, 2020
ruaok
I'd say max three sets of three. but certainly two.
2020-06-03 15524, 2020
Mr_Monkey
I can. Gotta think about it, since I'm the one who suggested the current solution :p
2020-06-03 15548, 2020
pristine__
Okay. I will open a PR for that.
2020-06-03 15523, 2020
ruaok
thanks. once I have a set of files, I'll copy it out there. should be within a few hours.
2020-06-03 15541, 2020
pristine__
ruaok: can you have a quick look at #896?
2020-06-03 15550, 2020
pristine__
Nice :)
2020-06-03 15510, 2020
ishaanshah
Mr_Monkey: Can we have a pill style dropdown
2020-06-03 15519, 2020
ishaanshah
To make it more evident
2020-06-03 15539, 2020
Mr_Monkey
Not sure what tha looks like, but if it's waht I imagine yes
2020-06-03 15517, 2020
ruaok
let me get the dumps finished, then I'll review.
2020-06-03 15517, 2020
ishaanshah
I mean the instead of a transparent button, we color it orange as we had for the entity selection tabs before
2020-06-03 15522, 2020
Mr_Monkey
Yeah, I think something like that could work
2020-06-03 15530, 2020
ishaanshah
iliekcomputers: does that sound good to you?
2020-06-03 15523, 2020
iliekcomputers
i think that makes sense. i'd tag ruaok on the PR with a screenshot when you have it up
