#metabrainz

/

      • shivam-kapila
        ishaanshah: Thats 2002
      • 2020-06-03 15539, 2020

      • ishaanshah
        1589241595
      • 2020-06-03 15543, 2020

      • ishaanshah
        sorry that was all_time
      • 2020-06-03 15549, 2020

      • iliekcomputers
        ruaok: i'm in dublin though
      • 2020-06-03 15512, 2020

      • ishaanshah
        Monday, 11 May 2020 23:59:55
      • 2020-06-03 15525, 2020

      • ruaok
        and I wasn't being serious, either....
      • 2020-06-03 15527, 2020

      • ishaanshah
        This is the datetime
      • 2020-06-03 15552, 2020

      • iliekcomputers
        ah
      • 2020-06-03 15552, 2020

      • ishaanshah
        UTC datetime*
      • 2020-06-03 15506, 2020

      • ishaanshah
        as its close to 00:00
      • 2020-06-03 15533, 2020

      • ishaanshah
        it shows tuesday for some and monday for some ig
      • 2020-06-03 15536, 2020

      • iliekcomputers
        ok, that makes sense
      • 2020-06-03 15509, 2020

      • iliekcomputers
        dublin is 1 hour ahead of utc for daylight savings, yep, makes sense. sorry for the confusion.
      • 2020-06-03 15540, 2020

      • iliekcomputers
        could we add a test to make sure that `getUTCDate` gets called here
      • 2020-06-03 15512, 2020

      • iliekcomputers
        hmm, not sure if it's worth it.
      • 2020-06-03 15518, 2020

      • iliekcomputers
        let's leave it for now
      • 2020-06-03 15533, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #899 (master…date_timezone): LB-611: The week date shown on the page ends up on a Tuesday https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-03 15534, 2020

      • BrainzBot
        LB-611: The week date shown on the page ends up on a Tuesday https://tickets.metabrainz.org/browse/LB-611
      • 2020-06-03 15512, 2020

      • MrBrave has quit
      • 2020-06-03 15559, 2020

      • Eagles_ROCKX23 has quit
      • 2020-06-03 15549, 2020

      • BrainzGit
        [musicbrainz-docker] yvanzo opened pull request #160 (master…install-on-ubuntu): Document setting up requirements on recent Ubuntu https://github.com/metabrainz/musicbrainz-docker/…
      • 2020-06-03 15527, 2020

      • Rotab has quit
      • 2020-06-03 15518, 2020

      • tavasti joined the channel
      • 2020-06-03 15516, 2020

      • tavasti has left the channel
      • 2020-06-03 15537, 2020

      • Rotab joined the channel
      • 2020-06-03 15506, 2020

      • SomalRudra
        ruaok: Hi ! I'm pleased to let you know we have progressed ahead of what we have scheduled for the android app.
      • 2020-06-03 15506, 2020

      • SomalRudra
        To make the tasks more achievable and keep a track of the progress gr0uch0mars have created a project under the official repo.
      • 2020-06-03 15506, 2020

      • SomalRudra
        However,to make cards in the project I need to be authorized i.e. I have to be a member of metabrainz foundation and a member of metabrainz/android app.
      • 2020-06-03 15506, 2020

      • SomalRudra
        I need some help regarding this issue.
      • 2020-06-03 15556, 2020

      • iliekcomputers
        SomalRudra: what's your github?
      • 2020-06-03 15558, 2020

      • SomalRudra
      • 2020-06-03 15502, 2020

      • iliekcomputers
        thanks
      • 2020-06-03 15526, 2020

      • iliekcomputers
        sent
      • 2020-06-03 15511, 2020

      • SomalRudra
        iliekcomputers: Thank you ! issue regarding the card resolved now
      • 2020-06-03 15521, 2020

      • iliekcomputers
        ruaok: i've reviewed the timescale pr and the migration doc, both of them look good to me, had a few comments on both.
      • 2020-06-03 15534, 2020

      • iliekcomputers
        i'll look at the scripts you mentioned too
      • 2020-06-03 15539, 2020

      • iliekcomputers
        SomalRudra: no worries
      • 2020-06-03 15541, 2020

      • alastairp
        ruaok: remember how you had trouble getting timescale postgres auth working in docker?
      • 2020-06-03 15558, 2020

      • v6lur has quit
      • 2020-06-03 15509, 2020

      • alastairp
        it looks like postgres' docker image for a long time just had trust auth by default, and timescale disabled it because they thought it was a security risk
      • 2020-06-03 15515, 2020

      • alastairp
        postgres has disabled it now too
      • 2020-06-03 15551, 2020

      • alastairp
        (oh man, just saw that people are talking about dates. I feel bad for you!)
      • 2020-06-03 15559, 2020

      • iliekcomputers
        yep
      • 2020-06-03 15545, 2020

      • Mr_Monkey retches at the thought of dates
      • 2020-06-03 15532, 2020

      • alastairp
      • 2020-06-03 15532, 2020

      • BrainzBot
        LB-531: "x days/minutes/seconds ago" is unclear
      • 2020-06-03 15556, 2020

      • alastairp
        we have to work out how to convert UTC to the user's local timezone _at the time the track was listened to_
      • 2020-06-03 15525, 2020

      • alastairp
        otherwise for half the year, people's listen times will be an hour out
      • 2020-06-03 15532, 2020

      • ruaok
        iliekcomputers: thx!
      • 2020-06-03 15559, 2020

      • ruaok
        alastairp: yeah, I figured it was something like that.
      • 2020-06-03 15520, 2020

      • reosarevok
      • 2020-06-03 15536, 2020

      • reosarevok
        Seems they're slowly moving forward with this, even with the racists in the government. Surprising
      • 2020-06-03 15515, 2020

      • yvanzo
        bitmap: I almost set up test.mb.o but live reindexing. There still are a pair of issues: musicbrainz_ro cannot be used, sir cannot find musicbrainz_schema_change. Not sure how to fix these, how did you managed musicbrainz_ro last time?
      • 2020-06-03 15554, 2020

      • yvanzo
        PG database is created from latest public dumps, and Solr search indexes (but editor) have been loaded from latest public dumps too.
      • 2020-06-03 15522, 2020

      • bitmap
        you have to create musicbrainz_ro with https://github.com/metabrainz/docker-postgres/blo…
      • 2020-06-03 15545, 2020

      • bitmap
        musicbrainz_schema_change seems to be gone from the pgbouncer config, and so is musicbrainz_json_dump again :\
      • 2020-06-03 15558, 2020

      • bitmap
        idk how consul-template is deleting those
      • 2020-06-03 15550, 2020

      • bitmap
        I'll just merge https://github.com/metabrainz/docker-postgres/pul… in case that's causing issues
      • 2020-06-03 15532, 2020

      • ruaok
        bitmap: did you see the link the reo posted about digital nomad visas for .ee ?
      • 2020-06-03 15547, 2020

      • ruaok
        could be fine ticket out of ORD and the weather may even be better in .ee.
      • 2020-06-03 15515, 2020

      • bitmap
        ah I had heard about that before, are they actually implementing that?
      • 2020-06-03 15548, 2020

      • yvanzo
        bitmap: I did restart postgres-williams to apply change in consul config, that might explain musicbrainz_json_dump is gone again.
      • 2020-06-03 15527, 2020

      • jmp_music has quit
      • 2020-06-03 15540, 2020

      • ruaok
        2 weeks. wow.
      • 2020-06-03 15555, 2020

      • alastairp
        and right as all of the countries were shutting borders in March!
      • 2020-06-03 15510, 2020

      • yvanzo
        bitmap: thanks, I just applied these commands but it still fails.
      • 2020-06-03 15500, 2020

      • bitmap
        the db still isn't in the pgbouncer config, I'm updating it now
      • 2020-06-03 15523, 2020

      • bitmap
        try now
      • 2020-06-03 15528, 2020

      • yvanzo
      • 2020-06-03 15550, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1548 (master…MBS-10862): MBS-10862: Report "CatNoLooksLikeLabelCode" https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-03 15551, 2020

      • BrainzBot
        MBS-10862: Report for releases with catalog numbers that look like label codes https://tickets.metabrainz.org/browse/MBS-10862
      • 2020-06-03 15506, 2020

      • yvanzo
        still not
      • 2020-06-03 15520, 2020

      • bitmap
        that's being run from musicbrainz-website-test on williams or?
      • 2020-06-03 15538, 2020

      • yvanzo
        no, from paco
      • 2020-06-03 15533, 2020

      • bitmap
        I mean InitDb.pl
      • 2020-06-03 15540, 2020

      • yvanzo
        I have shut down musicbrainz-website-test and musicbrainz-webservice-test on williams for now.
      • 2020-06-03 15506, 2020

      • yvanzo
        bitmap: I ran InitDb.pl from musicbrainz-webservice-test on williams
      • 2020-06-03 15509, 2020

      • bitmap
        then I'll have to start that container back up to see what it's doing
      • 2020-06-03 15511, 2020

      • yvanzo
      • 2020-06-03 15521, 2020

      • yvanzo
        bitmap: no problem, just uncomment it from scripts/nodes/williams.sh
      • 2020-06-03 15500, 2020

      • bitmap
        there's already a musicbrainz_schema_change db though. is it safe to drop that? otherwise InitDb.pl will fail
      • 2020-06-03 15503, 2020

      • yvanzo
        this error with SIR (test) is possibly related: https://gist.github.com/yvanzo/a5b2732b15a286e2cd…
      • 2020-06-03 15515, 2020

      • yvanzo
        bitmap: no, don't drop it :)
      • 2020-06-03 15544, 2020

      • yvanzo
        it took eons to import ^^
      • 2020-06-03 15558, 2020

      • bitmap
        ok I'm not sure what you're trying to do then :)
      • 2020-06-03 15545, 2020

      • yvanzo
        psql query using musicbrainz_ro fails, connecting sir to the database fails too.
      • 2020-06-03 15510, 2020

      • yvanzo
        InitDb.pl succeeded after I replaced musicbrainz_ro with musicbrainz for the READONLY database.
      • 2020-06-03 15522, 2020

      • yvanzo
        (it is all in gist comments)
      • 2020-06-03 15544, 2020

      • bitmap
      • 2020-06-03 15535, 2020

      • bitmap
        as superuser ofcourse
      • 2020-06-03 15546, 2020

      • yvanzo
        thanks, musicbrainz_ro works now :)
      • 2020-06-03 15530, 2020

      • bitmap
        great
      • 2020-06-03 15548, 2020

      • bitmap
        the `GRANT SELECT ON ALL TABLES` one actually needs to be run whenever we add new tables, too
      • 2020-06-03 15505, 2020

      • shivam-kapila
        iliekcomputers: HI. I agree with the test specific behaviour comment. I have removed that specific behaviour from fetch_listens_from_storage. But not for SQL view queries as the views not exact values instantly.
      • 2020-06-03 15515, 2020

      • shivam-kapila
        ruaok: Hi I studied most of the tests. Most of them dont ideally depend on the try_Harder thing. I was my fault earlier about the 12 tests failing. Sorry. So I am thinking that I can add a new test to see that pagination effectively works. I will add a listen with more than 3 week gap. And try with try_harder flag that it works effectively. What do you think?
      • 2020-06-03 15526, 2020

      • shivam-kapila
        I added 1 more listen to json 4 week apart and saw that none of the tests are based on try_harder thing. The failing one were `mock.assertHasBeenCalledWith(..., ts=<max_ts>)`
      • 2020-06-03 15545, 2020

      • ruaok
        shivam-kapila: the latest version of timescale, which I think we are using, now has continuous aggregates that are always up to date. we may be able to get rid of those test exceptions. give it it try.
      • 2020-06-03 15552, 2020

      • djwhitey has quit
      • 2020-06-03 15507, 2020

      • shivam-kapila
        Worth a try
      • 2020-06-03 15543, 2020

      • ruaok
        and the rest of your plan for the try_harder thing also makes sense. and I'm sure you've seen the note that iliekcomputers has poopoo'ed the name try_harder.
      • 2020-06-03 15513, 2020

      • shivam-kapila
        Yes I saw that
      • 2020-06-03 15515, 2020

      • ruaok
        I guess it makes sense, because I did the same under the hood -- time_range. not sure exactly how to express that on the user level.
      • 2020-06-03 15510, 2020

      • shivam-kapila
        Will have to look for a better name.
      • 2020-06-03 15536, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1547 (master…MBS-10882): MBS-10882: Remove accidental duplicate push https://github.com/metabrainz/musicbrainz-server/…
      • 2020-06-03 15537, 2020

      • BrainzBot
        MBS-10882: ISE when filtering RGs https://tickets.metabrainz.org/browse/MBS-10882
      • 2020-06-03 15536, 2020

      • ruaok
      • 2020-06-03 15546, 2020

      • ruaok
        that is where the mapping will live going forward.
      • 2020-06-03 15505, 2020

      • ruaok
        once we merge that PR you are working on, we will delete that last remaining dir in that dir.
      • 2020-06-03 15507, 2020

      • yvanzo
        bitmap: thanks, that also solved sir issue.
      • 2020-06-03 15518, 2020

      • bitmap
        w00t
      • 2020-06-03 15535, 2020

      • yvanzo
        currently rebuilding editor index
      • 2020-06-03 15548, 2020

      • shivam-kapila
        ruaok: Continuous aggregates solved it. woohoo
      • 2020-06-03 15558, 2020

      • BrainzGit
        [musicbrainz-docker] yvanzo merged pull request #160 (master…install-on-ubuntu): Document setting up requirements on recent Ubuntu https://github.com/metabrainz/musicbrainz-docker/…
      • 2020-06-03 15510, 2020

      • ruaok
        niiiice!
      • 2020-06-03 15506, 2020

      • shivam-kapila
        Also I had a thought. Can we also do weekly plannings. I think it can be more productive. :)
      • 2020-06-03 15557, 2020

      • ruaok
        sure, but let's not go for the daily meetings, ok? that's a bit much for me.
      • 2020-06-03 15535, 2020

      • ruaok
        shall we meet 1 hour prior to the team meeting?
      • 2020-06-03 15531, 2020

      • blinky42 has quit
      • 2020-06-03 15515, 2020

      • shivam-kapila
        Sure works for me.
      • 2020-06-03 15501, 2020

      • shivam-kapila
        Thanks :)
      • 2020-06-03 15503, 2020

      • ruaok puts it into the calendar
      • 2020-06-03 15551, 2020

      • sampsyo joined the channel
      • 2020-06-03 15538, 2020

      • ruaok
        reosarevok: bitmap : yvanzo is it still possible to pull up mb entity pages using the rowids? e.g. I have artist.id = 65 and I would like to make a link without the need for finding the MBID
      • 2020-06-03 15554, 2020

      • sampsyo has quit
      • 2020-06-03 15558, 2020

      • ruaok
        akshauly, never mind. I have the DB to hand, I'll just join the data.
      • 2020-06-03 15524, 2020

      • rdswift
        <shivam-kapila> Will have to look for a better name. Perhaps "expand search range" or "expand search dates" (or maybe just "expand search")?
      • 2020-06-03 15534, 2020

      • yvanzo
        ruaok: I didn’t know it has ever been.
      • 2020-06-03 15540, 2020

      • sampsyo joined the channel
      • 2020-06-03 15533, 2020

      • bitmap
        ruaok: Yep, /artist/65 should still work
      • 2020-06-03 15520, 2020

      • ruaok
        nice.
      • 2020-06-03 15540, 2020

      • ruaok
        do we have anything to call up pages for artist_credits?
      • 2020-06-03 15524, 2020

      • ruaok is playing with the msid mapping
      • 2020-06-03 15526, 2020

      • ruaok
      • 2020-06-03 15557, 2020

      • v6lur joined the channel
      • 2020-06-03 15529, 2020

      • chaban
        reosarevok: Found another PUID that doesn't load MBS-10883 :D (looks like cloning a ticket includes the assignee, hope you don't mind or should I remove you for now?)
      • 2020-06-03 15530, 2020

      • BrainzBot
        MBS-10883: "remove PUID" edit doesn't load https://tickets.metabrainz.org/browse/MBS-10883
      • 2020-06-03 15511, 2020

      • CatQuest
      • 2020-06-03 15541, 2020

      • CatQuest
        Mr_Monkey: let me test it
      • 2020-06-03 15532, 2020

      • Chinmay3199 has quit
      • 2020-06-03 15547, 2020

      • d4rkie joined the channel
      • 2020-06-03 15547, 2020

      • D4RK-PH0ENiX has quit
      • 2020-06-03 15548, 2020

      • Zastai has quit
      • 2020-06-03 15541, 2020

      • CatQuest
        Mr_Monkey: i consither this fixed - it wasn't un-resolvable after all!
      • 2020-06-03 15556, 2020

      • v6lur has quit