the COPY can be run from pink but have to be run as the postgres user
2020-06-04 15648, 2020
bitmap
(if you're busy with something else I can finish it)
2020-06-04 15606, 2020
alastairp
Mr_Monkey: what's up with python?
2020-06-04 15615, 2020
Mr_Monkey
I got it running now
2020-06-04 15615, 2020
alastairp
tell me what you're running and what's going wrong
2020-06-04 15618, 2020
Mr_Monkey
Testing
2020-06-04 15603, 2020
alastairp
so, now the /react endpoint will fill in react-props with json of the current page
2020-06-04 15650, 2020
Mr_Monkey
OK, I'm still running into a—i think— js compilation issue, so i'll continue on that
2020-06-04 15654, 2020
jmp_music has quit
2020-06-04 15612, 2020
iliekcomputers
ishaanshah: sorry, need to cancel today too. i'll be available tomorrow afternoon, so let's chat then.
2020-06-04 15626, 2020
ishaanshah
Ok, sure
2020-06-04 15651, 2020
reosarevok
bitmap: in pink as postgres I need to (seemingly) do FROM musicbrainz.edit etc, but I guess it's working?
2020-06-04 15659, 2020
reosarevok
Since it takes long :p
2020-06-04 15617, 2020
bitmap
oh, yes
2020-06-04 15622, 2020
bitmap
unless you set the search_path first
2020-06-04 15643, 2020
reosarevok
Ok, I ran those
2020-06-04 15654, 2020
reosarevok
I guess we should copy them out and check they worked :p
2020-06-04 15602, 2020
reosarevok
(the COPY ones, didn't delete anything yet)
2020-06-04 15612, 2020
reosarevok
Wanna tunnel them out and do the FTP bit?
2020-06-04 15602, 2020
reosarevok
They seem legit, although maybe we should add a header to it for them to be understandable later
2020-06-04 15623, 2020
bitmap
sure
2020-06-04 15629, 2020
bitmap
I can just put a README in the archive
2020-06-04 15638, 2020
reosarevok
I guess that works
2020-06-04 15657, 2020
reosarevok
I'd copy them myself but I always get a bit confused with tunnels and docker containers
2020-06-04 15619, 2020
CatQuest
this is a weird bug: https://beta.musicbrainz.org/edit/70367366 (I didn't edit any url, i removed one url that was duplicate (had two download for free urls, and the one purchase for download url was identical to one of those so I removed the "duplicated" "for free" url))
2020-06-04 15601, 2020
reosarevok
bitmap: let me know if you copy them so I can run the deletions :)
2020-06-04 15616, 2020
bitmap
okay
2020-06-04 15628, 2020
Zastai
CatQuest: given that (at the moment) both links go to a purchase page with the price as either GBP0.00 and USD0.00, I'm surprised you removed the "for free" url rel
2020-06-04 15630, 2020
bitmap
I've copied those outside the container so you can run them in any case
2020-06-04 15601, 2020
reosarevok
Ok!
2020-06-04 15608, 2020
CatQuest
Zastai: i.. removed *one* for free url
2020-06-04 15617, 2020
bitmap
just open a transaction first and make sure it deletes exactly 1193148 rows :)
2020-06-04 15622, 2020
CatQuest
there whre two
2020-06-04 15633, 2020
Zastai
yes, one uk, one us
2020-06-04 15636, 2020
CatQuest
yes
2020-06-04 15639, 2020
CatQuest
so i removed one
2020-06-04 15640, 2020
reosarevok
bitmap: wait, I should do this in floyd, not pink, whoops
2020-06-04 15646, 2020
bitmap
yup
2020-06-04 15633, 2020
CatQuest
so now there is one "for free" nad one "for purchase"
2020-06-04 15601, 2020
reosarevok
CatQuest: I guess Zastai's point is that they were two different country ones
2020-06-04 15606, 2020
CatQuest
uh
2020-06-04 15608, 2020
reosarevok
Although I'm not sure that matters
2020-06-04 15609, 2020
Zastai
but a) they are not the same site, and b) they offer both a free download and the option to pay. so if anything, I would have ensure both urls appeared in both categories
2020-06-04 15619, 2020
CatQuest
but the "for purchase" one is theo ther one :D
2020-06-04 15645, 2020
Zastai
no, both have it available for 0 (dollars or pounds)
bitmap: lol, ERROR: canceling statement due to statement timeout
2020-06-04 15600, 2020
CatQuest
idk
2020-06-04 15612, 2020
Zastai
but the available payment options differ, for example (uk can use paypal, us can't)
2020-06-04 15618, 2020
CatQuest
well i never touched the "for pay" one
2020-06-04 15620, 2020
Zastai
not a huge deal, but still
2020-06-04 15628, 2020
reosarevok
uk preorder gives euros to me, so that's weird
2020-06-04 15638, 2020
bitmap
reosarevok: oops, ROLLBACK; BEGIN; SET LOCAL statement_timeout = 0;
2020-06-04 15638, 2020
reosarevok
Why would they have two if one can support two currencies
2020-06-04 15606, 2020
CatQuest
ok once more: this was how it looked: there was one uk one us both where "for free" (which apparently just gives you whatever currency) then there was *pne* us- for pay i didn't touch that
2020-06-04 15604, 2020
reosarevok
US does always give USD, UK gives GBP or EUR
2020-06-04 15605, 2020
reosarevok
:D
2020-06-04 15611, 2020
CatQuest
since they both co to the same page apaprenl i removed "us" for free as that's "already on for pay"
2020-06-04 15613, 2020
reosarevok
I think we can just keep one, anyway
2020-06-04 15614, 2020
Zastai
reosarevok: I agree that it's a weird situation; I guess it's a shop front that normally expects there to be a price.
2020-06-04 15625, 2020
reosarevok
Since we don't usually keep all different ASINs for the same release
ERROR: update or delete on table "edit" violates foreign key constraint "edit_recording_fk_edit" on table "edit_recording"
2020-06-04 15634, 2020
reosarevok
DETAIL: Key (id)=(6630087) is still referenced from table "edit_recording".
2020-06-04 15638, 2020
reosarevok
CatQuest: dropping all the PUID edits
2020-06-04 15641, 2020
CatQuest
uhm
2020-06-04 15654, 2020
CatQuest
i guess..
2020-06-04 15600, 2020
CatQuest
wait. evne the ones with comments on it?
2020-06-04 15617, 2020
reosarevok
Yes, since they're all useless and get in the way of other stuff
2020-06-04 15635, 2020
reosarevok
(PUIDs themselves don't exist, after all)
2020-06-04 15637, 2020
CatQuest
hmm maube there could hve been soem usefull converstion on one thoguh. but i guess
2020-06-04 15606, 2020
reosarevok
Well, I think it's sensible to take the risk of losing a few conversations vs being able to see the other edits that were between all the useless-by-now PUID ones :)
2020-06-04 15609, 2020
CatQuest
that data is saved in soem backup jsut for saving the data though or what?
2020-06-04 15611, 2020
reosarevok
Yes
2020-06-04 15619, 2020
reosarevok
That's what bitmap and I were doing just before :)
2020-06-04 15621, 2020
CatQuest
then it's fien by me
2020-06-04 15632, 2020
reosarevok
bitmap: does that also save the edit notes? If not, should it?
2020-06-04 15641, 2020
CatQuest
imho yes. (juuust incase)
2020-06-04 15600, 2020
CatQuest
better to be safe than sorry :D
2020-06-04 15602, 2020
Zastai
if there are any such edits (or their notes) being referenced from notes on non-PUID edits, I might have wanted to keep those
2020-06-04 15613, 2020
CatQuest
my thoguhts exactly
2020-06-04 15619, 2020
Zastai
any unreferenced PUID edits I'm happy to lose
2020-06-04 15627, 2020
bitmap
reosarevok: those are in the edit_note table
2020-06-04 15631, 2020
CatQuest
puid editsgo the way of trm edits :D
2020-06-04 15658, 2020
CatQuest
and if muz was here I would say I *still* pronounce it phu-eed
2020-06-04 15619, 2020
bitmap
we can dump that + vote too (I have a backup of the most recent edit dump with them, anyway)
2020-06-04 15620, 2020
Zastai
Pepe le PUID
2020-06-04 15636, 2020
reosarevok
bitmap: if you can be bothered to write the SQL, I can dump it :)
2020-06-04 15656, 2020
reosarevok
I haven't done COMMIT on any removing yet
2020-06-04 15637, 2020
reosarevok
I'll look into the DELETE for the edit_recording table
2020-06-04 15637, 2020
Zastai
DELETE FROM EDITS; RECOVER DELETED EDITS WHERE NOT PUID; - that's how SQL works, right? ;)
2020-06-04 15633, 2020
bitmap
reosarevok: you can ROLLBACK; that for now
2020-06-04 15658, 2020
reosarevok
bitmap: I guess we don't need to dump edit_recording since the needed data should be in edit_data
DELETE FROM edit_note_recipient WHERE edit_note IN (SELECT id FROM edit_note WHERE edit IN (SELECT id FROM edit WHERE type IN (77, 113)));
2020-06-04 15611, 2020
ruaok
Why meeeee? 😆
2020-06-04 15640, 2020
sumedh joined the channel
2020-06-04 15647, 2020
Mr_Monkey
alastairp: App is working well now
2020-06-04 15655, 2020
alastairp
cool! I'm back
2020-06-04 15603, 2020
alastairp
what was the trick?
2020-06-04 15624, 2020
reosarevok
zas: what was the solution for SSL handshake failed in Picard?
2020-06-04 15642, 2020
reosarevok
well, the delete from edit_note takes forever
2020-06-04 15651, 2020
alastairp
Mr_Monkey: a bit disappointing to see a whole webpack.config file there ;)
2020-06-04 15601, 2020
alastairp
sure sure, it's not too long, but still
2020-06-04 15610, 2020
alastairp
> added 582 packages from 258 contributors and audited 582 packages in 9.723s
2020-06-04 15612, 2020
alastairp
incredible
2020-06-04 15638, 2020
Mr_Monkey
Tell me about it.
2020-06-04 15653, 2020
Mr_Monkey
Well, at least it'll run anywhere, the bugger
2020-06-04 15624, 2020
Mr_Monkey
It was either that or browserify
2020-06-04 15638, 2020
alastairp
Mr_Monkey: so I see it's still doing the initial API call, right?
2020-06-04 15617, 2020
Mr_Monkey
Currently yes, adjusting that now
2020-06-04 15658, 2020
alastairp
got it
2020-06-04 15602, 2020
alastairp
I'm looking at the jsx
2020-06-04 15645, 2020
Mr_Monkey
Pushed
2020-06-04 15637, 2020
Mr_Monkey
We do a similar thing in BB to what you do in the python app (i.e. reuse the fetch-me-some-data code to be used in the html page route and the API route). That's the way to go.
