#metabrainz

/

      • Mr_Monkey
        I'm gonna call it there for the day but high five alastairp, that was a productive hack!
      • 2020-06-04 15613, 2020

      • alastairp
        yeah, me too, thanks a lot!
      • 2020-06-04 15617, 2020

      • alastairp
        I think we have a lot of good stuff
      • 2020-06-04 15626, 2020

      • alastairp
        we should work out what the next step is
      • 2020-06-04 15653, 2020

      • alastairp
        we should get ishaanshah onboard with his specific endpoints
      • 2020-06-04 15602, 2020

      • alastairp
        especially because we're already using pydantic here!
      • 2020-06-04 15636, 2020

      • alastairp
        and work with iliekcomputers to prioritise fixing the rendering of the listens page
      • 2020-06-04 15615, 2020

      • alastairp
        Mr_Monkey: mmm, one thing I noticed that we don't have... you defined the AppProps type yourself. that should be a pydantic model too, and so we will be able to generate a schema for it
      • 2020-06-04 15612, 2020

      • Mr_Monkey
        Yeah, I guess that's what I clumsily asked earlier
      • 2020-06-04 15610, 2020

      • Mr_Monkey
        That round sit up nicely
      • 2020-06-04 15610, 2020

      • alastairp
        oh, I didn't even pick up on that, sorry!
      • 2020-06-04 15640, 2020

      • alastairp
        oh, I understand the question you asked now!
      • 2020-06-04 15618, 2020

      • sumedh has quit
      • 2020-06-04 15601, 2020

      • alastairp
        ah, the other thing... do we care if the number of pages changes while we're on that screen?
      • 2020-06-04 15635, 2020

      • alastairp
        and - in the case of listens, this page updates. This is a slightly different feature than what we've been talking about (e.g. we'd probably need websockets or something)
      • 2020-06-04 15642, 2020

      • alastairp
        but something in general to think about
      • 2020-06-04 15606, 2020

      • Mr_Monkey
        There's already websockets implemented to update the listens page, if I'm not mistaken
      • 2020-06-04 15619, 2020

      • Mr_Monkey
        But I agree, a separate feature
      • 2020-06-04 15608, 2020

      • Chinmay3199 has quit
      • 2020-06-04 15623, 2020

      • sumedh joined the channel
      • 2020-06-04 15644, 2020

      • alastairp
        Mr_Monkey: for tomorrow - I updated but it can't find `tsc` when running npm build. and when I npm install tsc, I get `Argument for '--target' option must be 'ES3', 'ES5', or 'ES6'.` and `Unknown compiler option 'jsx'.`
      • 2020-06-04 15654, 2020

      • rdswift has quit
      • 2020-06-04 15606, 2020

      • rdswift joined the channel
      • 2020-06-04 15604, 2020

      • chaban
        Voting seems impossible right now due to ISE: `57014 DBD::Pg::st execute failed: ERROR: canceling statement due to statement timeout [for Statement "LOCK vote IN SHARE ROW EXCLUSIVE MODE"]`
      • 2020-06-04 15605, 2020

      • chaban
        Seen this kind of errors shortly after PG12 upgrade too.
      • 2020-06-04 15615, 2020

      • chaban
      • 2020-06-04 15645, 2020

      • chaban
        Guess this is due to PUIDs being dropped. reosarevok?
      • 2020-06-04 15653, 2020

      • reosarevok
        Probably. Shit.
      • 2020-06-04 15655, 2020

      • reosarevok
        bitmap: ^
      • 2020-06-04 15612, 2020

      • reosarevok
        The DELETE FROM edit is still going in the transaction....
      • 2020-06-04 15649, 2020

      • kurisu has quit
      • 2020-06-04 15628, 2020

      • reosarevok
        Didn't think it would affect that, but then I also didn't think it'd take like 4 hours
      • 2020-06-04 15631, 2020

      • reosarevok
        Think I'm going to cancel this for now then
      • 2020-06-04 15604, 2020

      • reosarevok
        chaban: can you vote now?
      • 2020-06-04 15638, 2020

      • chaban
        Yup
      • 2020-06-04 15641, 2020

      • reosarevok
        Thanks
      • 2020-06-04 15648, 2020

      • reosarevok
        We'll need to do it more carefully then
      • 2020-06-04 15617, 2020

      • reosarevok
        bitmap: left a comment on https://tickets.metabrainz.org/browse/MBS-6864 - what's the best way to do this? Do we need to go RO for a while?
      • 2020-06-04 15618, 2020

      • BrainzBot
        MBS-6864: Remove PUID edits
      • 2020-06-04 15632, 2020

      • reosarevok
        Do you think the fact people were hitting the edit table is what caused it to go so slow?
      • 2020-06-04 15608, 2020

      • mwhitehe22 joined the channel
      • 2020-06-04 15617, 2020

      • mwhitehe22
        hello. I was just trying to build musicbrainz 5.1.0 under Gentoo and it failed.
      • 2020-06-04 15622, 2020

      • mwhitehe22
        This patch fixed it
      • 2020-06-04 15624, 2020

      • mwhitehe22
      • 2020-06-04 15629, 2020

      • mwhitehe22
        Do I have to create a bug, or can someone do that on my behalf?
      • 2020-06-04 15654, 2020

      • sumedh has quit
      • 2020-06-04 15625, 2020

      • sumedh joined the channel
      • 2020-06-04 15639, 2020

      • v6lur joined the channel
      • 2020-06-04 15653, 2020

      • Chinmay3199 joined the channel
      • 2020-06-04 15615, 2020

      • mwhitehe22
        @all ^^^
      • 2020-06-04 15643, 2020

      • alastairp
        mwhitehe22: thanks for the report. I've opened it as https://tickets.metabrainz.org/browse/LMB-52
      • 2020-06-04 15644, 2020

      • BrainzBot
        LMB-52: Fails to compile under Gentoo
      • 2020-06-04 15650, 2020

      • Mr_Monkey
        alastairp: I had typescript installed globally, didn't think about that. Pushed the added dependency.
      • 2020-06-04 15605, 2020

      • alastairp
        merçi
      • 2020-06-04 15629, 2020

      • alastairp
        tomorrow I'll add the missing schema, and there are a few other things I'd like to talk about 👍
      • 2020-06-04 15638, 2020

      • Mr_Monkey
        Haven't checked again, so that error you saw might still be there. Something for tomorrow :)
      • 2020-06-04 15623, 2020

      • sumedh has quit
      • 2020-06-04 15608, 2020

      • mwhitehe22
        alastairp Gentoo just created a patch to workaround it. That is here : https://bugs.gentoo.org/698090
      • 2020-06-04 15659, 2020

      • mwhitehe22 has left the channel
      • 2020-06-04 15628, 2020

      • rdswift has quit
      • 2020-06-04 15620, 2020

      • bitmap
        reosarevok: probably adding a LIMIT to the inner query and deleting them in chunks...though we can drop the edit_recording, edit_note, and vote rows separately I think
      • 2020-06-04 15659, 2020

      • d4rkie joined the channel
      • 2020-06-04 15617, 2020

      • D4RK-PH0ENiX has quit
      • 2020-06-04 15608, 2020

      • Chinmay3199 has quit
      • 2020-06-04 15643, 2020

      • discopatrick has quit
      • 2020-06-04 15647, 2020

      • alastairp has quit
      • 2020-06-04 15602, 2020

      • ishaanshah has quit
      • 2020-06-04 15608, 2020

      • chaban has quit
      • 2020-06-04 15618, 2020

      • prabal has quit
      • 2020-06-04 15629, 2020

      • mruszczyk has quit
      • 2020-06-04 15629, 2020

      • MightyJay has quit
      • 2020-06-04 15633, 2020

      • gr0uch0mars has quit
      • 2020-06-04 15637, 2020

      • outsidecontext has quit
      • 2020-06-04 15637, 2020

      • SomalRudra has quit
      • 2020-06-04 15643, 2020

      • shivam-kapila_ joined the channel
      • 2020-06-04 15645, 2020

      • diru1100_ joined the channel
      • 2020-06-04 15646, 2020

      • Mr_Monkey_ joined the channel
      • 2020-06-04 15650, 2020

      • KassOtsimine_ joined the channel
      • 2020-06-04 15651, 2020

      • MrBrave has quit
      • 2020-06-04 15652, 2020

      • KassOtsimine has quit
      • 2020-06-04 15653, 2020

      • diru1100 has quit
      • 2020-06-04 15653, 2020

      • KassOtsimine_ is now known as KassOtsimine
      • 2020-06-04 15653, 2020

      • diru1100_ is now known as diru1100
      • 2020-06-04 15603, 2020

      • reosarevok has quit
      • 2020-06-04 15604, 2020

      • Leftmost has quit
      • 2020-06-04 15607, 2020

      • revi has quit
      • 2020-06-04 15607, 2020

      • ruaok has quit
      • 2020-06-04 15607, 2020

      • HorusHorrendus has quit
      • 2020-06-04 15608, 2020

      • _lucifer has quit
      • 2020-06-04 15611, 2020

      • outsidecontext joined the channel
      • 2020-06-04 15612, 2020

      • Mr_Monkey has quit
      • 2020-06-04 15615, 2020

      • Mr_Monkey_ is now known as Mr_Monkey
      • 2020-06-04 15626, 2020

      • kuno has quit
      • 2020-06-04 15627, 2020

      • zas has quit
      • 2020-06-04 15630, 2020

      • kuno_ joined the channel
      • 2020-06-04 15645, 2020

      • shivam-kapila has quit
      • 2020-06-04 15645, 2020

      • iliekcomputers has quit
      • 2020-06-04 15645, 2020

      • Freso has quit
      • 2020-06-04 15655, 2020

      • shivam-kapila_ is now known as shivam-kapila
      • 2020-06-04 15658, 2020

      • MrBrave joined the channel
      • 2020-06-04 15611, 2020

      • gr0uch0mars joined the channel
      • 2020-06-04 15612, 2020

      • HorusHorrendus joined the channel
      • 2020-06-04 15642, 2020

      • SomalRudra joined the channel
      • 2020-06-04 15645, 2020

      • Leftmost joined the channel
      • 2020-06-04 15609, 2020

      • Freso joined the channel
      • 2020-06-04 15619, 2020

      • chaban joined the channel
      • 2020-06-04 15624, 2020

      • discopatrick joined the channel
      • 2020-06-04 15631, 2020

      • ruaok joined the channel
      • 2020-06-04 15637, 2020

      • iliekcomputers joined the channel
      • 2020-06-04 15603, 2020

      • alastairp joined the channel
      • 2020-06-04 15609, 2020

      • prabal joined the channel
      • 2020-06-04 15612, 2020

      • ishaanshah joined the channel
      • 2020-06-04 15616, 2020

      • mruszczyk joined the channel
      • 2020-06-04 15640, 2020

      • _lucifer joined the channel
      • 2020-06-04 15624, 2020

      • MightyJay joined the channel
      • 2020-06-04 15623, 2020

      • reosarevok joined the channel
      • 2020-06-04 15608, 2020

      • zas joined the channel
      • 2020-06-04 15657, 2020

      • MrBrave has quit
      • 2020-06-04 15642, 2020

      • MrBrave joined the channel
      • 2020-06-04 15612, 2020

      • revi joined the channel
      • 2020-06-04 15630, 2020

      • rdswift joined the channel
      • 2020-06-04 15624, 2020

      • Lotheric_ has quit
      • 2020-06-04 15649, 2020

      • Lotheric joined the channel
      • 2020-06-04 15650, 2020

      • Lotheric_ joined the channel
      • 2020-06-04 15640, 2020

      • Lotheric__ joined the channel
      • 2020-06-04 15645, 2020

      • Lotheric has quit
      • 2020-06-04 15622, 2020

      • Lotheric_ has quit
      • 2020-06-04 15623, 2020

      • Lotheric__ has quit
      • 2020-06-04 15618, 2020

      • KindTwo joined the channel
      • 2020-06-04 15611, 2020

      • KindOne has quit
      • 2020-06-04 15607, 2020

      • KindOne joined the channel
      • 2020-06-04 15637, 2020

      • KindTwo has quit
      • 2020-06-04 15629, 2020

      • KindTwo joined the channel
      • 2020-06-04 15648, 2020

      • KindOne has quit
      • 2020-06-04 15643, 2020

      • KindTwo is now known as KindOne