I'm gonna call it there for the day but high five alastairp, that was a productive hack!
2020-06-04 15613, 2020
alastairp
yeah, me too, thanks a lot!
2020-06-04 15617, 2020
alastairp
I think we have a lot of good stuff
2020-06-04 15626, 2020
alastairp
we should work out what the next step is
2020-06-04 15653, 2020
alastairp
we should get ishaanshah onboard with his specific endpoints
2020-06-04 15602, 2020
alastairp
especially because we're already using pydantic here!
2020-06-04 15636, 2020
alastairp
and work with iliekcomputers to prioritise fixing the rendering of the listens page
2020-06-04 15615, 2020
alastairp
Mr_Monkey: mmm, one thing I noticed that we don't have... you defined the AppProps type yourself. that should be a pydantic model too, and so we will be able to generate a schema for it
2020-06-04 15612, 2020
Mr_Monkey
Yeah, I guess that's what I clumsily asked earlier
2020-06-04 15610, 2020
Mr_Monkey
That round sit up nicely
2020-06-04 15610, 2020
alastairp
oh, I didn't even pick up on that, sorry!
2020-06-04 15640, 2020
alastairp
oh, I understand the question you asked now!
2020-06-04 15618, 2020
sumedh has quit
2020-06-04 15601, 2020
alastairp
ah, the other thing... do we care if the number of pages changes while we're on that screen?
2020-06-04 15635, 2020
alastairp
and - in the case of listens, this page updates. This is a slightly different feature than what we've been talking about (e.g. we'd probably need websockets or something)
2020-06-04 15642, 2020
alastairp
but something in general to think about
2020-06-04 15606, 2020
Mr_Monkey
There's already websockets implemented to update the listens page, if I'm not mistaken
2020-06-04 15619, 2020
Mr_Monkey
But I agree, a separate feature
2020-06-04 15608, 2020
Chinmay3199 has quit
2020-06-04 15623, 2020
sumedh joined the channel
2020-06-04 15644, 2020
alastairp
Mr_Monkey: for tomorrow - I updated but it can't find `tsc` when running npm build. and when I npm install tsc, I get `Argument for '--target' option must be 'ES3', 'ES5', or 'ES6'.` and `Unknown compiler option 'jsx'.`
2020-06-04 15654, 2020
rdswift has quit
2020-06-04 15606, 2020
rdswift joined the channel
2020-06-04 15604, 2020
chaban
Voting seems impossible right now due to ISE: `57014 DBD::Pg::st execute failed: ERROR: canceling statement due to statement timeout [for Statement "LOCK vote IN SHARE ROW EXCLUSIVE MODE"]`
2020-06-04 15605, 2020
chaban
Seen this kind of errors shortly after PG12 upgrade too.
reosarevok: probably adding a LIMIT to the inner query and deleting them in chunks...though we can drop the edit_recording, edit_note, and vote rows separately I think