this isn't still loading the datafiles, I'm looking into it
2020-06-24 17617, 2020
jmp_music
cool. thanks!
2020-06-24 17651, 2020
thomasross joined the channel
2020-06-24 17617, 2020
jmp_music
After fixing and testing gaia's results I would also to have a discussion about a research I did in parallelizing some of the processes in the new infrastructure with some relevant python libraries
I'm now seeing a UnicodeDecodeError when loading the yaml data files. it looks like this might be a problem with Gaia loading yaml files with python 3. I'll look into it after lunch
2020-06-24 17627, 2020
jmp_music
Oh ok! I'll add it to the PR. Let's see if everything would be ok after these changes.
2020-06-24 17635, 2020
sumedh joined the channel
2020-06-24 17638, 2020
jmp_music
have a good lunch time
2020-06-24 17616, 2020
thomasross has quit
2020-06-24 17608, 2020
outsidecontext
oh, it's nearly two years since Picard 2.0. Time goes fast
2020-06-24 17604, 2020
sumedh has quit
2020-06-24 17640, 2020
sumedh joined the channel
2020-06-24 17656, 2020
alastairp
jmp_music: hi, I've been looking into this in further detail
2020-06-24 17619, 2020
alastairp
it's clear that we didn't test this very well when we upgraded to python 3, there are issues all over the place
2020-06-24 17639, 2020
alastairp
I recommend that we revert back to python 2 for this, it's going to be much faster to get things going
I had a card based layou in mind for the stats page
2020-06-24 17622, 2020
ishaanshah
Different stats on different different cards
2020-06-24 17652, 2020
iliekcomputers
Right, sounds cool!
2020-06-24 17620, 2020
ishaanshah
I made the logging PR too
2020-06-24 17657, 2020
ishaanshah
Also found that the entity queries are a bit wrong
2020-06-24 17621, 2020
iliekcomputers
Ujson.dumps doesn't take the indent param, iirc
2020-06-24 17639, 2020
iliekcomputers
Reading through the logging pr
2020-06-24 17643, 2020
ishaanshah
Oh
2020-06-24 17656, 2020
ishaanshah
Didn't know that
2020-06-24 17606, 2020
ishaanshah
I will change that tomorrow
2020-06-24 17612, 2020
iliekcomputers
Sure!
2020-06-24 17642, 2020
ishaanshah
About the entity stats
2020-06-24 17627, 2020
ishaanshah
The group by was not working correctly because we had to apply the functions applied in select to group by too
2020-06-24 17645, 2020
iliekcomputers
Oh.
2020-06-24 17656, 2020
CatQuest
Mr_Monkey: I actually came over yet another artist-work relation here: "gjendikted" (basically literally re-poemwriting ("dikting" is a verbified "dikt"(poem), a writing that's specific for poetry, "oppdiktet" is our word for "made up")
2020-06-24 17656, 2020
CatQuest
which I belive is similar, but different from "translated" what are your thoughts
2020-06-24 17656, 2020
iliekcomputers
Is that why we had the validation errors yesterday?
2020-06-24 17602, 2020
ishaanshah
I am updating the tests so that we will check that too
2020-06-24 17623, 2020
ishaanshah
> Is that why we had the validation errors yesterday?
2020-06-24 17623, 2020
ishaanshah
I dont think so
2020-06-24 17639, 2020
ishaanshah
Ideally there shouldnt have been a validation error
2020-06-24 17646, 2020
CatQuest
(in this case it's a poem-y short picture-book (think dr seuss-y) where a (rather famous) native writer has "rewritten" it)
2020-06-24 17654, 2020
ishaanshah
Because I put it in try except
2020-06-24 17618, 2020
ishaanshah
Not sure though
2020-06-24 17630, 2020
iliekcomputers
Hmm, we'll have to look into it, I guess
2020-06-24 17633, 2020
jmp_music has quit
2020-06-24 17642, 2020
ishaanshah
We will know for sure after the logging starts
2020-06-24 17645, 2020
Mr_Monkey
Hm, interesting. I see the distinction, but don't know of a word for it in English nor French
2020-06-24 17651, 2020
iliekcomputers
👍🏽
2020-06-24 17633, 2020
Mr_Monkey
"reinterpreted"
2020-06-24 17648, 2020
ishaanshah
I didn't see the validation error in sentry though
2020-06-24 17622, 2020
iliekcomputers
ishaanshah: yeah, there was an error while connecting to sentry too, that's why I pasted the logs here :D
2020-06-24 17650, 2020
ishaanshah
Oh
2020-06-24 17616, 2020
ishaanshah
Was it only one message or multiple?
2020-06-24 17635, 2020
iliekcomputers
It was multiple iirc
2020-06-24 17641, 2020
ishaanshah
Oh
2020-06-24 17647, 2020
iliekcomputers
The logs should have the details, I might be wrong
2020-06-24 17601, 2020
iliekcomputers
I reverted the consumers to an older version for now
2020-06-24 17617, 2020
ishaanshah
Yeah that makes sense
2020-06-24 17644, 2020
ishaanshah
We should trigger after merging the logging PR
2020-06-24 17605, 2020
ishaanshah
Pydantic is actually proving to be useful
2020-06-24 17606, 2020
iliekcomputers
ishaanshah: yeah, sounds like a plan
2020-06-24 17612, 2020
iliekcomputers
Indeed. :)
2020-06-24 17628, 2020
ishaanshah
We wouldn't have caught these errors without validation
2020-06-24 17634, 2020
iliekcomputers
Asserting on assumptions in production is always a good idea.
2020-06-24 17652, 2020
CatQuest
Mr_Monkey: ah never mind, inside the book it says "oversatt" (translated)
2020-06-24 17652, 2020
CatQuest
but yea maybe we shoudl ahve a "reinterpreated" *atribute* on the "translated" rel?
2020-06-24 17658, 2020
iliekcomputers
Surprises always pop up.
2020-06-24 17605, 2020
CatQuest
(once atributes are up and running)
2020-06-24 17623, 2020
ishaanshah
Yep
2020-06-24 17640, 2020
ishaanshah
Cool, thats all I had for today
2020-06-24 17648, 2020
Mr_Monkey
Or a sub-relationship? We have provisions for multiple levels, although I don't think it's implemented that way on the website itself
2020-06-24 17649, 2020
ishaanshah
Give 10 mins
2020-06-24 17602, 2020
ishaanshah
I will update ujson to json
2020-06-24 17615, 2020
CatQuest
Mr_Monkey: that would be the aforementioned "parent_id/ child_id" thing, yes
2020-06-24 17624, 2020
iliekcomputers
Cool! I'm assuming you're tracking the issues, because I tend to forget without tickets.
ok alastairp! Thus, I should also change and the other issues we resolved to be compatible with the 2.7 version, e.g. the items() --> iteritems(), right?
2020-06-24 17627, 2020
BrainzGit
[musicbrainz-server] mwiencek merged pull request #1569 (master…MBS-10894-label_code_in_reelase_editor): MBS-10894: Add LC code in help bubble after adding label in release editor https://github.com/metabrainz/musicbrainz-server/…
