15:47 PM
iliekcomputers
Oh right
2020-06-25 17706, 2020
15:47 PM
iliekcomputers
Sorry
2020-06-25 17710, 2020
15:47 PM
ruaok
that's the whole point of trying this again.
2020-06-25 17710, 2020
15:47 PM
ruaok
np
2020-06-25 17711, 2020
15:47 PM
iliekcomputers
Yeah, I can do that.
2020-06-25 17714, 2020
15:47 PM
ruaok
thx
2020-06-25 17745, 2020
15:47 PM
ruaok
2020-06-25 17758, 2020
15:47 PM
ruaok
not a lot of window dressing yet.
2020-06-25 17746, 2020
15:48 PM
ruaok
I also realized just not that this a permanent script, not a one-off. let me integrate this into manage.py ...
2020-06-25 17718, 2020
15:49 PM
iliekcomputers
I was just gonna say that :)
2020-06-25 17744, 2020
15:49 PM
ruaok
2020-06-25 17753, 2020
15:49 PM
ruaok
hmmm. visual basic for the 21st century.
2020-06-25 17706, 2020
15:55 PM
ishaanshah
iliekcomputers: sure
2020-06-25 17709, 2020
16:15 PM
iliekcomputers
ishaanshah: nvm, i got free
2020-06-25 17717, 2020
16:15 PM
iliekcomputers
you wanna talk now?
2020-06-25 17737, 2020
16:15 PM
ruaok
2020-06-25 17716, 2020
16:16 PM
iliekcomputers
ruaok: yes! thank you. that looks great
2020-06-25 17724, 2020
16:16 PM
ruaok
np
2020-06-25 17725, 2020
16:16 PM
iliekcomputers
there is an extra / after spark_dump though
2020-06-25 17748, 2020
16:16 PM
iliekcomputers
not sure if that's significant
2020-06-25 17705, 2020
16:17 PM
ruaok
that's a find artifact. I just checked. :)
2020-06-25 17721, 2020
16:18 PM
ishaanshah
iliekcomputers: give me 2 mins
2020-06-25 17702, 2020
16:19 PM
iliekcomputers
ruaok: nice :D
2020-06-25 17711, 2020
16:20 PM
BrainzGit
2020-06-25 17712, 2020
16:20 PM
BrainzBot
2020-06-25 17731, 2020
16:22 PM
ishaanshah
iliekcomputers: Hi
2020-06-25 17737, 2020
16:22 PM
iliekcomputers
hey!
2020-06-25 17712, 2020
16:23 PM
jmp_music has quit
2020-06-25 17729, 2020
16:23 PM
ishaanshah
Worked on listening activty frontend today
2020-06-25 17733, 2020
16:23 PM
ishaanshah
activity*
2020-06-25 17750, 2020
16:23 PM
ishaanshah
2020-06-25 17708, 2020
16:24 PM
iliekcomputers
!m ishaanshah
2020-06-25 17708, 2020
16:24 PM
BrainzBot
You're doing good work, ishaanshah!
2020-06-25 17715, 2020
16:24 PM
ishaanshah
still have to add the header and buttons
2020-06-25 17719, 2020
16:24 PM
iliekcomputers
that looks amazing
2020-06-25 17754, 2020
16:24 PM
ishaanshah
Thanks :D
2020-06-25 17754, 2020
16:24 PM
ishaanshah
It will look even better with the new design
2020-06-25 17719, 2020
16:25 PM
ishaanshah
right now the cards are looking a bit out of place, but will be fixed soon enough
2020-06-25 17722, 2020
16:25 PM
iliekcomputers
could we add a scale on the y axis too?
2020-06-25 17743, 2020
16:25 PM
ishaanshah
Yep, we should
2020-06-25 17754, 2020
16:25 PM
ishaanshah
I will do that
2020-06-25 17706, 2020
16:26 PM
ishaanshah
I have to add a legend too
2020-06-25 17726, 2020
16:26 PM
iliekcomputers
yep, makes sense
2020-06-25 17738, 2020
16:26 PM
iliekcomputers
i'm a bit concerned on the name of the tab
2020-06-25 17750, 2020
16:26 PM
iliekcomputers
there's no real difference between statistics and charts
2020-06-25 17707, 2020
16:27 PM
ishaanshah
Hmm
2020-06-25 17720, 2020
16:27 PM
ishaanshah
I dont like the charts name
2020-06-25 17730, 2020
16:27 PM
ishaanshah
But I can't think of anything better
2020-06-25 17711, 2020
16:28 PM
iliekcomputers
last.fm uses library for the entity charts
2020-06-25 17735, 2020
16:28 PM
iliekcomputers
and reports for the stats
2020-06-25 17716, 2020
16:29 PM
ishaanshah
I dont like the library name too
2020-06-25 17723, 2020
16:29 PM
ishaanshah
It doesnt make sense
2020-06-25 17751, 2020
16:29 PM
ishaanshah
Reports instead of statistics sounds good though
2020-06-25 17704, 2020
16:30 PM
iliekcomputers
ok, let's do reports
2020-06-25 17715, 2020
16:30 PM
iliekcomputers
if we get user feedback that it's confusing, we'll think about it more
2020-06-25 17718, 2020
16:30 PM
ishaanshah
So reports and charts?
2020-06-25 17725, 2020
16:30 PM
iliekcomputers
for now, sure
2020-06-25 17743, 2020
16:30 PM
ishaanshah
Cool, I will change that
2020-06-25 17714, 2020
16:31 PM
iliekcomputers
awesome
2020-06-25 17720, 2020
16:31 PM
iliekcomputers
i'll deploy the stuff i merged today
2020-06-25 17727, 2020
16:31 PM
ishaanshah
Other than that improved the all_time query
2020-06-25 17740, 2020
16:31 PM
iliekcomputers
oh cool, yeah i looked at that, looked good
2020-06-25 17744, 2020
16:31 PM
iliekcomputers
i'll bring that in too
2020-06-25 17745, 2020
16:31 PM
ishaanshah
it came down to 2 mins from 3.5 mins on local env
2020-06-25 17702, 2020
16:32 PM
ishaanshah
but the number of listens in full dump is a lot more
2020-06-25 17706, 2020
16:32 PM
ishaanshah
So lets see
2020-06-25 17709, 2020
16:32 PM
iliekcomputers
yeah
2020-06-25 17752, 2020
16:32 PM
D4RK-PH0ENiX has quit
2020-06-25 17710, 2020
16:33 PM
iliekcomputers
cool, hopefully we'll have the sentry errors that were blocking you by tomorrow
2020-06-25 17721, 2020
16:33 PM
ishaanshah
I think I am gonna need a bit more time for the frontend
2020-06-25 17746, 2020
16:33 PM
iliekcomputers
sure, no rush
2020-06-25 17750, 2020
16:33 PM
ishaanshah
Will try to get it to work by next tuesday
2020-06-25 17756, 2020
16:33 PM
iliekcomputers
sounds good to me
2020-06-25 17747, 2020
16:34 PM
ishaanshah
Cool, thats all I had for today
2020-06-25 17750, 2020
16:34 PM
iliekcomputers
i don't have anything else
2020-06-25 17707, 2020
16:35 PM
iliekcomputers
cool, i'll deploy this stuff
2020-06-25 17720, 2020
16:35 PM
ishaanshah
Sounds good
2020-06-25 17754, 2020
16:35 PM
iliekcomputers
ishaanshah: i wonder though
2020-06-25 17701, 2020
16:36 PM
iliekcomputers
sorry, this might be a bit too late
2020-06-25 17737, 2020
16:36 PM
iliekcomputers
2020-06-25 17703, 2020
16:37 PM
iliekcomputers
given that we have discrete data, not continuous
2020-06-25 17729, 2020
16:38 PM
ishaanshah
I am not particularly against it, but I kind of prefer line graph
2020-06-25 17731, 2020
16:38 PM
D4RK-PH0ENiX joined the channel
2020-06-25 17738, 2020
16:38 PM
ishaanshah
It looks sleek
2020-06-25 17708, 2020
16:39 PM
ishaanshah
Although I can add an option to choose the type of graph
2020-06-25 17715, 2020
16:39 PM
ishaanshah
bar or line
2020-06-25 17706, 2020
16:40 PM
iliekcomputers
let's keep it a line graph for now.
2020-06-25 17719, 2020
16:40 PM
iliekcomputers
no need to waste your work.
2020-06-25 17728, 2020
16:40 PM
iliekcomputers
we'll look into it later if we get the time
2020-06-25 17736, 2020
16:40 PM
ishaanshah
I will open a ticket for the bar option too
2020-06-25 17754, 2020
16:40 PM
ishaanshah
Some people might prefer that as you said
2020-06-25 17726, 2020
16:46 PM
ishaanshah
LB-644
2020-06-25 17727, 2020
16:46 PM
BrainzBot
2020-06-25 17727, 2020
16:47 PM
sumedh has quit
2020-06-25 17724, 2020
16:48 PM
iliekcomputers
thanks!
2020-06-25 17758, 2020
16:49 PM
CatQuest
prabal: for "add to collection" I'd have it on the edition page and ot have a popup modal (I kinda dislike those tho :D)
2020-06-25 17744, 2020
16:50 PM
prabal
Yees the plan to add the option in both entity page
2020-06-25 17754, 2020
16:50 PM
prabal
And from search results
2020-06-25 17735, 2020
16:52 PM
prabal
Are you saying to have it only on entity page?
2020-06-25 17752, 2020
16:52 PM
BrainzGit
2020-06-25 17714, 2020
16:54 PM
prabal
2020-06-25 17720, 2020
16:54 PM
JoshDi has quit
2020-06-25 17736, 2020
16:55 PM
BrainzGit
2020-06-25 17759, 2020
16:55 PM
Mr_Monkey
On emore PR merged ! 🎉
2020-06-25 17736, 2020
16:59 PM
iliekcomputers
ishaanshah: running the all-time query
2020-06-25 17739, 2020
16:59 PM
travis-ci joined the channel
2020-06-25 17739, 2020
16:59 PM
travis-ci
2020-06-25 17739, 2020
16:59 PM
travis-ci has left the channel
2020-06-25 17723, 2020
17:03 PM
iliekcomputers
and it's done
2020-06-25 17725, 2020
17:03 PM
iliekcomputers
2020-06-25 17748, 2020
17:04 PM
iliekcomputers
ruaok: new dump triggered
2020-06-25 17707, 2020
17:05 PM
ruaok
Thx!
2020-06-25 17717, 2020
17:07 PM
BrainzGit
2020-06-25 17755, 2020
17:07 PM
ishaanshah
iliekcomputers: how much time did it take?
2020-06-25 17712, 2020
17:08 PM
BrainzGit
2020-06-25 17730, 2020
17:08 PM
iliekcomputers
less than a minute
2020-06-25 17739, 2020
17:08 PM
iliekcomputers
the joys of explain/analyze
2020-06-25 17750, 2020
17:08 PM
ishaanshah
Noice
2020-06-25 17730, 2020
17:09 PM
iliekcomputers
pristine___: hey
2020-06-25 17754, 2020
17:09 PM
iliekcomputers
i'm trying to estimate how much time each job needed for recommendations takes
2020-06-25 17728, 2020
17:10 PM
iliekcomputers
do you have an idea ? it'll help me figure out how much time i'll have to monitor this stuff
2020-06-25 17702, 2020
17:19 PM
alastairp
Mr_Monkey: hi, still working?
2020-06-25 17710, 2020
17:19 PM
Mr_Monkey
yep
2020-06-25 17722, 2020
17:19 PM
Mr_Monkey
What's on your mind?
2020-06-25 17725, 2020
17:19 PM
alastairp
got time to design a bikeshed?
2020-06-25 17734, 2020
17:19 PM
alastairp
2020-06-25 17751, 2020
17:19 PM
alastairp
I'm adding documentation to this page, the idea is to explain what each setting means
2020-06-25 17716, 2020
17:20 PM
alastairp
thoughts on where to put it? we have the whole right hand side of the page. it's in bootstrap too, so it should be pretty responsive if the screen gets smaller
2020-06-25 17753, 2020
17:20 PM
alastairp
my two ideas are to have it permanently on the right side, or alternatively, have individual (?) buttons next to each field that show a popup
2020-06-25 17709, 2020
17:21 PM
Mr_Monkey
Ding ding ! I'd go for #2
2020-06-25 17736, 2020
17:21 PM
alastairp
oh?
2020-06-25 17737, 2020
17:21 PM
Mr_Monkey
2020-06-25 17745, 2020
17:21 PM
alastairp
it's not react :(
2020-06-25 17750, 2020
17:21 PM
Mr_Monkey
Yeah, tooltips are my fave
2020-06-25 17757, 2020
17:21 PM
Mr_Monkey
Ah, well. Still Bootstrap, though.
2020-06-25 17711, 2020
17:22 PM
alastairp
cool, I see it
2020-06-25 17714, 2020
17:22 PM
Mr_Monkey
2020-06-25 17734, 2020
17:22 PM
alastairp
what do you think - next to the key/title, or to the right of the field?
2020-06-25 17747, 2020
17:22 PM
Mr_Monkey
Yeah. I find it's easy for users to find if they want to, but it moves a lot of -possibly blocky- content out of the way
2020-06-25 17755, 2020
17:22 PM
alastairp
I guess this means that we can't add links to the tooltips either
2020-06-25 17702, 2020
17:23 PM
Mr_Monkey
Next to the key I think
2020-06-25 17710, 2020
17:23 PM
Mr_Monkey
They should support basic html
2020-06-25 17731, 2020
17:23 PM
alastairp
it's OK, I think we'll be ok here. I can have some descriptive text, and then the (?) as well. let me mock it up
2020-06-25 17734, 2020
17:23 PM
alastairp
oh? cool. I'll try
2020-06-25 17747, 2020
17:23 PM
alastairp
now I also need a "reset to defaults" button for the last 3 items
2020-06-25 17754, 2020
17:23 PM
v6lur has quit
2020-06-25 17754, 2020
17:23 PM
alastairp
to the right of the field?
2020-06-25 17745, 2020
17:24 PM
Mr_Monkey
You want them separate? Or would a single "use defaults" that resets the items you're interested in work?
2020-06-25 17714, 2020
17:25 PM
Mr_Monkey
If not, right of the filed, yes. For the inputs, I'd suggest input buttons
2020-06-25 17730, 2020
17:25 PM
Mr_Monkey