#metabrainz

Oh right

Sorry

that's the whole point of trying this again.

np

Yeah, I can do that.

thx

not a lot of window dressing yet.

I also realized just not that this a permanent script, not a one-off. let me integrate this into manage.py ...

I was just gonna say that :)

hmmm. visual basic for the 21st century.

iliekcomputers: sure

ishaanshah: nvm, i got free

you wanna talk now?

iliekcomputers: https://gist.github.com/mayhem/630f9eb20dd85a27... better?

ruaok: yes! thank you. that looks great

np

there is an extra / after spark_dump though

not sure if that's significant

that's a find artifact. I just checked. :)

iliekcomputers: give me 2 mins

ruaok: nice :D

[acousticbrainz-server] alastair opened pull request #381 (ab439-hl-threads…ab439-multi-extractor): AB-349 (II): Process multiple documents with the highlevel extractor at once https://github.com/metabrainz/acousticbrainz-se...

AB-349: Get data for more foreign key referenced tables https://tickets.metabrainz.org/browse/AB-349

iliekcomputers: Hi

hey!

Worked on listening activty frontend today

activity*

!m ishaanshah

You're doing good work, ishaanshah!

still have to add the header and buttons

that looks amazing

Thanks :D

It will look even better with the new design

right now the cards are looking a bit out of place, but will be fixed soon enough

could we add a scale on the y axis too?

Yep, we should

I will do that

I have to add a legend too

yep, makes sense

i'm a bit concerned on the name of the tab

there's no real difference between statistics and charts

Hmm

I dont like the charts name

But I can't think of anything better

last.fm uses library for the entity charts

and reports for the stats

I dont like the library name too

It doesnt make sense

Reports instead of statistics sounds good though

ok, let's do reports

if we get user feedback that it's confusing, we'll think about it more

So reports and charts?

for now, sure

Cool, I will change that

awesome

i'll deploy the stuff i merged today

Other than that improved the all_time query

oh cool, yeah i looked at that, looked good

i'll bring that in too

it came down to 2 mins from 3.5 mins on local env

but the number of listens in full dump is a lot more

So lets see

yeah

cool, hopefully we'll have the sentry errors that were blocking you by tomorrow

I think I am gonna need a bit more time for the frontend

sure, no rush

Will try to get it to work by next tuesday

sounds good to me

Cool, thats all I had for today

i don't have anything else

cool, i'll deploy this stuff

Sounds good

ishaanshah: i wonder though

sorry, this might be a bit too late

would something like this be more appropriate for what info we're trying to show https://usercontent.irccloud-cdn.com/file/H5ZNu...

given that we have discrete data, not continuous

I am not particularly against it, but I kind of prefer line graph

It looks sleek

Although I can add an option to choose the type of graph

bar or line

let's keep it a line graph for now.

no need to waste your work.

we'll look into it later if we get the time

I will open a ticket for the bar option too

Some people might prefer that as you said

LB-644

LB-644: Add option to view listening activity stats as a bar graph. https://tickets.metabrainz.org/browse/LB-644

thanks!

prabal: for "add to collection" I'd have it on the edition page and ot have a popup modal (I kinda dislike those tho :D)

Yees the plan to add the option in both entity page

And from search results

Are you saying to have it only on entity page?

[listenbrainz-server] paramsingh merged pull request #931 (master…all_time_listening_activity): Improve query for all time "Listening Activity" statsistics https://github.com/metabrainz/listenbrainz-serv...

CatQuest: have a look at these mockups if you have time? https://community.metabrainz.org/t/gsoc-2020-us...

[bookbrainz-site] MonkeyDo merged pull request #434 (UserCollection…editor-collections): Collections: Editor Profile Tab https://github.com/bookbrainz/bookbrainz-site/p...

On emore PR merged ! 🎉

ishaanshah: running the all-time query

Project bookbrainz-site build #3167: passed in 3 min 28 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

and it's done

ruaok: new dump triggered

Thx!

[listenbrainz-server] release v-2020-06-25.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-serv...

iliekcomputers: how much time did it take?

[listenbrainz-server] paramsingh merged pull request #922 (master…param-obj): use parameter object to handle function arguments https://github.com/metabrainz/listenbrainz-serv...

less than a minute

the joys of explain/analyze

Noice

pristine___: hey

i'm trying to estimate how much time each job needed for recommendations takes

do you have an idea ? it'll help me figure out how much time i'll have to monitor this stuff

Mr_Monkey: hi, still working?

yep

What's on your mind?

got time to design a bikeshed?

I'm adding documentation to this page, the idea is to explain what each setting means

thoughts on where to put it? we have the whole right hand side of the page. it's in bootstrap too, so it should be pretty responsive if the screen gets smaller

my two ideas are to have it permanently on the right side, or alternatively, have individual (?) buttons next to each field that show a popup

Ding ding ! I'd go for #2

oh?

You can reuse these react components: https://bookbrainz.org/work/create

it's not react :(

Yeah, tooltips are my fave

Ah, well. Still Bootstrap, though.

cool, I see it

what do you think - next to the key/title, or to the right of the field?

Yeah. I find it's easy for users to find if they want to, but it moves a lot of -possibly blocky- content out of the way

I guess this means that we can't add links to the tooltips either

They should support basic html

it's OK, I think we'll be ok here. I can have some descriptive text, and then the (?) as well. let me mock it up

oh? cool. I'll try

now I also need a "reset to defaults" button for the last 3 items

to the right of the field?

You want them separate? Or would a single "use defaults" that resets the items you're interested in work?

If not, right of the filed, yes. For the inputs, I'd suggest input buttons