17:25 PM
alastairp
C, Gama, and Preprocessing all need an independent reset button
2020-06-25 17714, 2020
17:26 PM
alastairp
button addon looks good
2020-06-25 17734, 2020
17:26 PM
Mr_Monkey
And for the checkboxes, I guess another list item that's a "reset" button
2020-06-25 17714, 2020
17:27 PM
alastairp
it'd be nice to put it to the right of 'basic', directly under where the reset button for gamma will be. not sure
2020-06-25 17736, 2020
17:27 PM
alastairp
maybe I can do x cols for gamma, and x-1 cols for preprocessing, and an extra col for reset
2020-06-25 17704, 2020
17:29 PM
Mr_Monkey
You can try the class `pull-right` on your button. If you're lucky and sacrifice three live flies to the CSS gods it might align to the top-right of the row that contains the preprocessing values section.
2020-06-25 17715, 2020
17:29 PM
Mr_Monkey
If not, add more flies.
2020-06-25 17727, 2020
17:29 PM
alastairp
yeah, I've got experience doing that
2020-06-25 17730, 2020
17:29 PM
alastairp
thanks!
2020-06-25 17702, 2020
17:30 PM
alastairp
I think you're right, some things here might be much easier to do in react. I haven't even asked you about hiding fieldsets and expanding them when a button is clicked ;)
2020-06-25 17757, 2020
17:30 PM
Mr_Monkey
2020-06-25 17707, 2020
17:31 PM
alastairp
exactly like that!
2020-06-25 17734, 2020
17:31 PM
alastairp looks sideways at bootstrap 2
2020-06-25 17742, 2020
17:31 PM
Mr_Monkey
Oh frameworks, how much CSS would we actually have to do without you?
2020-06-25 17738, 2020
17:41 PM
prabal
Mr_Monkey: which do you prefer React Class or function?
2020-06-25 17755, 2020
17:41 PM
Mr_Monkey
If you don't need a state, functional class is better
2020-06-25 17714, 2020
17:42 PM
Mr_Monkey
er… functional component*
2020-06-25 17755, 2020
17:42 PM
prabal
:P
2020-06-25 17757, 2020
17:42 PM
prabal
2020-06-25 17702, 2020
17:43 PM
prabal
I am converting this to class
2020-06-25 17713, 2020
17:43 PM
prabal
i need to use state here
2020-06-25 17718, 2020
17:43 PM
prabal
is that alright?
2020-06-25 17733, 2020
17:43 PM
Mr_Monkey
If it's needed there, then no problem
2020-06-25 17755, 2020
17:43 PM
prabal
okay thanks!
2020-06-25 17758, 2020
17:43 PM
prabal
(Y)
2020-06-25 17700, 2020
17:44 PM
prabal
(y)
2020-06-25 17702, 2020
17:44 PM
prabal
huh?
2020-06-25 17706, 2020
17:44 PM
Mr_Monkey
The general advice is: if you don't need state or lifecycle events, prefr functional components. If not, class it is
2020-06-25 17709, 2020
17:44 PM
prabal
👍
2020-06-25 17730, 2020
17:44 PM
prabal
okayy
2020-06-25 17744, 2020
17:44 PM
Mr_Monkey
(I'll admit my opinion is only based on reading some articles, but…)
2020-06-25 17702, 2020
17:45 PM
Mr_Monkey
2020-06-25 17713, 2020
17:46 PM
Mr_Monkey
prabal: Why do you need the state specifically in the footer?
2020-06-25 17719, 2020
17:46 PM
Mr_Monkey
Out of curiosity
2020-06-25 17721, 2020
17:46 PM
prabal
add to collection
2020-06-25 17726, 2020
17:46 PM
prabal
modal
2020-06-25 17738, 2020
17:46 PM
Mr_Monkey
Right, makes sense.
2020-06-25 17714, 2020
17:47 PM
prabal
Yepp
2020-06-25 17712, 2020
18:05 PM
alastairp
Mr_Monkey: what are your thoughts on using a checkbox as the way of toggling a collapsable block?
2020-06-25 17726, 2020
18:05 PM
alastairp
the idea is that you'd have a box which says [ ] use advanced features
2020-06-25 17732, 2020
18:05 PM
alastairp
checking it will show the advanced features
2020-06-25 17724, 2020
18:36 PM
Mr_Monkey
alastairp: I'd say if your form has chekboxes for actual form info and you just want to show/hide some elements, checkbox isn't a good choice.
2020-06-25 17712, 2020
18:37 PM
Mr_Monkey
There are toggles (checkboxes with fancy CSS), buttons, button links and I'm sure other solutions that could work
2020-06-25 17703, 2020
18:39 PM
iliekcomputers
pristine___: hey, i ran your code, i think there are a couple of bugs, which is why nothing got written to the db
2020-06-25 17705, 2020
18:39 PM
alastairp
2020-06-25 17712, 2020
18:39 PM
alastairp
Mr_Monkey: this is what I was thinking
2020-06-25 17738, 2020
18:39 PM
ruaok
pristine___: but loads of notification emails being sent. 🤣
2020-06-25 17745, 2020
18:39 PM
Mr_Monkey
Yeah, I think that's more confusing that it needs to be
2020-06-25 17748, 2020
18:39 PM
alastairp
the "nice" thing about this is that I'd have the values of these checkboxes on the server, so it makes validation nice
2020-06-25 17709, 2020
18:40 PM
Mr_Monkey
Ah, meaning if they are checked you know to use the defaults?
2020-06-25 17723, 2020
18:40 PM
alastairp
yeah, the reverse. if they're unchecked I'll use defaults
2020-06-25 17727, 2020
18:40 PM
alastairp
if checked, use whatever is set
2020-06-25 17735, 2020
18:40 PM
Mr_Monkey
Er, right.
2020-06-25 17744, 2020
18:40 PM
alastairp
so, by default it'll look like this:
2020-06-25 17701, 2020
18:41 PM
alastairp
2020-06-25 17706, 2020
18:41 PM
alastairp
and you can just hit evaluate if you want
2020-06-25 17727, 2020
18:41 PM
Mr_Monkey
Right. In this case, they're part of the form, so checkboxes make sense
2020-06-25 17729, 2020
18:41 PM
alastairp
if you think there's a visual way of making it look better, we can definitely talk about that
2020-06-25 17745, 2020
18:41 PM
alastairp
if that means representing these 2 checkboxes in a different way, fine
2020-06-25 17720, 2020
18:43 PM
ruaok
iliekcomputers: you still about?
2020-06-25 17734, 2020
18:43 PM
iliekcomputers
ruaok: yea
2020-06-25 17753, 2020
18:43 PM
iliekcomputers
disclaimer: might be a little braindead
2020-06-25 17701, 2020
18:44 PM
ruaok
I've received a few hunded "recommendations being written into DB" emails.
2020-06-25 17713, 2020
18:45 PM
iliekcomputers
Huh
2020-06-25 17722, 2020
18:45 PM
ruaok
and its still going.
2020-06-25 17732, 2020
18:45 PM
iliekcomputers
Whoops
2020-06-25 17740, 2020
18:45 PM
ruaok
since I've pinged you I've gotten another 60 or so.
2020-06-25 17745, 2020
18:45 PM
iliekcomputers
That's the recommendation job, sorry about that.
2020-06-25 17704, 2020
18:46 PM
iliekcomputers
Looks like it's not handling emails correctly
2020-06-25 17706, 2020
18:46 PM
ruaok
I'll make a filter for now.
2020-06-25 17729, 2020
18:46 PM
iliekcomputers
I'll open a ticket for pristine___ , that shouldn't happen.
2020-06-25 17753, 2020
18:46 PM
iliekcomputers
Sorry about that, I haven't really read this part of the code, didn't know it was sending an email per user...
2020-06-25 17723, 2020
18:47 PM
ruaok
yeah, I didn't catch that either.
2020-06-25 17724, 2020
18:49 PM
iliekcomputers
I think it's a bug, the table has nothing.
2020-06-25 17736, 2020
18:49 PM
iliekcomputers
🤷🏽♂️
2020-06-25 17744, 2020
18:49 PM
iliekcomputers
I'll open a few tickets
2020-06-25 17754, 2020
18:49 PM
iliekcomputers
And purge the queuw
2020-06-25 17702, 2020
18:50 PM
ruaok
th
2020-06-25 17703, 2020
18:50 PM
ruaok
x
2020-06-25 17722, 2020
18:50 PM
ruaok
now that my brain fog has lifted, I'm finally going to play with recommendation stuff.
2020-06-25 17732, 2020
18:50 PM
iliekcomputers
Queue has been purged
2020-06-25 17749, 2020
18:50 PM
iliekcomputers
Cool!
2020-06-25 17711, 2020
18:51 PM
iliekcomputers
I figure pristine___'s work should have an API endpoint on prod soon
2020-06-25 17722, 2020
18:51 PM
iliekcomputers
Once the bugs are ironed out
2020-06-25 17751, 2020
18:51 PM
ruaok
yeah, I've got several more support objects to write.
2020-06-25 17708, 2020
18:52 PM
ruaok
tonights goal is to fetch some user stats and do the MSID->MBID translation
2020-06-25 17726, 2020
18:52 PM
iliekcomputers
The user stats are in the latest dump btw
2020-06-25 17735, 2020
18:52 PM
iliekcomputers
If you don't wanna go through the API endpoint
2020-06-25 17753, 2020
18:55 PM
ruaok
I specifically want to go through the API endpoint.
2020-06-25 17738, 2020
18:56 PM
ruaok
I'm hoping to make everything work with APIs, so that devs can download one simple python program and its deps and get rolling
2020-06-25 17715, 2020
18:58 PM
iliekcomputers
Right, makes sense
2020-06-25 17712, 2020
18:59 PM
iliekcomputers
2020-06-25 17713, 2020
18:59 PM
BrainzBot
LB-645: Recommendation pipeline bugs
2020-06-25 17717, 2020
19:00 PM
iliekcomputers
2020-06-25 17718, 2020
19:00 PM
BrainzBot
LB-646: the recommended recordings endpoint says /artist
2020-06-25 17744, 2020
19:07 PM
iliekcomputers
2020-06-25 17745, 2020
19:07 PM
BrainzBot
LB-648: Allow ability to ask for generation of recommendations for list of users
2020-06-25 17735, 2020
19:10 PM
iliekcomputers
2020-06-25 17731, 2020
19:18 PM
iliekcomputers
huh looking more into it, this is probably me not doing the schema change correctly
2020-06-25 17703, 2020
19:21 PM
travis-ci joined the channel
2020-06-25 17703, 2020
19:21 PM
travis-ci
2020-06-25 17703, 2020
19:21 PM
travis-ci has left the channel
2020-06-25 17739, 2020
19:27 PM
iliekcomputers
ruaok: looks like it was my fault, i've disabled emails and run the job again
2020-06-25 17757, 2020
19:27 PM
ruaok
thanks for chasing that down.
2020-06-25 17722, 2020
19:32 PM
travis-ci joined the channel
2020-06-25 17722, 2020
19:32 PM
travis-ci
2020-06-25 17722, 2020
19:32 PM
travis-ci has left the channel
2020-06-25 17727, 2020
19:34 PM
ruaok
2020-06-25 17739, 2020
19:34 PM
ruaok
for people who copy URLs and don't fully fix them.
2020-06-25 17752, 2020
19:34 PM
ruaok is suggesting this for a friend, of course
2020-06-25 17732, 2020
19:41 PM
iliekcomputers
heh
2020-06-25 17750, 2020
19:41 PM
ruaok
> count (int) – Optional, number of recordings to return, Default: DEFAULT_ITEMS_PER_GET Max: MAX_ITEMS_PER_GET
2020-06-25 17734, 2020
19:42 PM
ruaok
taken from the stats docs. I don't see where the actual values of these are defined. it would be nice that for user's sake we listed the actual values in this place.
2020-06-25 17734, 2020
19:42 PM
iliekcomputers
this reminds me
2020-06-25 17747, 2020
19:42 PM
iliekcomputers
2020-06-25 17749, 2020
19:43 PM
ruaok
I'd use that right this second. :)
2020-06-25 17710, 2020
19:44 PM
iliekcomputers
on my list for tomorrow
2020-06-25 17716, 2020
19:45 PM
ruaok
does it have rate limiting support?
2020-06-25 17727, 2020
19:45 PM
ruaok
if it does, I'll switch to it.
2020-06-25 17733, 2020
19:45 PM
iliekcomputers
yes
2020-06-25 17734, 2020
19:45 PM
ruaok
in a heartbeat
2020-06-25 17756, 2020
19:45 PM
ruaok
great, then I won't put a lot of effort into this code and just slap it together for my needs tonight.
2020-06-25 17707, 2020
19:47 PM
iliekcomputers
yes!
2020-06-25 17712, 2020
19:47 PM
iliekcomputers
first user lol
2020-06-25 17721, 2020
19:47 PM
iliekcomputers
#dogfooding
2020-06-25 17723, 2020
19:47 PM
ruaok
hehehe
2020-06-25 17745, 2020
20:17 PM
iliekcomputers
2020-06-25 17710, 2020
20:18 PM
ruaok
WOWOWOWOW!
2020-06-25 17750, 2020
20:18 PM
ruaok
non-unique list. :(
2020-06-25 17707, 2020
20:19 PM
iliekcomputers
i only trained the models on last 60 days for now
2020-06-25 17721, 2020
20:19 PM
iliekcomputers
i'll open a ticket
2020-06-25 17730, 2020
20:19 PM
ruaok
thx.
2020-06-25 17752, 2020
20:19 PM
ruaok
uhm, I'm going to make that playable next. that will be interesting.
2020-06-25 17700, 2020
20:20 PM
ruaok
"next"
2020-06-25 17712, 2020
20:20 PM
iliekcomputers
lol
2020-06-25 17731, 2020
20:20 PM
ruaok
there are 15 next items. I'm sure you understand
2020-06-25 17740, 2020
20:20 PM
iliekcomputers
i get it
2020-06-25 17737, 2020
20:22 PM
iliekcomputers
pristine___: "0bf9fcd2-8a96-4860-bc4c-5343dac8e2ba"
2020-06-25 17741, 2020
20:22 PM
iliekcomputers
ugh
2020-06-25 17704, 2020
20:23 PM
iliekcomputers
2020-06-25 17720, 2020
20:23 PM
iliekcomputers
it works! i'll close the ticket i opened
2020-06-25 17725, 2020
20:23 PM
iliekcomputers
(and open other tickets)
2020-06-25 17724, 2020
20:29 PM
iliekcomputers
2020-06-25 17725, 2020
20:29 PM
BrainzBot
LB-649: collaborative filtering recommendations
2020-06-25 17738, 2020
20:29 PM
iliekcomputers
let's chat about how to productionize this more when you get a chance
2020-06-25 17753, 2020
20:29 PM
ruaok
BINGO!
2020-06-25 17709, 2020
20:30 PM
ruaok
I've been waiting to cross off productionize for eons!!
2020-06-25 17719, 2020
20:30 PM
ruaok
:D
2020-06-25 17739, 2020
20:31 PM
iliekcomputers
my pylistenbrainz thingy is actually used by someone lol
2020-06-25 17712, 2020
20:32 PM
ruaok
noice
