prabal: Hi again! About PR 467, is there a reason you have the onShowModal/onCloseModal methods in the entity pages rather than once in the footer component?
2020-06-26 17810, 2020
Mr_Monkey
I'm not sure there was a need to transform them into class components
2020-06-26 17834, 2020
prabal
I tried it with footer
2020-06-26 17803, 2020
prabal
it was not working properly
2020-06-26 17820, 2020
prabal
idk why it was happening though
2020-06-26 17831, 2020
prabal
later i thought it's better to have modal in the top layer
2020-06-26 17842, 2020
prabal
😅
2020-06-26 17847, 2020
Mr_Monkey
I'd suggest revisiting it (for one component at first), to help reduce code duplication
2020-06-26 17858, 2020
prabal
Okayy
2020-06-26 17808, 2020
prabal
I'll try to add modal in the footer component
2020-06-26 17809, 2020
Mr_Monkey
Well, I would argue otherwise, considering the entity page doesn't really need to know about that modal
2020-06-26 17830, 2020
Mr_Monkey
Might as well keep that logic where the modal is usedd
2020-06-26 17841, 2020
prabal
Okayy
2020-06-26 17846, 2020
Mr_Monkey
OK, I was wondering if I was missing something
2020-06-26 17833, 2020
ishaanshah
shivam-kapila: hi! I needed 2 components for designing the stats page so I created them. I am going to open a PR shortly, have a look and let me know if anything should be changed. Just wanted to let you know so that we dont end up duplicating work.
2020-06-26 17827, 2020
prabal
Mr_Monkey: are you already done with that pr or going through it r?
2020-06-26 17829, 2020
Mr_Monkey
prabal: Regarding checkboxes instead of links: yes :)
2020-06-26 17840, 2020
prabal
Yeah okayy
2020-06-26 17845, 2020
Mr_Monkey
Going throught the PR at the moment. haven't run it locally yet
2020-06-26 17800, 2020
Mr_Monkey
Want me to take a look at the buttons issue?
2020-06-26 17806, 2020
prabal
yeah
2020-06-26 17807, 2020
prabal
I tried
2020-06-26 17812, 2020
prabal
but couldn't fix it
2020-06-26 17818, 2020
Mr_Monkey
👌
2020-06-26 17823, 2020
prabal
Thankss!
2020-06-26 17839, 2020
Mr_Monkey
Ah, found it !
2020-06-26 17823, 2020
prabal
....
2020-06-26 17826, 2020
Mr_Monkey
prabal: So, the issue with the buttons in the footer is that all the other buttons are actually `<a>` tags, while the new collection button is a `<button>` element. Somehow that throws bootstrap in a ditch. So you'll need to add an `href` property on the collection button, like `href="#"`.
2020-06-26 17844, 2020
prabal
Hmm
2020-06-26 17847, 2020
prabal
Okayy
2020-06-26 17809, 2020
prabal
did you run this?
2020-06-26 17816, 2020
Mr_Monkey
No XD
2020-06-26 17819, 2020
Mr_Monkey
Let me check.
2020-06-26 17840, 2020
prabal
I started getting this error
2020-06-26 17854, 2020
prabal
when i added `handleAddToCollection: PropTypes.func.isRequired`
2020-06-26 17856, 2020
prabal
this in props
2020-06-26 17800, 2020
prabal
weird
2020-06-26 17809, 2020
prabal
I think i tried adding href, it didn't work
2020-06-26 17811, 2020
prabal
I am checking again
2020-06-26 17812, 2020
jmp_music joined the channel
2020-06-26 17814, 2020
prabal
Mr_Monkey: worked
2020-06-26 17816, 2020
prabal
:)))
2020-06-26 17820, 2020
Mr_Monkey
Ah, great :)
2020-06-26 17839, 2020
prabal
Thankss
2020-06-26 17834, 2020
Mr_Monkey
No problem.
2020-06-26 17827, 2020
Mr_Monkey
shivam-kapila: Are you around?
2020-06-26 17800, 2020
jmp_music has quit
2020-06-26 17818, 2020
Mr_Monkey
prabal: Just spotted something else witht he buttons in the footer: there's not enough space for the colelction button in some sizes. I'd recommend this change: `<Col md={6} mdOffset={3}>` => `<Col md={8} mdOffset={2}>`
2020-06-26 17837, 2020
prabal
Hmm okayy
2020-06-26 17849, 2020
prabal
I'll change that
2020-06-26 17836, 2020
Mr_Monkey
I also think we should introduce another button colour…
2020-06-26 17816, 2020
Mr_Monkey
Something like `lightseagreen` perhaps?
2020-06-26 17842, 2020
jmp_music joined the channel
2020-06-26 17802, 2020
prabal
Yes I'll try it
2020-06-26 17826, 2020
shivam-kapila
Mr_Monkey: sorry I missed that. Can you give around 10 minutes?
2020-06-26 17822, 2020
Mr_Monkey
15 actually, if you don't mind, I gotta run out to the shop :)
2020-06-26 17844, 2020
diru1100
Is anyone attending the Open source summit by Linux foundation?
2020-06-26 17826, 2020
ruaok
I thought everything in 2020 was cancelled.
2020-06-26 17809, 2020
yvanzo
chaban: thanks, I removed that spammer and its tickets
2020-06-26 17837, 2020
Mr_Monkey
shivam-kapila: I'm back
2020-06-26 17841, 2020
_lucifer
OSS is online.
2020-06-26 17813, 2020
CatQuest
Mr_Monkey: I wote for "didgerblue" and some kidn of orange too :DDD colouurrss!!!
ruaok: It's virtual, yes. June 29th - July 2nd. The schedule is intimidating
2020-06-26 17858, 2020
yvanzo
reosarevok, chaban: The message you linked is about /edits pages, that can be resolved by clearing edit history of these unrelated edits in the database afterwards.
2020-06-26 17839, 2020
reosarevok
Yes, but makes people unable to vote properly in the meantime. but given it's already Friday it probably doesn't matter that much anymore
2020-06-26 17840, 2020
ABCbum joined the channel
2020-06-26 17813, 2020
yvanzo
reosarevok: I found there are around 170K such edits in artists’ editing histories since 2020-06-15, and almost 800K since 2012.
2020-06-26 17837, 2020
reosarevok
That seems kind of insane
2020-06-26 17818, 2020
reosarevok
One fourth in one week
2020-06-26 17825, 2020
reosarevok
So yeah, probably should remove them all
2020-06-26 17827, 2020
yvanzo
And I did not check editing histories for recordings and releases yet.
