-
travis-ci
2020-06-26 17808, 2020
-
travis-ci has left the channel
2020-06-26 17855, 2020
-
yvanzo
reosarevok, cc chaban: I created MBS-10921 to track the clean up of editing history.
2020-06-26 17856, 2020
-
BrainzBot
2020-06-26 17834, 2020
-
ABCbum has quit
2020-06-26 17832, 2020
-
ishaanshah
iliekcomputers: Give me 2 mins
2020-06-26 17818, 2020
-
iliekcomputers
sure, take 10 :D
2020-06-26 17857, 2020
-
BrainzGit
2020-06-26 17857, 2020
-
BrainzBot
2020-06-26 17837, 2020
-
ishaanshah
iliekcomputers: Hi, I am around
2020-06-26 17855, 2020
-
iliekcomputers
give me 5 min, sorry!
2020-06-26 17801, 2020
-
ishaanshah
No worries
2020-06-26 17834, 2020
-
ishaanshah
2020-06-26 17840, 2020
-
ishaanshah
2020-06-26 17847, 2020
-
ishaanshah
Have a look when you are free
2020-06-26 17837, 2020
-
sumedh joined the channel
2020-06-26 17852, 2020
-
iliekcomputers
ishaanshah: hey
2020-06-26 17853, 2020
-
iliekcomputers
sup
2020-06-26 17817, 2020
-
ishaanshah
Hi
2020-06-26 17853, 2020
-
ishaanshah
> sup
2020-06-26 17853, 2020
-
ishaanshah
nothing much, continued working on the frontend
2020-06-26 17858, 2020
-
iliekcomputers
nice nice
2020-06-26 17802, 2020
-
iliekcomputers
the demo looks cool.
2020-06-26 17813, 2020
-
ishaanshah
That's your data btw
2020-06-26 17822, 2020
-
iliekcomputers
however, looking at it, i feel a bar graph would be much more useful :D
2020-06-26 17851, 2020
-
iliekcomputers
we should have "week of" etc etc instead of this week and last week
2020-06-26 17856, 2020
-
iliekcomputers
because of the delay
2020-06-26 17802, 2020
-
ishaanshah
I will add that too, in a subsequent PR if it is ok
2020-06-26 17830, 2020
-
iliekcomputers
sure, no worries
2020-06-26 17842, 2020
-
ruaok runs off or the weekend
2020-06-26 17847, 2020
-
iliekcomputers
will we use the pills in the other page too?
2020-06-26 17852, 2020
-
ishaanshah
yes
2020-06-26 17857, 2020
-
ruaok
lets hope this getaway will work better than the last one. have a good weekend everyone!
2020-06-26 17802, 2020
-
iliekcomputers
great, sounds good!
2020-06-26 17806, 2020
-
iliekcomputers
you too ruaok !
2020-06-26 17807, 2020
-
ishaanshah
It's a part of shivam-kapila's design
2020-06-26 17833, 2020
-
iliekcomputers
nice
2020-06-26 17802, 2020
-
ishaanshah
2020-06-26 17803, 2020
-
iliekcomputers
very nitty stuff but there's too little space between the y axis and the card border
2020-06-26 17816, 2020
-
ishaanshah
will fix that
2020-06-26 17844, 2020
-
iliekcomputers
wait, let me get off my phone for the sentry link
2020-06-26 17823, 2020
-
shivam-kapila
ishaanshah: Hi. Can I see that tomorrow. I am not in a state to concentrate. Really sorry.
2020-06-26 17859, 2020
-
iliekcomputers
ishaanshah: it's only 6 users huh
2020-06-26 17859, 2020
-
ishaanshah
Yeah no rush, just wanted to know if you had any improvements in mind
2020-06-26 17811, 2020
-
ishaanshah
actually its only 2
2020-06-26 17812, 2020
-
iliekcomputers
shivam-kapila: take the weekend off :)
2020-06-26 17841, 2020
-
iliekcomputers
that's not much of an issue, should be ok.
2020-06-26 17843, 2020
-
ishaanshah
3 errors per user for
2020-06-26 17813, 2020
-
ishaanshah
I dont know how but some of there listens are missing essential data
2020-06-26 17814, 2020
-
iliekcomputers
i didn't get an email today, that's concerning.
2020-06-26 17830, 2020
-
ishaanshah
like track name and artist name
2020-06-26 17846, 2020
-
ishaanshah
We can fix it by adding a where clause
2020-06-26 17815, 2020
-
ishaanshah
Or just skipping the entries where data is incorrect
2020-06-26 17823, 2020
-
iliekcomputers
i'd just skip the entries
2020-06-26 17833, 2020
-
iliekcomputers
don't want to make the query too complex
2020-06-26 17856, 2020
-
iliekcomputers
the queue seems ok for today
2020-06-26 17801, 2020
-
iliekcomputers
maybe i missed the email
2020-06-26 17818, 2020
-
iliekcomputers
oh yeah, wrong ID, sorry about that
2020-06-26 17823, 2020
-
ishaanshah
I haven't received any other error till now
2020-06-26 17839, 2020
-
ishaanshah
on the server side
2020-06-26 17856, 2020
-
iliekcomputers
my release stats are back lol
2020-06-26 17859, 2020
-
iliekcomputers
so that's nice
2020-06-26 17831, 2020
-
iliekcomputers
not completely sure what's happening though...
2020-06-26 17841, 2020
-
ishaanshah
seems like the problem fixed itself afterall :D
2020-06-26 17851, 2020
-
iliekcomputers
heh
2020-06-26 17814, 2020
-
ishaanshah
Although all time recordings are missing for quite a few
2020-06-26 17824, 2020
-
iliekcomputers
in my experience, it'll come back in a month or so when we forget everything we learned
2020-06-26 17827, 2020
-
iliekcomputers
ishaanshah: right
2020-06-26 17831, 2020
-
iliekcomputers
i was reading up on rmq
2020-06-26 17841, 2020
-
iliekcomputers
and i think the problem is the size of the message
2020-06-26 17850, 2020
-
iliekcomputers
rmq doesn't handle huge messages well
2020-06-26 17802, 2020
-
iliekcomputers
i figure if we make the messages smaller, it'll fix itself.
2020-06-26 17818, 2020
-
ishaanshah
but if that is the case the data shouldn't get inserted in the db
2020-06-26 17832, 2020
-
ishaanshah
Because we are validating before insertion too
2020-06-26 17844, 2020
-
iliekcomputers
what do you mean?
2020-06-26 17857, 2020
-
iliekcomputers
this is about us dropping messages in the spark_result queue, right?
2020-06-26 17829, 2020
-
pristine___
iliekcomputers: did you disable html files when requesting for candidate sets and other stuff?
2020-06-26 17829, 2020
-
pristine___
iliekcomputers: did you disable html files when requesting for candidate sets and other stuff?
2020-06-26 17846, 2020
-
ishaanshah
2020-06-26 17846, 2020
-
iliekcomputers
pristine___: i ran the steps that were in the readme
2020-06-26 17851, 2020
-
iliekcomputers
didn't do anything else
2020-06-26 17854, 2020
-
ishaanshah
we are validating over here
2020-06-26 17824, 2020
-
ishaanshah
Also if you look at the errors on sentry,
2020-06-26 17827, 2020
-
iliekcomputers
ishaanshah: my point is that i think the message doesn't even get that far from rmq
2020-06-26 17827, 2020
-
pristine___
iliekcomputers: did you disable html files when requesting for candidate sets and other stuff?
2020-06-26 17835, 2020
-
iliekcomputers
pristine___: no
2020-06-26 17807, 2020
-
pristine___
iliekcomputers: did you disable html files when requesting for candidate sets and other stuff?
2020-06-26 17812, 2020
-
ishaanshah
The data is there in the db but in an incorrect format
2020-06-26 17823, 2020
-
ishaanshah
IRCloud glitching
2020-06-26 17825, 2020
-
iliekcomputers
are we sure about that?
2020-06-26 17837, 2020
-
iliekcomputers
i guess we can confirm when i deploy today
2020-06-26 17846, 2020
-
iliekcomputers
ah yes, releases on 6 PM fridays
2020-06-26 17839, 2020
-
pristine___
iliekcomputers: html files can help to decode repeating mbids. I will have a look. Thanks.
2020-06-26 17819, 2020
-
iliekcomputers
pristine___: cool, if you need any help or need me to run something, ping with details
2020-06-26 17827, 2020
-
ishaanshah
iliekcomputers: in the data insertion query
2020-06-26 17830, 2020
-
pristine___
🌹
2020-06-26 17837, 2020
-
sumedh has quit
2020-06-26 17858, 2020
-
ishaanshah
We are using string formatting to insert the data
2020-06-26 17822, 2020
-
ishaanshah
So maybe to long strings are getting clipped or something
2020-06-26 17846, 2020
-
iliekcomputers
Wait what
2020-06-26 17804, 2020
-
ishaanshah
2020-06-26 17831, 2020
-
iliekcomputers
That's not string formatting
2020-06-26 17835, 2020
-
iliekcomputers
That's sqlalchemy
2020-06-26 17840, 2020
-
ishaanshah
sorry sqlalchemy
2020-06-26 17852, 2020
-
iliekcomputers
You had me scared there for a second lol
2020-06-26 17822, 2020
-
BrainzGit
2020-06-26 17825, 2020
-
BrainzBot
2020-06-26 17834, 2020
-
iliekcomputers
2020-06-26 17853, 2020
-
ishaanshah
Yep, yep got it, I got confused
2020-06-26 17820, 2020
-
iliekcomputers
I don't think it's sql alchemy, I feel it is rmq and the message size here
2020-06-26 17848, 2020
-
iliekcomputers
When I first wrote request consumer, I was sending all data in one message and it didn't work reliably
2020-06-26 17803, 2020
-
iliekcomputers
When I split it up into a message per user, it worked much better
2020-06-26 17822, 2020
-
iliekcomputers
I have a feeling making the message smaller would fix this here too
2020-06-26 17822, 2020
-
ishaanshah
I am not sure too, but we would have caught the messages during validation is what I am saying
2020-06-26 17839, 2020
-
ishaanshah
Lets have a look after deploying i guess
2020-06-26 17841, 2020
-
iliekcomputers
Maybe it was in there from before we introduced validatoon
2020-06-26 17843, 2020
-
iliekcomputers
Yeah
2020-06-26 17815, 2020
-
iliekcomputers
Anything else we should chat about
2020-06-26 17815, 2020
-
iliekcomputers
?
2020-06-26 17845, 2020
-
ishaanshah
Nah nothing else on my mind
2020-06-26 17800, 2020
-
ishaanshah
Will you get time to deploy tonight?
2020-06-26 17827, 2020
-
iliekcomputers
I'm gonna do it rn
2020-06-26 17802, 2020
-
ishaanshah
cool
2020-06-26 17808, 2020
-
iliekcomputers
Famous last words lol
2020-06-26 17816, 2020
-
iliekcomputers
My laptop died
2020-06-26 17848, 2020
-
ishaanshah
Oops :(
2020-06-26 17859, 2020
-
iliekcomputers
😐
2020-06-26 17831, 2020
-
iliekcomputers
ishaanshah: probably not today then
2020-06-26 17856, 2020
-
iliekcomputers
ishaanshah: deployed
2020-06-26 17837, 2020
-
BrainzGit
2020-06-26 17852, 2020
-
iliekcomputers
I see the error in sentry
2020-06-26 17840, 2020
-
ishaanshah
yep me too
2020-06-26 17804, 2020
-
ishaanshah
thats wierd
2020-06-26 17844, 2020
-
ishaanshah
from_ts, to_ts hasn't been written and recordings is a dictionary instead of an array
2020-06-26 17847, 2020
-
ishaanshah
If thats the case, it shouldn't pass the validation before inserting
2020-06-26 17804, 2020
-
iliekcomputers
Yeah.
2020-06-26 17808, 2020
-
iliekcomputers
That's pretty weird
2020-06-26 17820, 2020
-
iliekcomputers
Maybe it was written before validation
2020-06-26 17850, 2020
-
ishaanshah
hmmm
2020-06-26 17812, 2020
-
ishaanshah
but then we should have gotten newer validation errors
2020-06-26 17829, 2020
-
ishaanshah
and iirc we had setup validation before recording stats
2020-06-26 17829, 2020
-
iliekcomputers
Ah, didn't remember that.
2020-06-26 17822, 2020
-
iliekcomputers
Inexplicable situations like these make me suspicious of infra
2020-06-26 17830, 2020
-
iliekcomputers
Which brings us back to rmq
2020-06-26 17832, 2020
-
ishaanshah
I am not sure how we can split the messages into smaller ones
2020-06-26 17814, 2020
-
iliekcomputers
We can limit the number of listens we return per user
2020-06-26 17822, 2020
-
iliekcomputers
Number of recordings
2020-06-26 17836, 2020
-
iliekcomputers
To like 750 or so
2020-06-26 17855, 2020
-
iliekcomputers
Does anybody really care about more than top 100 irl
2020-06-26 17802, 2020
-
iliekcomputers
I don't think do
