-
shivam-kapila
ishaanshah: I mean to show a text like "your activity over the past 30 days"
2020-07-23 20504, 2020
-
iliekcomputers
ideally it won't happen, but it could
2020-07-23 20512, 2020
-
shivam-kapila
Yes it can
2020-07-23 20515, 2020
-
iliekcomputers
if you say "past 30 days", it could be inaccurate
2020-07-23 20505, 2020
-
iliekcomputers
2020-07-23 20526, 2020
-
shivam-kapila
Past month would sound more inaccurate since I would expect it be June's data
2020-07-23 20529, 2020
-
iliekcomputers
ishaanshah: the API endpoint is a bit confusing.
2020-07-23 20514, 2020
-
iliekcomputers
we should have a field with the actual date in there as well. so that it's obvious why we have multiple instances of (<Day>, <hour>)
2020-07-23 20515, 2020
-
shivam-kapila
+1
2020-07-23 20548, 2020
-
shivam-kapila
Is it possible if we do all 24 hours of sunday and then all 24 hours of monday?
2020-07-23 20500, 2020
-
iliekcomputers
shivam-kapila: yes, which is why I'm recommending either showing the exact range ((maybe, in a tooltip)
2020-07-23 20514, 2020
-
ishaanshah
I have sorted them according to hours
2020-07-23 20528, 2020
-
iliekcomputers
ishaanshah: yeah, i think that's ok.
2020-07-23 20533, 2020
-
iliekcomputers
however just looking at the output
2020-07-23 20551, 2020
-
ishaanshah
I don't understand
2020-07-23 20556, 2020
-
iliekcomputers
it isn't clear how the 0th element in the list is different from the 7th element
2020-07-23 20503, 2020
-
ishaanshah
We cant have a exact date
2020-07-23 20527, 2020
-
iliekcomputers
ah ok.
2020-07-23 20530, 2020
-
iliekcomputers
whoops, sorry
2020-07-23 20533, 2020
-
iliekcomputers
I'm being dump
2020-07-23 20541, 2020
-
iliekcomputers
(day, hour) is unique here
2020-07-23 20547, 2020
-
ishaanshah
Yep
2020-07-23 20502, 2020
-
iliekcomputers
yeah, sorry, i got confused for a second.
2020-07-23 20502, 2020
-
ishaanshah
I could merge it in a single field
2020-07-23 20521, 2020
-
shivam-kapila
iliekcomputers: your activity from june 24- july 23 ?
2020-07-23 20522, 2020
-
ishaanshah
but that would add unnecessary string proccessing
2020-07-23 20525, 2020
-
iliekcomputers
I think it'd be much easier to comprehend if we nested the hours inside the day field somehow.
2020-07-23 20544, 2020
-
ishaanshah
Yeah, we can do that
2020-07-23 20558, 2020
-
ishaanshah
But we would have to process it on server side
2020-07-23 20513, 2020
-
ishaanshah
It's difficult to do it on spark side
2020-07-23 20515, 2020
-
iliekcomputers
like [{"day": "Friday", "listen_counts": [{"hour": 0, "listen_count": 34}]]
2020-07-23 20524, 2020
-
iliekcomputers
i think we should do it on the api endpoint
2020-07-23 20534, 2020
-
ishaanshah
Yep, that we can do
2020-07-23 20545, 2020
-
ishaanshah
I will open up a PR tomorrow
2020-07-23 20554, 2020
-
iliekcomputers
shivam-kapila: yeah, exactly, make the range explicit.
2020-07-23 20558, 2020
-
iliekcomputers
ishaanshah: cool.
2020-07-23 20500, 2020
-
ishaanshah
That will make the frontend a bit more clearly
2020-07-23 20502, 2020
-
iliekcomputers
thanks!
2020-07-23 20508, 2020
-
ishaanshah
clearly -> clear
2020-07-23 20549, 2020
-
iliekcomputers
👍🏽
2020-07-23 20518, 2020
-
shivam-kapila
Thanks
2020-07-23 20516, 2020
-
shivam-kapila
ishaanshah: shall we discuss a bit more about the graph? Because you have worked with them
2020-07-23 20517, 2020
-
ishaanshah
2020-07-23 20540, 2020
-
iliekcomputers
that actually looks really cool
2020-07-23 20547, 2020
-
ishaanshah
Its still messy, but we can definitely trends
2020-07-23 20554, 2020
-
iliekcomputers
is it yearly?
2020-07-23 20558, 2020
-
ishaanshah
see trends
2020-07-23 20500, 2020
-
iliekcomputers
what time range?
2020-07-23 20501, 2020
-
ishaanshah
all_time
2020-07-23 20511, 2020
-
iliekcomputers
could you post mine ?
2020-07-23 20517, 2020
-
shivam-kapila
Can we make it area graph?
2020-07-23 20535, 2020
-
ishaanshah
2020-07-23 20547, 2020
-
ishaanshah
^ iliekcomputers
2020-07-23 20551, 2020
-
iliekcomputers
i don't think an area graph makes sense, each line is a different day
2020-07-23 20510, 2020
-
iliekcomputers
ishaanshah: that's slick!
2020-07-23 20515, 2020
-
shivam-kapila
Wait I will show somehing
2020-07-23 20522, 2020
-
ishaanshah
2020-07-23 20525, 2020
-
ishaanshah
shivam-kapila ^
2020-07-23 20528, 2020
-
iliekcomputers
we should fix up the colors, there's not enough contrast
2020-07-23 20540, 2020
-
iliekcomputers
a few of the lines are too transparent
2020-07-23 20547, 2020
-
iliekcomputers
but overall, i'm happy with it.
2020-07-23 20550, 2020
-
ishaanshah
Yep I have to work on fine tuning
2020-07-23 20505, 2020
-
iliekcomputers
!m ishaanshah
2020-07-23 20505, 2020
-
BrainzBot
You're doing good work, ishaanshah!
2020-07-23 20510, 2020
-
ishaanshah
I was thinking of a purple to orange transition
2020-07-23 20519, 2020
-
ishaanshah
Thanls :D
2020-07-23 20511, 2020
-
shivam-kapila
2020-07-23 20549, 2020
-
shivam-kapila
ishaanshah and iliekcomputers^^
2020-07-23 20519, 2020
-
shivam-kapila
Will work with purple to orange transitin
2020-07-23 20519, 2020
-
iliekcomputers
it looks cool, but i have a feeling with 7 layers, a few of them will just get completely hidden
2020-07-23 20532, 2020
-
ishaanshah
shivam-kapila: That hides some of the data and makes it hard to see that there is a specific trend
2020-07-23 20549, 2020
-
shivam-kapila
Opacity
2020-07-23 20554, 2020
-
iliekcomputers
but we should probably add an average line
2020-07-23 20500, 2020
-
iliekcomputers
like average of all the days
2020-07-23 20504, 2020
-
ishaanshah
Yep, gonna do that
2020-07-23 20516, 2020
-
shivam-kapila
But if you 2 find it bad we can try afterwords
2020-07-23 20548, 2020
-
shivam-kapila
Plus do you waana keep the points 😅
2020-07-23 20505, 2020
-
ishaanshah
I am thinking of removing them
2020-07-23 20537, 2020
-
shivam-kapila
Those kind of divert me from the patterns
2020-07-23 20507, 2020
-
ishaanshah
2020-07-23 20515, 2020
-
shivam-kapila
Smooth
2020-07-23 20517, 2020
-
ishaanshah
2020-07-23 20521, 2020
-
ishaanshah
tooltip*
2020-07-23 20540, 2020
-
iliekcomputers
looks better without the points!
2020-07-23 20549, 2020
-
shivam-kapila
You just need to tweak the shades and its good to go
2020-07-23 20549, 2020
-
ishaanshah
Agreed
2020-07-23 20554, 2020
-
shivam-kapila
+100
2020-07-23 20502, 2020
-
ishaanshah
I want to make a legend
2020-07-23 20518, 2020
-
ishaanshah
You can interact with it
2020-07-23 20531, 2020
-
ishaanshah
and disable certain days if you want to
2020-07-23 20540, 2020
-
shivam-kapila
Purrfect
2020-07-23 20551, 2020
-
shivam-kapila
Inspiring work
2020-07-23 20556, 2020
-
ishaanshah
nivo doesn't support it by default
2020-07-23 20509, 2020
-
ishaanshah
Lets see if I can tweak it a bit
2020-07-23 20548, 2020
-
shivam-kapila
Does nivo support drop shadow for lines?
2020-07-23 20558, 2020
-
iliekcomputers
could we do it in two PRs? let's try to merge what you have already soon-ish, and then follow up with the legend and interaction?
2020-07-23 20539, 2020
-
shivam-kapila is increasing load on ishaanshah
2020-07-23 20521, 2020
-
ishaanshah
2020-07-23 20535, 2020
-
ishaanshah
I will have a look
2020-07-23 20548, 2020
-
shivam-kapila
No prob
2020-07-23 20533, 2020
-
ishaanshah
2020-07-23 20547, 2020
-
iliekcomputers
awesome, let's do that then. thanks!
2020-07-23 20500, 2020
-
ishaanshah
I will tune the graph tomorrow and then work on the tests
2020-07-23 20524, 2020
-
ishaanshah
shivam-kapila: About the graph on listens page
2020-07-23 20555, 2020
-
shivam-kapila
I also had some other suggestions. Minute ones. We may take them as we integrate them in the dashboard
2020-07-23 20501, 2020
-
ishaanshah
I will try to make a component that you can plug in by next tuesday
2020-07-23 20520, 2020
-
shivam-kapila
Oh you are volunteering. Thank you
2020-07-23 20542, 2020
-
ishaanshah
Finally learnt the trick :D
2020-07-23 20553, 2020
-
shivam-kapila
Haha 😆
2020-07-23 20529, 2020
-
ishaanshah
iliekcomputers: How much time did the all_time query take?
2020-07-23 20558, 2020
-
iliekcomputers
not much. minutes
2020-07-23 20521, 2020
-
ishaanshah
Noice, so we can make it work for listening_activity as well
2020-07-23 20522, 2020
-
iliekcomputers
4-5 min
2020-07-23 20525, 2020
-
iliekcomputers
yep
2020-07-23 20539, 2020
-
ishaanshah
thats quite intriguing
2020-07-23 20518, 2020
-
ishaanshah
Slightly tweaking the query improves the efficiency by so much
2020-07-23 20533, 2020
-
ishaanshah
From what I read online spark is not good at doing range joins
2020-07-23 20548, 2020
-
ishaanshah
so we should avoid it as much as possible
2020-07-23 20511, 2020
-
iliekcomputers
yep, the explain explained it though, they did a sorted merge join for the equality check and a entire nested loop join for the <= & >= join
2020-07-23 20518, 2020
-
MajorLurker joined the channel
2020-07-23 20546, 2020
-
MajorLurker has quit
2020-07-23 20520, 2020
-
pristine___
Why so many stats mail 🤔
2020-07-23 20538, 2020
-
iliekcomputers
pristine___: i messed up a deployment
2020-07-23 20514, 2020
-
iliekcomputers
huh, they're still coming...
2020-07-23 20520, 2020
-
iliekcomputers
that shouldn't be happening.
2020-07-23 20528, 2020
-
pristine___
Phew.
2020-07-23 20536, 2020
-
iliekcomputers
sorry, i'm not sure why it's happening. just create a filter for now. if it happens again, i'll look into it.
2020-07-23 20537, 2020
-
BrainzGit
2020-07-23 20539, 2020
-
BrainzBot
2020-07-23 20519, 2020
-
reosarevok
2020-07-23 20520, 2020
-
BrainzBot
MBS-10982: Batch-adding relationships temporarily uses a huge amount of RAM
2020-07-23 20532, 2020
-
bitmap
yes, I haven't looked into it yet though
2020-07-23 20544, 2020
-
reosarevok
Most of the recently opened React edit conversions should be fairly trivial to review, btw :) for whenever you're bored, no hurry
2020-07-23 20517, 2020
-
ruaok
iliekcomputers: you haz new PR on pylistenbrainz
2020-07-23 20544, 2020
-
iliekcomputers
Nice. I'll look.
2020-07-23 20543, 2020
-
BrainzGit
2020-07-23 20544, 2020
-
BrainzBot
2020-07-23 20550, 2020
-
iliekcomputers
ruaok: i triggered a dump on lemmy to check that it works. and it's working at around 8k listens per second.
2020-07-23 20518, 2020
-
ruaok
yeah, the xz really slows it down. alas.
2020-07-23 20538, 2020
-
ruaok
similar support now added to the PR
2020-07-23 20558, 2020
-
ruaok
woo!
2020-07-23 20503, 2020
-
iliekcomputers
2020-07-23 20552, 2020
-
ruaok
oh, cool. I can change requirements.txt to point to pypi
2020-07-23 20504, 2020
-
MajorLurker joined the channel
2020-07-23 20555, 2020
-
BrainzGit
2020-07-23 20536, 2020
-
BrainzGit
2020-07-23 20518, 2020
-
BrainzGit
2020-07-23 20520, 2020
-
BrainzBot
2020-07-23 20520, 2020
-
BrainzBot
2020-07-23 20550, 2020
-
MajorLurker has quit
