> I'm just cautious about introducing code that might break future versions of YT player
2020-07-27 20920, 2020
shivam-kapila
Agreed
2020-07-27 20945, 2020
Mr_Monkey
There should be a safe way to do it though, so I'll look into it.
2020-07-27 20947, 2020
white_shadow joined the channel
2020-07-27 20956, 2020
shivam-kapila
Thank you :)
2020-07-27 20902, 2020
_lucifer
ruaok: another license related question (i am really bad at this licensing thing). Someone has asked at the android repo which license is the code available? so i rpelied GPLv3 but once the legacy code is gone we are open to a less restrictive license. That is possible right?
2020-07-27 20941, 2020
_lucifer wonders if someone could suggest him a source to learn more about how the licensing stuff
iliekcomputers, ruaok : The LB API docs say about the `/user/(user_name)/listens` endpoint that “Listens are always returned in descending timestamp order.”
I'll make a PR and then maybe we can merge pristine___'s PR at the same time and hope for a release soon
2020-07-27 20954, 2020
shivam-kapila
I can make one tomorrow.
2020-07-27 20905, 2020
ruaok
I'll make one now.
2020-07-27 20903, 2020
shivam-kapila
thanks
2020-07-27 20931, 2020
slriv joined the channel
2020-07-27 20931, 2020
alastairp
ruaok: do you mean to make it the same as the documentation?
2020-07-27 20959, 2020
alastairp
I have a niggling thought that we did a reverse() in the view if necessary
2020-07-27 20959, 2020
ruaok
no, I thought it would be best to do something entirely different. I'm thinking of returning them in random order...
2020-07-27 20946, 2020
alastairp
ok
2020-07-27 20913, 2020
ruaok
what I don't understand is how we would've changed the test to match what was being returned. that is odd to me. but yes, I think there was a reverse in there.
2020-07-27 20946, 2020
ruaok
right now I am just trying my local installation to actually return me anything I just imported.
2020-07-27 20915, 2020
white_shadow joined the channel
2020-07-27 20933, 2020
yvanzo
hi slriv, neither the errors you mentioned nor the jump of 18G is a known thing, it is most likely environmental.
2020-07-27 20958, 2020
white_shadow
Hi _lucifer
2020-07-27 20902, 2020
white_shadow
What's next?
2020-07-27 20917, 2020
_lucifer
white_shadow: i suggest to use the app a bit and get a better feel of how it work
2020-07-27 20932, 2020
_lucifer
i saw that you used the okhttp cache thats good
2020-07-27 20906, 2020
_lucifer
what things will it cache?
2020-07-27 20941, 2020
_lucifer
and do we need an external room db cache or the okhttp one will suffice
2020-07-27 20951, 2020
white_shadow
no need of room db
2020-07-27 20949, 2020
_lucifer
good then, it would come with a lot of complexity which we can avoid now
2020-07-27 20934, 2020
white_shadow
yes
2020-07-27 20915, 2020
ruaok
heh, found a bug in the process, lol
2020-07-27 20943, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC students start here: https://bit.ly/2NUaxgb | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Meeting agenda: Reviews
2020-07-27 20957, 2020
ishaanshah
iliekcomputers: Hi!
2020-07-27 20932, 2020
iliekcomputers
ishaanshah: hey
2020-07-27 20940, 2020
white_snack joined the channel
2020-07-27 20957, 2020
ishaanshah
How are you?
2020-07-27 20909, 2020
iliekcomputers
good, good.
2020-07-27 20929, 2020
iliekcomputers
saw the daily activity pr
2020-07-27 20932, 2020
iliekcomputers
exciting!
2020-07-27 20918, 2020
ishaanshah
Its nearly complete
2020-07-27 20918, 2020
ishaanshah
Tests are remaining
2020-07-27 20944, 2020
ishaanshah
and some improvements to listening_activity
2020-07-27 20956, 2020
iliekcomputers
nice
2020-07-27 20903, 2020
ishaanshah
Bring the header inside the card, maintain aspect ratio etc.
2020-07-27 20923, 2020
iliekcomputers
yeah, the header inside the card makes sense. I was gonna point that out.
2020-07-27 20938, 2020
prabal
Mr_Monkey: hi
2020-07-27 20943, 2020
Mr_Monkey
Hiya!
2020-07-27 20907, 2020
white_shadow has quit
2020-07-27 20909, 2020
Mr_Monkey
Sorry, give me two minutes to look at your PR
2020-07-27 20916, 2020
ishaanshah
We should get the artist map done till friday ig
2020-07-27 20927, 2020
ishaanshah
So 2 graphs in a week :D
2020-07-27 20929, 2020
iliekcomputers
woo!
2020-07-27 20904, 2020
ishaanshah
I will complete the tests by tomorrow afternoon and start working on artist origin
2020-07-27 20908, 2020
iliekcomputers
the endpoint is slow rn, because of the many GET requests.
2020-07-27 20926, 2020
iliekcomputers
but once we can POST to the dataset hoster, it should be good.
2020-07-27 20930, 2020
Mr_Monkey
prabal: So how's the testing been going?
2020-07-27 20934, 2020
iliekcomputers
ishaanshah: sounds good!
2020-07-27 20953, 2020
ishaanshah
Should I push directly to your branch or create another PR?
2020-07-27 20904, 2020
iliekcomputers
i'd say just push to mine
2020-07-27 20913, 2020
iliekcomputers
i have left a bunch of comments there.
2020-07-27 20916, 2020
prabal
Mr_Monkey: i copied your trick of logging in the agent
2020-07-27 20927, 2020
prabal
From your merge route tests
2020-07-27 20944, 2020
ishaanshah
Cool, will do
2020-07-27 20946, 2020
iliekcomputers
oh also, i used a dictionary for the alpha 2 to 3 mapping, we should use pycountry instead
