[bookbrainz-site] snyk-bot opened pull request #479 (master…snyk-upgrade-c82bd8a457a52d9f0af0f950f9d89865): [Snyk] Upgrade prop-types from 15.6.2 to 15.7.2 https://github.com/bookbrainz/bookbrainz-site/pul…
2020-07-30 21224, 2020
BrainzGit
[bookbrainz-site] snyk-bot opened pull request #480 (master…snyk-upgrade-ab71637327b70edad54688c8bf48293b): [Snyk] Upgrade connect-redis from 3.3.3 to 3.4.2 https://github.com/bookbrainz/bookbrainz-site/pul…
2020-07-30 21230, 2020
BrainzGit
[bookbrainz-site] snyk-bot opened pull request #481 (master…snyk-upgrade-bee51cd3c6853a5923dea1777d5e2eb2): [Snyk] Upgrade express from 4.16.3 to 4.17.1 https://github.com/bookbrainz/bookbrainz-site/pul…
2020-07-30 21235, 2020
BrainzGit
[bookbrainz-site] snyk-bot opened pull request #482 (master…snyk-upgrade-4943cf7d8cf239b8b61c91ceb074cd8d): [Snyk] Upgrade superagent from 5.2.2 to 5.3.1 https://github.com/bookbrainz/bookbrainz-site/pul…
yvanzo: when would the search server return a 404?
2020-07-30 21257, 2020
reosarevok
/search/error/no-results.tt is supposed to come up if the server 404s, but we usually hit "No results found. Try refining your search query." in PaginatedSearchResults instead since it returns but with 0 results
2020-07-30 21213, 2020
reosarevok
So I'm not sure we ever hit that, or at least not for anything connected to no results?
2020-07-30 21207, 2020
sumedh joined the channel
2020-07-30 21205, 2020
killme has quit
2020-07-30 21250, 2020
killme joined the channel
2020-07-30 21213, 2020
alastairp
morning
2020-07-30 21210, 2020
alastairp
ruaok: I might have deleted the messybrainz mapping temp tables from bono. I was using the musicbrainz database there to run the script and didn't realised that it _wrote_ to the musicbrainz_db database. I'm running create-pairs again now and it's reinserting
2020-07-30 21250, 2020
alastairp
yvanzo: hi, where do you prefer musicbrainz-docker tickets?
2020-07-30 21217, 2020
ruaok
Did you run the script and it nuked the mapping?
2020-07-30 21205, 2020
ruaok
Perhaps that needs to become a separate step now that the code is closer to production.
2020-07-30 21253, 2020
alastairp
yeah, I was just playing around and ran the script and saw the first log message "Drop/create pairs table"
2020-07-30 21210, 2020
alastairp
does that mapping include FKs to the musicbrainz database?
2020-07-30 21235, 2020
alastairp
if not, I wonder if a separate database would be safer? instead of a schema on the same database
2020-07-30 21258, 2020
alastairp
or at the very least a separate configuration string in config.py, so that you can point it to either the same database or a different one
2020-07-30 21225, 2020
CallerNo6 has quit
2020-07-30 21229, 2020
jmp_music_
Morning!
2020-07-30 21209, 2020
ruaok
alastairp: it writes the tracks to a different schema, but the key point of the mapping is that it needs to join to many MB tables.
2020-07-30 21236, 2020
ruaok
having it outside the DB would be a freaking nightmare. so, a schema is the best sort of compromise....
2020-07-30 21254, 2020
ruaok
but I agree, making the drop table part separate is now the right time.
2020-07-30 21205, 2020
alastairp
OK, sure. If it has to join to those tables then it should absolutely be part of that db - I wasn't sure if that was the case or not
2020-07-30 21248, 2020
ruaok
and really given the nature of bono, there is no problem with you messing around dropping random tables. it can all be recreated.
2020-07-30 21250, 2020
ruaok
right?
2020-07-30 21203, 2020
alastairp
agreed, especially given how easy it was for me to rerun create-pairs and fix it
2020-07-30 21212, 2020
alastairp
in fact, it's finished. I could have got away with not telling you
2020-07-30 21235, 2020
ruaok
then I wouldn't have gotten an important nudge to make it safer. :)
2020-07-30 21208, 2020
MajorLurker joined the channel
2020-07-30 21201, 2020
ruaok
what is your intention with the web_home volume on the develop.sh improvements?
2020-07-30 21209, 2020
alastairp
it's so that bash and ipython can write their history to /root
2020-07-30 21216, 2020
alastairp
and when you run it again, your history is still there
2020-07-30 21233, 2020
ruaok
ah, ok.
2020-07-30 21243, 2020
ruaok
its not obvious why that is there.
2020-07-30 21247, 2020
ruaok
maybe add a comment?
2020-07-30 21207, 2020
alastairp
sure. to the volume definition, or to the mapping in the web service?
2020-07-30 21218, 2020
alastairp
tbf, I added that change in a separate commit which explained this :)
2020-07-30 21255, 2020
ruaok
future reader of the file will not be reading the commit history...
2020-07-30 21234, 2020
MajorLurker has quit
2020-07-30 21237, 2020
CallerNo6 joined the channel
2020-07-30 21237, 2020
CallerNo6 has quit
2020-07-30 21237, 2020
CallerNo6 joined the channel
2020-07-30 21245, 2020
alastairp
in the general case, yes. I've found that I look at annotate/history a lot these days to work out reasoning behind a change, but I realise that not everyone does it
a backend issue it seems, gateways are properly configured, cert was generated
2020-07-30 21238, 2020
zas
it hits 10.2.2.31:13048
2020-07-30 21251, 2020
ruaok
agreed. gateways are working as expected.
2020-07-30 21217, 2020
ruaok
I found a shortcoming in a the dataset hoster -- it can't find its templates.
2020-07-30 21240, 2020
v6lur joined the channel
2020-07-30 21232, 2020
yvanzo
hi alastairp: I prefer it as Jira tickets
2020-07-30 21251, 2020
ptitjano has left the channel
2020-07-30 21254, 2020
alastairp
yvanzo: thanks. on what project? mbvm?
2020-07-30 21209, 2020
alastairp
wow. I managed to consistently crash musicbrainz-docker postgres!
2020-07-30 21248, 2020
alastairp
in the end it was because shared_buffers was higher than maximum ram the docker VM on mac had
2020-07-30 21216, 2020
sumedh has quit
2020-07-30 21222, 2020
iliekcomputers
when you wake up at 8:45 to realize you have a meeting at 9 😥
2020-07-30 21259, 2020
alastairp
15 minutes? luxury
2020-07-30 21202, 2020
Gazooo has quit
2020-07-30 21207, 2020
ruaok
gah. anyone have experience shipping package-data or using MANIFEST.in in setup.py
2020-07-30 21223, 2020
ruaok
I can't get distutils to include my template files to save the life of me.
2020-07-30 21217, 2020
alastairp
urgh. sometimes, but it always involves poking something, trying it, trying again, throwing everything against a wall and going for a bike ride, etc
2020-07-30 21242, 2020
ruaok
shit, I have no access to a bike, but that is what I've been doing.
2020-07-30 21206, 2020
Gazooo joined the channel
2020-07-30 21228, 2020
ruaok
strangely works when I use the package in a dev server. but not in docker.
2020-07-30 21259, 2020
alastairp
ruaok: in messybrainz-labs, is `python3 formats.py | psql` required>
2020-07-30 21200, 2020
alastairp
?
2020-07-30 21211, 2020
alastairp
I'm just updating the readme to use run.py
2020-07-30 21235, 2020
ruaok
actually, the messybrainz stuff is in flux right now.
2020-07-30 21253, 2020
alastairp
right right now? OK, it can wait
2020-07-30 21257, 2020
ruaok
thanks for fixing things but I really need to clean up more before tossing you into the mix.
2020-07-30 21213, 2020
ruaok
not right right now, but soonish now.
2020-07-30 21220, 2020
alastairp
OK. Sertan wanted a copy of the mapping, so I was passing the repo his way
2020-07-30 21228, 2020
ruaok
oh.
2020-07-30 21237, 2020
alastairp
but maybe a dump of the mapping tables might be enough for now
2020-07-30 21237, 2020
ruaok
hang on.
2020-07-30 21246, 2020
ruaok
that might be best.
2020-07-30 21258, 2020
alastairp
ok. I can do it, unless you have one that you prepared earlier
2020-07-30 21258, 2020
ruaok
because you need at least 64GB of ram to create the mappings. :)
2020-07-30 21237, 2020
ruaok
hmm. ok.
2020-07-30 21240, 2020
ruaok
actually, go ahead.
2020-07-30 21213, 2020
ruaok
I had made a branch to move the mapping to LB, but I've realized that that branch had problems and I since made other changes that are current in the messybrainz-labs repo.
2020-07-30 21232, 2020
ruaok
but its on the short list to move this code to the LB repo.
