zas: Hi, Can I please have a login on trille (critiquebrainz) and gaga (LB timescale)?
2020-07-31 21335, 2020
iliekcomputers
shivam-kapila: i'm hesitant to do too much with very basic components like loaders and pills
2020-07-31 21348, 2020
iliekcomputers
it leads to stuff getting flashy for flashiness sake
2020-07-31 21357, 2020
iliekcomputers
but i'll leave it up to you
2020-07-31 21321, 2020
shivam-kapila
I also dont want it to be too funky
2020-07-31 21337, 2020
shivam-kapila
Butr the current loader doesnt look so good
2020-07-31 21340, 2020
iliekcomputers
also, the less code we have to maintain over time, the better
2020-07-31 21312, 2020
shivam-kapila
or we may wait for BS4 migration and use the inbuilt one once we are there
2020-07-31 21301, 2020
iliekcomputers
if a BS4 migration takes more than a day or two's worth of work, i don't see it happening anytime soon
2020-07-31 21323, 2020
shivam-kapila
I guess it will be
2020-07-31 21305, 2020
shivam-kapila
Actually the thing which makes me feel to change the loader is that:
2020-07-31 21305, 2020
shivam-kapila
1. The current loader is a little ugly icon
2020-07-31 21305, 2020
shivam-kapila
2. There are 5 loaders currently on report page itself so I aim to replace it with a simple decent loader that covers the page and when the components are ready show them
2020-07-31 21327, 2020
iliekcomputers
yes.
2020-07-31 21344, 2020
iliekcomputers
i'd prefer a simple circle
2020-07-31 21326, 2020
shivam-kapila
shall I go with the npm package I pointed and use its simple circle animation?
2020-07-31 21331, 2020
iliekcomputers
sgtm.
2020-07-31 21333, 2020
iliekcomputers
thansk
2020-07-31 21337, 2020
shivam-kapila
thanks
2020-07-31 21323, 2020
Mr_Monkey
+1 for simple circle
2020-07-31 21300, 2020
Mr_Monkey
iliekcomputers: Are the websockets irremediably broken then, for suggesting we do polling?
2020-07-31 21326, 2020
iliekcomputers
i'm not sure. i don't remember if we made it work with the listens page.
2020-07-31 21334, 2020
iliekcomputers
did we?
2020-07-31 21340, 2020
Mr_Monkey
It was definitely working at some point, and updating the page.
2020-07-31 21358, 2020
iliekcomputers
i see
2020-07-31 21309, 2020
Mr_Monkey
Not sure exactly how that would work now if we navigate to another page (probably would just add it to the top of that page)
2020-07-31 21315, 2020
iliekcomputers
we should open a ticket if it's broken.
2020-07-31 21301, 2020
Mr_Monkey
OK, I'll do that
2020-07-31 21302, 2020
iliekcomputers
thanks!
2020-07-31 21306, 2020
Mr_Monkey
Here it is: LB-679. I also created LB-680 and assigned it to myself, to integrate working solution into the current navigation mechanism.
that image will need to be pushed to docker hub some time, too
2020-07-31 21319, 2020
white_shadow joined the channel
2020-07-31 21303, 2020
yvanzo
alastairp: we usually have two approvals before merging but this one is such a small pr :)
2020-07-31 21319, 2020
alastairp
that's OK, I approved it too ;)
2020-07-31 21322, 2020
white_snack has quit
2020-07-31 21303, 2020
white_shadow has quit
2020-07-31 21359, 2020
zas
alastairp: try to log in trille & gaga
2020-07-31 21347, 2020
alastairp
zas: login key and sudo works. thanks
2020-07-31 21336, 2020
Mr_Monkey
ruaok: Do you agree with mine and shivam-kapila's conclusion that we should implement the automatically-search-in-bigger-time-range mechanism (if listens count < requested count) in the `/user/XXXXX/listens` API endpoint?
2020-07-31 21329, 2020
ruaok
Yes, I do.
2020-07-31 21330, 2020
Mr_Monkey
Currently, PR #992 removes the mechanism from the front-end (the "Search Larger Time Range" button), and there is no existing way to request a larger time-range from the API (using for example a time_range param). It also makes sense to do it automatically on the API endpoint rather than do another API call…
2020-07-31 21333, 2020
Mr_Monkey
OK
2020-07-31 21317, 2020
ruaok
But,what is the logic behind expanding the range?
2020-07-31 21328, 2020
Mr_Monkey
I'm not convinced I'll be able to implement that in python without setting the whole thing on fire, but I'll give it a try. I might need help with special cases (such as "no, really, you only have 10 listens, no need to look for more")
2020-07-31 21333, 2020
ruaok
If fewer are returned, search the whole range?
2020-07-31 21335, 2020
gr0uch0mars
ruaok: evaluations sent! I had it in mind for today, but could’t do it this morning
