#metabrainz

there was a syntax error in my code

thats why they didnt run in the first place

hmm, this is weird

[listenbrainz-server] shivam-kapila opened pull request #1000 (master…ui-improvements): Minor improvements to shared React components https://github.com/metabrainz/listenbrainz-serv...

PR #1000

:tada

🎉

Happy 1000 PRs

prabal: on the page you sent me, if I select the one author's checkbox and refresh, the checkbox becomes un-checked.

Woo, 1000!

Not sure what you're seeing, but not the same for me :/

_lucifer: have you heard from gr0uch0mars recently?

yes ruaok, yesterday around 1500-1600 UTC

we had a conversation about the status of the app

filling evals was on his list next but it seems not done yet

Mr_Monkey: See

I think it's because of my browser

shivam-kapila: so you finally got #1000 :D 🎊

1000 woaahh!!

Definitely not happening in my browser :)

(Brave)

Not happening in Chrome either

Nor in Safari

Ah, it is happening in Firefox however

_lucifer: Lol. Yeah

XD

Fixed the tests finally!

this line was the issue

COngrats iliekcomputers

sorry ishaanshah

🤣

Apparently we can import functions from the api endpoint file

cant*

do you have more details about why this doesn't work?

was it a circular import? or something that we were looking at with regard to the requests mock plugin?

zas: Happy SysAdmin day!

Mr_Monkey: ping

pong

hi

Hiya!

I am trying to make the LB footer stick to bottom of page

If I use position fixed then pull-right in child components is not working

Any idea how we can achieve this?

hi bitmap, yvanzo. I'm trying to generate musicbrainz-server/docker/templates/Dockerfile.test-database.m4 with m4, but it's not outputting anything

Hm. do you have some html I could play with?

My gut feeling is that flexbox should be able to sort that for you

I am not too good at css

But maybe the simple solution is to just not use pull-right inside?

CSS is a dark art

Mr_Monkey: http://shivamkapila.pagekite.me/faq

footer in this

:+1

👍

e.g. `m4 -I templates -P templates/Dockerfile.test-database.m4` (the contents of generate_dockerfiles.sh)

this outputs nothing

shivam-kapila: https://usercontent.irccloud-cdn.com/file/fRi0R...

and that `clearfix` class is also not needed anymore.

thanks Mr_Monkey

No problem !

alastairp: see the Makefile

yvanzo: ah! I saw the script but not the makefile, thanks

alastairp: it is just calling the script actually

ahhh, the others work, but Dockerfile.test-database remains empty

hah, actually it's my fault

I called the script incorrectly initially, and it blanked the template file out :)

no wonder the output is also blank

Mr_Monkey: didnt work on mobile screens. Not urgent at all but if you find a solution please let me know.

alastairp: I get this: https://gist.github.com/yvanzo/b40bc988cc22bfa0...

yes, it was my mistake, sorry

[musicbrainz-server] alastair opened pull request #1621 (master…test-database-bzip2): Install bzip2 in the test-database docker image https://github.com/metabrainz/musicbrainz-serve...

Mr_Monkey: suggestion, if we're on the first page of the listens, we should poll the API every ~5-10 minutes or so and update the page

Does the LB team want to integrate a loader like this https://codepen.io/shivam-kapila/pen/ZEQGKoN

or should I go with https://www.npmjs.com/package/react-loader-spinner

zas: Hi, Can I please have a login on trille (critiquebrainz) and gaga (LB timescale)?

shivam-kapila: i'm hesitant to do too much with very basic components like loaders and pills

it leads to stuff getting flashy for flashiness sake

but i'll leave it up to you

I also dont want it to be too funky

Butr the current loader doesnt look so good

also, the less code we have to maintain over time, the better

or we may wait for BS4 migration and use the inbuilt one once we are there

if a BS4 migration takes more than a day or two's worth of work, i don't see it happening anytime soon

I guess it will be

Actually the thing which makes me feel to change the loader is that:

1. The current loader is a little ugly icon

2. There are 5 loaders currently on report page itself so I aim to replace it with a simple decent loader that covers the page and when the components are ready show them

yes.

i'd prefer a simple circle

shall I go with the npm package I pointed and use its simple circle animation?

sgtm.

thansk

thanks

+1 for simple circle

iliekcomputers: Are the websockets irremediably broken then, for suggesting we do polling?

i'm not sure. i don't remember if we made it work with the listens page.

did we?

It was definitely working at some point, and updating the page.

i see

Not sure exactly how that would work now if we navigate to another page (probably would just add it to the top of that page)

we should open a ticket if it's broken.

OK, I'll do that

thanks!

Here it is: LB-679. I also created LB-680 and assigned it to myself, to integrate working solution into the current navigation mechanism.

LB-679: Listens page - Websockets not working anymore https://tickets.metabrainz.org/browse/LB-679

LB-680: Update first page of listens with new listens https://tickets.metabrainz.org/browse/LB-680

shivam-kapila: >didnt work on mobile screens

What's not working? Got a screenshot?

yvanzo: I updated the ordering of the apt installation. should I merge myself, or would you like to?

Mr_Monkey: I will send u after having tea

i saw a person from work following me on twitter on the /recent page a few days ago

this is an interesting and short overview of some problems in music recommendation

I think that we're in a really good position with the musicbrainz database to overcome most of them, which I think is great

_lucifer have you merged or found any issues?

[musicbrainz-server] yvanzo merged pull request #1621 (master…test-database-bzip2): Install bzip2 in the test-database docker image https://github.com/metabrainz/musicbrainz-serve...

thanks yvanzo!

that image will need to be pushed to docker hub some time, too

alastairp: we usually have two approvals before merging but this one is such a small pr :)

that's OK, I approved it too ;)

alastairp: try to log in trille & gaga

zas: login key and sudo works. thanks

ruaok: Do you agree with mine and shivam-kapila's conclusion that we should implement the automatically-search-in-bigger-time-range mechanism (if listens count < requested count) in the `/user/XXXXX/listens` API endpoint?

Yes, I do.

Currently, PR #992 removes the mechanism from the front-end (the "Search Larger Time Range" button), and there is no existing way to request a larger time-range from the API (using for example a time_range param). It also makes sense to do it automatically on the API endpoint rather than do another API call…

OK

But,what is the logic behind expanding the range?

I'm not convinced I'll be able to implement that in python without setting the whole thing on fire, but I'll give it a try. I might need help with special cases (such as "no, really, you only have 10 listens, no need to look for more")

ruaok: evaluations sent! I had it in mind for today, but could’t do it this morning

Sorry for delay!