#metabrainz

/

      • ishaanshah
        yep
      • 2020-08-07 22020, 2020

      • ishaanshah
        or maybe have a constant domain
      • 2020-08-07 22029, 2020

      • ishaanshah
        [0, 300]
      • 2020-08-07 22058, 2020

      • ishaanshah
      • 2020-08-07 22059, 2020

      • iliekcomputers
        yeah, making it constant would be nice, that way the graphs are comparable for different time ranges
      • 2020-08-07 22009, 2020

      • ishaanshah
        if you see this graph
      • 2020-08-07 22019, 2020

      • ishaanshah
        the whole thing is pale orange
      • 2020-08-07 22028, 2020

      • ishaanshah
        because of the nos of artists from US
      • 2020-08-07 22036, 2020

      • reosarevok
        I like that numbers under 10 is 1.0 etc
      • 2020-08-07 22027, 2020

      • reosarevok
        Also, it would be fun to have a way to check which artists they are (so, if I see ruaok has listened to one Estonian artist, I could click and see who)
      • 2020-08-07 22044, 2020

      • ishaanshah
        reosarevok: Yeah we have a ticket open for that
      • 2020-08-07 22015, 2020

      • iliekcomputers
        we've had two people ask that in the short time it's been on beta, guess we know what to build soon :D
      • 2020-08-07 22036, 2020

      • reosarevok
        Is there a way to check by amount of listens too?
      • 2020-08-07 22056, 2020

      • iliekcomputers
        reosarevok: not yet, but that should be possible.
      • 2020-08-07 22001, 2020

      • iliekcomputers
        could you open a ticket? :D
      • 2020-08-07 22005, 2020

      • reosarevok
        Sure. LB?
      • 2020-08-07 22009, 2020

      • iliekcomputers
        yep.
      • 2020-08-07 22017, 2020

      • ishaanshah
        reosarevok: I didnt understand
      • 2020-08-07 22026, 2020

      • iliekcomputers
        ishaanshah: like the number of listens per country
      • 2020-08-07 22027, 2020

      • slriv has quit
      • 2020-08-07 22041, 2020

      • reosarevok
        Yeah, to see if I maybe listen to like three artists from Norway but a lot
      • 2020-08-07 22043, 2020

      • ishaanshah
        if you hover on in you will get that
      • 2020-08-07 22045, 2020

      • iliekcomputers
        5k listens from 400 artists from US
      • 2020-08-07 22053, 2020

      • ishaanshah
        oh
      • 2020-08-07 22058, 2020

      • ishaanshah
        sorry i misunderstood
      • 2020-08-07 22004, 2020

      • ishaanshah
        got it
      • 2020-08-07 22027, 2020

      • ishaanshah
        yeah thats a good feature too
      • 2020-08-07 22041, 2020

      • slriv joined the channel
      • 2020-08-07 22000, 2020

      • reosarevok
        Because I have 1.6k different US artists
      • 2020-08-07 22008, 2020

      • reosarevok
        I'm not sure there *are* 1.6k different Estonian artists :D
      • 2020-08-07 22014, 2020

      • reosarevok
        I mean, there are, but you know what I mean
      • 2020-08-07 22023, 2020

      • iliekcomputers
        yeah, makes sense.
      • 2020-08-07 22026, 2020

      • reosarevok
        But on actual amount of listens it's probably (a bit) closer than that
      • 2020-08-07 22028, 2020

      • reosarevok
        I'll ticket
      • 2020-08-07 22055, 2020

      • reosarevok
        What's the component, -labs?
      • 2020-08-07 22058, 2020

      • iliekcomputers
        i think both the number of listens and number of artists are interesting pieced of information
      • 2020-08-07 22014, 2020

      • reosarevok
        Sure :)
      • 2020-08-07 22059, 2020

      • iliekcomputers
        reosarevok: component doesn't really matter. I've started using epics personally (we have an epic called "statistics for Listenbrainz"), but just a ticket would be enough.
      • 2020-08-07 22018, 2020

      • reosarevok
        Ok
      • 2020-08-07 22032, 2020

      • reosarevok
        I haven't even tried epics :)
      • 2020-08-07 22009, 2020

      • iliekcomputers
        ishaanshah: let's make the domain constant, maybe 500
      • 2020-08-07 22009, 2020

      • slriv has quit
      • 2020-08-07 22024, 2020

      • ishaanshah
        Yeah I will experiment a bit with the values
      • 2020-08-07 22041, 2020

      • ishaanshah
      • 2020-08-07 22053, 2020

      • ishaanshah
        USA only has 44 artists
      • 2020-08-07 22057, 2020

      • slriv joined the channel
      • 2020-08-07 22008, 2020

      • reosarevok
        Added LB-689 then
      • 2020-08-07 22009, 2020

      • BrainzBot
        LB-689: Show stats for listens per artist origin country https://tickets.metabrainz.org/browse/LB-689
      • 2020-08-07 22010, 2020

      • ishaanshah
      • 2020-08-07 22020, 2020

      • ishaanshah
        we have 100 in USA
      • 2020-08-07 22035, 2020

      • ishaanshah
        MB data is much more complete and comprehensive
      • 2020-08-07 22020, 2020

      • SothoTalKer
        you guys are listening to music?
      • 2020-08-07 22052, 2020

      • iliekcomputers
        ishaanshah: i see 101 for the US in the link you sent :D
      • 2020-08-07 22019, 2020

      • ishaanshah
        oh its showing 101 for me in incognito
      • 2020-08-07 22022, 2020

      • ishaanshah
        caching ig
      • 2020-08-07 22030, 2020

      • ishaanshah
        :D
      • 2020-08-07 22049, 2020

      • iliekcomputers
        i think it's using the lfm api which uses MB
      • 2020-08-07 22057, 2020

      • iliekcomputers
        so should be the same-ish
      • 2020-08-07 22003, 2020

      • ishaanshah
        Hmm
      • 2020-08-07 22002, 2020

      • iliekcomputers
        although
      • 2020-08-07 22014, 2020

      • iliekcomputers
        looking at explr.fm more
      • 2020-08-07 22030, 2020

      • iliekcomputers
        it looks like it's using Last.FM tags to determine country
      • 2020-08-07 22049, 2020

      • iliekcomputers
        that sounds non-ideal tbh
      • 2020-08-07 22025, 2020

      • iliekcomputers
        Mr_Monkey: hey
      • 2020-08-07 22025, 2020

      • slriv has quit
      • 2020-08-07 22056, 2020

      • iliekcomputers
        i have a very nitty bug, but my css-fu isn't good enough to actually fix it
      • 2020-08-07 22013, 2020

      • slriv joined the channel
      • 2020-08-07 22059, 2020

      • iliekcomputers
        I removed the beta below the ListenBrainz text and now it seems mis-aligned :D https://usercontent.irccloud-cdn.com/file/CEmu6Y7…
      • 2020-08-07 22015, 2020

      • iliekcomputers
        (in the navbar)
      • 2020-08-07 22027, 2020

      • ishaanshah
        iliekcomputers: I found another minor bug
      • 2020-08-07 22028, 2020

      • ishaanshah
      • 2020-08-07 22043, 2020

      • ishaanshah
        i'll fix it along with the tests for the previous one
      • 2020-08-07 22052, 2020

      • iliekcomputers
        cool. thanks
      • 2020-08-07 22010, 2020

      • iliekcomputers
        how'd you catch that?
      • 2020-08-07 22034, 2020

      • ishaanshah
        I have a list of users for whom I check stats each time 😅
      • 2020-08-07 22042, 2020

      • ishaanshah
        for diversity
      • 2020-08-07 22042, 2020

      • slriv has quit
      • 2020-08-07 22026, 2020

      • slriv joined the channel
      • 2020-08-07 22035, 2020

      • iliekcomputers
        nice
      • 2020-08-07 22051, 2020

      • iliekcomputers
        i got my kid sister to sign up today
      • 2020-08-07 22052, 2020

      • slriv has quit
      • 2020-08-07 22053, 2020

      • iliekcomputers
        ;)
      • 2020-08-07 22040, 2020

      • slriv joined the channel
      • 2020-08-07 22047, 2020

      • ishaanshah
        I got one of my friend too
      • 2020-08-07 22053, 2020

      • ishaanshah
        he
      • 2020-08-07 22017, 2020

      • ishaanshah
        he's primary issue was that it was not very clear how to set up the scrobbling
      • 2020-08-07 22032, 2020

      • ishaanshah
        Ig there's a recent ticket about that
      • 2020-08-07 22034, 2020

      • iliekcomputers
        yeah, a ticket came in recently
      • 2020-08-07 22037, 2020

      • iliekcomputers
        yep!
      • 2020-08-07 22049, 2020

      • iliekcomputers
        i'll work on that if i get the time this weekend
      • 2020-08-07 22052, 2020

      • ishaanshah
        nice!
      • 2020-08-07 22007, 2020

      • ishaanshah
        I think I found a way to import complete spotify history
      • 2020-08-07 22016, 2020

      • Mr_Monkey
        iliekcomputers: How do you expect the logo to be aligned?
      • 2020-08-07 22031, 2020

      • ishaanshah
        I will try to work on a script this weekend
      • 2020-08-07 22035, 2020

      • shivam-kapila
        ishaanshah: how. I am interested
      • 2020-08-07 22050, 2020

      • shivam-kapila
        Mr_Monkey: I guess bottom of nav line
      • 2020-08-07 22059, 2020

      • iliekcomputers
        Mr_Monkey: maybe it should be a bit bigger? i think it's the whitespace between the brainz and the text that's a bit too much now that the "beta" is gone
      • 2020-08-07 22046, 2020

      • v6lur has quit
      • 2020-08-07 22056, 2020

      • ishaanshah
        shivam-kapila: Spotify allows you to get all your personal data
      • 2020-08-07 22035, 2020

      • ishaanshah
        it includes the complete listening history
      • 2020-08-07 22040, 2020

      • ishaanshah
        so we can use that
      • 2020-08-07 22040, 2020

      • iliekcomputers
        ah
      • 2020-08-07 22042, 2020

      • iliekcomputers
        nice!
      • 2020-08-07 22047, 2020

      • iliekcomputers
        actually thinking about it
      • 2020-08-07 22058, 2020

      • iliekcomputers
        that should be available for google play music and apple music too
      • 2020-08-07 22001, 2020

      • iliekcomputers
        with gdpr
      • 2020-08-07 22003, 2020

      • ishaanshah
        gdpr for the win!
      • 2020-08-07 22023, 2020

      • ishaanshah
        hah 😆
      • 2020-08-07 22055, 2020

      • Mr_Monkey
      • 2020-08-07 22048, 2020

      • shivam-kapila
        ishaanshah: ooo. Noice
      • 2020-08-07 22003, 2020

      • ishaanshah
        iliekcomputers: about the constant domain
      • 2020-08-07 22018, 2020

      • ishaanshah
        I dont think constant domain is a good idea for everyon
      • 2020-08-07 22037, 2020

      • ishaanshah
      • 2020-08-07 22040, 2020

      • ishaanshah
      • 2020-08-07 22055, 2020

      • ishaanshah
        It looks good for Zastai but doesn't look good for me
      • 2020-08-07 22020, 2020

      • ishaanshah
        I think we need some other mathematical metric, like median or something
      • 2020-08-07 22032, 2020

      • iliekcomputers
        Mr_Monkey: could we get the z to end closer to where the navbar starts?
      • 2020-08-07 22033, 2020

      • slriv has quit
      • 2020-08-07 22047, 2020

      • Mr_Monkey
        That's already the case, 15px closer
      • 2020-08-07 22057, 2020

      • slriv joined the channel
      • 2020-08-07 22004, 2020

      • Mr_Monkey
        I'd argie against less space than that
      • 2020-08-07 22009, 2020

      • Mr_Monkey
        argue*
      • 2020-08-07 22023, 2020

      • iliekcomputers
        why?
      • 2020-08-07 22024, 2020

      • slriv has quit
      • 2020-08-07 22035, 2020

      • iliekcomputers
        ishaanshah: ok, let's think about it over the weekend.
      • 2020-08-07 22051, 2020

      • shivam-kapila
        If we just move the logo down?
      • 2020-08-07 22057, 2020

      • ishaanshah
        cool
      • 2020-08-07 22009, 2020

      • slriv joined the channel
      • 2020-08-07 22055, 2020

      • Mr_Monkey
        iliekcomputers: I find it a bit crunched up. Too close in my opinion https://usercontent.irccloud-cdn.com/file/4usbiRb…
      • 2020-08-07 22033, 2020

      • Mr_Monkey
        Moving the logo down looked kind of weird shivam-kapila
      • 2020-08-07 22048, 2020

      • iliekcomputers
        oh. that looks better to me tbh.
      • 2020-08-07 22005, 2020

      • shivam-kapila
        wait I wanna give a try
      • 2020-08-07 22027, 2020

      • Mr_Monkey
      • 2020-08-07 22035, 2020

      • shivam-kapila
        I ttake back my words
      • 2020-08-07 22044, 2020

      • shivam-kapila
        that looks wierd
      • 2020-08-07 22009, 2020

      • Mr_Monkey
        In any case, the two items to look at are: https://github.com/metabrainz/listenbrainz-server… Removing the `navbar-padding-horizontal` there reduces the space between the logo and navbar
      • 2020-08-07 22035, 2020

      • shivam-kapila
        lets go with upper one
      • 2020-08-07 22036, 2020

      • slriv has quit
      • 2020-08-07 22047, 2020

      • Mr_Monkey
        And adjusting the logo's padding-top: https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-07 22014, 2020

      • iliekcomputers
        hmm, ok that makes sense. thanks Mr_Monkey !
      • 2020-08-07 22020, 2020

      • Mr_Monkey
        No problem!
      • 2020-08-07 22023, 2020

      • slriv joined the channel
      • 2020-08-07 22007, 2020

      • Mr_Monkey is a pro at Cascading Shit Stain
      • 2020-08-07 22021, 2020

      • Mr_Monkey
        Love/hate relationship.
      • 2020-08-07 22023, 2020

      • shivam-kapila
        hehe. lol
      • 2020-08-07 22010, 2020

      • abhinavohri
        iliekcomputers: I have updated both PRs . Please review it.
      • 2020-08-07 22030, 2020

      • iliekcomputers
        thanks!
      • 2020-08-07 22005, 2020

      • abhinavohri
        Also, i want to work on LB-84.What should be done in case of less than 0 listens?
      • 2020-08-07 22005, 2020

      • BrainzBot
        LB-84: API doesn't validate that count is > 0 https://tickets.metabrainz.org/browse/LB-84
      • 2020-08-07 22031, 2020

      • iliekcomputers
        abhinavohri: we currently return 0 listens. we can either start returning 400s if count is negative OR just return the empty list of listens without hitting the db.