Do you think the feedback icons should be made a separate functional component
2020-08-16 22940, 2020
iliekcomputers
yes.
2020-08-16 22946, 2020
shivam-kapila
Or keep it simple and bind send feedback to FONTAWESOME component only
2020-08-16 22951, 2020
shivam-kapila
Ah ok
2020-08-16 22904, 2020
iliekcomputers
feedback will have functionality for hitting the api etc right
2020-08-16 22910, 2020
shivam-kapila
Yes
2020-08-16 22923, 2020
iliekcomputers
yeah, it should be a seperate component thne
2020-08-16 22929, 2020
shivam-kapila
Fine
2020-08-16 22955, 2020
shivam-kapila
Plus if the user page is not of the current user and the user has given feedback I am just fading up the icon a bit to denote that the other user has given feedback and I can also register feedback by clicking it
2020-08-16 22905, 2020
shivam-kapila
Sounds good?
2020-08-16 22936, 2020
iliekcomputers
you mean, if i'm on some other user's page, i can click the like button and it'll like the track?
2020-08-16 22943, 2020
shivam-kapila
Yes
2020-08-16 22945, 2020
ruaok
ah, is see. cool, thanks.
2020-08-16 22900, 2020
iliekcomputers
hmm, not sure about that. could be confusing.
2020-08-16 22919, 2020
shivam-kapila
So jist disable the icon if not current user
2020-08-16 22922, 2020
shivam-kapila
Just*
2020-08-16 22926, 2020
shivam-kapila
?
2020-08-16 22943, 2020
iliekcomputers
for now, yeah. i'd say that makes sense. it also makes less code, i guess
2020-08-16 22951, 2020
shivam-kapila
Far less
2020-08-16 22907, 2020
shivam-kapila
A lot of checks prevented
2020-08-16 22932, 2020
shivam-kapila
Thanks
2020-08-16 22905, 2020
MFCR_ColbyRay
does anyone know a form creator with theming other then jotform? im limited to 5 forms
See the undoc endpoints here? You could do that, or move it out of the API file entirely
2020-08-16 22942, 2020
shivam-kapila
Shall I make a helper_api.py file??
2020-08-16 22917, 2020
iliekcomputers
I'm hesitant to make helper files because it's not clear when they're supposed to contain something and when not
2020-08-16 22936, 2020
shivam-kapila
SO for now I will just undoc it
2020-08-16 22939, 2020
iliekcomputers
Maybe just put the endpoint in views/user.py
2020-08-16 22943, 2020
ruaok
I think a cover art cache with MSID as the primary key is a bad idea.
2020-08-16 22912, 2020
shivam-kapila
ruaok: Can you express your concern in details
2020-08-16 22927, 2020
shivam-kapila
detail*
2020-08-16 22904, 2020
ruaok
recording_msid is a poor key for anything. every time any bit of data for a listen is different from another listen it gets a different recording_msid.
2020-08-16 22926, 2020
MFCR_ColbyRay has quit
2020-08-16 22933, 2020
ruaok
the data space is very sparse and you'll have to have users use the site a lot before they start getting cache hits.
2020-08-16 22945, 2020
shivam-kapila
yes I agree
2020-08-16 22901, 2020
shivam-kapila
So track_name and artist_name?
2020-08-16 22901, 2020
ruaok
the right thing to do is to resolve recording_msid to release_mbid and cache release_mbid
2020-08-16 22950, 2020
shivam-kapila
> the right thing to do is to resolve recording_msid to release_mbid and cache release_mbid
