-
shivam-kapila
ok I will update it
2020-08-22 23531, 2020
-
shivam-kapila
feedback records?
2020-08-22 23509, 2020
-
shivam-kapila
or feedbackMap?
2020-08-22 23505, 2020
-
iliekcomputers
feedbackMap
2020-08-22 23515, 2020
-
iliekcomputers
recordingFeedbackMap
2020-08-22 23523, 2020
-
shivam-kapila
thanks
2020-08-22 23511, 2020
-
iliekcomputers
the json for the endpoint should return the user id
2020-08-22 23552, 2020
-
iliekcomputers
at the root level
2020-08-22 23508, 2020
-
iliekcomputers
other than that looks good to me
2020-08-22 23552, 2020
-
shivam-kapila
Sorry. which endpoint?
2020-08-22 23523, 2020
-
iliekcomputers
2020-08-22 23505, 2020
-
shivam-kapila
I used to return user_id earlier for other endpoints
2020-08-22 23534, 2020
-
shivam-kapila
then ruaok suggested to keep the structure same and uniform for both get by user/recording
2020-08-22 23547, 2020
-
shivam-kapila
so we decided to omit it at root level
2020-08-22 23504, 2020
-
shivam-kapila
Shall I update this one?
2020-08-22 23531, 2020
-
iliekcomputers
hmm, i generally like endpoints returning explicitly the thing for which the data is supposed to be.
2020-08-22 23547, 2020
-
iliekcomputers
like user for get_x_for_user and recording for get_x_for_recording
2020-08-22 23510, 2020
-
iliekcomputers
but i'm happy to keep it as is for now and add the values to the endpoint later.
2020-08-22 23522, 2020
-
shivam-kapila
will open a ticket
2020-08-22 23559, 2020
-
iliekcomputers
the build is still failing?
2020-08-22 23523, 2020
-
iliekcomputers
did you run integration tests locally before pushing?
2020-08-22 23521, 2020
-
shivam-kapila
still building for more than 20 min
2020-08-22 23540, 2020
-
iliekcomputers
2020-08-22 23512, 2020
-
iliekcomputers
2020-08-22 23536, 2020
-
shivam-kapila
oops... caught it now
2020-08-22 23551, 2020
-
shivam-kapila
running on my machine and will push only then
2020-08-22 23538, 2020
-
iliekcomputers
k
2020-08-22 23551, 2020
-
shivam-kapila
one thing I had in mind
2020-08-22 23507, 2020
-
shivam-kapila
for delete listens -- can I use bootstrap dropdown
2020-08-22 23530, 2020
-
shivam-kapila
and feed ListenControl item in it
2020-08-22 23518, 2020
-
iliekcomputers
sure
2020-08-22 23525, 2020
-
iliekcomputers
let's focus on this first
2020-08-22 23506, 2020
-
iliekcomputers
don't really think we'll meet the monday deadline...
2020-08-22 23517, 2020
-
shivam-kapila
I think we will
2020-08-22 23524, 2020
-
shivam-kapila
delete isnt much work
2020-08-22 23549, 2020
-
iliekcomputers
everything seems like not much work until we start doing it :)
2020-08-22 23527, 2020
-
shivam-kapila
I will have to meet it
2020-08-22 23550, 2020
-
shivam-kapila
I will fail otherwise 🥺
2020-08-22 23559, 2020
-
shivam-kapila
iliekcomputers: pass
2020-08-22 23550, 2020
-
shivam-kapila
oops jenkins
2020-08-22 23516, 2020
-
shivam-kapila
Can I get a CI account to retrigger jenkins builds
2020-08-22 23546, 2020
-
BrainzGit
2020-08-22 23554, 2020
-
iliekcomputers
looks reasonable on beta.
2020-08-22 23507, 2020
-
iliekcomputers
now we need a page with a list of loved/hated tracks
2020-08-22 23533, 2020
-
iliekcomputers
if we save just the recording msid we won't be able to show that immediately right?
2020-08-22 23546, 2020
-
shivam-kapila
nope
2020-08-22 23504, 2020
-
shivam-kapila
we need msid lookup
2020-08-22 23528, 2020
-
iliekcomputers
could also send over the track name and artist name and save it in the db
2020-08-22 23545, 2020
-
shivam-kapila
that was also what I proposed
2020-08-22 23548, 2020
-
iliekcomputers
given that not all msids will resolve to something in MusicBrainz.
2020-08-22 23559, 2020
-
shivam-kapila
but ruaok suggested to populate it afterwards
2020-08-22 23501, 2020
-
iliekcomputers
k, let's think about that again when rob is around.
2020-08-22 23507, 2020
-
shivam-kapila
sure
2020-08-22 23515, 2020
-
iliekcomputers
please open a ticket
2020-08-22 23534, 2020
-
shivam-kapila
People will for sure want a playlist of loved tracks
2020-08-22 23545, 2020
-
shivam-kapila
> please open a ticket
2020-08-22 23545, 2020
-
shivam-kapila
Will do
2020-08-22 23511, 2020
-
iliekcomputers
yeah, otherwise there's no real use
2020-08-22 23528, 2020
-
iliekcomputers
we can look at it when rob is back.
2020-08-22 23549, 2020
-
iliekcomputers
i'll tweet that we're releasing it for now and saving in the db, should have a page built out in the next few weeks
2020-08-22 23509, 2020
-
shivam-kapila
yep I will put it in my notion too
2020-08-22 23538, 2020
-
shivam-kapila
MSID lookup is still on bono
2020-08-22 23502, 2020
-
shivam-kapila
that can *actually solve* both coverarts and this playlist
2020-08-22 23529, 2020
-
iliekcomputers
hmm, let's do delete in the meanwhile
2020-08-22 23540, 2020
-
iliekcomputers
i think you have ~26 hours :P
2020-08-22 23544, 2020
-
shivam-kapila
Started
2020-08-22 23549, 2020
-
iliekcomputers
i should be around tomorrow, i think.
2020-08-22 23550, 2020
-
iliekcomputers
shivam-kapila: just noticed
2020-08-22 23557, 2020
-
iliekcomputers
you didn't really fix the indentation on the sql query
2020-08-22 23509, 2020
-
shivam-kapila
shit
2020-08-22 23514, 2020
-
iliekcomputers
the sql keywords should be right aligned
2020-08-22 23525, 2020
-
iliekcomputers
select and from and so on should end in the same column
2020-08-22 23526, 2020
-
shivam-kapila
oh gotcha
2020-08-22 23541, 2020
-
shivam-kapila
I will fix it with delete
2020-08-22 23556, 2020
-
iliekcomputers
would prefer a seperate PR
2020-08-22 23503, 2020
-
shivam-kapila
mini PR
2020-08-22 23508, 2020
-
iliekcomputers
yeah
2020-08-22 23514, 2020
-
iliekcomputers
with just the indentation fixes
2020-08-22 23512, 2020
-
shivam-kapila
2020-08-22 23559, 2020
-
iliekcomputers
in LEFT OUTER JOIN, the N should be below the M from the FROM
2020-08-22 23504, 2020
-
iliekcomputers
line 11
2020-08-22 23511, 2020
-
iliekcomputers
2020-08-22 23530, 2020
-
BrainzGit
2020-08-22 23533, 2020
-
Sophist-UK joined the channel
2020-08-22 23558, 2020
-
shivam-kapila goes to signup on twitter
2020-08-22 23508, 2020
-
pristine___
shivam-kapila: what happens when I tap on the heart and tap on it again?
2020-08-22 23522, 2020
-
shivam-kapila
de-love
2020-08-22 23529, 2020
-
shivam-kapila
you unlike it
2020-08-22 23534, 2020
-
pristine___
Will that remove the song from db?
2020-08-22 23535, 2020
-
pristine___
Ah
2020-08-22 23538, 2020
-
pristine___
Nice
2020-08-22 23542, 2020
-
shivam-kapila
the record will be deleted
2020-08-22 23552, 2020
-
iliekcomputers
the feedback record will be deleted
2020-08-22 23552, 2020
-
shivam-kapila
from DB
2020-08-22 23557, 2020
-
iliekcomputers
the listen will not
2020-08-22 23506, 2020
-
iliekcomputers
just to make sure we're on the same page
2020-08-22 23510, 2020
-
shivam-kapila
oh yes :p
2020-08-22 23517, 2020
-
shivam-kapila
that dustbin is coming
2020-08-22 23517, 2020
-
pristine___
shivam-kapila: thanks
2020-08-22 23524, 2020
-
shivam-kapila
pristine___: welcome
2020-08-22 23522, 2020
-
pristine___
And what will happen if I double tap the broken heart sign shivam-kapila
2020-08-22 23548, 2020
-
iliekcomputers
tapping it once means you hate the track, tapping it again removes the hate feedback
2020-08-22 23557, 2020
-
shivam-kapila
that^
2020-08-22 23516, 2020
-
shivam-kapila
if you press heart and then broken heart it will toggle the feedback
2020-08-22 23516, 2020
-
iliekcomputers
maybe a better thing to do here is show a <3 </3 if theres no feedback
2020-08-22 23536, 2020
-
iliekcomputers
if someone has liked something show a cross instead of the heart
2020-08-22 23540, 2020
-
iliekcomputers
not sure though
2020-08-22 23554, 2020
-
pristine___
I like how it is now.
2020-08-22 23503, 2020
-
shivam-kapila
me too
2020-08-22 23508, 2020
-
iliekcomputers
yeah, thinking about it, what i said makes no sense.
2020-08-22 23516, 2020
-
iliekcomputers
it would remove the actual feedback being shown
2020-08-22 23538, 2020
-
iliekcomputers
pristine___: ok, but if you had to ask what happens, then it's not ideal.
2020-08-22 23553, 2020
-
pristine___
I mean it is kinda obvious that you don't want to keep the *love* record if you double tap
2020-08-22 23503, 2020
-
pristine___
iliekcomputers: was confirming
2020-08-22 23514, 2020
-
iliekcomputers
ok.
2020-08-22 23534, 2020
-
pristine___
If there is any other functionality attached with it
2020-08-22 23556, 2020
-
shivam-kapila
a big heart for triple tap?
2020-08-22 23523, 2020
-
pristine___
Umm.... In my opinion it's nice the way it is now
2020-08-22 23536, 2020
-
shivam-kapila
NVM... JK
2020-08-22 23543, 2020
-
pristine___
:p
2020-08-22 23514, 2020
-
shivam-kapila
pristine___: I have been listening to a lot of songs of varied artists
2020-08-22 23523, 2020
-
shivam-kapila
Might wanna chk the recs
2020-08-22 23545, 2020
-
BrainzGit
2020-08-22 23559, 2020
-
BrainzGit
2020-08-22 23558, 2020
-
iliekcomputers
feedback looks good, shivam-kapila, nicely done.
2020-08-22 23512, 2020
-
iliekcomputers
shivam-kapila: found a bug :)
2020-08-22 23507, 2020
-
iliekcomputers
when there's a now playing listen in the list, it sends an "undefined" to the endpoint for getting feedback for recording_msids leading to a 400
2020-08-22 23514, 2020
-
shivam-kapila
Oh I will have to add a skip to that
2020-08-22 23522, 2020
-
shivam-kapila
If its not playing now
2020-08-22 23527, 2020
-
iliekcomputers
yep.
2020-08-22 23558, 2020
-
shivam-kapila
thanks :)
2020-08-22 23543, 2020
-
BrainzGit
2020-08-22 23508, 2020
-
iliekcomputers
hopefully the build passes lol
2020-08-22 23514, 2020
-
shivam-kapila
oh you did it. thanks
2020-08-22 23535, 2020
-
iliekcomputers
yeah, errors on the listens page isn't a good look.
2020-08-22 23544, 2020
-
iliekcomputers
i'll let you add the tests tomorrow
2020-08-22 23556, 2020
-
iliekcomputers
if the build passes, i'll merge and release
2020-08-22 23514, 2020
-
shivam-kapila
I will add tests after delete listen thing
2020-08-22 23543, 2020
-
iliekcomputers
k, i'll open a ticket
2020-08-22 23552, 2020
-
shivam-kapila
thanks
2020-08-22 23542, 2020
-
shivam-kapila
> i'll let you add the tests tomorrow
2020-08-22 23542, 2020
-
shivam-kapila
In the same PR?
2020-08-22 23517, 2020
-
iliekcomputers
no, i'm planning on merging and releasing this one
2020-08-22 23530, 2020
-
shivam-kapila
ah yes. missed that sorry
2020-08-22 23534, 2020
-
iliekcomputers
LB-712
2020-08-22 23535, 2020
-
BrainzBot
2020-08-22 23553, 2020
-
iliekcomputers
can you review the PR?
2020-08-22 23516, 2020
-
shivam-kapila
done
2020-08-22 23528, 2020
-
iliekcomputers
thanks
2020-08-22 23545, 2020
-
BrainzGit
