#metabrainz

/

      • pristine___
        Two recording_mbids can have same artist msid
      • 2020-08-23 23637, 2020

      • pristine___
        So I yes artist msids will repeat.
      • 2020-08-23 23610, 2020

      • ishaanshah
        so that explains the huge number of entries
      • 2020-08-23 23622, 2020

      • pristine___
        One thing which is distinct in the mapping is recording_mbid
      • 2020-08-23 23631, 2020

      • ishaanshah
        cross product causes the number to blow up
      • 2020-08-23 23637, 2020

      • pristine___
        Yup
      • 2020-08-23 23654, 2020

      • ishaanshah
        which maybe a reason for query being slow too
      • 2020-08-23 23618, 2020

      • pristine___
        I think so. Cross join will take time.
      • 2020-08-23 23608, 2020

      • pristine___
        If you can, you should use recording_mbid as the distinct key in mapping or maybe get distinct artist mbids.
      • 2020-08-23 23650, 2020

      • ishaanshah
        hmm, I was thinking of adding an unique statement over here
      • 2020-08-23 23650, 2020

      • ishaanshah
      • 2020-08-23 23657, 2020

      • pristine___
        Umm... I think it is not the perfect thing
      • 2020-08-23 23613, 2020

      • pristine___
        So
      • 2020-08-23 23631, 2020

      • pristine___
        If there is an artist with mbid: a, and the msids are b and c ( since many msids can map to one mbid). The distinct will give you two rows but ideally you should have one row
      • 2020-08-23 23629, 2020

      • ishaanshah
        but we want unique msids right
      • 2020-08-23 23644, 2020

      • ishaanshah
        because we are joining on msids
      • 2020-08-23 23636, 2020

      • pristine___
        Okay. If you want get distinct artist msid then it's fine. But if you want to get distinct artists then it is not the ideal thing.
      • 2020-08-23 23647, 2020

      • ishaanshah
        yep yep
      • 2020-08-23 23655, 2020

      • ishaanshah
        The problem right now is
      • 2020-08-23 23614, 2020

      • ishaanshah
        I am getting non distinct msids in the mapping df
      • 2020-08-23 23638, 2020

      • ishaanshah
        which is causing a cross join to happen and us getting a very huge tabe
      • 2020-08-23 23643, 2020

      • ishaanshah
        table
      • 2020-08-23 23651, 2020

      • pristine___
        Hmm. Right. Also you should test this distinct thing on your local machine with small data and see if you get the result you expect ( the final count of artist you expect)
      • 2020-08-23 23625, 2020

      • pristine___
        It is sometimes easier to debug things on local machine than the cluster :)
      • 2020-08-23 23626, 2020

      • ishaanshah
        Yep, I'll do that now
      • 2020-08-23 23646, 2020

      • pristine___
        Nice. Lemme know how it goes :)
      • 2020-08-23 23620, 2020

      • ishaanshah
        Yep, will do :D
      • 2020-08-23 23647, 2020

      • pristine___
        Ishaanshah: I didn't generate stats on my machone. You got it before that. Wow 🌹🌹
      • 2020-08-23 23610, 2020

      • ishaanshah
        I was reading this when we talking
      • 2020-08-23 23615, 2020

      • ishaanshah
      • 2020-08-23 23654, 2020

      • ishaanshah
        > I was reading this when we talking
      • 2020-08-23 23654, 2020

      • ishaanshah
        were*
      • 2020-08-23 23615, 2020

      • pristine___
        <3
      • 2020-08-23 23625, 2020

      • BrainzGit
        [listenbrainz-server] AbhinavOhri opened pull request #1048 (master…trailing-slash): LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-23 23625, 2020

      • BrainzBot
        LB-571: Extra slash at the end of Listens Page URL leads to 404 error https://tickets.metabrainz.org/browse/LB-571
      • 2020-08-23 23629, 2020

      • shivam-kapila
        iliekcomputers: Hi. Deletion working, state updating
      • 2020-08-23 23641, 2020

      • shivam-kapila
        working on tests and then a smooth animation
      • 2020-08-23 23611, 2020

      • thomasross joined the channel
      • 2020-08-23 23621, 2020

      • shivam-kapila
        iliekcomputers: ping
      • 2020-08-23 23650, 2020

      • sumedh joined the channel
      • 2020-08-23 23611, 2020

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #1049 (master…delete-listen): Add controls to delete listens https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-23 23644, 2020

      • Lotheric-Srain has quit
      • 2020-08-23 23602, 2020

      • iliekcomputers
        shivam-kapila: pong
      • 2020-08-23 23610, 2020

      • iliekcomputers
        I've reviewed the pr
      • 2020-08-23 23657, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1022 (master…max-to-min): LB-518: Allow users to specify both max_ts and min_ts in the get listens endpoint https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-23 23658, 2020

      • BrainzBot
        LB-518: Allow for both min_ts and max_ts in the get_listens API endpoint. https://tickets.metabrainz.org/browse/LB-518
      • 2020-08-23 23619, 2020

      • _lucifer
        pristine___: around?
      • 2020-08-23 23636, 2020

      • shivam-kapila
        iliekcomputers:
      • 2020-08-23 23639, 2020

      • shivam-kapila
        > RecentListens2 is not a descriptive name. Maybe RecentListensControls.test.tsx? Why did we add a second file though? Could we not put these tests in a Seperate describe block in the old file?
      • 2020-08-23 23654, 2020

      • shivam-kapila
        Regarding this remember the memory issue in jest
      • 2020-08-23 23617, 2020

      • shivam-kapila
        maximum calls reached
      • 2020-08-23 23638, 2020

      • iliekcomputers
        Yeah
      • 2020-08-23 23620, 2020

      • shivam-kapila
        that was actully because jest tries to make a stack of all the mock calls and arrange them according to the heirarchical need
      • 2020-08-23 23649, 2020

      • shivam-kapila
        so there were so many calls eventually the sort function led to maximum calls reached
      • 2020-08-23 23608, 2020

      • shivam-kapila
        so I split the file and it vanished
      • 2020-08-23 23624, 2020

      • iliekcomputers
        Huh
      • 2020-08-23 23657, 2020

      • iliekcomputers
        Do you have a link where I can read more about jest behaviour?
      • 2020-08-23 23604, 2020

      • iliekcomputers
        That's very weird
      • 2020-08-23 23635, 2020

      • shivam-kapila
        Actually I read through each function in the traceback
      • 2020-08-23 23652, 2020

      • shivam-kapila
        and found the comments in jest node modules functions
      • 2020-08-23 23600, 2020

      • pristine___
        _lucifer: yo
      • 2020-08-23 23601, 2020

      • shivam-kapila
        and then came to this conclusion
      • 2020-08-23 23636, 2020

      • iliekcomputers
        I don't fully understand the cause here. The number of tests shouldn't affect test behaviour
      • 2020-08-23 23658, 2020

      • iliekcomputers
        But I'm OK with keeping two files since they're a reasonable split
      • 2020-08-23 23605, 2020

      • iliekcomputers
        Can you rename the file?
      • 2020-08-23 23613, 2020

      • shivam-kapila
        I will reproduce it aftwerwards
      • 2020-08-23 23625, 2020

      • shivam-kapila
        renamed
      • 2020-08-23 23637, 2020

      • _lucifer
        pristine___: i was seeing your pr of showing candidate recording on lb website. i wanted to know if that option was available from a public api?
      • 2020-08-23 23605, 2020

      • _lucifer
        i mean to retrieve candidate recordings using a public api endpoint
      • 2020-08-23 23614, 2020

      • shivam-kapila
        yes
      • 2020-08-23 23628, 2020

      • iliekcomputers
        shivam-kapila: thanks. Also would appreciate a video and screenshots before I merge
      • 2020-08-23 23652, 2020

      • shivam-kapila
        the whole list doesnt update just the below listens push up
      • 2020-08-23 23600, 2020

      • shivam-kapila
        I am still working on a smooth animation
      • 2020-08-23 23604, 2020

      • shivam-kapila
        rest is all done
      • 2020-08-23 23606, 2020

      • iliekcomputers
        I think the text in the dropdown might read better if it's "Confirm Delete" or something, but would like to see what it looks like before asking for the change
      • 2020-08-23 23623, 2020

      • iliekcomputers
        Yeah I realize there isn't any code for the animation
      • 2020-08-23 23628, 2020

      • shivam-kapila
        lemme give you a screenshot
      • 2020-08-23 23631, 2020

      • iliekcomputers
        _lucifer: there is an undocumented as of yet endpoint for recommended tracks, but not one for the candidate tracks list where the recommendations come from
      • 2020-08-23 23613, 2020

      • _lucifer
        iliekcomputers: either one works :). can you point me to code or somewhere where I can read about it?
      • 2020-08-23 23601, 2020

      • iliekcomputers
      • 2020-08-23 23603, 2020

      • _lucifer
        thanks
      • 2020-08-23 23608, 2020

      • shivam-kapila
      • 2020-08-23 23621, 2020

      • iliekcomputers
        Something like /1/cf/recommendation/user/username/recordings
      • 2020-08-23 23651, 2020

      • pristine___
        _lucifer: hey. My internet connection dropped. Anyway, the endpoint iliekcomputers gave you gives you a list of *candidate recordings* and rating associated. We believe that the users might like listening to them.
      • 2020-08-23 23603, 2020

      • iliekcomputers
        shivam-kapila: can we show a trashcan icon next to the test?
      • 2020-08-23 23625, 2020

      • iliekcomputers
        Text
      • 2020-08-23 23631, 2020

      • shivam-kapila
        I am not very fond of keeping both icon and text. Do you prefer it?
      • 2020-08-23 23643, 2020

      • iliekcomputers
        No strong opinions, asking
      • 2020-08-23 23602, 2020

      • shivam-kapila
        we can
      • 2020-08-23 23608, 2020

      • shivam-kapila
        pristine___: _lucifer your votes please
      • 2020-08-23 23619, 2020

      • iliekcomputers
        Should the text be "Delete this listen" instead of "Delete"
      • 2020-08-23 23635, 2020

      • iliekcomputers
        Or "Delete listen"
      • 2020-08-23 23638, 2020

      • shivam-kapila
        delete listen?
      • 2020-08-23 23652, 2020

      • shivam-kapila
        lets keep that
      • 2020-08-23 23657, 2020

      • iliekcomputers
        Cool
      • 2020-08-23 23603, 2020

      • _lucifer
        text or icon, one should be shown in my opinion
      • 2020-08-23 23621, 2020

      • iliekcomputers
        let's keep the text then
      • 2020-08-23 23643, 2020

      • pristine___
        shivam-kapila: any one.
      • 2020-08-23 23655, 2020

      • shivam-kapila
        ok text it is then
      • 2020-08-23 23659, 2020

      • shivam-kapila
        thanks :)
      • 2020-08-23 23611, 2020

      • pristine___
        I personally like icons more than text but yeah any one for sure.
      • 2020-08-23 23634, 2020

      • _lucifer
        are the recs available for all users now?
      • 2020-08-23 23614, 2020

      • pristine___
        Yup.
      • 2020-08-23 23622, 2020

      • _lucifer
        nice
      • 2020-08-23 23623, 2020

      • pristine___
        all the active users
      • 2020-08-23 23649, 2020

      • pristine___
        Users which were active in the past 7 days when the recs were generated
      • 2020-08-23 23644, 2020

      • pristine___
        They were updated long back. Do you want to get fresh recs? We can run the scripts tomorrow or whenever ruaok is here
      • 2020-08-23 23617, 2020

      • _lucifer
        no, just asking for showing them in the app as well
      • 2020-08-23 23633, 2020

      • pristine___
        _lucifer: the 7 days window can be changed. If you want the recs for all users we can try to expand that window and get them for all users
      • 2020-08-23 23636, 2020

      • pristine___
        Ah!
      • 2020-08-23 23639, 2020

      • pristine___
        Cool
      • 2020-08-23 23644, 2020

      • pristine___
        Nice thing to have.
      • 2020-08-23 23600, 2020

      • _lucifer
        yeah, i also think get a play button next to the recs
      • 2020-08-23 23608, 2020

      • iliekcomputers
        _lucifer: one thing to note here is that they're not recommendations in terms of playlists or anything, as of now, they're just a random list of tracks we think the user might like
      • 2020-08-23 23646, 2020

      • _lucifer
        yes, i read that from the pr. i'll put a disclaimer
      • 2020-08-23 23650, 2020

      • iliekcomputers
        I'd chat with ruaok once to make sure that the app sets correct expectations for the users.
      • 2020-08-23 23625, 2020

      • _lucifer
        yeah i need to set up a few other things first to add that
      • 2020-08-23 23610, 2020

      • _lucifer
        so i'll first discuss it
      • 2020-08-23 23642, 2020

      • _lucifer
        then try adding those to the app
      • 2020-08-23 23653, 2020

      • iliekcomputers
        👍🏽
      • 2020-08-23 23610, 2020

      • ruaok
        Let's not do that -- the candidate tracks are are very labs-y.
      • 2020-08-23 23626, 2020

      • ruaok
        I think more solid features should be in the app.
      • 2020-08-23 23604, 2020

      • _lucifer
        ok, sure. recs later then.
      • 2020-08-23 23659, 2020

      • sumedh has quit
      • 2020-08-23 23604, 2020

      • reosarevok
        zas: you made the last changes to https://github.com/dufferzafar/Userscripts/pull/2… that I can see, so maybe you want to take a look at this one?
      • 2020-08-23 23621, 2020

      • reosarevok
        Unless there's a working version somewhere I didn't find and I wasted my time, but eh
      • 2020-08-23 23606, 2020

      • iliekcomputers
        shivam-kapila: ping me when you want me to take a look at the pr again
      • 2020-08-23 23633, 2020

      • shivam-kapila
        okk
      • 2020-08-23 23645, 2020

      • Sophist-UK has quit
      • 2020-08-23 23652, 2020

      • rdswift has quit
      • 2020-08-23 23647, 2020

      • rdswift joined the channel
      • 2020-08-23 23602, 2020

      • v6lur joined the channel
      • 2020-08-23 23604, 2020

      • shivam-kapila
        iliekcomputers:
      • 2020-08-23 23605, 2020

      • shivam-kapila
        oing
      • 2020-08-23 23610, 2020

      • shivam-kapila
        ping*
      • 2020-08-23 23620, 2020

      • iliekcomputers
        Pong
      • 2020-08-23 23626, 2020

      • shivam-kapila
      • 2020-08-23 23630, 2020

      • shivam-kapila
        video
      • 2020-08-23 23654, 2020

      • iliekcomputers
        Nice!
      • 2020-08-23 23609, 2020

      • shivam-kapila
        smooth enough?
      • 2020-08-23 23613, 2020

      • iliekcomputers
        Looks good to me
      • 2020-08-23 23613, 2020

      • shivam-kapila
        thanks :)
      • 2020-08-23 23619, 2020

      • shivam-kapila
        making a push
      • 2020-08-23 23637, 2020

      • iliekcomputers
        Awesome, I'll take a look
      • 2020-08-23 23610, 2020

      • shivam-kapila
        2 min
      • 2020-08-23 23617, 2020

      • shivam-kapila
        pushed
      • 2020-08-23 23627, 2020

      • shivam-kapila
        ah I am 20 min late :p
      • 2020-08-23 23624, 2020

      • iliekcomputers
        looking
      • 2020-08-23 23637, 2020

      • iliekcomputers
        lgtm, one nit
      • 2020-08-23 23610, 2020

      • iliekcomputers
        shivam-kapila: i'm gonna apply the suggestion, which should trigger the travis build again.