#metabrainz

Morning

Morning!

shivam-kapila: LB-714

LB-714: Pointer should change to a hand when hovering over feedback controls and three dots https://tickets.metabrainz.org/browse/LB-714

ruaok: Hi ! I wanted to transfer the kotlin-Taglib Tagger library repository to metabrainz org. How do I do it? currently I'm getting "You don’t have the permission to create public repositories on metabrainz" message while transfering

ishaanshah: around?

hi

I dont personally like hand

But is there is some design aesthetics

ishaanshah: ^

> But is there is some design aesthetics

I did not understand

ishaanshah: I was trying to find where this 51 years is coming from? Do you have any idea? i understand that is it is related to unix epch but I am not sure how is it getting rendered. I have used the BrainzPlayer.

the recommendations list wont have a listened_at field

you would have to remove this <td> cell

will*

I think you should rebase over master once

that part of the code has changed significantly after the addition of listens card

I have rebased over master.

ishaanshah: so how are recent listens and brainzplayer connected?

BrainzPlayer is a seperate component of it's own

it takes in a listen as argument and plays it using spotify / youtube / soundcloud

Right. So i have used brainzplayer to make the playlist but you linked the <td> in RecentListens.tsx?

So I think you cannot directly use the recent listens component for showing the recs

because recs don't have fields for listened at and love hate control

One thing, RecentListen.tsx is a file that contains many components and Brainzplayer is one of them, is that?

yoyes

yes*

ishaanshah: And Brainzplayer uses the general structure of RecentListens so I cannot use that because there is not listened_at field in recs?

yep

I want to keep love hate control in recs but not the listened_at field. What can be a good way to achieve this? Do you have any opinion on this?

recent listens is essentially a list of ListenCard components

We have a mode prop that we pass in the component

currently there are three modes

We use conditional rendering depending upon the mode we are in

we can add another mode "recs"

and use this to conditionally remove the listened_at field

This is not an ideal way but it is the fastest that I can think of

Why not ideal?

the code becomes hard to read

We are doing a lot of stuff in the same component

So what should be the ideal way?

Make a new component?

Ideally yes

but we also have to think about how to separate the already present modes too

Umm... Since I am not so comfortable in react atm, may be we can have a new mode now, and make a new component later?

Yeah thats why I suggested the new modde

ishaanshah: aren't the modes too much interlinked?

meaning?

yeah they have a lot of common stuff

But when I was porting the recent listens page to ts, I found it a bit confusing to read

iliekcomputers and I discussed about it then and opened a ticket for it

But we haven't discussed about how to fix it yet

I am not so much comfortable in react so I think that is the reason I am so much confused. But yes, I understand what you say.

Till we find a way to fix it, I will try to add a new mode.

At least the recs will be shown.

On the site.

yep, I think thats the way to go right now.

Thank you so much 🌹

[listenbrainz-server] phw opened pull request #1050 (master…controls-cursor): Use pointer cursor for listen control buttons https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] paramsingh merged pull request #1050 (master…controls-cursor): Use pointer cursor for listen control buttons https://github.com/metabrainz/listenbrainz-serv...

morning!

hi

jmp_music_: around? let's sort out this PR

ishaanshah: sorry I didnt get you in morning. Now I researched and found its correct

To change cursor

Hello. I am a bit confused about this VLC plugin that adds ListenBrainz.

I don't know where to put the *.so file from the releases section. I am on Linux.

alastairp: give me 5 minutes to restart my pc

no prob. take you rtime

ksynwa: I'm not familiar with the plugin, but the readme file says that if you run `sudo make install` that it will copy the so file to VLC's plugin directory

rdswift: There is definitely an error on the LB listens page that prevent it from auto-updating with the recent listens and "now playing" notifications. We have a CORS issue that broke that functionality down. I'll see if there's a ticket open and open one otherwise

hi Mr_Monkey!

Hmm that makes sense. Let me try.

alastairp Yes that worked. Thank you very much.

👍 glad we could help

Hi alastairp !

rdswift: they were already reported: LB-624 and LB-679

LB-624: Socket CORS errors in the web pages https://tickets.metabrainz.org/browse/LB-624

LB-679: Listens page - Websockets not working anymore https://tickets.metabrainz.org/browse/LB-679

alastairp: I 'm back

when you have time let's do this

OK, I'm just getting my tea

jmp_music_: ok, right

so I'm looking at your branch, at the output of `git log -p --pretty=fuller`

I closed the other PR as you suggested me

specifically Im looking at commit d3930e5e2b3256d4caeaee46780678f937ee2507, which is your merge

yeah, that's great

I can't tell for sure what happened, but I wonder if you had some conflicts that you tried to fix? and got into an unexpected situation where you ended up creating a regular commit

it seems that the conflict may have been around the train_gaia stuff, right? because you modified that, and I did too

this isn't a problem. looking at the commits: https://github.com/metabrainz/acousticbrainz-se..., I recommend that we keep the first 3 commits, undo the others, perform a proper merge, and then re-apply any additional commits that we need. this should be quite easy

right! There is a function that I implemented. The previous train parameters did not include the C, gamma inputs from the form

right

I made these changes and I built the function for training gaia

so, first I'm going to do `git reset --hard 54ab98724862eee`. This will undo until the commit where you added the readme

then `git merge origin/master`, and obviously it's failed with "CONFLICT (content): Merge conflict in dataset_eval/evaluate.py"

exactly

you can follow along if you want. make sure you stash any local changes, or have them in a separate branch. as long as all of your commits are on github it'll be very difficult to lose anything

ok

OK, so the conflicted section isn't very large https://usercontent.irccloud-cdn.com/file/1QlVF...

so what we want to do here is fix the conflict, git add that file, and then git commit the result

including the git's comments?

and then making the changes?

after the commit

?

yes, right. because at the moment we're in the middle of the merge