#metabrainz

/

      • SothoTalKer has quit
      • 2020-08-24 23757, 2020

      • SothoTalKer joined the channel
      • 2020-08-24 23731, 2020

      • SothoTalKer has quit
      • 2020-08-24 23703, 2020

      • SothoTalKer joined the channel
      • 2020-08-24 23718, 2020

      • supersandro2000 has quit
      • 2020-08-24 23738, 2020

      • supersandro2000 joined the channel
      • 2020-08-24 23709, 2020

      • Nyanko-sensei has quit
      • 2020-08-24 23753, 2020

      • Nyanko-sensei joined the channel
      • 2020-08-24 23704, 2020

      • thomasross has quit
      • 2020-08-24 23748, 2020

      • shivam-kapila
        Morning
      • 2020-08-24 23702, 2020

      • ephemer0l has quit
      • 2020-08-24 23720, 2020

      • ephemer0l joined the channel
      • 2020-08-24 23737, 2020

      • ishaanshah
        Morning!
      • 2020-08-24 23737, 2020

      • ishaanshah
        shivam-kapila: LB-714
      • 2020-08-24 23738, 2020

      • BrainzBot
        LB-714: Pointer should change to a hand when hovering over feedback controls and three dots https://tickets.metabrainz.org/browse/LB-714
      • 2020-08-24 23759, 2020

      • SomalRudra
        ruaok: Hi ! I wanted to transfer the kotlin-Taglib Tagger library repository to metabrainz org. How do I do it? currently I'm getting "You don’t have the permission to create public repositories on metabrainz" message while transfering
      • 2020-08-24 23712, 2020

      • sumedh joined the channel
      • 2020-08-24 23714, 2020

      • pristine___
        ishaanshah: around?
      • 2020-08-24 23745, 2020

      • ishaanshah
        hi
      • 2020-08-24 23721, 2020

      • d4rkie joined the channel
      • 2020-08-24 23750, 2020

      • shivam-kapila
        I dont personally like hand
      • 2020-08-24 23712, 2020

      • Nyanko-sensei has quit
      • 2020-08-24 23712, 2020

      • shivam-kapila
        But is there is some design aesthetics
      • 2020-08-24 23726, 2020

      • shivam-kapila
        ishaanshah: ^
      • 2020-08-24 23706, 2020

      • MajorLurker joined the channel
      • 2020-08-24 23755, 2020

      • ishaanshah
        > But is there is some design aesthetics
      • 2020-08-24 23755, 2020

      • ishaanshah
        I did not understand
      • 2020-08-24 23742, 2020

      • pristine___
      • 2020-08-24 23750, 2020

      • pristine___
        ishaanshah: I was trying to find where this 51 years is coming from? Do you have any idea? i understand that is it is related to unix epch but I am not sure how is it getting rendered. I have used the BrainzPlayer.
      • 2020-08-24 23758, 2020

      • ishaanshah
      • 2020-08-24 23723, 2020

      • ishaanshah
        the recommendations list wont have a listened_at field
      • 2020-08-24 23747, 2020

      • ishaanshah
        you would have to remove this <td> cell
      • 2020-08-24 23752, 2020

      • ishaanshah
        will*
      • 2020-08-24 23707, 2020

      • ishaanshah
        I think you should rebase over master once
      • 2020-08-24 23725, 2020

      • ishaanshah
        that part of the code has changed significantly after the addition of listens card
      • 2020-08-24 23726, 2020

      • MajorLurker has quit
      • 2020-08-24 23749, 2020

      • pristine___
        I have rebased over master.
      • 2020-08-24 23710, 2020

      • pristine___
        ishaanshah: so how are recent listens and brainzplayer connected?
      • 2020-08-24 23714, 2020

      • MajorLurker joined the channel
      • 2020-08-24 23703, 2020

      • ishaanshah
        BrainzPlayer is a seperate component of it's own
      • 2020-08-24 23753, 2020

      • ishaanshah
        it takes in a listen as argument and plays it using spotify / youtube / soundcloud
      • 2020-08-24 23723, 2020

      • ishaanshah
      • 2020-08-24 23745, 2020

      • pristine___
        Right. So i have used brainzplayer to make the playlist but you linked the <td> in RecentListens.tsx?
      • 2020-08-24 23726, 2020

      • ishaanshah
        So I think you cannot directly use the recent listens component for showing the recs
      • 2020-08-24 23703, 2020

      • ishaanshah
        because recs don't have fields for listened at and love hate control
      • 2020-08-24 23742, 2020

      • pristine___
        One thing, RecentListen.tsx is a file that contains many components and Brainzplayer is one of them, is that?
      • 2020-08-24 23753, 2020

      • ishaanshah
        yoyes
      • 2020-08-24 23756, 2020

      • ishaanshah
        yes*
      • 2020-08-24 23702, 2020

      • pristine___
        ishaanshah: And Brainzplayer uses the general structure of RecentListens so I cannot use that because there is not listened_at field in recs?
      • 2020-08-24 23742, 2020

      • ishaanshah
        yep
      • 2020-08-24 23753, 2020

      • pristine___
        I want to keep love hate control in recs but not the listened_at field. What can be a good way to achieve this? Do you have any opinion on this?
      • 2020-08-24 23713, 2020

      • ishaanshah
        recent listens is essentially a list of ListenCard components
      • 2020-08-24 23753, 2020

      • ishaanshah
      • 2020-08-24 23710, 2020

      • ishaanshah
        We have a mode prop that we pass in the component
      • 2020-08-24 23720, 2020

      • ishaanshah
        currently there are three modes
      • 2020-08-24 23748, 2020

      • ishaanshah
      • 2020-08-24 23704, 2020

      • ishaanshah
        We use conditional rendering depending upon the mode we are in
      • 2020-08-24 23720, 2020

      • ishaanshah
        we can add another mode "recs"
      • 2020-08-24 23742, 2020

      • ishaanshah
        and use this to conditionally remove the listened_at field
      • 2020-08-24 23706, 2020

      • ishaanshah
        This is not an ideal way but it is the fastest that I can think of
      • 2020-08-24 23719, 2020

      • pristine___
        Why not ideal?
      • 2020-08-24 23700, 2020

      • ishaanshah
        the code becomes hard to read
      • 2020-08-24 23714, 2020

      • ishaanshah
        We are doing a lot of stuff in the same component
      • 2020-08-24 23725, 2020

      • pristine___
        So what should be the ideal way?
      • 2020-08-24 23731, 2020

      • pristine___
        Make a new component?
      • 2020-08-24 23757, 2020

      • ishaanshah
        Ideally yes
      • 2020-08-24 23729, 2020

      • ishaanshah
        but we also have to think about how to separate the already present modes too
      • 2020-08-24 23744, 2020

      • pristine___
        Umm... Since I am not so comfortable in react atm, may be we can have a new mode now, and make a new component later?
      • 2020-08-24 23702, 2020

      • ishaanshah
        Yeah thats why I suggested the new modde
      • 2020-08-24 23711, 2020

      • pristine___
        ishaanshah: aren't the modes too much interlinked?
      • 2020-08-24 23740, 2020

      • ishaanshah
        meaning?
      • 2020-08-24 23753, 2020

      • ishaanshah
        yeah they have a lot of common stuff
      • 2020-08-24 23730, 2020

      • ishaanshah
        But when I was porting the recent listens page to ts, I found it a bit confusing to read
      • 2020-08-24 23700, 2020

      • ishaanshah
        iliekcomputers and I discussed about it then and opened a ticket for it
      • 2020-08-24 23737, 2020

      • ishaanshah
        But we haven't discussed about how to fix it yet
      • 2020-08-24 23712, 2020

      • pristine___
        I am not so much comfortable in react so I think that is the reason I am so much confused. But yes, I understand what you say.
      • 2020-08-24 23730, 2020

      • pristine___
        Till we find a way to fix it, I will try to add a new mode.
      • 2020-08-24 23746, 2020

      • pristine___
        At least the recs will be shown.
      • 2020-08-24 23749, 2020

      • pristine___
        On the site.
      • 2020-08-24 23705, 2020

      • ishaanshah
        yep, I think thats the way to go right now.
      • 2020-08-24 23714, 2020

      • pristine___
        Thank you so much 🌹
      • 2020-08-24 23759, 2020

      • hugo___ has quit
      • 2020-08-24 23708, 2020

      • hugo___ joined the channel
      • 2020-08-24 23738, 2020

      • imdeni has quit
      • 2020-08-24 23739, 2020

      • imdeni joined the channel
      • 2020-08-24 23707, 2020

      • sumedh has quit
      • 2020-08-24 23700, 2020

      • CallerNo6 has quit
      • 2020-08-24 23754, 2020

      • BrainzGit
        [listenbrainz-server] phw opened pull request #1050 (master…controls-cursor): Use pointer cursor for listen control buttons https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-24 23710, 2020

      • CallerNo6 joined the channel
      • 2020-08-24 23710, 2020

      • CallerNo6 has quit
      • 2020-08-24 23710, 2020

      • CallerNo6 joined the channel
      • 2020-08-24 23738, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1050 (master…controls-cursor): Use pointer cursor for listen control buttons https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-24 23719, 2020

      • v6lur joined the channel
      • 2020-08-24 23754, 2020

      • antlarr has quit
      • 2020-08-24 23720, 2020

      • antlarr joined the channel
      • 2020-08-24 23745, 2020

      • Higilopochtli has quit
      • 2020-08-24 23712, 2020

      • Higilopochtli joined the channel
      • 2020-08-24 23709, 2020

      • jmp_music_
        morning!
      • 2020-08-24 23732, 2020

      • alastairp
        hi
      • 2020-08-24 23742, 2020

      • alastairp
        jmp_music_: around? let's sort out this PR
      • 2020-08-24 23739, 2020

      • MajorLurker has quit
      • 2020-08-24 23701, 2020

      • Gazooo7 has quit
      • 2020-08-24 23744, 2020

      • shivam-kapila
        ishaanshah: sorry I didnt get you in morning. Now I researched and found its correct
      • 2020-08-24 23747, 2020

      • Gazooo7 joined the channel
      • 2020-08-24 23751, 2020

      • heyarne[m] has left the channel
      • 2020-08-24 23755, 2020

      • shivam-kapila
        To change cursor
      • 2020-08-24 23746, 2020

      • ksynwa joined the channel
      • 2020-08-24 23738, 2020

      • ksynwa
        Hello. I am a bit confused about this VLC plugin that adds ListenBrainz.
      • 2020-08-24 23740, 2020

      • ksynwa
      • 2020-08-24 23710, 2020

      • ksynwa
        I don't know where to put the *.so file from the releases section. I am on Linux.
      • 2020-08-24 23733, 2020

      • jmp_music_
        alastairp: give me 5 minutes to restart my pc
      • 2020-08-24 23705, 2020

      • alastairp
        no prob. take you rtime
      • 2020-08-24 23714, 2020

      • alastairp
        ksynwa: I'm not familiar with the plugin, but the readme file says that if you run `sudo make install` that it will copy the so file to VLC's plugin directory
      • 2020-08-24 23725, 2020

      • Mr_Monkey
        rdswift: There is definitely an error on the LB listens page that prevent it from auto-updating with the recent listens and "now playing" notifications. We have a CORS issue that broke that functionality down. I'll see if there's a ticket open and open one otherwise
      • 2020-08-24 23726, 2020

      • alastairp
        hi Mr_Monkey!
      • 2020-08-24 23711, 2020

      • ksynwa
        Hmm that makes sense. Let me try.
      • 2020-08-24 23746, 2020

      • ksynwa
        alastairp Yes that worked. Thank you very much.
      • 2020-08-24 23710, 2020

      • alastairp
        👍 glad we could help
      • 2020-08-24 23713, 2020

      • Mr_Monkey
        Hi alastairp !
      • 2020-08-24 23742, 2020

      • Mr_Monkey
        rdswift: they were already reported: LB-624 and LB-679
      • 2020-08-24 23744, 2020

      • BrainzBot
        LB-624: Socket CORS errors in the web pages https://tickets.metabrainz.org/browse/LB-624
      • 2020-08-24 23744, 2020

      • BrainzBot
        LB-679: Listens page - Websockets not working anymore https://tickets.metabrainz.org/browse/LB-679
      • 2020-08-24 23733, 2020

      • jmp_music_
        alastairp: I 'm back
      • 2020-08-24 23746, 2020

      • jmp_music_
        when you have time let's do this
      • 2020-08-24 23753, 2020

      • alastairp
        OK, I'm just getting my tea
      • 2020-08-24 23708, 2020

      • alastairp
        jmp_music_: ok, right
      • 2020-08-24 23732, 2020

      • alastairp
        so I'm looking at your branch, at the output of `git log -p --pretty=fuller`
      • 2020-08-24 23747, 2020

      • jmp_music_
        I closed the other PR as you suggested me
      • 2020-08-24 23748, 2020

      • alastairp
        specifically Im looking at commit d3930e5e2b3256d4caeaee46780678f937ee2507, which is your merge
      • 2020-08-24 23752, 2020

      • alastairp
        yeah, that's great
      • 2020-08-24 23725, 2020

      • alastairp
        I can't tell for sure what happened, but I wonder if you had some conflicts that you tried to fix? and got into an unexpected situation where you ended up creating a regular commit
      • 2020-08-24 23759, 2020

      • MajorLurker joined the channel
      • 2020-08-24 23705, 2020

      • alastairp
        it seems that the conflict may have been around the train_gaia stuff, right? because you modified that, and I did too
      • 2020-08-24 23757, 2020

      • alastairp
        this isn't a problem. looking at the commits: https://github.com/metabrainz/acousticbrainz-serv…, I recommend that we keep the first 3 commits, undo the others, perform a proper merge, and then re-apply any additional commits that we need. this should be quite easy
      • 2020-08-24 23727, 2020

      • jmp_music_
        right! There is a function that I implemented. The previous train parameters did not include the C, gamma inputs from the form
      • 2020-08-24 23741, 2020

      • alastairp
        right
      • 2020-08-24 23721, 2020

      • jmp_music_
        I made these changes and I built the function for training gaia
      • 2020-08-24 23723, 2020

      • alastairp
        so, first I'm going to do `git reset --hard 54ab98724862eee`. This will undo until the commit where you added the readme
      • 2020-08-24 23749, 2020

      • alastairp
        then `git merge origin/master`, and obviously it's failed with "CONFLICT (content): Merge conflict in dataset_eval/evaluate.py"
      • 2020-08-24 23729, 2020

      • jmp_music_
        exactly
      • 2020-08-24 23730, 2020

      • alastairp
        you can follow along if you want. make sure you stash any local changes, or have them in a separate branch. as long as all of your commits are on github it'll be very difficult to lose anything
      • 2020-08-24 23728, 2020

      • jmp_music_
        ok
      • 2020-08-24 23741, 2020

      • alastairp
        OK, so the conflicted section isn't very large https://usercontent.irccloud-cdn.com/file/1QlVFbQ…
      • 2020-08-24 23711, 2020

      • alastairp
        so what we want to do here is fix the conflict, git add that file, and then git commit the result
      • 2020-08-24 23732, 2020

      • jmp_music_
        including the git's comments?
      • 2020-08-24 23740, 2020

      • jmp_music_
        and then making the changes?
      • 2020-08-24 23745, 2020

      • jmp_music_
        after the commit
      • 2020-08-24 23745, 2020

      • jmp_music_
        ?
      • 2020-08-24 23752, 2020

      • alastairp
        yes, right. because at the moment we're in the middle of the merge
      • 2020-08-24 23700, 2020

      • alastairp