13:15 PM
ishaanshah
we have to download and upload i think
2020-08-24 23702, 2020
13:16 PM
iliekcomputers
don't think that's a good idea, we'll start running out of space on the master server
2020-08-24 23702, 2020
13:16 PM
ishaanshah
I am not sure the speed implications for this
2020-08-24 23709, 2020
13:16 PM
jmp_music_
alastairp: I think if we could modify the function to accept these values and overwriting the default ones it could be possible. It isn't yet available because I saw that feature after adding the code to AB
2020-08-24 23732, 2020
13:16 PM
ishaanshah
we could save it in a temp directory
2020-08-24 23743, 2020
13:16 PM
alastairp
jmp_music_: sure. take a look at the code that was recently added and copy that into the sklearn version
2020-08-24 23753, 2020
13:16 PM
alastairp
what will you work on next?
2020-08-24 23704, 2020
13:17 PM
ishaanshah
using context manager so that we cleanup in case of errors too
2020-08-24 23700, 2020
13:19 PM
jmp_music_
alastairp: ok. I want to check the evaluation if it works properly when I evaluate a dataset from the UI. Till now, when I press the evaluate button, this error occurs
2020-08-24 23711, 2020
13:19 PM
iliekcomputers
you could call `hdfs dfs cp` using subprocess
2020-08-24 23714, 2020
13:19 PM
jmp_music_
2020-08-24 23738, 2020
13:19 PM
alastairp
oh yeah, I remember you commented on that
2020-08-24 23748, 2020
13:19 PM
alastairp
let me take a look with your branch
2020-08-24 23748, 2020
13:19 PM
ishaanshah
I dont think we have hdfs installed on request_consumer
2020-08-24 23754, 2020
13:19 PM
ishaanshah
I'll check once
2020-08-24 23756, 2020
13:19 PM
jmp_music_
Do I need to build again the CSS and JS?
2020-08-24 23735, 2020
13:20 PM
ishaanshah
`bash: hdfs: command not found`
2020-08-24 23738, 2020
13:20 PM
thomasross has quit
2020-08-24 23757, 2020
13:20 PM
ishaanshah
we can access it in the hadoop-master container
2020-08-24 23728, 2020
13:25 PM
ishaanshah
alastairp: The import worked for me
2020-08-24 23738, 2020
13:25 PM
ishaanshah
maybe some network issues on his side
2020-08-24 23752, 2020
13:25 PM
ishaanshah
can you ask him to try on another device?
2020-08-24 23709, 2020
13:26 PM
iliekcomputers
or get logs on errors from the console
2020-08-24 23732, 2020
13:26 PM
iliekcomputers
ishaanshah: hmm, we could install hdfs into request consumer.
2020-08-24 23757, 2020
13:26 PM
iliekcomputers
or just roll our own copy using read() and write()
2020-08-24 23719, 2020
13:28 PM
ishaanshah
i would prefer read+write
2020-08-24 23737, 2020
13:28 PM
ishaanshah
I am wary of installing java stuff 😅
2020-08-24 23738, 2020
13:29 PM
iliekcomputers
ok. sgtm.
2020-08-24 23744, 2020
13:29 PM
ishaanshah
abhinavohri: I think moving all of them would be fine
2020-08-24 23738, 2020
13:30 PM
_lucifer
ishaanshah: why so (wary of installing java stuff)?
2020-08-24 23701, 2020
13:31 PM
ishaanshah
haven't had good experience with java
2020-08-24 23719, 2020
13:31 PM
ishaanshah
I find it hard to write and understand
2020-08-24 23739, 2020
13:33 PM
alastairp
jmp_music_: when you submitted the dataset did you have any options selected?
2020-08-24 23717, 2020
13:34 PM
jmp_music_
hmm, I don't remember, but let me submit another one
2020-08-24 23734, 2020
13:34 PM
jmp_music_
give me few secs
2020-08-24 23723, 2020
13:35 PM
alastairp
because I just tried and it works fine
2020-08-24 23757, 2020
13:35 PM
jmp_music_
2020-08-24 23702, 2020
13:36 PM
jmp_music_
i did that way
2020-08-24 23735, 2020
13:36 PM
jmp_music_
by importing a csv that I dowloaded from the annotations
2020-08-24 23721, 2020
13:38 PM
alastairp
but that's the import page
2020-08-24 23728, 2020
13:38 PM
alastairp
so you imported, and then you chose evaluate?
2020-08-24 23735, 2020
13:38 PM
alastairp
or does that error occur when you import?
2020-08-24 23722, 2020
13:39 PM
abhinavohri
ishaanshah:
2020-08-24 23729, 2020
13:39 PM
abhinavohri
ok .
2020-08-24 23739, 2020
13:39 PM
jmp_music_
the error occurs only when I chose to evaluate the dataset
2020-08-24 23751, 2020
13:39 PM
jmp_music_
occurred*
2020-08-24 23752, 2020
13:39 PM
alastairp
and you've just reproduced it again now?
2020-08-24 23700, 2020
13:40 PM
alastairp
because I did the same thing and it works fine here
2020-08-24 23718, 2020
13:40 PM
jmp_music_
yeap. I deleted the dataset from the db manually
2020-08-24 23733, 2020
13:40 PM
jmp_music_
and I uploaded the dataset again
2020-08-24 23754, 2020
13:40 PM
jmp_music_
because the evaluation didnt work even when I deleted the job
2020-08-24 23701, 2020
13:41 PM
alastairp
super strange, because I'm running your branch, and I just evaluated a job
2020-08-24 23749, 2020
13:41 PM
jmp_music_
how can I rebuild the JS ?
2020-08-24 23756, 2020
13:41 PM
jmp_music_
maybe there is a problem there?
2020-08-24 23711, 2020
13:42 PM
alastairp
./develop.sh npm install
2020-08-24 23718, 2020
13:42 PM
alastairp
./develop.sh npm run build:deb
2020-08-24 23722, 2020
13:42 PM
alastairp
build:dev
2020-08-24 23701, 2020
13:44 PM
jmp_music_
i tried this yesterday, but let me check it again
2020-08-24 23729, 2020
13:45 PM
jmp_music_
it doent work
2020-08-24 23746, 2020
13:45 PM
jmp_music_
2020-08-24 23750, 2020
13:45 PM
jmp_music_
check this
2020-08-24 23722, 2020
13:46 PM
alastairp
that's fine
2020-08-24 23729, 2020
13:46 PM
jmp_music_
hmm ok
2020-08-24 23728, 2020
13:49 PM
jmp_music_
I even tried to delete the docker images and the containers too
2020-08-24 23744, 2020
13:49 PM
jmp_music_
I re-installed the AB server and it didnt work
2020-08-24 23701, 2020
13:50 PM
alastairp
and you didn't tick either box on the evaluation screen?
2020-08-24 23711, 2020
13:50 PM
alastairp
what browser do you use?
2020-08-24 23759, 2020
13:51 PM
jmp_music_
2020-08-24 23709, 2020
13:52 PM
alastairp
oh, interesting
2020-08-24 23714, 2020
13:52 PM
jmp_music_
there is no other option button
2020-08-24 23723, 2020
13:52 PM
jmp_music_
only the `Evaluate`
2020-08-24 23737, 2020
13:52 PM
alastairp
2020-08-24 23708, 2020
13:53 PM
jmp_music_
This is the toggle buttons inside the `forms.py` right?
2020-08-24 23720, 2020
13:53 PM
alastairp
yeah
2020-08-24 23725, 2020
13:53 PM
alastairp
did you modify this at all?
2020-08-24 23742, 2020
13:53 PM
jmp_music_
not yet
2020-08-24 23731, 2020
13:54 PM
jmp_music_
I tested the AB server both in firefox and chrome
2020-08-24 23701, 2020
13:57 PM
alastairp
yeah, that shouldn't be an issue
2020-08-24 23717, 2020
13:57 PM
alastairp
I'm just really surprised that we're both running the same code and you're not seeing the checkboxes
2020-08-24 23722, 2020
14:07 PM
alastairp
ishaanshah: It's possible that the error is because of firefox + ublock origin + some specific block lists. when he disabled ublock it worked fine
2020-08-24 23740, 2020
14:07 PM
alastairp
he got a specific error about a CORS request being blocked:
2020-08-24 23743, 2020
14:07 PM
jmp_music_
Is it a good idea to delete completely the ab directory where everything is located in my pc and download again the AB from the forked repo?
2020-08-24 23756, 2020
14:07 PM
alastairp
2020-08-24 23730, 2020
14:08 PM
alastairp
because of his tools, there's not much we can do, but perhaps we could detect this specific error, or if a blocker is installed, and put a notice saying to disable it?
2020-08-24 23735, 2020
14:08 PM
alastairp
jmp_music_: I'm pretty sure that won't help
2020-08-24 23743, 2020
14:08 PM
alastairp
jmp_music_: what's the full output of `git status` ?
2020-08-24 23740, 2020
14:09 PM
alastairp
jmp_music_: ohhh, I found the error :D
2020-08-24 23743, 2020
14:09 PM
alastairp
my mistake, sorry
2020-08-24 23759, 2020
14:09 PM
alastairp
2020-08-24 23709, 2020
14:10 PM
alastairp
see that we don't show some items if they're disabled in the config
2020-08-24 23728, 2020
14:10 PM
alastairp
so the form item isn't being set, and the validation is failing
2020-08-24 23740, 2020
14:10 PM
jmp_music_
hmm, ok
2020-08-24 23756, 2020
14:10 PM
alastairp
easy fix is to modify your config.py and add `FEATURE_EVAL_FILTERING = True` and `FEATURE_EVAL_MODEL_SELECTION = True`
2020-08-24 23721, 2020
14:11 PM
alastairp
but this is a bug that I'll fix so that form submission works if they're set to False
2020-08-24 23747, 2020
14:12 PM
jmp_music_
oh, because the config.py was set up the first time I installed the AB, it didnt change after the merging, bacause it is on gitingore
2020-08-24 23711, 2020
14:13 PM
alastairp
yeah, right
2020-08-24 23748, 2020
14:14 PM
shivam-kapila
alastairp: can you show the cors
2020-08-24 23739, 2020
14:16 PM
alastairp
shivam-kapila: I assume that the OPTIONS request was blocked, but it was ublock origin which did it
2020-08-24 23756, 2020
14:16 PM
alastairp
do you want me to confirm if it was the OPTIONS or the GET that failed?
2020-08-24 23729, 2020
14:18 PM
shivam-kapila
Yesterday our API also failed due to OPTIONS so I thought that might br it
2020-08-24 23738, 2020
14:19 PM
alastairp
it failed for him a week ago too, and this morning, and he just disabled ublock and it succeeded
2020-08-24 23751, 2020
14:19 PM
alastairp
so at the moment we believe that it was ublock, but he will do some further testing
2020-08-24 23741, 2020
14:21 PM
shivam-kapila
Ah.
2020-08-24 23752, 2020
14:21 PM
shivam-kapila
Thanks for info
2020-08-24 23706, 2020
14:36 PM
BrainzGit
2020-08-24 23707, 2020
14:36 PM
BrainzBot
2020-08-24 23753, 2020
14:44 PM
thomasross joined the channel
2020-08-24 23737, 2020
14:59 PM
ishaanshah
alastairp: I use ublock origin too so not sure whats happening, I will look into it in a bit more detail and add a note if needed.
2020-08-24 23719, 2020
15:00 PM
hugo____ joined the channel
2020-08-24 23702, 2020
15:01 PM
SothoTalKer_ joined the channel
2020-08-24 23750, 2020
15:02 PM
hugo___ has quit
2020-08-24 23750, 2020
15:02 PM
hugo____ is now known as hugo___
2020-08-24 23716, 2020
15:03 PM
kori has quit
2020-08-24 23756, 2020
15:03 PM
SothoTalKer has quit
2020-08-24 23757, 2020
15:03 PM
iliekcomputers has quit
2020-08-24 23742, 2020
15:05 PM
iliekcomputers joined the channel
2020-08-24 23743, 2020
15:07 PM
kori joined the channel
2020-08-24 23722, 2020
15:08 PM
thomasross has quit
2020-08-24 23736, 2020
15:09 PM
reosarevok_ joined the channel
2020-08-24 23759, 2020
15:09 PM
reosarevok has quit
2020-08-24 23759, 2020
15:09 PM
reosarevok_ is now known as reosarevok
2020-08-24 23758, 2020
15:11 PM
rdswift has quit
2020-08-24 23740, 2020
15:12 PM
rdswift joined the channel
2020-08-24 23755, 2020
15:12 PM
Higilopochtli has quit
2020-08-24 23712, 2020
15:13 PM
Higilopochtli joined the channel
2020-08-24 23725, 2020
15:22 PM
i7c has quit
2020-08-24 23740, 2020
15:22 PM
revi has quit
2020-08-24 23741, 2020
15:22 PM
reg[m] has quit
2020-08-24 23741, 2020
15:22 PM
Mineo has quit
2020-08-24 23741, 2020
15:22 PM
djinni` has quit
2020-08-24 23743, 2020
15:22 PM
milkii has quit
2020-08-24 23743, 2020
15:22 PM
legoktm has quit
2020-08-24 23743, 2020
15:22 PM
Leftmost has quit
2020-08-24 23758, 2020
15:25 PM
BrainzGit
2020-08-24 23759, 2020
15:25 PM
BrainzBot
2020-08-24 23754, 2020
15:29 PM
abhinavohri
ishaanshah: i am working on LB-707 . Please tell me how should i split them.
2020-08-24 23755, 2020
15:29 PM
BrainzBot
2020-08-24 23739, 2020
15:33 PM
reg[m] joined the channel
2020-08-24 23754, 2020
15:33 PM
revi joined the channel
2020-08-24 23754, 2020
15:33 PM
Mineo joined the channel
2020-08-24 23754, 2020
15:33 PM
djinni` joined the channel
2020-08-24 23709, 2020
15:34 PM
milkii joined the channel
2020-08-24 23709, 2020
15:34 PM
legoktm joined the channel
2020-08-24 23709, 2020
15:34 PM
Leftmost joined the channel
2020-08-24 23712, 2020
15:42 PM
BrainzGit
2020-08-24 23709, 2020
15:49 PM
ishaanshah
abhinavohri: You can make another stats module in db module
2020-08-24 23737, 2020
15:49 PM
ishaanshah
and follow the directory structure similar to this
2020-08-24 23738, 2020
15:49 PM
ishaanshah
2020-08-24 23711, 2020
15:50 PM
ishaanshah
user_artist/release/recording go in an entity.py file
2020-08-24 23723, 2020
15:50 PM
ishaanshah
others in their own files
