#metabrainz

/

      • iliekcomputers
        shivam-kapila: you around?

        • 2020-08-28 24115, 2020

      • iliekcomputers
        i had a question about the spotify pr

        • 2020-08-28 24127, 2020

      • iliekcomputers
        why'd you change the testcase parent class to database test case?

        • 2020-08-28 24131, 2020

      • iliekcomputers
        Is that really needed

        • 2020-08-28 24150, 2020

      • shivam-kapila
        I needed a test user

        • 2020-08-28 24116, 2020

      • shivam-kapila
        And that user needed to be removed post tests

        • 2020-08-28 24127, 2020

      • iliekcomputers
        why?

        • 2020-08-28 24142, 2020

      • iliekcomputers
        the user can be faked like it was being faked already right?

        • 2020-08-28 24147, 2020

      • shivam-kapila
        Otherwise timescale listenstore tests were failing

        • 2020-08-28 24148, 2020

      • iliekcomputers
        why does it need to be in the database?

        • 2020-08-28 24159, 2020

      • iliekcomputers
        huh?

        • 2020-08-28 24126, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1056 (master…improve-heart-colors): Update heart color shades https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24134, 2020

      • shivam-kapila
        If I didnt create a real user then there was an error

        • 2020-08-28 24134, 2020

      • shivam-kapila
        Relation "user" doesnt exist

        • 2020-08-28 24117, 2020

      • shivam-kapila
        There's a check for token refresh in the code that was failing

        • 2020-08-28 24122, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1057 (master…fix-listen-time): Add dash after playing now and fix italic styling https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24156, 2020

      • iliekcomputers
        i see. :/

        • 2020-08-28 24105, 2020

      • shivam-kapila
        I can look again if you feel its unnecessary

        • 2020-08-28 24124, 2020

      • iliekcomputers
        no, given that we have the database in there now

        • 2020-08-28 24144, 2020

      • iliekcomputers
        i think we need a test that checks that the function is called with the timestamp value in the database also

        • 2020-08-28 24153, 2020

      • iliekcomputers
        the current test checks that after is zero

        • 2020-08-28 24112, 2020

      • shivam-kapila
        Yeah actually

        • 2020-08-28 24145, 2020

      • shivam-kapila
        Its because the latest_listened_at is none

        • 2020-08-28 24155, 2020

      • shivam-kapila
        That fallbacks to zero

        • 2020-08-28 24121, 2020

      • shivam-kapila
        I will add a test for other than zero

        • 2020-08-28 24122, 2020

      • iliekcomputers
        yeah. the fallback case is fine

        • 2020-08-28 24129, 2020

      • iliekcomputers
        the other case needs a test

        • 2020-08-28 24147, 2020

      • shivam-kapila
        Ok will add that

        • 2020-08-28 24147, 2020

      • iliekcomputers
        left another comment on the PR

        • 2020-08-28 24111, 2020

      • iliekcomputers
        did you get a chance to start on the work product or LB-686 today?

        • 2020-08-28 24112, 2020

      • BrainzBot
        LB-686: Separate, obvious page for ways to scrobble and import listens https://tickets.metabrainz.org/browse/LB-686

        • 2020-08-28 24114, 2020

      • shivam-kapila
        Work product... Yes

        • 2020-08-28 24134, 2020

      • iliekcomputers
        would appreciate a link so that i can take a quick read

        • 2020-08-28 24150, 2020

      • shivam-kapila
        I am not at home currently 😅

        • 2020-08-28 24110, 2020

      • iliekcomputers
        ok

        • 2020-08-28 24120, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1061 (master…make-release-fields-in-model-optional): Make release msid and release name field optional in the pydantic model https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24153, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1058 (master…smoothen-animation): Smoothen deletion animation https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24100, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #1060 (master…remove-unused-return): don't return playcounts_df which is not used later in the code https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24134, 2020

      • BrainzGit
        [listenbrainz-server] release v-2020-08-28.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-server…

        • 2020-08-28 24107, 2020

      • MajorLurker joined the channel

        • 2020-08-28 24101, 2020

      • MajorLurker has quit

        • 2020-08-28 24125, 2020

      • Gazooo79 has quit

        • 2020-08-28 24151, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 merged pull request #53 (master…fixes_before_2nd_release): Fixes before 2nd release https://github.com/metabrainz/musicbrainz-android…

        • 2020-08-28 24146, 2020

      • reosarevok
        yvanzo: would you want to review https://github.com/metabrainz/musicbrainz-server/… or would you rather just skip it? If you want to review several big commits can basically be ignored because they're super trivial fwiw

        • 2020-08-28 24137, 2020

      • dolina has quit

        • 2020-08-28 24120, 2020

      • MajorLurker joined the channel

        • 2020-08-28 24144, 2020

      • MajorLurker has quit

        • 2020-08-28 24154, 2020

      • iconoclasthero has quit

        • 2020-08-28 24100, 2020

      • d4rkie joined the channel

        • 2020-08-28 24108, 2020

      • Nyanko-sensei has quit

        • 2020-08-28 24156, 2020

      • dseomn1 is now known as dseomn

        • 2020-08-28 24144, 2020

      • rdswift has quit

        • 2020-08-28 24154, 2020

      • rdswift joined the channel

        • 2020-08-28 24111, 2020

      • d4rkie has quit

        • 2020-08-28 24103, 2020

      • Nyanko-sensei joined the channel

        • 2020-08-28 24108, 2020

      • MajorLurker joined the channel