0:25 AM
supersandro2000 has quit
2020-09-09 25357, 2020
0:25 AM
supersandro2000 joined the channel
2020-09-09 25359, 2020
1:06 AM
supersandro2000 has quit
2020-09-09 25315, 2020
2:26 AM
supersandro2000 joined the channel
2020-09-09 25330, 2020
3:01 AM
SomalRudra
Congrtulations people 🎊
2020-09-09 25321, 2020
3:24 AM
sumedh joined the channel
2020-09-09 25348, 2020
3:24 AM
nelgin
yvanzo how can I tell where the live index is in the replicated files? It's not stoppped for a couple of days.
2020-09-09 25311, 2020
3:27 AM
nelgin
and it seems to be consuming a lot of disk space.
2020-09-09 25353, 2020
4:08 AM
sumedh has quit
2020-09-09 25320, 2020
4:09 AM
sumedh joined the channel
2020-09-09 25346, 2020
4:43 AM
diru1100
Morning !! 🔥🔥
2020-09-09 25357, 2020
4:43 AM
shivam-kapila
morning
2020-09-09 25357, 2020
5:54 AM
reosarevok
I'm confused
2020-09-09 25308, 2020
5:55 AM
reosarevok
2020-09-09 25322, 2020
5:55 AM
reosarevok
That should have a "home-favicon" class...
2020-09-09 25357, 2020
5:55 AM
reosarevok
Will check later
2020-09-09 25339, 2020
6:24 AM
MusicbrainzB0T joined the channel
2020-09-09 25324, 2020
6:25 AM
MusicbrainzB0T2 joined the channel
2020-09-09 25325, 2020
6:25 AM
MusicbrainzB0T3 joined the channel
2020-09-09 25355, 2020
6:25 AM
MusicbrainzB0T1 has quit
2020-09-09 25326, 2020
6:26 AM
MusicbrainzB0T has quit
2020-09-09 25342, 2020
6:26 AM
MusicbrainzB0T3 has quit
2020-09-09 25311, 2020
6:58 AM
gr0uch0mars joined the channel
2020-09-09 25317, 2020
7:32 AM
nelgin
yvanzo ?
2020-09-09 25301, 2020
7:33 AM
v6lur joined the channel
2020-09-09 25342, 2020
8:02 AM
yvanzo
hi nelgin, you can check the queue size in rabbitmq to monitor live indexing
2020-09-09 25353, 2020
8:02 AM
BrainzGit
2020-09-09 25354, 2020
8:02 AM
BrainzBot
2020-09-09 25338, 2020
8:05 AM
yvanzo
either publish the port 15672 (if your machine has a decent firewall) and use your browser, or use rabbitmqadmin command line.
2020-09-09 25342, 2020
8:06 AM
reosarevok
yvanzo: looking into MBS-11085 and hoping we don't need a second hotfix :p
2020-09-09 25343, 2020
8:06 AM
BrainzBot
2020-09-09 25323, 2020
8:09 AM
yvanzo
nelgin: sudo docker-compose exec mq rabbitmqadmin -u sir -p sir -V /search-index-rebuilder list queues
2020-09-09 25324, 2020
8:15 AM
reosarevok
yvanzo: we probably do need a second hotfix :/
2020-09-09 25301, 2020
8:21 AM
yvanzo
shhh, we saved a lot of bandwidth, that's the most important :D
2020-09-09 25354, 2020
8:21 AM
BrainzGit
2020-09-09 25356, 2020
8:21 AM
BrainzBot
2020-09-09 25316, 2020
8:22 AM
reosarevok
True! :D
2020-09-09 25324, 2020
8:22 AM
reosarevok
yvanzo, bitmap ^
2020-09-09 25348, 2020
8:22 AM
reosarevok
Tested locally, works fine, so I wouldn't even wait for bitmap if he's not around. yvanzo, if it works for you let's hotfix? :)
2020-09-09 25349, 2020
8:23 AM
reosarevok checks other recent reports in case we broke some other thing
2020-09-09 25356, 2020
8:23 AM
nelgin
yvanzo
2020-09-09 25356, 2020
8:23 AM
nelgin
| search.delete | 0 |
2020-09-09 25356, 2020
8:23 AM
nelgin
| search.failed | 152 |
2020-09-09 25356, 2020
8:23 AM
nelgin
| search.index | 230987 |
2020-09-09 25356, 2020
8:23 AM
nelgin
| search.retry | 0 |
2020-09-09 25357, 2020
8:23 AM
nelgin
+---------------+----------+
2020-09-09 25333, 2020
8:27 AM
nelgin
Getting tons of scroll for the live index log, but none of the numbers seem to be moving.
2020-09-09 25334, 2020
8:34 AM
reosarevok
yvanzo: added another (much more minor, but still) regression fix to that PR
2020-09-09 25343, 2020
8:36 AM
nelgin
| search.index | 230984 |
2020-09-09 25348, 2020
8:36 AM
nelgin
ok, seems to be going down, slowly.
2020-09-09 25309, 2020
8:37 AM
yvanzo
how often do you replicate the database?
2020-09-09 25326, 2020
8:37 AM
yvanzo
(the default is one time per day)
2020-09-09 25357, 2020
8:37 AM
yvanzo
reosarevok: reviewing it
2020-09-09 25301, 2020
8:38 AM
reosarevok
Thanks
2020-09-09 25323, 2020
8:42 AM
ruaok
moooooin!
2020-09-09 25320, 2020
8:55 AM
reosarevok
yvanzo: if it seems fine I can deal with the releasing, hopefully won't get stuck with anything :D
2020-09-09 25331, 2020
8:57 AM
Mr_Monkey
Moin moin
2020-09-09 25302, 2020
9:05 AM
Gazooo794 has quit
2020-09-09 25308, 2020
9:07 AM
Gazooo794 joined the channel
2020-09-09 25358, 2020
9:07 AM
gr0uch0mars has quit
2020-09-09 25314, 2020
9:13 AM
alastairp
2020-09-09 25336, 2020
9:14 AM
ruaok
interesting. thanks for sharing.
2020-09-09 25355, 2020
9:16 AM
alastairp
sounds like it was a combination of 1) estimates for 4 months while everyone was living at home, 2) everyone using more than 6m^3 of water, after which prices triple, and 3) this new tax for recycling, which they decided to tie to water consumption
2020-09-09 25322, 2020
9:23 AM
sumedh has quit
2020-09-09 25304, 2020
9:24 AM
yvanzo
reosarevok: cherry-pick'n'deploy but don't tag it yet, I feel like more patches may go through today ^^
2020-09-09 25347, 2020
9:27 AM
sumedh joined the channel
2020-09-09 25311, 2020
9:28 AM
reosarevok
yvanzo: so, cherrypick onto prod, merge prod into beta, merge beta into master?
2020-09-09 25338, 2020
9:28 AM
reosarevok
Or well, I guess I can merge into master first then cherrypick, but do you have any preference re: cherrypicking twice vs merging prod into beta :)
2020-09-09 25350, 2020
9:32 AM
yvanzo
reosarevok: merge to master, merge to beta, merge to prod, merge to master
2020-09-09 25308, 2020
9:33 AM
yvanzo
actually there is no other commit on master, so merge is fine
2020-09-09 25340, 2020
9:33 AM
BrainzGit
2020-09-09 25342, 2020
9:33 AM
BrainzBot
2020-09-09 25342, 2020
9:33 AM
BrainzBot
2020-09-09 25309, 2020
9:34 AM
yvanzo
cherry-picking a merge commit is not possible (or you need to specify parent), whereas merge is fine her.
2020-09-09 25351, 2020
9:34 AM
yvanzo
and maybe merging back to master is not needed until we tag production branch.
2020-09-09 25317, 2020
9:35 AM
reosarevok
Ok
2020-09-09 25336, 2020
9:35 AM
reosarevok
So, merge master into beta, release beta, merge beta into prod, release prod, stop for now
2020-09-09 25346, 2020
9:35 AM
yvanzo
+1
2020-09-09 25342, 2020
9:37 AM
nelgin
yvanzo corryect, once per day.
2020-09-09 25300, 2020
9:38 AM
reosarevok
yvanzo, bitmap: also, should we be updating jenkins?
2020-09-09 25305, 2020
9:38 AM
nelgin
| search.index | 229996 |
2020-09-09 25308, 2020
9:38 AM
nelgin
It's slowly going down.
2020-09-09 25315, 2020
9:39 AM
nelgin
Took about an hour and 10 minutes to do 991.
2020-09-09 25359, 2020
9:41 AM
reosarevok
Ouch
2020-09-09 25302, 2020
9:44 AM
BestSteve has quit
2020-09-09 25352, 2020
9:45 AM
BestSteve joined the channel
2020-09-09 25335, 2020
9:47 AM
reosarevok
releasing beta
2020-09-09 25301, 2020
9:59 AM
zas
2020-09-09 25327, 2020
9:59 AM
reosarevok
zas: if they used lodash, then that
2020-09-09 25339, 2020
9:59 AM
reosarevok
That's what happened to loujine's ones, anyway
2020-09-09 25308, 2020
10:02 AM
pristine___
ishaanshah: you about?
2020-09-09 25338, 2020
10:02 AM
ishaanshah
pristine___: Hi
2020-09-09 25329, 2020
10:04 AM
pristine___
2020-09-09 25312, 2020
10:05 AM
pristine___
Is there a reason to have 10 as min??
2020-09-09 25327, 2020
10:05 AM
reosarevok
releasing prod
2020-09-09 25351, 2020
10:05 AM
ishaanshah
I dont think so, but we are going to change the cron tab soon
2020-09-09 25306, 2020
10:06 AM
ishaanshah
2020-09-09 25311, 2020
10:06 AM
ishaanshah
Refer to this one
2020-09-09 25332, 2020
10:08 AM
sumedh has quit
2020-09-09 25319, 2020
10:24 AM
sumedh joined the channel
2020-09-09 25327, 2020
10:40 AM
BrainzGit
2020-09-09 25317, 2020
10:42 AM
ishaanshah
iliekcomputers: ping
2020-09-09 25336, 2020
10:42 AM
ruaok
pristine___: your crontab is not future proof.
2020-09-09 25355, 2020
10:42 AM
iliekcomputers
let's not create a new crontab for this
2020-09-09 25357, 2020
10:42 AM
ruaok
those 4 steps, should they always be executed sequentially?
2020-09-09 25321, 2020
10:43 AM
pristine___
ruaok: meaning? Yup.
2020-09-09 25341, 2020
10:43 AM
ruaok
if so, it would be better to add one script that executes the four commands that is invoked by cron.
2020-09-09 25359, 2020
10:43 AM
ruaok
otherwise if one step runs longer, then it may not finish before the next step kicks off.
2020-09-09 25332, 2020
10:44 AM
iliekcomputers
because this is just sending over requests to the consumer in a queue, it should be ok
2020-09-09 25335, 2020
10:44 AM
ruaok
and then what iliekcomputers said: no need for a separate crontab -- just add the invocation of the new script to the existing crontab
2020-09-09 25310, 2020
10:45 AM
ruaok
iliekcomputers: agreed, but it makes me wig out. it feels very wrong.
2020-09-09 25315, 2020
10:46 AM
reosarevok
yvanzo, bitmap: hotfixes out, all done AFAICT
2020-09-09 25343, 2020
10:46 AM
iliekcomputers
ishaanshah: pong
2020-09-09 25359, 2020
10:46 AM
ishaanshah
iliekcomputers: Hi
2020-09-09 25312, 2020
10:47 AM
ishaanshah
I was working on showing listen count on artist map
2020-09-09 25347, 2020
10:47 AM
iliekcomputers
ooh awesome!
2020-09-09 25355, 2020
10:47 AM
ishaanshah
So, basically it's just adding another listen count field
2020-09-09 25301, 2020
10:48 AM
iliekcomputers
right
2020-09-09 25307, 2020
10:48 AM
ishaanshah
However we cache our result right
2020-09-09 25323, 2020
10:48 AM
iliekcomputers
mhmm
2020-09-09 25327, 2020
10:48 AM
ishaanshah
so it might take time for users' data to update
2020-09-09 25338, 2020
10:48 AM
ishaanshah
which might lead to bugs on frontend
2020-09-09 25303, 2020
10:50 AM
ishaanshah
One possible way is to add a dirty bit style column to DB which is set to 1 for all users
2020-09-09 25322, 2020
10:50 AM
ishaanshah
and changes to 0 as data is recalculated
2020-09-09 25343, 2020
10:50 AM
ishaanshah
or, wait for a week after deploying and then deploy the frontend
2020-09-09 25303, 2020
10:52 AM
iliekcomputers
i'm not sure i understand
2020-09-09 25316, 2020
10:52 AM
iliekcomputers
how are you calculating the listen count?
2020-09-09 25319, 2020
10:52 AM
yvanzo
reosarevok: thanks!
2020-09-09 25333, 2020
10:52 AM
iliekcomputers
from the top artists?
2020-09-09 25337, 2020
10:52 AM
ishaanshah
yep
2020-09-09 25303, 2020
10:53 AM
ishaanshah
add listen count for individual artists
2020-09-09 25346, 2020
10:53 AM
iliekcomputers
right.
2020-09-09 25305, 2020
10:54 AM
iliekcomputers
i'm ok with it taking time for the user's data to update tbh
2020-09-09 25335, 2020
10:54 AM
iliekcomputers
it'll be done by next week right? i don't think we need to do extra engineering work to update everything immediately
2020-09-09 25353, 2020
10:54 AM
iliekcomputers
just make the frontend backwards compatible, so that it works without listen counts as well
2020-09-09 25320, 2020
10:55 AM
ishaanshah
yep, it will get updated in a week from when it is deployed
2020-09-09 25346, 2020
10:55 AM
ishaanshah
cool, cool will do
2020-09-09 25354, 2020
10:55 AM
iliekcomputers
awesome, thanks!
2020-09-09 25303, 2020
10:56 AM
iliekcomputers
the full dump didn't fail this time
2020-09-09 25311, 2020
10:56 AM
ishaanshah
yep, stats updated
2020-09-09 25325, 2020
10:56 AM
iliekcomputers
i'm gonna try to merge and test your incremental dumps PR today
2020-09-09 25317, 2020
10:57 AM
ishaanshah
Cool cool sounds good, I have some free time today, I will try to get the frontend done
2020-09-09 25323, 2020
10:57 AM
iliekcomputers
nice
2020-09-09 25346, 2020
10:57 AM
iliekcomputers
ping me if you need to chat about things we could work on in the future
2020-09-09 25300, 2020
11:02 AM
iliekcomputers
ishaanshah: i was thinking
2020-09-09 25319, 2020
11:02 AM
iliekcomputers
while you're looking at this, is there any way we could show the names of the artists as well?
2020-09-09 25325, 2020
11:03 AM
ishaanshah
Yep, we could do it, basically have a custom tooltip which shows the top 5 artists maybe
2020-09-09 25349, 2020
11:03 AM
ishaanshah
I thought it would be better to do it in a different PR though
2020-09-09 25356, 2020
11:05 AM
iliekcomputers
yeah, not in this one, but we should keep it in mind
2020-09-09 25300, 2020
11:06 AM
iliekcomputers
i was thinking this
