keep a list right next to the map (empty initially)
2020-09-09 25328, 2020
iliekcomputers
when the user clicks on a country, the list populates with artists from that country
2020-09-09 25335, 2020
ishaanshah
Hmm, I am a bit inclined towards the tooltip solution, mainly because people are mostly interested in the top 10 at max and I think adding a list on the map would make it a bit cluttered
2020-09-09 25352, 2020
ishaanshah
mainly on mobile
2020-09-09 25312, 2020
shivam-kapila
ishaanshah: move the list below map on mobile
2020-09-09 25300, 2020
ishaanshah
iliekcomputers: do you mean something like the top artist card we have or on the map itself?
2020-09-09 25346, 2020
iliekcomputers
not on the map, it'd be hard to do i guess, a seperate list but in the artist origin card
2020-09-09 25350, 2020
ishaanshah
Hmm, I am not sure how it would work out at the moment, but I'll try that once when I implement it
2020-09-09 25315, 2020
iliekcomputers
so what I am imagining is this
2020-09-09 25324, 2020
iliekcomputers
the artist origin card is a React component right?
2020-09-09 25333, 2020
ishaanshah
yes
2020-09-09 25358, 2020
iliekcomputers
add artistNamesToList to the state
2020-09-09 25317, 2020
iliekcomputers
create a function that sets it, pass it as callback to the onclick function on the choropleth
2020-09-09 25341, 2020
iliekcomputers
then display artistNamesToList from the state after the map
2020-09-09 25324, 2020
iliekcomputers
admittedly, i don't remember the exact details of the code, but the basic idea would be this i guess
2020-09-09 25356, 2020
ishaanshah
Yep yep, technically its definitely possible, I was talking about the space constraints and overall look
2020-09-09 25306, 2020
iliekcomputers
ah ok.
2020-09-09 25314, 2020
iliekcomputers
i think there's enough space on desktop
2020-09-09 25334, 2020
iliekcomputers
for phone, it'd probably go below the map (or just not be there)
2020-09-09 25348, 2020
ishaanshah
yep something like that mostly
2020-09-09 25305, 2020
ishaanshah
I'll experiment with it when we add that
2020-09-09 25319, 2020
iliekcomputers
👍🏽
2020-09-09 25322, 2020
ishaanshah
it's definitely an interesting stat
2020-09-09 25340, 2020
ishaanshah
Like right now I dont know which artist from DEU I am listening to
2020-09-09 25352, 2020
iliekcomputers
exactly!
2020-09-09 25323, 2020
iliekcomputers
once we have the list on the side of it, we can also look at adding links to MusicBrainz for artists that we couldn't get countries for
2020-09-09 25307, 2020
ishaanshah
ooh, thats a plus too
2020-09-09 25335, 2020
ishaanshah
like by default it shows the one's havent been mmatched
2020-09-09 25300, 2020
iliekcomputers
yep!
2020-09-09 25337, 2020
ishaanshah
and if I click on a region with 0 artists, we could run ruaok troi algorithm to recommend some new artists
2020-09-09 25301, 2020
iliekcomputers
🤩
2020-09-09 25313, 2020
iliekcomputers
that sounds amazing tbh
2020-09-09 25342, 2020
ishaanshah goes to creates lots of tickets...
2020-09-09 25321, 2020
ruaok
:D
2020-09-09 25346, 2020
iliekcomputers
ishaanshah: the listening activity graph dates are off again :)
Tests, right. I have to write tests for 1042. Thanks :p
2020-09-09 25314, 2020
pristine___
ruaok: can you remind me the order? First merge #1042 and then post on community or the other way round? I forgot what you said that day during discussion
2020-09-09 25302, 2020
ruaok
post a placeholder on community, merge, update placeholder.
2020-09-09 25310, 2020
ruaok
but I am not married to that concept.
2020-09-09 25327, 2020
pristine___
So how should this be done according to you ruaok? Imo, we shouldn't include the *take a look here* line in the rec info. Merge it. Post on community and then update the rec info with the link. Placeholder is a bit off for me.
2020-09-09 25356, 2020
ruaok
sure, that works.
2020-09-09 25306, 2020
ruaok
"we'll update this post with a link shortly"
2020-09-09 25316, 2020
ruaok
this one time we can let a promise like this slide. :)
2020-09-09 25355, 2020
pristine___
Yes. And it will take atmost a day to get the link given we edit and finalize the post before merging the PR. Then it's just a click away.
2020-09-09 25318, 2020
ruaok
lets see if we can shorten that to a few hours.
2020-09-09 25300, 2020
_lucifer
iliekcomputers: available to chat on the profiling thing
2020-09-09 25322, 2020
pristine___
Doable.
2020-09-09 25322, 2020
iliekcomputers
_lucifer: great, today an hour before normal meeting time?
I don't know if that's the flask testing framework that we use
2020-09-09 25334, 2020
diru1100
alastairp: Hey, I am trying to understand CB better by going through the tickets, articles written, previous gsoc project and it's use cases in other brainzes.
2020-09-09 25309, 2020
diru1100
Also as CB uses full instance of MB, i dont think my machine is enough to handle that 😅
2020-09-09 25324, 2020
diru1100
MBP with 8 gb ram
2020-09-09 25332, 2020
diru1100
other is ubuntu with 8 gb ram
2020-09-09 25306, 2020
ruaok
for testing purposes you can install a smaller version of the DB
2020-09-09 25309, 2020
diru1100
is it easy to make a test instance fix for CB as wel ?
2020-09-09 25321, 2020
ruaok
might help, but a newer laptop would be better.
2020-09-09 25347, 2020
nelgin
yvanzo, are you SURE this should be taking so long?
2020-09-09 25347, 2020
nelgin
| search.index | 220184 |
2020-09-09 25347, 2020
nelgin
9812 in 6 hours.
2020-09-09 25322, 2020
alastairp
diru1100: what do you mean test instance fix?
2020-09-09 25328, 2020
diru1100
yup, planning for an upgrade, but still i wanna make some progress with CB for now and explore it more. Will try with samller version
2020-09-09 25349, 2020
diru1100
i mean MB has a dev version without index searching iirc
2020-09-09 25317, 2020
pristine___
alastairp: shivam-kapila thanks <3
2020-09-09 25357, 2020
thomasross joined the channel
2020-09-09 25328, 2020
alastairp
with the instructions in CB you can install the small sample database, and you need nothing else from musicbrainz. no webserver, no search
2020-09-09 25342, 2020
alastairp
_lucifer did this a few days ago
2020-09-09 25353, 2020
diru1100
cool, will do that :)
2020-09-09 25308, 2020
diru1100
any other specific areas do you suggest to focus on ?
2020-09-09 25324, 2020
thomasross has quit
2020-09-09 25349, 2020
thomasross joined the channel
2020-09-09 25308, 2020
diru1100
i will try testing the application more and understand the workflow for now.
2020-09-09 25313, 2020
alastairp
in terms of things to fix?
2020-09-09 25316, 2020
diru1100
yea
2020-09-09 25328, 2020
diru1100
and also to get better understanding of CB
2020-09-09 25339, 2020
alastairp
as I mentioned to _lucifer, look at the most recent opened tickets that I created. the majority of those are bugs that I found when trying to set up CB
2020-09-09 25300, 2020
alastairp
I don't know it very well either, so perhaps you should just have a click around and see if you understand it, and look at the tickets
2020-09-09 25301, 2020
diru1100
alright got it.
2020-09-09 25331, 2020
diru1100
I am just documenting everything i understand for next week meeting
