I can hardly understand how that would be an improvement though, just changing the column label woudn't do?
2020-09-09 25316, 2020
reosarevok
Because the writers column wasn't meant to be a list of all relationships to a work, it was supposed to be for writer-related rels
2020-09-09 25324, 2020
reosarevok
It's not that bad in here (although still distracting)
2020-09-09 25300, 2020
yvanzo
But at that time, there was no interest/effort put in dedication and all, maybe now it's different?
2020-09-09 25330, 2020
reosarevok
But it's super weird in an inline search, where while searching for, say, Tavener's Eternal Memory you'll get "John Tavener, Australian Chamber Orchestra, Steven Isserlis"
2020-09-09 25333, 2020
reosarevok
eh.
2020-09-09 25336, 2020
yvanzo
Returning less results doesn't look like an improvement to me.
2020-09-09 25343, 2020
reosarevok
"Writers: John Tavener, Australian Chamber Orchestra, Steven Isserlis"
2020-09-09 25355, 2020
yvanzo
That is a presentation issue.
2020-09-09 25307, 2020
reosarevok
At that time we didn't realize we would have artist-work relationships that are not writers
2020-09-09 25321, 2020
reosarevok
... yes? All of this is about presentation. To be precised, this stuff shouldn't be presented there
2020-09-09 25325, 2020
reosarevok
*precise
2020-09-09 25351, 2020
reosarevok
I mean, we could instead rename that column and the inline search to "artists related to the work" rather than "writers"
2020-09-09 25352, 2020
yvanzo
but changing search results isn't just changing presentation
2020-09-09 25321, 2020
reosarevok
Well, given the search is "artists" and not "writers", maybe that can be kept, they just wouldn't appear under writers nor artists because they're neither
2020-09-09 25342, 2020
bitmap
I'm not sure where/if we should show the non-writers but removing them from the writers columns makes sense to me
2020-09-09 25301, 2020
bitmap
we do already have an "artists" column though which it may be confused with
2020-09-09 25340, 2020
yvanzo
"composition & misc"?
2020-09-09 25333, 2020
yvanzo
getting search results without the relationship to the queried artist would be weird
2020-09-09 25329, 2020
reosarevok
I expect most classical editors (the case where these other rels are most common) don't want the writers column full of irrelevant stuff
2020-09-09 25334, 2020
yvanzo
column "artists" can be renamed "recording artists"
2020-09-09 25337, 2020
reosarevok
Renaming the column doesn't help with the usability issue
2020-09-09 25351, 2020
reosarevok
The inline search issue is especially bad
2020-09-09 25315, 2020
reosarevok
I need to be able to see at a glance that this is by Tavener, not try to guess it from a bunch of crap
2020-09-09 25344, 2020
bitmap
right, it's a bigger issue there
2020-09-09 25346, 2020
yvanzo
there is nothing about "the inline search issue" in the ticket
2020-09-09 25346, 2020
reosarevok
I would personally rather drop these reltypes than keep them there tbh, and I added them because I wanted them in the first place. But not at that price
2020-09-09 25314, 2020
reosarevok
It's the same issue, only there's not even info about what kind of role each writer had
2020-09-09 25349, 2020
reosarevok
And that there it was always meant to tell the composers and whatnot at a glance - all the other info is completely irrelevant there
2020-09-09 25307, 2020
reosarevok
I can't think of a single case where you're looking in the inline search for a work dedicated to X
2020-09-09 25325, 2020
bitmap
we have limited space there anyway so I would def. remove the non-writers there
2020-09-09 25352, 2020
bitmap
should we add another column for the non-writing rels to the search results?
2020-09-09 25326, 2020
yvanzo
this seems to be specific to the inline search
2020-09-09 25339, 2020
reosarevok
No, this is most important in the inline search
2020-09-09 25354, 2020
reosarevok
But the expectation of our editors is that they'll find writers in there
2020-09-09 25301, 2020
reosarevok
If you want we can have a misc column, yes
2020-09-09 25316, 2020
reosarevok
Eh. " in there" -> in the writers column
2020-09-09 25340, 2020
yvanzo
it's already confusing to have "writers" and "artists" to be honest
2020-09-09 25345, 2020
reosarevok
I guess that would fit fine, so if you want a third column with "misc. relationships"... :)
2020-09-09 25308, 2020
reosarevok
I mean, it's cool info, if it doesn't get in the way
2020-09-09 25313, 2020
bitmap
we could put them in the existing artists column with small performers/misc. headings?
2020-09-09 25318, 2020
bitmap
dunno
2020-09-09 25347, 2020
reosarevok
The existing artists column is already sometimes absurdly big (did we already merge the code collapsing it in those cases? I think we did)
2020-09-09 25305, 2020
bitmap
not sure if we did
2020-09-09 25304, 2020
yvanzo
reosarevok: I mean the solution is specific to the inline search: it seems legit to drop these dedications from the inline search if the rel type can't be displayed, but not from the work search page where it can be displayed.
2020-09-09 25314, 2020
bitmap
slapping on a "Misc. Relationships" column is fine with me for now too, as long as we're all happy with it
2020-09-09 25326, 2020
reosarevok
yvanzo: they're not writing-related. They shouldn't be under writers
