also yvanzo, EPs are exported in a dump as well right?
2020-09-12 25610, 2020
_lucifer
i am trying to track down a bug in CB where all release groups are shown but EPs are missing
2020-09-12 25646, 2020
yokel joined the channel
2020-09-12 25649, 2020
yvanzo
_lucifer: yup, it's included in sample dump
2020-09-12 25640, 2020
_lucifer
👍
2020-09-12 25616, 2020
yokel has quit
2020-09-12 25621, 2020
shivam-kapila
pristine___: excited for the recs
2020-09-12 25651, 2020
yokel joined the channel
2020-09-12 25647, 2020
snazz
Do we actually import listens from Spotify (as in past listening history) or do we only use Spotify's "scrobbling" functionality?
2020-09-12 25608, 2020
snazz
From what I've seen its only the later, but I may be incorrect...
2020-09-12 25634, 2020
ishaanshah
snazz: Yep spotify only allows the past 50 listens for an user
2020-09-12 25647, 2020
ishaanshah
So we cant import the whole history
2020-09-12 25653, 2020
shivam-kapila
Actually theres a workaround
2020-09-12 25600, 2020
shivam-kapila
But havent got to that
2020-09-12 25616, 2020
snazz
That's actually a good thing, it makes it much easier to word on the website what we are doing with Spotify
2020-09-12 25623, 2020
pristine___
shivam-kapila: react tests remaining. Scary 😱
2020-09-12 25627, 2020
shivam-kapila
The way we optimised spotify imports that can be used to import whole history
2020-09-12 25646, 2020
shivam-kapila
pristine___: jest is easier than react
2020-09-12 25600, 2020
shivam-kapila
pristine___: jest is easier than react
2020-09-12 25620, 2020
pristine___
Phew!
2020-09-12 25655, 2020
yokel has quit
2020-09-12 25642, 2020
yokel joined the channel
2020-09-12 25645, 2020
snazz has quit
2020-09-12 25633, 2020
yokel has quit
2020-09-12 25633, 2020
MightyJay has quit
2020-09-12 25643, 2020
MightyJay joined the channel
2020-09-12 25626, 2020
yokel joined the channel
2020-09-12 25607, 2020
ishaanshah
iliekcomputers: #1082 is ready for review
2020-09-12 25641, 2020
ishaanshah
I'll open a separate PR for frontend so that we can deploy it a week after this PR has been deployed
2020-09-12 25639, 2020
mckean has quit
2020-09-12 25631, 2020
snazz joined the channel
2020-09-12 25656, 2020
yokel has quit
2020-09-12 25616, 2020
snazz
lmao
2020-09-12 25632, 2020
snazz
I forgot that pytest made my laptop feel like it was taking off
2020-09-12 25602, 2020
shivam-kapila
any rust dev here
2020-09-12 25614, 2020
snazz
poor thinkpad is about to burn a hole in my lap
2020-09-12 25625, 2020
BrainzGit
[listenbrainz-server] tomnieuwland opened pull request #1086 (master…LB-686-user-information-cleanup): LB-686 Cleaned up a variety of user information pages https://github.com/metabrainz/listenbrainz-server…
No worries. I went a little outside the scope of the original ticket, because I noticed a lot of information was either seemingly in the wrong spot on the website, or was being repeated elsewhere...
2020-09-12 25609, 2020
snazz
I'm sure it will make sense with the PR... I hope!
2020-09-12 25644, 2020
shivam-kapila
iliekcomputers: doesnt add to whitelist work for brainzbot now
shivam-kapila: line 11, i am assigning a value to here, so ideally there shouldn't be any prob but it say `Type 'Listen[] | undefined' is not assignable to type 'Listen[]'`
2020-09-12 25656, 2020
pristine___
i understand why there should be a check in if else, but why a check when we are assigning value to something.
