#metabrainz

And after that I do sudo docker-compose restart musicbrainz ?

reosarevok: Not sure which file you edited?

DBDefs.pm I mean

in the container?

or in build/musicbrainz-dev/ or build/musicbrainz/ ?

No, locally. But I guess I should edit it in the container, from that question

you mean in your local git working tree?

Ye

*Yes

I’m not sure restarting the container is even required but it should do no harm.

Oops, no, it will reset it :P

Ok

Will check again

Modify /DBDefs.pm in the container instead.

So far, it all seems to be ignored and it still uses the sample DB

In the container as in, after docker-compose exec musicbrainz bash ?

/musicbrainz-server/lib/DBDefs.pm is replaced with /DBDefs.pm on container startup.

yes

You can try something as: cat /musicbrainz-server/lib/DBDefs.pm > /DBDefs.pm

Ok, so if I have ssh -L 172.17.0.1:65401:localhost:65401 pink -N

Then I should have host => "127.17.0.1", port => "65401" inside the container?

Or is the host different inside there?

?

No, just copy the PROD_STANDBY :)

You can find the original values in build/musicbrainz-dev/DBDefs.pm (in musicbrainz-docker)

s/127/172/ probably

nelgin: interesting

ooh, LB crossed 11k users today

fun

congrats

yvanzo: duh, typo, thanks

yvanzo: ok, changed this:

(so, more or less what I used to do locally to get what I wanted)

But it's still using the old DB. Do I need to tell it something so that it will re-check this and change DBs?

not sure, RT_SLAVE maybe?

Restarting the container should be fine if you modified /DBDefs.pm

You can also backup this file as follows: sudo docker cp musicbrainz-docker_musicbrainz_1:/DBDefs.pm /tmp/backup-DBDefs.pm

Restarting the container overwrote it again :)

So I guess that can't be the way to do this

With my usual plackup thing IIRC any changes to dbdefs would be understood and dealt with without any extra changes on my part

But this doesn't seem to do the same

Unless I'm changing something weird. I should still be changing lib/DBDefs.pm, just inside the container, right? There's no separate DBDefs this uses

the LB user growth chart would be interesting to see, i have a feeling the rate has increased since we shipped stats

reosarevok: are you changing /DBDefs.pm (at container's root /)?

No, the lib one, I didn't realize there was a second

13:21 < yvanzo> /musicbrainz-server/lib/DBDefs.pm is replaced with /DBDefs.pm on container startup.

Yeah

:)

I thought you meant my local one with the container one

Didn't notice this has a separate one in a place I didn't expect :D

Ok, let's change that :D

Oh sorry, I didn't imagine your local one was installed under /musicbrainz-server as well.

Well, it's under home, whatever, musicbrainz-server, but I didn't think that much :D

Aaanyway

Let's try again :)

Sorry I'm slow

this is what happens on container's startup: https://github.com/metabrainz/musicbrainz-docke...

whoo, I'm in pink

(that sounds like I'm wearing a princess dress... sadly I don't own any)

I'd pay good $$$ to see that!

sigh. which is it that they never sell pink pricess dresses for adult males??

No you wouldn't

You wouldn't wait 3 to 5 hours even for that

ok, fair, I'd order you one online

ruaok planning to order summit dresses instead of tees for reo?

Fuck it

shivam-kapila: yep. are you more of a pink sort of programmer or a light blue one??

Summit dresses for everyone

ruaok: light blue... blue is my fav

reosarevok: the only satidfied customer will be pristine___

customink doesn't sell mini dresses. that would've been perfect.

oh good. I found a supplier.

😈

reosarevok, get kilts

:)

https://www.scotlandshop.com/tartanblog/our-top... ... well

niiice!

That's my school's kindergarten dress 😮

lmao

ruaok: I think diru1100 also wantys one

thank you, next 😂

Also LB got 11k+ users, noice !!

I am tired of assignments

iliekcomputers: looking forward to read more blogs of yours!!

I don't have assignments, but tests started :/

lol what

you can always upgrade

btw by gamification in cb mean like a reward point system?

maybe badges?

like bb

yea

i am taking a poll from my friend circle what they wish they want in CB. And also about BB and CB integration

goodreads is famous among people who read a lot of books

I thought of having an upvote option instead of "was it useful" will make the user interface more

Also a thread kinda thing for each review to extend the discussion

reddit

yea...

list them in a doc... we will add

quora and reddit basically.

will do :)

then discuss with the team what to hack on

I think we should keep "was it useful" up/down but i think a reply fucntion might be interesting

ishaanshah: shivam-kapila can you please review #1042. I really need a lot of react tips

And shivam-kapila thank you so much for helping me all along the way :)

19 files changed. :(

pristine___: most welcome

ruaok: only two python files.

But all of this should be done in one PR :(

something is odd about this PR. how come it adds a view for delete_listen?

Link?

why does CB have a like option as well as a was it useful thing?

like option looks like its linked with fb but i dont think it is

pristine___: that's quite a of tests you've written for these features. which is great in general. but....

isn't this basically for a feature for a limited time?

I'm just wondering about spending so much time on tests for a feature that might go away in a few weeks.

Yes. But it should work well in that limited time.

Hmm.

oh, for sure.

few things are going to get past those tests!

Hmmm.

you see my point?

Yeah, I understand.

Will keep this in mind.

ruaok: so should I remove a few tests?

no, not at all.