> Plus we dont use api rather simple endpoints for recs page
2020-09-21 26544, 2020
pristine___
We use db.
2020-09-21 26547, 2020
shivam-kapila
pristine___: nvm i am just stupid
2020-09-21 26559, 2020
pristine___
I don't think so
2020-09-21 26529, 2020
pristine___
shivam-kapila: it's a bug, two such events in Sentry :(
2020-09-21 26539, 2020
shivam-kapila
I caught this one two
2020-09-21 26543, 2020
shivam-kapila
too*
2020-09-21 26504, 2020
pristine___
What do you think shivam-kapila ?
2020-09-21 26523, 2020
pristine___
I checked props just now, current user was define for me
2020-09-21 26505, 2020
iliekcomputers
if you're not logged in
2020-09-21 26510, 2020
iliekcomputers
current_user will not be defined
2020-09-21 26545, 2020
shivam-kapila
exactly
2020-09-21 26523, 2020
pristine___
shivam-kapila: I should add the login_required condition I think.
2020-09-21 26541, 2020
shivam-kapila
not needed IG
2020-09-21 26549, 2020
BrainzGit
[listenbrainz-server] shivam-kapila opened pull request #1102 (master…fix-anonymous-user-mixin-error): Fix anonymous user mixin error that occurs if user isn't logged in https://github.com/metabrainz/listenbrainz-server…
MBS-11094: Edit error message appears (and prevents update) unrelated to current edits
2020-09-21 26541, 2020
reosarevok
We generally skip the error setting by making the user click a checkbox like "this is fine" but in this case it will never be fine
2020-09-21 26504, 2020
reosarevok
But we also don't want to force the user to change it if it's already there and they only wanted to fix something else
2020-09-21 26534, 2020
reosarevok
Should I split this into a warning + the error message, even if there's no specific checkbox? So that the error is shown only when adding but the warning is shown always?
I personally think the display of that page shouldn't change if the user is logged in or not.
2020-09-21 26510, 2020
ruaok
so, I should be able to see the listens.
2020-09-21 26539, 2020
pristine___
ruoak: Okay. Nice. shivam-kapila isn't around, should I push changes to his PR so that we can make the process faster?
2020-09-21 26544, 2020
pristine___
I mean if it's not a bad practice to push changes to someone else's PR
2020-09-21 26503, 2020
ruaok
not if you're trying to get a release done.
2020-09-21 26507, 2020
ruaok
but that is my take
2020-09-21 26523, 2020
pristine___
ruaok: cool, I will wait for him then.
2020-09-21 26538, 2020
pristine___
Oh shit, I read something else.
2020-09-21 26539, 2020
pristine___
Lol
2020-09-21 26542, 2020
ruaok
heh.
2020-09-21 26546, 2020
shivam-kapila
I am here
2020-09-21 26504, 2020
pristine___
Phew!
2020-09-21 26537, 2020
shivam-kapila
What can I do
2020-09-21 26540, 2020
pristine___
shivam-kapila: does the comment on 1102 makes sense to you?
2020-09-21 26519, 2020
shivam-kapila
Havent seen it
2020-09-21 26522, 2020
shivam-kapila
A sec
2020-09-21 26542, 2020
shivam-kapila
couldnt run the code though
2020-09-21 26545, 2020
shivam-kapila
no recs
2020-09-21 26556, 2020
pristine___
shivam-kapila: didn't get you.
2020-09-21 26528, 2020
shivam-kapila
can you suggest that change
2020-09-21 26540, 2020
pristine___
See the comment
2020-09-21 26552, 2020
shivam-kapila
I mean comment as a suggestion
2020-09-21 26503, 2020
shivam-kapila
I can directly accept it then
2020-09-21 26506, 2020
pristine___
Ah!
2020-09-21 26510, 2020
pristine___
A sec
2020-09-21 26554, 2020
shivam-kapila
sorry for the trouble. Aint well
2020-09-21 26522, 2020
ruaok
maybe we should cancel today and all go back to bed.
2020-09-21 26537, 2020
pristine___
shivam-kapila: done!
2020-09-21 26541, 2020
reosarevok
s/today/2020?
2020-09-21 26555, 2020
ruaok
reosarevok: yeah, sounds even better.
2020-09-21 26515, 2020
ruaok
but, I do have one uplifting thought. Was if 2020 was the last good year the planet has left?
2020-09-21 26522, 2020
ruaok
s/was/what/
2020-09-21 26535, 2020
shivam-kapila
nooooo
2020-09-21 26547, 2020
ruaok
I do believe I do not have enough chocolate to contemplate this
2020-09-21 26502, 2020
pristine___
shivam-kapila: I hope you run on dev next time :p
2020-09-21 26508, 2020
pristine___
But thanks for the commit
2020-09-21 26545, 2020
shivam-kapila
I dont have recs on local setup actually
2020-09-21 26559, 2020
pristine___
Hmm.
2020-09-21 26505, 2020
shivam-kapila needs chocolate to fight the headache
2020-09-21 26516, 2020
pristine___
shivam-kapila: same pinch!
2020-09-21 26522, 2020
ruaok
ok, I go to the shop then.
2020-09-21 26541, 2020
pristine___
ruaok: cool, lemme know when you are back
2020-09-21 26505, 2020
pristine___
shivam-kapila: has pushed the changes
2020-09-21 26558, 2020
reosarevok
yvanzo: we have warning + error already for a lot of cases :)
2020-09-21 26508, 2020
BrainzGit
[listenbrainz-server] vansika merged pull request #1102 (master…fix-anonymous-user-mixin-error): Fix anonymous user mixin error that occurs if user isn't logged in https://github.com/metabrainz/listenbrainz-server…
2020-09-21 26528, 2020
pristine___
ruaok: all set! You can release now!
2020-09-21 26507, 2020
reosarevok
yvanzo: for example we have a warning if: hasVariousArtistTracks and inside that conditional an error if: hasUnconfirmedVariousArtists specifically
