MBS-11061: Don't allow MusicBrainz URLs in relationships
2020-09-23 26731, 2020
dseomn1 is now known as dseomn
2020-09-23 26740, 2020
dseomn
on second thought, I'm not sure it's really worth putting that much effort into this
2020-09-23 26732, 2020
dseomn
like, I think it's fun to do weird stuff with the database when I can claim artist intent (cataloger's intent?), but that doesn't mean y'all need to support that :)
2020-09-23 26739, 2020
reosarevok
I mean, it's trivial to add && (isNewLink || linkTypeChanged) to the check so that old links get grandfathered in, but I'm not sure it makes sense :p
2020-09-23 26718, 2020
reosarevok
Of course, the current error message doesn't make a lot of sense unless you yourself just entered the link :)
2020-09-23 26755, 2020
dseomn goes back to doing something potentially unwise with speaker wire
Yeah, seems great! depending on how much time it takes to fix all these, I say we add the recordings as well. What do you think?
2020-09-23 26713, 2020
_lucifer
The feature to be able to review recordings I mean
2020-09-23 26745, 2020
alastairp
remember, our deadline to get a release (and try and get some momentum on the site) is the meeting after the summit, so that's only about 2-3 weeks away
2020-09-23 26701, 2020
Gazooo794 has quit
2020-09-23 26711, 2020
alastairp
what do we have currently? what items can we review, and what items can we rate?
2020-09-23 26724, 2020
_lucifer
let me check once
2020-09-23 26742, 2020
Gazooo794 joined the channel
2020-09-23 26751, 2020
_lucifer
We can review Artist, Release Group, Event, Place, Work and Label
2020-09-23 26716, 2020
_lucifer
We can rate release group, label for sure
2020-09-23 26718, 2020
_lucifer
others i am not sure, i have only the sample dump so I do not know what event/work/place to search for and check but according to the code it seems it is possible to rate any entity. just the ui may be missing
2020-09-23 26756, 2020
alastairp
ok, right. because you just opened this PR to rate artists, right?
2020-09-23 26740, 2020
alastairp
for reviews, I believe that only releasegroups are on production, correct? and all of the others are only on beta?
2020-09-23 26723, 2020
_lucifer
yeah, i just checked the templates only artist rating support is missing and a pr is already opened for that
2020-09-23 26736, 2020
alastairp
ok, cool
2020-09-23 26743, 2020
alastairp
so, I think a good plan might be this:
2020-09-23 26745, 2020
_lucifer
only release group, event and place are in production
2020-09-23 26747, 2020
alastairp
1) do a release to beta today with the things that we discussed yesterday, 2) finish the items in the 'next' release that I added 3) aim for production release next friday (before the summit), 4) if we have time for recording reviews add it, but don't hold the release for that if it's not finished, 5) in the following week, promote what we have and solicit more specific feedback for improvements/next work
2020-09-23 26716, 2020
_lucifer
sounds great! let's do it
2020-09-23 26719, 2020
alastairp
there was already 1 feature request on the thread that I opened on the forum, and there are a few more things that I would like to see
i think it is low priority because given the level of CB interest at present it is unlikely
2020-09-23 26710, 2020
alastairp
for the PRs that you reopened, can you please add a summary of what the feature is, how much has been done, and what is remaining? e.g. if it was only waiting for a new version of BU, add a comment saying that it is ready to merge
2020-09-23 26722, 2020
_lucifer
sure will do that
2020-09-23 26740, 2020
_lucifer
we should handle that case but i think it can wait after the release
2020-09-23 26751, 2020
alastairp
ok, understood. I agree
2020-09-23 26700, 2020
alastairp
perfect. let me know if you have any other questions on the remaining open tickets in the 'next' release
beta is updated. have a quick sanity check look before I push to production.
2020-09-23 26725, 2020
pristine___
ruaok: looks good!
2020-09-23 26733, 2020
pristine___
Mr_Monkey: heyo!
2020-09-23 26740, 2020
Mr_Monkey
Hi !
2020-09-23 26745, 2020
ruaok
did you poke around making sure we broke nothing?
2020-09-23 26750, 2020
ruaok waves at Mr_Monkey
2020-09-23 26754, 2020
pristine___
ruaok: Clicked on the link, redirects to the post
2020-09-23 26716, 2020
ruaok
right, now remember that any release has the potential to break stuff that we didn't touch.
2020-09-23 26731, 2020
pristine___
Right
2020-09-23 26734, 2020
ruaok
in theory it shouldn't. but we should at least check the core features and make sure those pages load.
2020-09-23 26744, 2020
pristine___
Doing
2020-09-23 26755, 2020
ruaok
do recent tracks load? do they look the same as the production site?
2020-09-23 26716, 2020
ruaok
does your listens page have the right listens on it you'd expect? compared to production?
2020-09-23 26714, 2020
pristine___
Everything looks good to me!
2020-09-23 26725, 2020
ruaok
ok, i'll proceed then.
2020-09-23 26730, 2020
pristine___
Mr_Monkey: when I double click on a card, I get an error `we couldn't find a matching song on any of the music service`, yet the track is being played.
2020-09-23 26735, 2020
pristine___
Is this expected?
2020-09-23 26748, 2020
Mr_Monkey
No
2020-09-23 26720, 2020
Mr_Monkey
Could you please paste the entirety of your web page's console logs in a pastebin?
2020-09-23 26747, 2020
Mr_Monkey
Does it succesfully play the track with spotify or youtube?
2020-09-23 26747, 2020
pristine___
It is something related to BrainzPlayer because I have seen it happen on my listen, recent listen page too
2020-09-23 26749, 2020
pristine___
A sec
2020-09-23 26755, 2020
pristine___
I closed the window :(
2020-09-23 26706, 2020
pristine___
Mr_Monkey: so now when I double click there is no error :( I will keep in mind to open the console before playing and I will send you the logs then. Also, if I double click on a song, it says no match and moves to the next card, but when I again double click on the previous card the song plays, is it something related to buffering, maybe
2020-09-23 26732, 2020
Mr_Monkey
Possibly.
2020-09-23 26705, 2020
ruaok
pristine___: released.
2020-09-23 26707, 2020
Mr_Monkey
The youtube player is abit flaky. I'm fixuing it as I go, but it's detifitely possible that it misbehaves.
2020-09-23 26752, 2020
ruaok
iliekcomputers: I just pushed out pr 1106 -- just one link changed -- do we need to make an official release for that?
2020-09-23 26723, 2020
Mr_Monkey
pristine___: I set up the youtube player to run a manual check 1.5 seconds after trying to launch a track. That check is most likely the cause of the issue you're seeing. It's a bit of a hack to replace some missing functionality from the Youtube's player API : https://github.com/metabrainz/listenbrainz-server…
2020-09-23 26723, 2020
Mr_Monkey
If you run into the issue again, you could try setting a breakpoint (in the browser console) in that ^ method and see what's happening.
2020-09-23 26728, 2020
Mr_Monkey
To be honest, I'm not proud of the hack, but haven't found a better solution yet to make sure the player doesn't get stuck on an error and interrupts the page's playback
2020-09-23 26728, 2020
Mr_Monkey
Anyway. Something for me to look at and improve. I'll try throttling my connection to see if I get similar results as you do with more buffering time
2020-09-23 26740, 2020
Mr_Monkey
Thanks for reporting !
2020-09-23 26725, 2020
pristine___
Ah! Nice hack, I mean better than getting stuck on an error.
2020-09-23 26729, 2020
reosarevok
bitmap, yvanzo: opinion on MBS-15 ? Should we close and assume people are fine with closing / navigating away?
heh. that reminds me of the time that german companies wanted to build rail cars for the UK. but they had no suitable tracks that were in such poor condition to mimic the tracks in the UK. they literally had to build and then severely damage a track to replicate the conditions in the UK. 🙄
2020-09-23 26713, 2020
reosarevok
Ouch.
2020-09-23 26724, 2020
reosarevok
Re: MBS-200 - does anyone in the world still use either haudio or playdar?
