So rn users can give feedback on listens page, have you seen that?
2020-09-30 27432, 2020
ruaok
_lucifer: iliekcomputers alastairp Mr_Monkey : my calendar suggests that Nov 21/22 would be a good day for a hack weekend. does that work for you?
2020-09-30 27447, 2020
alastairp
pristine___: I have
2020-09-30 27405, 2020
Mr_Monkey
Nothing on my plate for that date
2020-09-30 27409, 2020
d4rkie has quit
2020-09-30 27426, 2020
alastairp
nothing for me either
2020-09-30 27429, 2020
alastairp
sounds good
2020-09-30 27445, 2020
Nyanko-sensei joined the channel
2020-09-30 27424, 2020
shivam-kapila
Help me with good playlists ;)
2020-09-30 27456, 2020
pristine___
alastairp: nice. So there is a schema, `recording_feedback`, where user feedback is stored. Now we want to have user feedback on recs page too (like/dislike the recommended *recording*). There are two options, save the rec feedback in recording_feedback (same table where feedback of listens page is stored) but I don't really feel good about it. I prefer the second option, which is to have a separate schema
2020-09-30 27456, 2020
pristine___
recommendation_feedback. I mean when a user gives feedback on rec page, back in the mind they know that this feedback is for recommendations, when they give feedback for listens back in the mind they know that this feedback is for listens, so I think we should have two separate schema. Can you me some arguments to accept/discard my reasoning? Just wanted to have a discussion on this before I move forward.
2020-09-30 27439, 2020
alastairp
pristine___: interestingly, Mr_Monkey and ruaok and I just had a bit of a discussion about this exact topic this morning
2020-09-30 27446, 2020
pristine___
Nice. Can you share with me the key points?
2020-09-30 27452, 2020
pristine___
Or is there a doc?
2020-09-30 27459, 2020
alastairp
I like the idea of keeping it separate. What metadata do you have available?
2020-09-30 27424, 2020
alastairp
we don't really have much design other than "hey, we should save a bunch of feedback from various things"
alastairp: should we assume that if a user dislikes a recording on listens page, the user doesn't want that recording in recs too?
2020-09-30 27426, 2020
pristine___
I mean data of recording_feedback is *very* useful for recs.
2020-09-30 27442, 2020
alastairp
pristine___: right, this is the core question that we were asking this morning
2020-09-30 27438, 2020
pristine___
I am stuck at have a different schema for rec_feedback but also use data from recording_feedback? Doing both of them together doesn't make sense to me though
2020-09-30 27454, 2020
alastairp
give me a link to the recording feedback table?
2020-09-30 27414, 2020
shivam-kapila
pristine___: can I ask a question?
2020-09-30 27429, 2020
alastairp
do recommendations have a recording mbid? or a msid, or something else? Are they just textual metadata?
alastairp: we send recommended recording mbids from spark and then do a look up to get artist name, track name etc, any data we want can be shipped from spark, not an issue
2020-09-30 27403, 2020
shivam-kapila
Because the above point is something that doesnt sound concrete
2020-09-30 27410, 2020
pristine___
> What is your motivation behind a separate schema
2020-09-30 27428, 2020
pristine___
I just wrote that in a message to alastairp . Can you scroll and read?
2020-09-30 27437, 2020
pristine___
The first big message.
2020-09-30 27437, 2020
shivam-kapila
I read that
2020-09-30 27458, 2020
shivam-kapila
Just to keep it separate that user liked a rec / listen?
ruaok and I are talking it over in person, give us 5-10 minuts
2020-09-30 27418, 2020
pristine___
Cool! Ping me later. I am here :)
2020-09-30 27403, 2020
pristine___
> Can you me some arguments to accept/discard my reasoning? Just wanted to have a discussion on this before I move forward.
2020-09-30 27451, 2020
pristine___
Yeah shivam-kapila . The point is not concrete, maybe. I just want a discussion on this. Not saying I just want to have a diff schema :)
2020-09-30 27413, 2020
niceplaces has quit
2020-09-30 27417, 2020
pristine___
I am just having contradicting thoughts :p
2020-09-30 27416, 2020
shivam-kapila
I see
2020-09-30 27401, 2020
shivam-kapila
I have a few points. Hopefully useful
2020-09-30 27426, 2020
niceplace joined the channel
2020-09-30 27420, 2020
pristine___
shivam-kapila: yup. Go on?
2020-09-30 27422, 2020
shivam-kapila
To me both the feedback are quite linked
2020-09-30 27410, 2020
shivam-kapila
1. When we like a listen, we like a track and not a listen. Similarly if I like a rec, I actually like the track in the end
2020-09-30 27426, 2020
shivam-kapila
2. If I like a track, I would like to see it affect my recs
2020-09-30 27447, 2020
shivam-kapila
3. If I like a rec, it ideally will reflect in my listen hiastory too
2020-09-30 27441, 2020
shivam-kapila
4. If I had liked some tracks and those pop in my recs, they should be marked loved, that helps user see, "ah I like that track, good recommendation"
2020-09-30 27442, 2020
shivam-kapila
5. In the end we should present user "your liked tracks". which should essentially encapsulate both my likes from recs and listens
2020-09-30 27416, 2020
pristine___
4 and 5 is a diff feature all together, though I agree with 1, 2 and 3
2020-09-30 27449, 2020
shivam-kapila
6. I see you want users to mark how they like the recommenadation, but if you see as a user and provide those buttons, he will see them as a feedback for track, in view of consistency
2020-09-30 27439, 2020
shivam-kapila
conflicting user experinces are never goof
2020-09-30 27442, 2020
shivam-kapila
good*
2020-09-30 27459, 2020
shivam-kapila
Hopefully I framed my thoughts presentably.
2020-09-30 27450, 2020
pristine___
Yeah. You have a bunch of useful thoughts.
2020-09-30 27456, 2020
pristine___
❤
2020-09-30 27412, 2020
alastairp
ok, we're back
2020-09-30 27415, 2020
ruaok
alastairp: will come with interesting stuff.
2020-09-30 27418, 2020
shivam-kapila
Both of them are directly linked to my listening habits, and I feed they share a base
2020-09-30 27434, 2020
shivam-kapila now puts the pen down
2020-09-30 27444, 2020
alastairp
we decided that first of all it'd be nice to have a table that directly references recording mbids
2020-09-30 27457, 2020
alastairp
so for that reason, making a new table is a good idea
2020-09-30 27436, 2020
pristine___
Right!
2020-09-30 27417, 2020
alastairp
we also talked about the score field
2020-09-30 27441, 2020
alastairp
we decided that being a bit more explicit might be good, so we're recommending an enum instead of an integer
2020-09-30 27407, 2020
alastairp
with the values "I like this", "I really like this", "I don't like this", "I never want to hear this again", and "this is a bad recommendation"
2020-09-30 27422, 2020
alastairp
if we come up with more types of feedback, we can just alter the enum to add them
2020-09-30 27441, 2020
ruaok
or we feel that we wish to express the values in different ways, we can do that too.
2020-09-30 27433, 2020
pristine___
Integers are easier to interpret and process I guess
2020-09-30 27447, 2020
alastairp
I don't think so
2020-09-30 27405, 2020
alastairp
and there are plenty of ways of converting enums to integers if we really need it
2020-09-30 27431, 2020
alastairp
the issue with the current `score` field is that other than 1 and -1, we don't really know what any other value means
2020-09-30 27414, 2020
pristine___
> the issue with the current `score` field is that other than 1 and -1, we don't really know what any other value means
2020-09-30 27417, 2020
pristine___
I agree here.
2020-09-30 27415, 2020
pristine___
alastairp: cool! I will write a schema on the basis of above points.
2020-09-30 27435, 2020
alastairp
great. send me an example of it when you have it and I'll give some feedback
2020-09-30 27420, 2020
shivam-kapila
I agree witb alastairp more
2020-09-30 27424, 2020
shivam-kapila
OP
2020-09-30 27427, 2020
pristine___
I am on a vacation this week but I have my laptop with me. So I will be working for a few hours everyday. Sure, will send by tonight or tomorrow for sure.
2020-09-30 27443, 2020
alastairp
pristine___: sure, whenever you want, just mention me with a link
2020-09-30 27451, 2020
alastairp
Mr_Monkey: did you see, at least shivam-kapila agrees with me
2020-09-30 27450, 2020
Mr_Monkey
I agree too
2020-09-30 27402, 2020
shivam-kapila
How many among us will be at OB this summit
2020-09-30 27425, 2020
Mr_Monkey raises his hand
2020-09-30 27439, 2020
Mr_Monkey
Assuming OB = OfficeBrainz
2020-09-30 27455, 2020
ruaok
\ø
2020-09-30 27446, 2020
shivam-kapila
But I am excited
2020-09-30 27424, 2020
kieto joined the channel
2020-09-30 27439, 2020
iliekcomputers
>I am on a vacation this week but I have my laptop with me. So I will be working for a few hours everyday.
2020-09-30 27447, 2020
iliekcomputers
so... not a vacation?
2020-09-30 27414, 2020
ruaok
I know that feeling.
2020-09-30 27417, 2020
iliekcomputers
ruaok: nov 21 sounds good to me
2020-09-30 27427, 2020
ruaok
sweet, into the calendar it goes.
2020-09-30 27458, 2020
ruaok
iliekcomputers: alastairp _lucifer Mr_Monkey : We're confirmed for Nov 21/22
2020-09-30 27432, 2020
Mr_Monkey
👍
2020-09-30 27458, 2020
_lucifer
👍
2020-09-30 27424, 2020
ruaok
that is going to be serious fun, I think. :)
2020-09-30 27458, 2020
CatQuest has quit
2020-09-30 27420, 2020
CatQuest joined the channel
2020-09-30 27420, 2020
CatQuest has quit
2020-09-30 27420, 2020
CatQuest joined the channel
2020-09-30 27451, 2020
alastairp
5:15 PM <ruaok> that is going to be serious
2020-09-30 27408, 2020
alastairp
is all I read at first
2020-09-30 27442, 2020
pristine___
Nov 21....oooo...idk why I was reading it Oct 21 in every message
2020-09-30 27447, 2020
shivam-kapila
iliekcomputers: ping
2020-09-30 27401, 2020
iliekcomputers
pong
2020-09-30 27407, 2020
shivam-kapila
Hi
2020-09-30 27423, 2020
shivam-kapila
I saw you had done the work I should have done in #1097
2020-09-30 27428, 2020
shivam-kapila
sorry for that
2020-09-30 27433, 2020
shivam-kapila
I am a little lost
2020-09-30 27439, 2020
iliekcomputers
no worries, i wanted to get that merged quickly.
2020-09-30 27446, 2020
shivam-kapila
can you guide me whats left
2020-09-30 27453, 2020
iliekcomputers
i'm planning on writing a few tests and merging it.
2020-09-30 27404, 2020
shivam-kapila
tests for only modal are left
2020-09-30 27405, 2020
shivam-kapila
?
2020-09-30 27408, 2020
iliekcomputers
if you have any css changes and things like that, we can do it in a followup
2020-09-30 27419, 2020
shivam-kapila
sure
2020-09-30 27425, 2020
iliekcomputers
a test or two for the modal and tests for the /followers and /following endpoints
2020-09-30 27432, 2020
pristine___
ishaanshah: blank template in #1115?
2020-09-30 27438, 2020
shivam-kapila
okay I will add that
2020-09-30 27414, 2020
ishaanshah
pristine___: updated
2020-09-30 27417, 2020
iliekcomputers
shivam-kapila: actually, i've started on it, i'll finish it up today
