i was looking in the site language not review text language
2020-10-05 27935, 2020
CatQuest
funny i was going ot screenshot that evne before yo upsoted this list (wich is a lot shorter thna the dropdown too)
2020-10-05 27950, 2020
CatQuest
are you looking at website transaltions?
2020-10-05 27956, 2020
_lucifer
yeah
2020-10-05 27959, 2020
CatQuest
heh
2020-10-05 27908, 2020
_lucifer
my mistake 😓
2020-10-05 27913, 2020
CatQuest
no problem!
2020-10-05 27914, 2020
kieto has quit
2020-10-05 27905, 2020
thomasross joined the channel
2020-10-05 27949, 2020
BrainzGit
[listenbrainz-server] paramsingh merged pull request #1089 (master…ishaan/store-import-id): Make sure incremental dump import is not skipped if RC crashes https://github.com/metabrainz/listenbrainz-server…
2020-10-05 27913, 2020
iliekcomputers
ishaanshah: hey
2020-10-05 27916, 2020
iliekcomputers
just to confirm
2020-10-05 27918, 2020
alastairp
_lucifer: I believe that 16.sql has been applied, but not 17 or 19
2020-10-05 27922, 2020
alastairp
I don't know where 18 is
2020-10-05 27915, 2020
iliekcomputers
i'm gonna import full dump 195 and then ask to import until the newest incremental dump
2020-10-05 27939, 2020
iliekcomputers
this will get the cluster back to valid data, right ishaanshah ?
2020-10-05 27943, 2020
_lucifer
alastairp: 19 will fix the errors in sentry
2020-10-05 27921, 2020
_lucifer
18.sql is in the recordings PR
2020-10-05 27939, 2020
ishaanshah
iliekcomputers: Hi
2020-10-05 27951, 2020
ishaanshah
hope you are feeling well
2020-10-05 27907, 2020
ishaanshah
> this will get the cluster back to valid data, right ishaanshah ?
2020-10-05 27907, 2020
ishaanshah
not exactly
2020-10-05 27921, 2020
ishaanshah
some of the listens will still be lost
2020-10-05 27946, 2020
iliekcomputers
Why?
2020-10-05 27921, 2020
ishaanshah
beacause new listens in full dump 202 and 218 are not present in incremental dump
2020-10-05 27902, 2020
iliekcomputers
They would be present in incremental dumps 202 and 218
2020-10-05 27939, 2020
ishaanshah
oh
2020-10-05 27941, 2020
ishaanshah
then yes
2020-10-05 27956, 2020
ishaanshah
first full dump with id
2020-10-05 27908, 2020
ishaanshah
and then newest incremental dump
2020-10-05 27913, 2020
_lucifer
one question, say i import listens in from the past month today will they be present in the today's dump?
oh wow ,i just thought of something in relation to individual instruments/individual brands we talked about on the summit: for individual gamelan orchestra, that's another example of "individual orchestra"
2020-10-05 27913, 2020
alastairp
_lucifer: in this case we should probably consider a fallback "we don't know what language this was written in", and trigger an alert in sentry (without crashing)
2020-10-05 27919, 2020
CatQuest
wich is somewhat different thna orchestra in the western sense (i should ahve used the term "ensemble")
2020-10-05 27947, 2020
CatQuest
because the gamelan is about the instruments, whoever plays isn't that important, the important is the various ensemble's combination of instruments
2020-10-05 27935, 2020
_lucifer
alastairp: i am still taking a look and trying to figure why the language is shown at all if its not supported
2020-10-05 27946, 2020
_lucifer
iiuc, display a flash error on the top and log right?
2020-10-05 27945, 2020
yvanzo
reosarevok, bitmap: I fixed the message for tag v-2020-05-18-postgres12; make sure to delete your local tag to prevent accidental override: git tag -d v-2020-05-18-postgres12 # next fetch will grab the new tag
2020-10-05 27914, 2020
_lucifer
its an inconsistency, for instance people can write reviews in `no` but not view them afterwards
2020-10-05 27948, 2020
_lucifer
becasue the error is not triggered on writing the review in `no` but on trying to view them
2020-10-05 27930, 2020
CatQuest
yep it triggers ise both on saving and viewing
2020-10-05 27916, 2020
_lucifer
error on saving is because after the review is written, the user is redirected to the view page. from what i see locally, the review is saved in the db correctly
2020-10-05 27921, 2020
CatQuest
ahh that explains it indeed
2020-10-05 27940, 2020
CatQuest
(but why i got an error but it did save properly)
2020-10-05 27906, 2020
alastairp
_lucifer: ideally we shouldn't allow people to choose an option that results in an error on save
2020-10-05 27920, 2020
_lucifer
yeah
2020-10-05 27932, 2020
alastairp
But if it does happen, we shouldn't cause an error on read either
2020-10-05 27950, 2020
alastairp
My suggestion for the text was the error to show on read
2020-10-05 27933, 2020
CatQuest
no meeting today ?
2020-10-05 27936, 2020
alastairp
Because I think it shows "this review was written in [language]", right?
2020-10-05 27941, 2020
alastairp
CatQuest: no
2020-10-05 27949, 2020
_lucifer
makes sense
2020-10-05 27958, 2020
CatQuest
no there isn't or no there is? :P
2020-10-05 27918, 2020
_lucifer
there is an ISE if the locale is not supported alastairp
2020-10-05 27921, 2020
alastairp
it's in the topic
2020-10-05 27940, 2020
_lucifer
but it does show that language field in case it is supported
2020-10-05 27948, 2020
alastairp
I guess CatQuest's error on save was because it tried to show the review after it was written?
2020-10-05 27959, 2020
_lucifer
yes right
2020-10-05 27946, 2020
_lucifer
it happens after the redirect, the review CatQuest wrote will show up correctly even on homepage but display an error when clicked on
2020-10-05 27916, 2020
CatQuest
yep
2020-10-05 27905, 2020
yvanzo
_lucifer: can we quickly discuss the search changes after the meeting please?
2020-10-05 27921, 2020
_lucifer
no meeting today :)
2020-10-05 27903, 2020
_lucifer
yvanzo: but we can discuss now or later if you want
2020-10-05 27939, 2020
Freso
(Just a reminder that we don’t have meeting today (yvanzo and others).)
2020-10-05 27905, 2020
Sophist-UK
Freso: Is that because it is Republic Day here in Portugal? ;-)
2020-10-05 27917, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | No meeting today! Next meeting: 2020-10-12
2020-10-05 27943, 2020
Freso
Sophist-UK: Sure. Not at all related to having spent ~11 hours in meeting(s) over the weekend. :p
2020-10-05 27956, 2020
_lucifer
lol
2020-10-05 27933, 2020
yvanzo
_lucifer: ok, I was just checking which of these changes might break something or not
2020-10-05 27930, 2020
reosarevok
I like that we can review places in CB but MB doesn't even allow rating them
2020-10-05 27908, 2020
yvanzo
_lucifer: SEARCH-579 is breaking change as 'packaging' is moved from an object to a string
