Mr_Monkey: yeah, so it expects an array of listens type, but i want to pass an array of type recommendation
I have defined a rec type in type.ds
The rec type doesn't have listened_at, so BP returns an error. I can pass a constant for listened_at to get over this issue, but that will be just a hack
Since BP rn only accepts array of type listens
Mr_Monkey
Yes, better to modify BP to not freak out if there is no listened_at
Hang on, BP shouldn't have anything to do with listened_at
So if I pass an array of recs or anything which has a different type, BP will error out?
Though I will post the exact error in a while.
Will ping you then. Thanks.
shivam-kapila
pristine___: hi I saw your message
Is your doubt cleared
Reg key
pristine___
No :(
shivam-kapila
Ah
What was the exact doubt
_lucifer
alastairp: shivam-kapila: why not medium :)
pristine___
09:39:16 <pristine___> Also why is the `key` field required?
Mr_Monkey
pristine___: I suppose you could encounter errors if it's not a Listen type, but not regarding `listened_at` since BP doesn't use that at all.
In theory we try to be safe when trying to access properties of a listen, suing a method that won't throw an error if the property is missing. For example: https://github.com/metabrainz/listenbrainz-serv...
reosarevok: "We've long known about gender imbalances in the music industry and while we're happy that people are using our data to demonstrate this, we're dismayed at most of the findings in this article. What is more concerning is that we have a general impression that our community has a slight bias towards adding more information about music created by Women, which means that the overall situation may actually be worse than what one
can deduce from our data. :("
Mr_Monkey
The way around is to figure out if it is throwing an error when you send a Rec type, and adapt it to accept both
_lucifer
oh! didn't know that alastairp. yeah makes sense in that case
ruaok
how do you feel about that paragraph?
pristine___
Mr_Monkey: yeah right. I get that I it should accept both, was just I didn't know from where to start :p on skimming I realized maybe it will be lot of if else based in mode.
ruaok: is it worth adding a paragraph with a call to action to ensure that musicbrainz accurately reflects reality (even if the industry itself isn't very balanced)
pristine___
shivam-kapila: reference to what?
ruaok
alastairp: hmm. maybe. care to craft that paragraph?
Reference to the html element in react so that you can manipulate it (in this case to scroll the window to it)
pristine___
Oh. Got it now
alastairp
as a reminder, all data in MusicBrainz is contributed by members of the community. If you see any situations where women [or minorities?] are being mis/underrepresented, we encourage you to add this content to MusicBrainz, or ask for help on the forums.
Mr_Monkey
> I get that I it should accept both, was just I didn't know from where to start :p
I guess start by sending BP a Rec type element, and see if there is any error or anything that doesn't work. I don't anticipate a lot of issues related to the structure however. Mainly, what you'll need to ensure it can search for the track is what's in `getCurrentTrackName` and `getCurrentTrackArtists`:
I'd include the minorities part, but "or ask for help on the forums." feels odd.
Mr_Monkey
So you'll either need to change the Rec object structure to have `track_metadata.track_name` and `track_metadata. artist_name` string, or modify `getCurrentTrackName` and `getCurrentTrackArtists` to get the string from another property.
alastairp
yeah, I'm trying to work out what amount of effort people are willing to go towards
and it depends on who the audience of the post is
we could tell newcomers "hey, if you see somehting wrong, fix it", but fixing it can be imposing if you're not familiar with the community
you're right that we don't want to push the effort onto the existing community. I was trying to come up with a way of saying "there are people here who can help you to add stuff if you know what to add but don't know how to do it"
ruaok
".. we encourage you to add this content to MusicBrainz; If you get stuck, please ask for help on the forums." ?
alastairp
there we go
ruaok
ok, post is ready. care to review, alastairp ?
alastairp
looking
pristine___
Mr_Monkey: ooo. Makes sense. I will keep you posted :)
alastairp
do you also want to link to the actual research in addition to the news articles?
Mr_Monkey
Don't hesitate if you're lost!
(to ask questions)
ruaok
alastairp: I don't feel strongly about that -- add them if you like.
alastairp
the bbc article links to it, so I'm not too worried
[listenbrainz-server] mayhem merged pull request #1128 (master…update-readme-with-blog): Add note about the blog and about commercial use. (ORG-48) https://github.com/metabrainz/listenbrainz-serv...
