#metabrainz

/

      • supersandro2000 has quit
      • 2020-11-05 31041, 2020

      • supersandro2000 joined the channel
      • 2020-11-05 31046, 2020

      • d4rkie has quit
      • 2020-11-05 31050, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-11-05 31032, 2020

      • Lotheric
      • 2020-11-05 31005, 2020

      • sumedh joined the channel
      • 2020-11-05 31025, 2020

      • sumedh has quit
      • 2020-11-05 31003, 2020

      • supersandro2000 has quit
      • 2020-11-05 31039, 2020

      • adhawkins_ joined the channel
      • 2020-11-05 31045, 2020

      • adhawkins has quit
      • 2020-11-05 31043, 2020

      • adhawkins_ is now known as adhawkins
      • 2020-11-05 31018, 2020

      • supersandro2000 joined the channel
      • 2020-11-05 31002, 2020

      • sumedh joined the channel
      • 2020-11-05 31048, 2020

      • supersandro2000 has quit
      • 2020-11-05 31006, 2020

      • supersandro2000 joined the channel
      • 2020-11-05 31046, 2020

      • sumedh has quit
      • 2020-11-05 31024, 2020

      • pristine___
        ruaok: so I was thinking we can explain on the `info` page what each feedback option actually means. I guess it is important for us to do that so user can understand what exactly their feedback means!
      • 2020-11-05 31036, 2020

      • pristine___
        shivam-kapila: was just looking at YouTube's feedback options, they look great. We can definitely improve ours in future. Though YouTube doesn't allow to edit the feedback once submitted, I guess we are doing great since we allow the edits.
      • 2020-11-05 31024, 2020

      • shivam-kapila
        pristine___: totally agree
      • 2020-11-05 31056, 2020

      • sumedh joined the channel
      • 2020-11-05 31046, 2020

      • sumedh has quit
      • 2020-11-05 31028, 2020

      • sumedh joined the channel
      • 2020-11-05 31032, 2020

      • sumedh has quit
      • 2020-11-05 31044, 2020

      • sumedh joined the channel
      • 2020-11-05 31039, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #1169 (master…restart-cron-jobs): Re-enable dump cron jobs https://github.com/metabrainz/listenbrainz-server…
      • 2020-11-05 31055, 2020

      • v6lur joined the channel
      • 2020-11-05 31001, 2020

      • Gazooo79494 has quit
      • 2020-11-05 31044, 2020

      • Gazooo79494 joined the channel
      • 2020-11-05 31008, 2020

      • ruaok
        pristine___: yes, we should do that!
      • 2020-11-05 31037, 2020

      • BrainzGit
        [listenbrainz-server] mayhem merged pull request #1169 (master…restart-cron-jobs): Re-enable dump cron jobs https://github.com/metabrainz/listenbrainz-server…
      • 2020-11-05 31020, 2020

      • sumedh has quit
      • 2020-11-05 31038, 2020

      • ruaok
        ishaanshah: merged to prod, updated listenbrainz-cron-prod.
      • 2020-11-05 31001, 2020

      • ruaok
        let's hope data just flows normally now. 🤞
      • 2020-11-05 31036, 2020

      • sumedh joined the channel
      • 2020-11-05 31047, 2020

      • alastairp
        ruaok: sorry, just realised that I forgot your jar that you gave me with water fixer :( will add a reminder for monday
      • 2020-11-05 31007, 2020

      • ruaok
        no worries, not a top priority.
      • 2020-11-05 31023, 2020

      • niceplace has quit
      • 2020-11-05 31013, 2020

      • niceplace joined the channel
      • 2020-11-05 31002, 2020

      • ruaok
        random feedback for CAA: "Thanks a lot for your answer and your amazing work team !"
      • 2020-11-05 31007, 2020

      • ruaok
        !m team
      • 2020-11-05 31007, 2020

      • BrainzBot
        You're doing good work, team!
      • 2020-11-05 31010, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok closed pull request #1270 (master…eslint-fix-by-rule-pt-3): Eslint fixes by rule, pt. 3 https://github.com/metabrainz/musicbrainz-server/…
      • 2020-11-05 31015, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok closed pull request #1271 (master…eslint-fix-by-rule-pt-4): Eslint fixes by rule, pt. 4 https://github.com/metabrainz/musicbrainz-server/…
      • 2020-11-05 31018, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok closed pull request #1272 (master…eslint-fix-by-rule-pt-5): Eslint fixes by rule, pt. 5: quotes https://github.com/metabrainz/musicbrainz-server/…
      • 2020-11-05 31022, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok closed pull request #1273 (master…eslint-fix-by-rule-pt-6): Eslint fixes by rule, pt. 6 (last batch) https://github.com/metabrainz/musicbrainz-server/…
      • 2020-11-05 31035, 2020

      • alastairp
        here's something I learned this week: Many of spotify's "mood playlists" are automatically generated based on your tastes, rather than manually created
      • 2020-11-05 31017, 2020

      • alastairp
        after all of the promotion they did in terms of the articles talking about their playlist experts who manually made playlists... turns out that they _do_ automate a whole bunch of it
      • 2020-11-05 31051, 2020

      • ruaok
        alastairp: Mr_Monkey: Noms? or should we steal shauna's food?
      • 2020-11-05 31007, 2020

      • Mr_Monkey
        NOMS
      • 2020-11-05 31010, 2020

      • alastairp
        I bought tupper, happy to wait for you to order
      • 2020-11-05 31036, 2020

      • alastairp
        I could go for another of those coconut things though
      • 2020-11-05 31010, 2020

      • ruaok
        ask an ye shall receive. :)
      • 2020-11-05 31046, 2020

      • ruaok
        I'm listening to my daily jams every day when I get to the office. I've very pleased with it already and there are a lot of improvements pending. joy!
      • 2020-11-05 31013, 2020

      • alastairp
        nice
      • 2020-11-05 31003, 2020

      • Mr_Monkey
        ruaok: 15 minutes out
      • 2020-11-05 31010, 2020

      • ruaok
        fanks!
      • 2020-11-05 31056, 2020

      • Mr_Monkey
        pristine___: It took me a while to figure out the issue with the Rec tests, but I just had my eureka moment: we replace the afterRecommendationsDisplay function with a jest spy function, so of course the original one (and its setstate({loading:false}) isn't called:
      • 2020-11-05 31056, 2020

      • Mr_Monkey
      • 2020-11-05 31029, 2020

      • Mr_Monkey
        I don't remember exactly, but I think there's a way to keep the original function and spy on it at the same time
      • 2020-11-05 31035, 2020

      • Mr_Monkey
        Any jest afficionados around to help? Maybe shivam-kapila could have run into a similar case before?
      • 2020-11-05 31040, 2020

      • sumedh has quit
      • 2020-11-05 31053, 2020

      • pristine___
        Mr_Monkey: I wonder why it works here
      • 2020-11-05 31054, 2020

      • pristine___
      • 2020-11-05 31059, 2020

      • shivam-kapila
        Oh hi
      • 2020-11-05 31009, 2020

      • shivam-kapila
        What can I help with
      • 2020-11-05 31035, 2020

      • Mr_Monkey
        pristine___: in that test we don't overwrite `afterRecommendationsDisplay`, that's why
      • 2020-11-05 31021, 2020

      • Mr_Monkey
        shivam-kapila: Do you know if there is a way to spy on a function in Jest without replacing it? Meaning it'll keep working as usual but I can test if it's been called?
      • 2020-11-05 31040, 2020

      • Mr_Monkey
        Admittedly I can just google that, but…
      • 2020-11-05 31001, 2020

      • pristine___
        shivam-kapila: I wonder why it fails https://github.com/metabrainz/listenbrainz-server…
      • 2020-11-05 31016, 2020

      • pristine___
        though it works here
      • 2020-11-05 31022, 2020

      • pristine___
      • 2020-11-05 31032, 2020

      • pristine___
      • 2020-11-05 31045, 2020

      • Mr_Monkey
      • 2020-11-05 31056, 2020

      • shivam-kapila
        Mr_Monkey: I havent used as such but I think what you found is the way out
      • 2020-11-05 31016, 2020

      • Mr_Monkey
        Thanks :)
      • 2020-11-05 31036, 2020

      • alastairp
        Mr_Monkey: let's talk rating soon
      • 2020-11-05 31037, 2020

      • ZaphodBeeblebrox joined the channel
      • 2020-11-05 31004, 2020

      • CatQuest has quit
      • 2020-11-05 31014, 2020

      • sumedh joined the channel
      • 2020-11-05 31026, 2020

      • v6lur has quit
      • 2020-11-05 31001, 2020

      • ruaok
      • 2020-11-05 31014, 2020

      • alastairp
        that's awesome
      • 2020-11-05 31017, 2020

      • ruaok
        the first entry is correct. :)
      • 2020-11-05 31028, 2020

      • alastairp
        the others are from other releases?
      • 2020-11-05 31041, 2020

      • ruaok
        yes
      • 2020-11-05 31019, 2020

      • alastairp
        in the context of an item in the troi pipeline do you expect to pass in text or mbid?
      • 2020-11-05 31036, 2020

      • alastairp
        I guess if you go mbid -> metadata lookup, then you already have identically matching metadata
      • 2020-11-05 31049, 2020

      • alastairp
        and you conveniently bypass the issue of non-merged recording mbids
      • 2020-11-05 31007, 2020

      • ruaok
        text only was my plan.
      • 2020-11-05 31006, 2020

      • alastairp
        pristine___: hi, I was just talking to ruaok about your work on artist similarity in spark. this sounds really similar to previous work that both iliekcomputers and I did, so it would be great to have a talk to you some time about what you're planning on doing to make sure that we do it in a way that combines all of our ideas
      • 2020-11-05 31054, 2020

      • pristine___
        alastairp: I think I can write a small doc on the work I plan to do!
      • 2020-11-05 31001, 2020

      • alastairp
      • 2020-11-05 31014, 2020

      • pristine___
        Cool
      • 2020-11-05 31028, 2020

      • alastairp
        sure, a doc would be a great idea to have clear your expected transforms and inputs
      • 2020-11-05 31037, 2020

      • sumedh has quit
      • 2020-11-05 31039, 2020

      • Mr_Monkey
        Listening to the ListenBrainz recent page is some serious musical parkour: https://beta.listenbrainz.org/recent
      • 2020-11-05 31010, 2020

      • ruaok
        more challenging than having zas as a house guest
      • 2020-11-05 31032, 2020

      • zas
        lol
      • 2020-11-05 31045, 2020

      • sumedh joined the channel
      • 2020-11-05 31025, 2020

      • iliekcomputers
        The support email that came just now seems concerning...
      • 2020-11-05 31011, 2020

      • ruaok
        not quite sure what to make of it
      • 2020-11-05 31034, 2020

      • ruaok
        yvanzo: I've forwarded you that mail -- can you please take a look?
      • 2020-11-05 31043, 2020

      • ruaok
        I'll take care of the autoedit bits.
      • 2020-11-05 31047, 2020

      • ruaok
        zas: are you aware of any breaches to our servers? we have an old skool user saying that he got spam on a recently changed email address that was clearly only used in MB context.
      • 2020-11-05 31010, 2020

      • ruaok
        reosarevok: thanks for taking care of those.
      • 2020-11-05 31029, 2020

      • reosarevok
        np
      • 2020-11-05 31040, 2020

      • reosarevok
        Sorry, was already on it and didn't see your message here
      • 2020-11-05 31024, 2020

      • ruaok
        no pasó nada.
      • 2020-11-05 31018, 2020

      • zas
        not aware of any, but... it doesn't mean it wasn't the case
      • 2020-11-05 31025, 2020

      • ruaok
        I doubt we were compromised, question is did our data dumps leak data?
      • 2020-11-05 31035, 2020

      • ruaok
        and this all happened pretty fast.
      • 2020-11-05 31013, 2020

      • ruaok
      • 2020-11-05 31020, 2020

      • ruaok
        much better now.
      • 2020-11-05 31050, 2020

      • alastairp
        sweet
      • 2020-11-05 31020, 2020

      • zas
        about data dumps, I guess bitmap is the right person to ask to. I'll check servers for any hint. Can you pm me the concerned email address?
      • 2020-11-05 31041, 2020

      • alastairp
        ruaok: got a sec to discuss the names that I should give something?
      • 2020-11-05 31058, 2020

      • ruaok
        zas: done.
      • 2020-11-05 31037, 2020

      • bitmap
        we've been careful to sanitize those and haven't made any changes there recently, but I can certainly download a dump and check
      • 2020-11-05 31055, 2020

      • bitmap
        can't think of any places we'd leak the email on the website either
      • 2020-11-05 31049, 2020

      • bitmap
        no emails in mbdump-editor
      • 2020-11-05 31031, 2020

      • reosarevok
        Discourse? Jira?
      • 2020-11-05 31015, 2020

      • bitmap
        probably not jira since they haven't logged in there in years
      • 2020-11-05 31035, 2020

      • zas
        if there was a leak, I'd say more than one user would complain. This user changed email because of spam, added one digit to the previous email address... so my feeling it has nothing to do with us
      • 2020-11-05 31002, 2020

      • ruaok
        zas: my feeling as well. I asked Jan to forward the spam mail.
      • 2020-11-05 31008, 2020

      • ruaok
        (with headers)
      • 2020-11-05 31034, 2020

      • bitmap
        I can try creating a test account with a sufficiently random address and see what happens
      • 2020-11-05 31011, 2020

      • ruaok
        for what? to see if it gathers spam?
      • 2020-11-05 31000, 2020

      • bitmap
        right
      • 2020-11-05 31033, 2020

      • ruaok
        can't hurt, I guess. maybe document it in syswiki?
      • 2020-11-05 31039, 2020

      • alastairp
        ruaok: tomorrow I'm going to look at LB-742 and LB-741
      • 2020-11-05 31041, 2020

      • BrainzBot
        LB-742: Debug an element by passing a single item through it https://tickets.metabrainz.org/browse/LB-742
      • 2020-11-05 31041, 2020

      • BrainzBot
        LB-741: Add the ability to inspect a pipeline to see if an Element is part of it https://tickets.metabrainz.org/browse/LB-741
      • 2020-11-05 31056, 2020

      • alastairp
        it's possible that 741 is going to go somewhat towards LB-751 too
      • 2020-11-05 31057, 2020

      • BrainzBot
        LB-751: Implement pipeline type checking https://tickets.metabrainz.org/browse/LB-751
      • 2020-11-05 31011, 2020

      • alastairp
        did you make a start on LB-736?
      • 2020-11-05 31012, 2020

      • BrainzBot
        LB-736: Look into using argparse to specify patch arguments https://tickets.metabrainz.org/browse/LB-736
      • 2020-11-05 31013, 2020

      • ruaok
        ok, looks like we can finish a nice round set of features this week. nice. :)
      • 2020-11-05 31031, 2020

      • ruaok
        no, I have no code related to any of those features.
      • 2020-11-05 31044, 2020

      • alastairp
        OK. I'll assign to me if I make a start on any of those
      • 2020-11-05 31049, 2020

      • ruaok
        k
      • 2020-11-05 31058, 2020

      • sumedh has quit
      • 2020-11-05 31029, 2020

      • sumedh joined the channel
      • 2020-11-05 31021, 2020

      • CallerNo6 joined the channel
      • 2020-11-05 31021, 2020

      • CallerNo6 has quit
      • 2020-11-05 31021, 2020

      • CallerNo6 joined the channel
      • 2020-11-05 31049, 2020

      • BestSteve has quit
      • 2020-11-05 31033, 2020

      • BestSteve joined the channel
      • 2020-11-05 31013, 2020

      • sumedh has quit
      • 2020-11-05 31013, 2020

      • sumedh joined the channel
      • 2020-11-05 31013, 2020

      • sumedh has quit