#metabrainz

/

      • d4rkie has quit
      • 2020-11-06 31149, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-11-06 31149, 2020

      • supersandro2000 has quit
      • 2020-11-06 31156, 2020

      • supersandro2000 joined the channel
      • 2020-11-06 31108, 2020

      • ZaphodBeeblebrox is now known as CatQuest
      • 2020-11-06 31136, 2020

      • apetresc has quit
      • 2020-11-06 31146, 2020

      • Lotheric_ joined the channel
      • 2020-11-06 31114, 2020

      • Lotheric has quit
      • 2020-11-06 31119, 2020

      • Lotheric_ is now known as Lotheric
      • 2020-11-06 31114, 2020

      • ephemer0l_ has quit
      • 2020-11-06 31114, 2020

      • fs has quit
      • 2020-11-06 31104, 2020

      • flamingspinach joined the channel
      • 2020-11-06 31130, 2020

      • sumedh joined the channel
      • 2020-11-06 31143, 2020

      • sumedh has quit
      • 2020-11-06 31118, 2020

      • sumedh joined the channel
      • 2020-11-06 31145, 2020

      • supersandro2000 has quit
      • 2020-11-06 31103, 2020

      • supersandro2000 joined the channel
      • 2020-11-06 31145, 2020

      • ephemer0l_ joined the channel
      • 2020-11-06 31118, 2020

      • sumedh has quit
      • 2020-11-06 31149, 2020

      • niceplace has quit
      • 2020-11-06 31109, 2020

      • niceplace joined the channel
      • 2020-11-06 31157, 2020

      • sumedh joined the channel
      • 2020-11-06 31114, 2020

      • yvanzo
        mo’’in’
      • 2020-11-06 31128, 2020

      • yvanzo
        I don’t think that email issue is from MB either. His email could be leaked either by him or his provider, or the spammer may simply found this derivative address using an automated guesser. I would suggest him to try using a more random identifier suffix instead.
      • 2020-11-06 31102, 2020

      • sumedh has quit
      • 2020-11-06 31110, 2020

      • reosarevok
        Mr_Monkey (or ruaok?): can we do ORG-35? Got another email about it
      • 2020-11-06 31111, 2020

      • BrainzBot
        ORG-35: Specify a license on metabrainz-logos https://tickets.metabrainz.org/browse/ORG-35
      • 2020-11-06 31110, 2020

      • reosarevok
      • 2020-11-06 31101, 2020

      • yvanzo
      • 2020-11-06 31118, 2020

      • sumedh joined the channel
      • 2020-11-06 31127, 2020

      • v6lur joined the channel
      • 2020-11-06 31103, 2020

      • ruaok
        mooiin!
      • 2020-11-06 31118, 2020

      • ruaok
        yvanzo: yeah, I think we all kinda think along those lines. I'll draft a response in a bit.
      • 2020-11-06 31102, 2020

      • Gazooo79494 has quit
      • 2020-11-06 31125, 2020

      • sumedh has quit
      • 2020-11-06 31150, 2020

      • v6lur has quit
      • 2020-11-06 31157, 2020

      • v6lur joined the channel
      • 2020-11-06 31106, 2020

      • Sophist-UK joined the channel
      • 2020-11-06 31159, 2020

      • ruaok
        alastairp: your comments on LB-736 are why I skipped that part right away -- click does so much magic that a large part of the time will be spent fighting it, when instead we could spend 30 mins and just round out manual argument passing to suite our needs and roll with it.
      • 2020-11-06 31100, 2020

      • BrainzBot
        LB-736: Look into using argparse to specify patch arguments https://tickets.metabrainz.org/browse/LB-736
      • 2020-11-06 31110, 2020

      • ruaok
        but I know you like a challenge, so... heh.
      • 2020-11-06 31148, 2020

      • niceplace has quit
      • 2020-11-06 31139, 2020

      • alastairp
        ruaok: right, got it
      • 2020-11-06 31111, 2020

      • niceplace joined the channel
      • 2020-11-06 31136, 2020

      • sumedh joined the channel
      • 2020-11-06 31109, 2020

      • Mr_Monkey
        ruaok: I have no idea what license the logos should be available under. I imagine something like CC-BY-NC-SA?
      • 2020-11-06 31122, 2020

      • Mr_Monkey
        yvanzo: Thanks, they should be the same, I'll clean that up
      • 2020-11-06 31106, 2020

      • ruaok
        CC-by-sa, I think. NC might prevent someone from putting our logo on their webpage.
      • 2020-11-06 31106, 2020

      • pristine___
      • 2020-11-06 31134, 2020

      • pristine___
        gives `500`
      • 2020-11-06 31141, 2020

      • pristine___
        is it expected?
      • 2020-11-06 31138, 2020

      • ruaok
        500? expected on a production server?
      • 2020-11-06 31114, 2020

      • pristine___
      • 2020-11-06 31141, 2020

      • pristine___
        this shouldn't return `500`, it should say that the passed args are invalid
      • 2020-11-06 31146, 2020

      • pristine___
        shivam-kapila: ^^
      • 2020-11-06 31155, 2020

      • pristine___
        with something other than `500`
      • 2020-11-06 31127, 2020

      • pristine___
        please have a look at the `feedback` endpoint, it is not working as expected I think.
      • 2020-11-06 31125, 2020

      • pristine___
        https://api.listenbrainz.org/1/feedback/user/Vans…, this shouldn't return 500 as well, it should say that the user hasan't passed the required args
      • 2020-11-06 31100, 2020

      • pristine___
        the endpoint works well with react but in general it is borked, ig
      • 2020-11-06 31153, 2020

      • ruaok
        LB-755
      • 2020-11-06 31153, 2020

      • BrainzBot
        LB-755: 500 error on feedback endpoint https://tickets.metabrainz.org/browse/LB-755
      • 2020-11-06 31109, 2020

      • ruaok
        please open a ticket when you find a 500 in production. that is never acceptable.
      • 2020-11-06 31117, 2020

      • pristine___
        maybe you `500`s can be solved when you work on this https://github.com/metabrainz/listenbrainz-server…
      • 2020-11-06 31121, 2020

      • pristine___
        umm...oh wait
      • 2020-11-06 31130, 2020

      • pristine___
        they are separate issues, nevamind
      • 2020-11-06 31137, 2020

      • pristine___
        ruaok: okay, thanks for the ticket :)
      • 2020-11-06 31129, 2020

      • yvanzo
        Mr_Monkey, ruaok: Thanks for the t-shirt I just received, it rocks! _\nn/
      • 2020-11-06 31144, 2020

      • ruaok
        :D
      • 2020-11-06 31157, 2020

      • Mr_Monkey
        Woo !
      • 2020-11-06 31103, 2020

      • pristine___
      • 2020-11-06 31103, 2020

      • BrainzBot
        LB-748: Add separate endpoint to delete recording feedback
      • 2020-11-06 31107, 2020

      • pristine___
      • 2020-11-06 31108, 2020

      • BrainzBot
        LB-749: Avoid mutating state to update recording feedback
      • 2020-11-06 31127, 2020

      • pristine___
        alastairp: hey, shivam-kapila Opnened this tickets in light of this
      • 2020-11-06 31134, 2020

      • pristine___
      • 2020-11-06 31159, 2020

      • pristine___
        Do you want to discuss about it anytime soon?
      • 2020-11-06 31105, 2020

      • pristine___
        Let's fix a day :)
      • 2020-11-06 31114, 2020

      • pristine___
        These*
      • 2020-11-06 31143, 2020

      • alastairp
        hi pristine___, sure. In fact, Mr_Monkey and I had a discussion about this in the office yesterday. There are some things that we need to improve about feedback. It seems like there's a bit of confusion in a few places that we should fix
      • 2020-11-06 31159, 2020

      • pristine___
        Agreed!
      • 2020-11-06 31103, 2020

      • alastairp
        do you want to talk one day next week to cover this and the artist similarity things?
      • 2020-11-06 31100, 2020

      • pristine___
        Cool, sounds good. I will prepare the doc by then
      • 2020-11-06 31123, 2020

      • pristine___
        Let me know which day suits you :)
      • 2020-11-06 31156, 2020

      • alastairp
        let
      • 2020-11-06 31138, 2020

      • alastairp
        let's do early in the week. Monday or Tuesday, about midday Spanish time?
      • 2020-11-06 31144, 2020

      • ruaok
        so, 20 minutes late?
      • 2020-11-06 31153, 2020

      • ruaok
        or do you mean CET? 😆
      • 2020-11-06 31130, 2020

      • pristine___
        Tuesday sounds good
      • 2020-11-06 31156, 2020

      • ruaok
        I can join tuesday, except for lunch time.
      • 2020-11-06 31142, 2020

      • pristine___
        Nice.
      • 2020-11-06 31157, 2020

      • pristine___
        umm...uuid.UUID(rec_mbid) is this a good way to check if a string or something is an UUID?
      • 2020-11-06 31103, 2020

      • alastairp
        great. maybe around 12:00 tuesday CEST then?
      • 2020-11-06 31115, 2020

      • ruaok
        pristine___: yes, it is.
      • 2020-11-06 31117, 2020

      • pristine___
        or is there any better way?
      • 2020-11-06 31119, 2020

      • alastairp
        pristine___: yes, that's fine. we use this in many places
      • 2020-11-06 31120, 2020

      • ruaok
        alastairp: works for me.
      • 2020-11-06 31128, 2020

      • pristine___
        alastairp: cool
      • 2020-11-06 31157, 2020

      • pristine___
        thanks for confirmation on uuid stuff and 12:00 CET suits me
      • 2020-11-06 31116, 2020

      • alastairp
        also, consider using str(uuid.UUID(rec_id)) when you take input from a user and want to query in the database
      • 2020-11-06 31139, 2020

      • alastairp
        because uuids can be "valid", but have different things like upper-case letters, or - in different places
      • 2020-11-06 31132, 2020

      • alastairp
        ruaok: did we set a time for Monday?
      • 2020-11-06 31141, 2020

      • ruaok
        not yet, no.
      • 2020-11-06 31157, 2020

      • ruaok
        I'll be in the office all day, so matters less to me.
      • 2020-11-06 31118, 2020

      • pristine___
        alastairp: cool, so i am writing some rec feedback stuff, will you be able to review today/tomorrow?
      • 2020-11-06 31145, 2020

      • alastairp
        yes, probably, but let's focus on discussing it on Tuesday
      • 2020-11-06 31118, 2020

      • alastairp
        ruaok: OK. I'm just waiting to get feedback on another meeting in the morning, but will plan to be at the office from 12-> whenever
      • 2020-11-06 31130, 2020

      • ruaok
        sound good.
      • 2020-11-06 31149, 2020

      • ruaok
        I just reviewed the annoy PR, fyi.
      • 2020-11-06 31111, 2020

      • alastairp
        all great points, thanks for catching them 👍
      • 2020-11-06 31140, 2020

      • alastairp
        oh wow, some incredible acousticbrainz-based playlisting work coming out of a student in the lab
      • 2020-11-06 31106, 2020

      • alastairp
        I'm going to try and get it hosted today or early next week, and then convince them to add it all to troi :)
      • 2020-11-06 31122, 2020

      • ruaok
        noice!
      • 2020-11-06 31120, 2020

      • alastairp
        combination of genre + mood + "how much variation of mood within the genre"
      • 2020-11-06 31136, 2020

      • alastairp
        he'd really benefit from being able to embed brainzplayer, Mr_Monkey ;)
      • 2020-11-06 31153, 2020

      • Mr_Monkey
        Huh, wha?
      • 2020-11-06 31107, 2020

      • alastairp
        just someone else who needs embeddable BP + Spotify :)
      • 2020-11-06 31117, 2020

      • Mr_Monkey
        Gah
      • 2020-11-06 31132, 2020

      • alastairp
        hey, just thinking out loud
      • 2020-11-06 31142, 2020

      • alastairp
        could we have an iframe that points to lb?
      • 2020-11-06 31151, 2020

      • alastairp
        and embed that in other domains?
      • 2020-11-06 31134, 2020

      • Mr_Monkey
        I don't know if that'll solve the main issue which is the need for an LB token to get Spotify creds…
      • 2020-11-06 31127, 2020

      • Mr_Monkey
        I'd have to have a look at front-end only auth schemes for spotify, so that maybe we can allow BP itself to support spotify credentials
      • 2020-11-06 31109, 2020

      • alastairp
        but if someone signs into LB and links spotify, and then AB embeds an lb iframe, would that work?
      • 2020-11-06 31116, 2020

      • alastairp
        because it can get the creds directly from lb
      • 2020-11-06 31134, 2020

      • alastairp
        but you're right, frontend spotify auth should help there too
      • 2020-11-06 31145, 2020

      • Mr_Monkey
        I must admit I don't know what would happen with an iframe.
      • 2020-11-06 31124, 2020

      • alastairp
        I think that would be a good thing to look at first, because I have a feeling that it might work
      • 2020-11-06 31129, 2020

      • alastairp
        first - before I even copy it into AB
      • 2020-11-06 31132, 2020

      • shivam-kapila
        pristine___: yikes 500
      • 2020-11-06 31145, 2020

      • shivam-kapila
        ruaok: thanks for the ticket
      • 2020-11-06 31103, 2020

      • shivam-kapila
        I will fix these bugs in recording feedback soonish
      • 2020-11-06 31159, 2020

      • pristine___
        shivam-kapila: I feel that the endpoint nwas designed in way so that it works well with react requests, i.e keeping in mind that users will only interact with these endpoints via the site and not the api itself. That's why we have these sort of bugs, these bugs have been taken care of on the react end, ideally they should have been taken care of in the api script itself
      • 2020-11-06 31125, 2020

      • shivam-kapila
        I dont think so as there's two month gap between the code I wrote for api and react but I will get them done
      • 2020-11-06 31145, 2020

      • pristine___
        I don't understand what the two months gap line mean?
      • 2020-11-06 31116, 2020

      • shivam-kapila
        I mean I didnt have planned them according to react side by side
      • 2020-11-06 31134, 2020

      • shivam-kapila
        Sorry for the bugs will fix them soon
      • 2020-11-06 31148, 2020

      • pristine___
        Ah, cool. That's my general observation after reading react and api stuff. Nevamind
      • 2020-11-06 31149, 2020

      • pristine___
        :)
      • 2020-11-06 31111, 2020

      • pristine___
        No problem. It's good we found out before any user did :)
      • 2020-11-06 31141, 2020

      • shivam-kapila
        8 will work on 748 749 755. Any other related tickets in mind
      • 2020-11-06 31147, 2020

      • shivam-kapila
        ?
      • 2020-11-06 31101, 2020

      • ruaok
        and iliekcomputers and I were part of the discussion and the design of the endpoint changed quite a lot over time.
      • 2020-11-06 31120, 2020

      • ruaok
        its not all shivam-kapila's doing, so for once he's somewhat innocent-ish.
      • 2020-11-06 31129, 2020

      • Mr_Monkey
        ruaok: I've added the license info on https://github.com/metabrainz/metabrainz-logos
      • 2020-11-06 31130, 2020

      • Mr_Monkey
        Will respond to the forum post if that's satisfactory for you.
      • 2020-11-06 31151, 2020

      • ruaok
        +1
      • 2020-11-06 31129, 2020

      • Mr_Monkey
        👍
      • 2020-11-06 31100, 2020

      • pristine___
        shivam-kapila: i have pushed the changes requested by you on #1149, can you approve if you think things are in place.
      • 2020-11-06 31101, 2020

      • chirlu joined the channel
      • 2020-11-06 31129, 2020

      • chirlu has quit