SEARCH-634: Cannot search for partial or exact dates using advanced query syntax anymore
2020-11-20 32518, 2020
_lucifer
ruaok: great! i was thinking of working on the API and third party integration stuff.
2020-11-20 32558, 2020
ruaok
so, python hacking?
2020-11-20 32540, 2020
ruaok
there area lot of tasks for python hacking, I'm thinking of doing two things today: break the python tasks into smaller chunks and prioritize them. and then also start to define the API endpoints.
2020-11-20 32547, 2020
ruaok
so that everyone can start hacking in the morning.
2020-11-20 32506, 2020
_lucifer
yup, python hacking
2020-11-20 32544, 2020
_lucifer
sounds nice, i also have some time today as well so I can start once that is donw
I say “kinda” because if I then create an iframe pointing to `brainzplayer.acousticbrainz.org`, the resulting `origin` I get is the redirected `beta.listenbrainz.org` instead of `brainzplayer.acousticbrainz.org`.
2020-11-20 32538, 2020
Mr_Monkey
Do you know of any way to get the origin of the request before redirection?
2020-11-20 32519, 2020
ruaok
ah, I see.
2020-11-20 32543, 2020
ruaok
zas: this question is more for you.
2020-11-20 32506, 2020
ruaok
this is for the hack with the multiple vhosts. does the gateway set a header that indicates the requested vhost?
2020-11-20 32551, 2020
zas
hmmm I think so, but the best is to display headers received on backend side
2020-11-20 32503, 2020
ruaok
yeah, ok, see what actually gets displayed.
2020-11-20 32510, 2020
Mr_Monkey
As in print them to see what headers get?
2020-11-20 32526, 2020
ruaok
Mr_Monkey: I'm on my way to the office now. let me get there and then I can help you dump the headers if you need help
2020-11-20 32538, 2020
ruaok
Mr_Monkey: yes, that. and see if your answer is there.
2020-11-20 32541, 2020
Mr_Monkey
How about I come over to the office in a bit?
2020-11-20 32548, 2020
ruaok
see ya there!
2020-11-20 32549, 2020
Mr_Monkey
Yeah, let's do that.
2020-11-20 32507, 2020
sumedh joined the channel
2020-11-20 32550, 2020
v6lur joined the channel
2020-11-20 32504, 2020
ruaok
typesense is looking more promising by the minute. #eggciting
2020-11-20 32534, 2020
alastairp
ruaok: cool, I just saw the email. nice to see that you found a bug
2020-11-20 32549, 2020
ruaok
Rebuilding the index with newly gathered info. I think this will work well enough for the hack day for adding tracks.
2020-11-20 32511, 2020
alastairp
perfect
2020-11-20 32515, 2020
alastairp
what tricks did you add?
2020-11-20 32512, 2020
sumedh has quit
2020-11-20 32530, 2020
sumedh joined the channel
2020-11-20 32532, 2020
D4RK-PH0ENiX joined the channel
2020-11-20 32517, 2020
ruaok
well, capitalization matters apparently. so, lowercase, unaccent, remove punctuation.
2020-11-20 32523, 2020
ruaok
lets see how that does
2020-11-20 32544, 2020
BestSteve has quit
2020-11-20 32518, 2020
BestSteve joined the channel
2020-11-20 32505, 2020
ruaok
current_app.logger.info()
2020-11-20 32524, 2020
ruaok
from flask import current_app
2020-11-20 32538, 2020
ruaok
(these are for Mr_Monkey)
2020-11-20 32507, 2020
Mr_Monkey
I'm restarting LB beta
2020-11-20 32516, 2020
ruaok
request.headers.get('your-header-name')
2020-11-20 32520, 2020
v6lur has quit
2020-11-20 32519, 2020
Mr_Monkey
alastairp: That iframe domain trick worked ! Just tested a working iframe implemented on AB.org (manually)
2020-11-20 32538, 2020
alastairp
sweet. what was the specific trick that we're talking about?
is starring a playlist a different action than cloning it? our doc is not very clear on this point, alastairp, Mr_Monkey
2020-11-20 32508, 2020
alastairp
I think it's different
2020-11-20 32519, 2020
alastairp
if you want to star a playlist that isn't yours, you first have to copy it
2020-11-20 32532, 2020
Mr_Monkey
Hm. I think starring is separate (meaning we set a 'starred' flag on a playlist), but it also clones the playlist if it's an auto-generated playlist
2020-11-20 32544, 2020
alastairp
(I'm tending towards preferring 'copy' over clone or fork)
2020-11-20 32551, 2020
ruaok
what does it mean to star a playlist?
2020-11-20 32558, 2020
ruaok
alastairp: agreed on the copy part.
2020-11-20 32510, 2020
Mr_Monkey
That's a pointed question. Not sure what we had in mind.
2020-11-20 32523, 2020
alastairp
was it just to like/favourite?
2020-11-20 32536, 2020
Mr_Monkey
I think so, but does that even make sense?
2020-11-20 32542, 2020
alastairp
especially if it's not your playlist, a way of grouping together playlists that you like that are someone else's
2020-11-20 32552, 2020
alastairp
but if you're copying anyway... that puts it into your account
2020-11-20 32533, 2020
ruaok
exactly. it seems that star is really only to express "I like this playlist".
2020-11-20 32559, 2020
ruaok
but... seems iffy right now. My inclination would be to leave out starring of playlists for now.
2020-11-20 32501, 2020
Mr_Monkey
I think we should forget the starring until we have a good use case for it, and instead make it clear visually that you can make copies of playlists that aren't 'yours' (i.e. saved in your playlists)
2020-11-20 32526, 2020
ruaok
2 say no stars. alastairp?
2020-11-20 32529, 2020
alastairp
agreed
2020-11-20 32537, 2020
ruaok
ok, will nuke from the doc
2020-11-20 32550, 2020
alastairp
a question about copying... will we show playlist author?
2020-11-20 32552, 2020
Mr_Monkey
💣
2020-11-20 32509, 2020
alastairp
if it's copied from someone else, does their name appear?
2020-11-20 32518, 2020
ruaok
alastairp: that was my thought -- at at least with "copied from playlist X"
2020-11-20 32529, 2020
ruaok
which make the author of the playlist discoverable
2020-11-20 32548, 2020
alastairp
so in the datbase, playlist.author would be... ?
2020-11-20 32508, 2020
alastairp
the user who it's saved as, but you could do playlist.copied_from.author to discover original author?
2020-11-20 32515, 2020
Mr_Monkey
that
2020-11-20 32535, 2020
alastairp
and if that user deletes their version?
2020-11-20 32542, 2020
ruaok
copied_from makes sense
2020-11-20 32546, 2020
Mr_Monkey
At the very least we should save that information. We can surface it to the user and see what the feedback is. If it's confusing we can hide it.
2020-11-20 32500, 2020
Mr_Monkey
Well, I guess you get a 404 in that case?
2020-11-20 32511, 2020
ruaok
or "copied from a deleted playlist" ?
2020-11-20 32500, 2020
Mr_Monkey
Yes.
2020-11-20 32534, 2020
Mr_Monkey
That is if we want to check if it exists first, or if we need to make a query to get infor about said playlist anyway for other reasons.
2020-11-20 32506, 2020
Mr_Monkey
Always better not to create 404 links, I guess.
2020-11-20 32501, 2020
ruaok
alastairp: as for the question as to how generated playlists are created....
2020-11-20 32509, 2020
ruaok
Generated playlists will always be owned and managed by the bot user that creates them, I think.
2020-11-20 32528, 2020
ruaok
this way the bot can create and delete as it wishes without problems.
