i have probably debugged the issue with websockets. the client is not sending the correct cors header.
2020-11-21 32635, 2020
ruaok
very good. is it sending the right header now?
2020-11-21 32628, 2020
_lucifer
not yet. trying to work that out now.
2020-11-21 32639, 2020
shalini_ joined the channel
2020-11-21 32604, 2020
shalini__ joined the channel
2020-11-21 32633, 2020
_lucifer
looks like there is more than one issue at play here. LB is using Flask SocketIO for websockets and Flask CORS to handle cors. apparently, socketio does requires independent handling of CORS.
2020-11-21 32623, 2020
_lucifer
I configure Flask SOcketIO to allow cors from * for now. Before that the request was reaching the webserver and returned a 400. After the change, requests are now failing with
ruaok: get playlist by mbid: should it include recordings? Or maybe a flag to say if you want to include them or not. get all playlists for a user? Seems like it shouldn't return recordings in the normal case (e.g. for Mr_Monkey's default view)
2020-11-21 32613, 2020
ruaok
alastairp: flag seems wise, but I suspect I will always want recordings.
2020-11-21 32640, 2020
ruaok
> tried submitting listens to beta but that didn't work.
2020-11-21 32658, 2020
ruaok
_lucifer: did the listens not arrive or the listens arrived, but were not sent via sockets?
2020-11-21 32658, 2020
alastairp
I think default True for single playlist and default False for playlists by a user feels right for now. I'll leave the flag in, and we can revisit it later
2020-11-21 32612, 2020
_lucifer
ruaok: the sockets thing did not work,
2020-11-21 32622, 2020
ruaok
ok, thats good.
2020-11-21 32640, 2020
_lucifer
the listen showed up in BP but sockets still error out on beta.
2020-11-21 32649, 2020
ruaok
and sockets.listenbrainz.org is for production, so errors there should, at least in theory not be a problem right this sec.
2020-11-21 32601, 2020
ruaok
what error do you get on beta?
2020-11-21 32623, 2020
alastairp
ruaok: next: get playlists (plural) for a user - for the requesting user, this would include private playlists, but if it's for a different user you won't want to show the private ones. Do you want to filter that in sql, or in the api view?
Mr_Monkey: console shows Failed to execute 'postMessage' on 'DOMWindow': The target origin provided ('https://www.youtube.com') does not match the recipient window's origin ('https://beta.listenbrainz.org').
2020-11-21 32659, 2020
shivam-kapila
_lucifer: that occurs most of the time
2020-11-21 32659, 2020
Mr_Monkey
Yeah, I've seen some of those errors. Ignore them for now, I'll get to it. As far as I could tell it doesn't prevent the youtube player from working
2020-11-21 32630, 2020
shivam-kapila
Mr_Monkey: things going good. I will show something in some time
2020-11-21 32644, 2020
Mr_Monkey
Any blockers?
2020-11-21 32649, 2020
shivam-kapila is high on loads of coffee
2020-11-21 32651, 2020
Mr_Monkey
(or questions?)
2020-11-21 32627, 2020
shivam-kapila
Mr_Monkey: none yet. but I think I will soonish
2020-11-21 32637, 2020
Mr_Monkey
Cool :)
2020-11-21 32657, 2020
_lucifer
ruaok: can you check the follow server logs again when possible. this issue seems to be unrelated to the websockets issue
