#metabrainz

/

      • antlarr has quit
      • 2020-12-03 33850, 2020

      • antlarr joined the channel
      • 2020-12-03 33803, 2020

      • Nyanko-sensei has quit
      • 2020-12-03 33854, 2020

      • Nyanko-sensei joined the channel
      • 2020-12-03 33810, 2020

      • davic has quit
      • 2020-12-03 33850, 2020

      • sumedh joined the channel
      • 2020-12-03 33856, 2020

      • niceplace has quit
      • 2020-12-03 33829, 2020

      • niceplace joined the channel
      • 2020-12-03 33818, 2020

      • reosarevok
        ruaok: don't forget to transclude https://wiki.musicbrainz.org/jspf?diff=74928&… if it is ready
      • 2020-12-03 33842, 2020

      • shivam-kapila
        _lucifer: in fam
      • 2020-12-03 33845, 2020

      • thomasross has quit
      • 2020-12-03 33836, 2020

      • sumedh has quit
      • 2020-12-03 33827, 2020

      • yvanzo
        mo’’in’
      • 2020-12-03 33858, 2020

      • davic joined the channel
      • 2020-12-03 33804, 2020

      • yvanzo
        nobodyrocks[m]: can you please provide more info? which version of musicbrainz-docker are you using? which command did you run?
      • 2020-12-03 33856, 2020

      • yvanzo
        It looks like the 'db' service took more than 1min to get ready, so either it is slower than expected or something is blocking it.
      • 2020-12-03 33831, 2020

      • yvanzo
        It is usually ready for use within a few seconds at most.
      • 2020-12-03 33834, 2020

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1149 (rec-component-feedback…sync-feedback): Sync recommendation feedback with emoticons https://github.com/metabrainz/listenbrainz-server…
      • 2020-12-03 33845, 2020

      • zas
        bitmap: floyd sda6 is almost full, can you have a look
      • 2020-12-03 33814, 2020

      • zas
        most of disk space is used by /var/lib/docker/volumes/pgdata-floyd
      • 2020-12-03 33850, 2020

      • zas
        there's still 200Gb used by 9.5-backup though
      • 2020-12-03 33818, 2020

      • zas
        disk usage increased a lot since 2 days
      • 2020-12-03 33845, 2020

      • zas
        it will error if it continues growing before tomorrow
      • 2020-12-03 33808, 2020

      • zas
        yvanzo: can you have a look?
      • 2020-12-03 33800, 2020

      • sumedh joined the channel
      • 2020-12-03 33800, 2020

      • thallada has quit
      • 2020-12-03 33807, 2020

      • Gazooo79494 joined the channel
      • 2020-12-03 33838, 2020

      • sumedh has quit
      • 2020-12-03 33836, 2020

      • d4rkie joined the channel
      • 2020-12-03 33814, 2020

      • Nyanko-sensei has quit
      • 2020-12-03 33835, 2020

      • sumedh joined the channel
      • 2020-12-03 33808, 2020

      • v6lur joined the channel
      • 2020-12-03 33833, 2020

      • xuvatilavv joined the channel
      • 2020-12-03 33815, 2020

      • BrainzGit
        [critiquebrainz] alastair merged pull request #321 (master…exception-handler): CB-402: Take error argument in error handlers https://github.com/metabrainz/critiquebrainz/pull…
      • 2020-12-03 33816, 2020

      • BrainzGit
        [critiquebrainz] alastair merged pull request #322 (master…unknown-entities-cache): Update tests for unknown_entities_for_missing=True fix https://github.com/metabrainz/critiquebrainz/pull…
      • 2020-12-03 33838, 2020

      • BrainzGit
        [critiquebrainz] alastair opened pull request #323 (master…style-fixes): Address pylint and flake8 messages https://github.com/metabrainz/critiquebrainz/pull…
      • 2020-12-03 33832, 2020

      • yvanzo
        zas: The increase is huge (~100GB) but there is no such increase in MBDB tables.
      • 2020-12-03 33843, 2020

      • yvanzo
        The latest addition 'recording_first_release_date' takes less than 1GB and has been deployed last week (not two days ago).
      • 2020-12-03 33806, 2020

      • ruaok
      • 2020-12-03 33827, 2020

      • ruaok
        do all the endpoints that have POST also require OPTIONS?
      • 2020-12-03 33838, 2020

      • ruaok
        maybe I am missing a decorator?
      • 2020-12-03 33848, 2020

      • alastairp
        that's a great question
      • 2020-12-03 33837, 2020

      • alastairp
        there is a set of "standard headers", and if your request only uses those ones, you don't need to do OPTIONS.
      • 2020-12-03 33807, 2020

      • alastairp
        however, I believe we set the content-type header to application/json, which is "non-standard", so the answer to your question is probably "yes, you are missing a decorator"
      • 2020-12-03 33837, 2020

      • sumedh has quit
      • 2020-12-03 33845, 2020

      • ruaok
        I have `@crossdomain(headers="Authorization, Content-Type")` but not method OPTIONS.
      • 2020-12-03 33802, 2020

      • ruaok
        I guess that the decorator doesn't add the OPTIONS method.
      • 2020-12-03 33816, 2020

      • alastairp
        yeah, I think this is the same thing we ran into in the dataset hoster, too
      • 2020-12-03 33821, 2020

      • alastairp
        yes, we had to add method OPTIONS
      • 2020-12-03 33842, 2020

      • alastairp
        you're right, it could be interesting to see if we can modify that decorator to insert the method if it's not there. would that be too much magic?
      • 2020-12-03 33811, 2020

      • ruaok
      • 2020-12-03 33828, 2020

      • ruaok
        too much magic yes.
      • 2020-12-03 33850, 2020

      • ruaok
        I see that POSTs have OPTIONS. but why does feed/listens have it?
      • 2020-12-03 33805, 2020

      • ruaok
        and latest-import.
      • 2020-12-03 33818, 2020

      • ruaok
        I'll just add them to all endpoints.
      • 2020-12-03 33840, 2020

      • alastairp
        GET requests can trigger an OPTIONS too
      • 2020-12-03 33831, 2020

      • ruaok
        create, delete work now.
      • 2020-12-03 33843, 2020

      • alastairp
        👍
      • 2020-12-03 33826, 2020

      • ruaok
        looking pretty good!
      • 2020-12-03 33804, 2020

      • ruaok
      • 2020-12-03 33835, 2020

      • ruaok
        Mr_Monkey: can you please clear the last search terms if the last search ended up in a track being selected and added to the playlist?
      • 2020-12-03 33857, 2020

      • shivam-kapila
        Whats that ?
      • 2020-12-03 33815, 2020

      • ruaok
      • 2020-12-03 33828, 2020

      • shivam-kapila
        No the question mark in the card
      • 2020-12-03 33827, 2020

      • alastairp
        who's on first?
      • 2020-12-03 33830, 2020

      • shivam-kapila
      • 2020-12-03 33806, 2020

      • alastairp
        whoops. still a bit buggy
      • 2020-12-03 33812, 2020

      • ruaok
        alastairp: how do I create sentry IDs to test? it seems to be using beta.lb's keys.
      • 2020-12-03 33838, 2020

      • ruaok
        I'm happy *something* is working.
      • 2020-12-03 33846, 2020

      • alastairp
        ruaok: top right, add new -> project
      • 2020-12-03 33850, 2020

      • alastairp
      • 2020-12-03 33803, 2020

      • ruaok
        thx
      • 2020-12-03 33817, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1803 (master…mbs-11241): MBS-11241: Seed annotation, edit_note with textarea https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-03 33830, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1813 (beta…beta-cookie-samesite-none): Set SameSite=None on beta cookie https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-03 33836, 2020

      • shivam-kapila
        No login button on test.lb.org
      • 2020-12-03 33811, 2020

      • ruaok
        shivam-kapila: hang on reporting issues on test.lb for now.
      • 2020-12-03 33823, 2020

      • Mr_Monkey
        ruaok: Sure, I'll have a look at that select, it's been bugging me too.
      • 2020-12-03 33829, 2020

      • ruaok
        I'm still in the process of basic setup and it really isn't ready for others to chime in yet.
      • 2020-12-03 33834, 2020

      • ruaok
        Mr_Monkey: thanks!
      • 2020-12-03 33838, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1809 (master…editor-data-handling): Improvements to editor JSON handling https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-03 33838, 2020

      • shivam-kapila
        Sorry
      • 2020-12-03 33805, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1791 (master…MBS-10590): MBS-10590: Implement IROMBOOK images for instruments https://github.com/metabrainz/musicbrainz-server/…
      • 2020-12-03 33804, 2020

      • reosarevok
        CatQuest: ^
      • 2020-12-03 33822, 2020

      • CatQuest
        :o
      • 2020-12-03 33857, 2020

      • alastairp
        _lucifer: if you have 5 minutes, it'd be great to get your feedback on https://github.com/metabrainz/critiquebrainz/pull…, then we can fix the failing lint checks
      • 2020-12-03 33805, 2020

      • alastairp
        Mr_Monkey: hello
      • 2020-12-03 33813, 2020

      • Mr_Monkey
        Hallo !
      • 2020-12-03 33819, 2020

      • alastairp
        I'm looking at moving the lb frontend tests to jenkins
      • 2020-12-03 33846, 2020

      • alastairp
      • 2020-12-03 33824, 2020

      • alastairp
        do you know how node testing tools report failures to upstream tools? in pytest we can output 'junit format' log files, which jenkins can read and display nicely
      • 2020-12-03 33800, 2020

      • Mr_Monkey
        Let me look at what we o with BB
      • 2020-12-03 33804, 2020

      • Mr_Monkey
        do*
      • 2020-12-03 33809, 2020

      • alastairp
        it looks like https://github.com/jest-community/jest-junit does what I need
      • 2020-12-03 33821, 2020

      • alastairp
        I don't know if something like that is set up already
      • 2020-12-03 33848, 2020

      • _lucifer
        alastairp: the changes look fine to me. regarding the no-self check, how about we disable that for only the specific test class/file ?
      • 2020-12-03 33819, 2020

      • alastairp
        _lucifer: mmm, sure. I'm not really convinced either way though
      • 2020-12-03 33837, 2020

      • Mr_Monkey
        To be honest, I don't know more than you do.
      • 2020-12-03 33837, 2020

      • alastairp
        especially given that we don't really use classes anywhere else in CB
      • 2020-12-03 33800, 2020

      • alastairp
        Mr_Monkey: ok, no problem. when I look at it in more detail I'll poke you if I need any js help
      • 2020-12-03 33816, 2020

      • Mr_Monkey
        Sure thing
      • 2020-12-03 33830, 2020

      • _lucifer
        alastairp: my thinking is that we should have such checks in production code but may disable for tests as desired.
      • 2020-12-03 33858, 2020

      • alastairp
        _lucifer: ok, sure. you've convinced me
      • 2020-12-03 33812, 2020

      • Mr_Monkey
        alastairp: After a quick look, it does look like `jest --reporters="jest-junit"` is indeed what you need
      • 2020-12-03 33828, 2020

      • alastairp
        and that'll write a file somewhere?
      • 2020-12-03 33802, 2020

      • Mr_Monkey
        Yep. There's options you can pass (or with env variables) to control where
      • 2020-12-03 33822, 2020

      • Mr_Monkey
        `JEST_JUNIT_OUTPUT_DIR`
      • 2020-12-03 33836, 2020

      • Mr_Monkey
        etc;
      • 2020-12-03 33853, 2020

      • alastairp
        perfect
      • 2020-12-03 33816, 2020

      • alastairp
        I'm looking at format:ci and type-check. There is a warning messages parser for 'jslint', but we're using 'eslint'. Do you know if their output is the same?
      • 2020-12-03 33830, 2020

      • alastairp
        I need to see if it will deal with tsc output too. Will look into it later
      • 2020-12-03 33858, 2020

      • bitmap
        https://ci.metabrainz.org/job/listenbrainz-unit/2… is stuck on "Cannot import config.py. Waiting and retrying..."
      • 2020-12-03 33816, 2020

      • bitmap
        I canceled the built to clear up the queue
      • 2020-12-03 33845, 2020

      • alastairp
        thanks, I saw the message, but kind of assumed that it would stop after 10 tries or something
      • 2020-12-03 33846, 2020

      • alastairp
        sorry about that
      • 2020-12-03 33829, 2020

      • alastairp
        I added a fix to the PR that I have open, I'll get that merged so that other test runs don't have the same problem
      • 2020-12-03 33823, 2020

      • sumedh joined the channel
      • 2020-12-03 33825, 2020

      • Mr_Monkey
        ruaok: pushed a fix for clearing that select
      • 2020-12-03 33832, 2020

      • ruaok
        thanks!
      • 2020-12-03 33837, 2020

      • Mr_Monkey
        NP
      • 2020-12-03 33855, 2020

      • ruaok
        I'm still debugging various bits here and there.
      • 2020-12-03 33852, 2020

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1196 (master…initdb): name the timescale init_db method differently https://github.com/metabrainz/listenbrainz-server…
      • 2020-12-03 33808, 2020

      • BrainzGit
        [critiquebrainz] alastair merged pull request #323 (master…style-fixes): Address pylint and flake8 messages https://github.com/metabrainz/critiquebrainz/pull…
      • 2020-12-03 33801, 2020

      • sumedh has quit
      • 2020-12-03 33820, 2020

      • v6lur has quit
      • 2020-12-03 33811, 2020

      • sumedh joined the channel
      • 2020-12-03 33848, 2020

      • ruaok snaps and opens https://github.com/metabrainz/openresty-gateways/pull/4
      • 2020-12-03 33824, 2020

      • alastairp
        fiiiiinaly!
      • 2020-12-03 33837, 2020

      • ruaok
        heh, I couldn't stand it anymore.
      • 2020-12-03 33810, 2020

      • alastairp
      • 2020-12-03 33850, 2020

      • ruaok
        ohhh, neat. first impressions?
      • 2020-12-03 33806, 2020

      • alastairp
        of course the texture isn't like paper, as much as they claim it is
      • 2020-12-03 33812, 2020

      • alastairp
        but the response time is really good
      • 2020-12-03 33836, 2020

      • ruaok
        I've tried a tablet for notetaking and its just... not enough.
      • 2020-12-03 33835, 2020

      • alastairp
        it's got a pdf reader in it too, which I'm looking forward to trying
      • 2020-12-03 33852, 2020

      • ruaok
        ohhh, now're you're getting my attention.
      • 2020-12-03 33857, 2020

      • alastairp
        I don't read many academic papers any more, but it's much bigger than a kindle, and you can markup on it!
      • 2020-12-03 33802, 2020

      • ruaok
        reading long PDFs is currently a real pain.
      • 2020-12-03 33822, 2020

      • shivam-kapila can related
      • 2020-12-03 33825, 2020

      • shivam-kapila
        Relate*
      • 2020-12-03 33827, 2020

      • alastairp
        I'll bring it in next week
      • 2020-12-03 33827, 2020

      • ruaok
        I'm curious how that performs.
      • 2020-12-03 33830, 2020

      • ruaok
        nice!
      • 2020-12-03 33852, 2020

      • ruaok
        price tag is a bit much for an xmas present, sadly.
      • 2020-12-03 33800, 2020

      • alastairp
        yeah
      • 2020-12-03 33804, 2020

      • ruaok
        hmm, if I band my mother and my partners together... hmmm.
      • 2020-12-03 33826, 2020

      • alastairp
        they were doing some launch sales back when I bought it, so something was a bit cheaper...
      • 2020-12-03 33850, 2020

      • ruaok
        do you need their stylus? 60eur seems a bit steep.
      • 2020-12-03 33818, 2020

      • alastairp
        not clear. I tried with a finger and it didn't work
      • 2020-12-03 33836, 2020

      • alastairp
      • 2020-12-03 33855, 2020

      • alastairp
        oh, they're really good on open source too - lots of stuff is published, and the bootloader is open