ruaok: ^ that's me uploading a 15gb file to google docs... :)
2020-12-07 34215, 2020
alastairp
not great to hear that the cable didn't work for you. crappy ISP router?
2020-12-07 34205, 2020
v6lur joined the channel
2020-12-07 34232, 2020
ruaok
ha, nice, alastairp
2020-12-07 34221, 2020
ruaok
I've seen 600 mb from my router, so that is not likely it. I should move my router back with the cable I had it on and check to make sure it gets a gig net connection.
2020-12-07 34238, 2020
kgz has quit
2020-12-07 34230, 2020
kgz joined the channel
2020-12-07 34257, 2020
yokel has quit
2020-12-07 34226, 2020
ruaok
alastairp: nudge nudge, please review mbid-mapping soon. or let me merge it and then do your typical post mortem review...
2020-12-07 34236, 2020
alastairp
ruaok: yep, planning those two reviews for this afternoon
2020-12-07 34204, 2020
ruaok
thx
2020-12-07 34236, 2020
ruaok
I'm finishing out the last board bit of business for the year and then I'll have a look at your work on the playlist PR.
2020-12-07 34225, 2020
sumedh has quit
2020-12-07 34213, 2020
ruaok
Mr_Monkey: ping
2020-12-07 34236, 2020
Mr_Monkey
pong
2020-12-07 34254, 2020
ruaok
I'm reading your playlist.py view code.
2020-12-07 34207, 2020
ruaok
that one code block looks quite familiar. :)
2020-12-07 34246, 2020
ruaok
but it raised one issue with me -- when I wrote that block I missed an important part..
2020-12-07 34223, 2020
ruaok
namely if a playlist is public, but the person who loaded the page is not the owner of the playlist, they should not be able to edit the playlist. are you taking care of that in the front end?
2020-12-07 34248, 2020
ruaok
(it is taken care of by the backend, but it would be better to now allow the user to attempt it if they are not allowed to do it)
2020-12-07 34250, 2020
Mr_Monkey
Users shouldn't see any buttons to edit or delete a playlist that is not theirs, but that could always be bypassable, let me see if I do any other check
2020-12-07 34243, 2020
ruaok
perfect. that is all we need. the API will be the final enforcer.
2020-12-07 34207, 2020
Mr_Monkey
So indeed a user would need to be very crafty to show edit/delete UI if they are not the owner, but I'll also add some more checks if I'm missing any before API calls.
2020-12-07 34218, 2020
d4rkie joined the channel
2020-12-07 34229, 2020
Nyanko-sensei has quit
2020-12-07 34229, 2020
Mr_Monkey
OK ruaok, that's pushed.
2020-12-07 34238, 2020
ruaok
kewl
2020-12-07 34226, 2020
bitmap
zas: when you're around I can try re-enabling the archive_command and seeing if's unstuck
No mailed in reviews, and alastairp requested to go early, so…
2020-12-07 34209, 2020
Freso
alastairp: Go!
2020-12-07 34209, 2020
Freso
(Others up for reviews: bitmap, reosarevok, Freso, Mr_Monkey, ruaok, yvanzo, zas, shivam-kapila, jmp_music, CatQuest – anyone else who wish to give review, please let me know ASAP!)
2020-12-07 34217, 2020
alastairp
hi there!
2020-12-07 34220, 2020
CatQuest
:D
2020-12-07 34234, 2020
yvanzo
hi alastairp!
2020-12-07 34250, 2020
alastairp
last week I got listenbrainz tests working on jenkins, to avoid the slowdowns on travis
2020-12-07 34259, 2020
alastairp
I reviewed some CB pull requests
2020-12-07 34209, 2020
thomasross joined the channel
2020-12-07 34234, 2020
alastairp
and had a quick look at some playlist PRs that ruaok opened, but am behind on them. Planning on finishing that this evening
2020-12-07 34215, 2020
alastairp
we ran into some issues in LB with a new version of pip being released, and breaking some things. I spent some time trying to unwind the interaction between pip, brainzutils, and listenbrainz. almost got that cleaned up
2020-12-07 34237, 2020
alastairp
this coming week will probably be quieter, because tomorrow is a holiday and today is the day between the weekend and holiday that everyone takes off anyway
2020-12-07 34246, 2020
alastairp
bitmap: next
2020-12-07 34257, 2020
bitmap
hey
2020-12-07 34216, 2020
bitmap
last week I finished working on/updating PRs for MBS-11092 and the improvements to editor JSON handling
those were deployed to beta and should all get released today
2020-12-07 34247, 2020
bitmap
did a bunch of code review, caught up on most recent MBS PRs I think
2020-12-07 34215, 2020
bitmap
made some fixes to our postgres setup, firstly making sure the services come back up if the containers are restarted (which happened on accident recently), and updating syswiki to document how to bring those up
2020-12-07 34252, 2020
bitmap
yesterday I was helping debug issues with the postgres WAL archive_command, and important part of our backup system, which broke due to a missing environment variable
2020-12-07 34215, 2020
bitmap
it seems to be resolved as of today, but it's unclear why the environment changed. I guess it happened when the containers restarted
2020-12-07 34230, 2020
bitmap
that's mostly it I think, so fin! reosarevok go
2020-12-07 34236, 2020
reosarevok
Hi!
2020-12-07 34205, 2020
reosarevok
I spent some time on a couple tickets that had a lot of votes but hadn't been looked at recently: MBS-8371 / MBS-4548
