Just submitted my first PR to CB repo. How much time am I supposed to wait for a review/response before nudging someone? (I looked for this info in the contributing docs but couldn't find anything)
2020-12-22 35723, 2020
sumedh joined the channel
2020-12-22 35713, 2020
ultra_ joined the channel
2020-12-22 35702, 2020
ultra has quit
2020-12-22 35703, 2020
ultra_ is now known as ultra
2020-12-22 35758, 2020
alastairp
ultra: 6 minutes is a bit too short ;) The general answer is "when I have some time", but I'll try and get to it today - it looks like a small fix, thanks!
it's OK, you have write access, but you don't have write access to master!
2020-12-22 35703, 2020
alastairp
and it already prevents force pushes
2020-12-22 35740, 2020
_lucifer
strange the master shows me the commits from the mock test PR
2020-12-22 35722, 2020
alastairp
on your machine, or on github?
2020-12-22 35752, 2020
_lucifer
on github
2020-12-22 35732, 2020
alastairp
mm, weird
2020-12-22 35754, 2020
alastairp
let's leave it 20 minutes and see if any caches have to expire...
2020-12-22 35720, 2020
_lucifer
okay
2020-12-22 35730, 2020
alastairp
master definitely didn't update when I fetched from it using git
2020-12-22 35737, 2020
alastairp
so I'm tempted to say that it's fine
2020-12-22 35753, 2020
alastairp
paste me your terminal output?
2020-12-22 35731, 2020
alastairp
on https://github.com/metabrainz/critiquebrainz/pull… it says "amCap1712 force-pushed the amCap1712:CB-388 branch from 14a255e to 572a1e4 32 minutes ago", so you did do a force push, but only to this branch on your fork
Not sure how but I borked my Listenbrainz work folder with static builder stuck at 95% every time.
2020-12-22 35755, 2020
Mr_Monkey
Nothing I tried fixed it
2020-12-22 35709, 2020
Mr_Monkey
Is it building OK for you ruaok ?
2020-12-22 35754, 2020
Mr_Monkey
i.e. does `./develop.sh up` work, allowing static_builder to finish building the js files, and visiting localhost works ?
2020-12-22 35754, 2020
Mr_Monkey
Hm, might be a docker issue, my local folders aren't mounted it looks like
2020-12-22 35716, 2020
alastairp
everyone who upgraded docker to 3.0!
2020-12-22 35718, 2020
Mr_Monkey
Sure enough. Docker updates are a bit hit and miss I find
2020-12-22 35729, 2020
alastairp
I'm happy that I stayed on 2!
2020-12-22 35717, 2020
shivam-kapila
ruaok: thanks. feels refreshing to see what I listened to
2020-12-22 35734, 2020
ruaok
Mr_Monkey: uninstall docker, remove it's container files and then reinstall.
2020-12-22 35745, 2020
Mr_Monkey
I fixed it. Updated Docker
2020-12-22 35735, 2020
Mr_Monkey
I pushed the change you requested with the edit playlist API endpoint (public in extension)
2020-12-22 35742, 2020
Mr_Monkey
And found another small bug: I can't remove the last collaborator of a playlist, meaning when I pass an empty array (no collaborators), I think the api endpoint just ignores it instead of treating it as the new (empty) list of collaborators
2020-12-22 35729, 2020
alastairp
oh yeah, because we check for `if collaborators`
2020-12-22 35735, 2020
alastairp
I'll fix it
2020-12-22 35703, 2020
Mr_Monkey
Kewl
2020-12-22 35729, 2020
ruaok
how are things now? need anything from me?
2020-12-22 35704, 2020
alastairp
I've lost an API method, but I don't need help from you to find it
2020-12-22 35712, 2020
ruaok
I was hoping to make a playlist from "tracks releases in 2020 that you played a lot" but I have yet to see a playlist from anyone who does have a track of 2020 in it. seems like a dead end. #thanks2020
2020-12-22 35736, 2020
ruaok
I will hack out the "top tracks of 2020" playlist, but that is all I have planned right now.
2020-12-22 35746, 2020
ruaok
I was hoping to have at least one more playlist for people.
2020-12-22 35743, 2020
ruaok
ah. Mr_Monkey's suggestion of top tracks overall.
2020-12-22 35730, 2020
zas
ruaok: I proceeded with bono, upgrades done, ideally we should reboot it
2020-12-22 35723, 2020
ruaok
ok, I can do that.
2020-12-22 35707, 2020
ruaok
_lucifer: alastairp : you two have long idle tmux instances.
2020-12-22 35716, 2020
ruaok
alastairp has on that has been idle 222 days.
2020-12-22 35728, 2020
alastairp
closed
2020-12-22 35746, 2020
ruaok
thanks.
2020-12-22 35755, 2020
ruaok
all of _lucifer are 80 days old.
2020-12-22 35710, 2020
ruaok reboots
2020-12-22 35705, 2020
ruaok
ok, bono is back up. alastairp not sure if you need to restart any services..
I keep getting distracted from that. Can you remind me once these playlists are released?
2020-12-22 35714, 2020
ruaok
alastairp: ^
2020-12-22 35718, 2020
alastairp
can do
2020-12-22 35721, 2020
alastairp
thx
2020-12-22 35703, 2020
alastairp looks at Mr_Monkey's camelCaseVariables in python code
2020-12-22 35724, 2020
Mr_Monkey
*hrm hrm*
2020-12-22 35702, 2020
Mr_Monkey
oneCaseToRuleThemAll
2020-12-22 35745, 2020
alastairp
I've pushed the `include_private` flag in get_playlists_collaborated_on, and passed the variable in on the API and the html view
2020-12-22 35757, 2020
alastairp
Mr_Monkey: I updated the logic to compute this flag, I think it's correct
2020-12-22 35714, 2020
alastairp
I have a call now, I'll do the "remove last collaborator" fix after that
2020-12-22 35732, 2020
ruaok
alastairp: anything I need to do after this push?
2020-12-22 35741, 2020
alastairp
no, I've fixed both sides
2020-12-22 35746, 2020
ruaok
thx
2020-12-22 35737, 2020
sumedh has quit
2020-12-22 35752, 2020
sumedh joined the channel
2020-12-22 35706, 2020
alastairp
ruaok: what's the minimum data required to edit a playlist?
2020-12-22 35730, 2020
alastairp
e.g. I want to just change the collaborators, so I just send the collaborators extension, but it fails validation because it says that "public" is required
2020-12-22 35751, 2020
alastairp
I would think that if you don't want to edit that field, you shouldn't have to send it. What do you think?
2020-12-22 35757, 2020
ruaok
agreed.
2020-12-22 35704, 2020
alastairp
ok. will fix
2020-12-22 35708, 2020
ruaok
I think validate playlist needs a flag about checking public.
alastairp: i tried increasing the timeout but it still doesn't work. two things I am doubtful about.
2020-12-22 35712, 2020
ballin joined the channel
2020-12-22 35725, 2020
ballin
parsing listenbrainz data. i'm getting worse results searching MB with 6 fields (artist, release, track, x2 for the MBIDs) than with just the IDs. does boosting work on the API via Lucene? https://lucene.apache.org/core/7_7_2/queryparser/…
ballin: what is your use case for searching using solr? if you're looking up tracks to find MBIDs, this endpoint will give better results: https://datasets.listenbrainz.org/acrm-search
2020-12-22 35733, 2020
zas
yvanzo: restarting sir-prod worked, queue was consumed
2020-12-22 35745, 2020
ballin
last fm import - i have track IDs which aren't always strictly correct (last fm providing bad data) and 50% of the data has no IDs
2020-12-22 35708, 2020
ruaok
yep, use the endpoint I linked. the best tool we have to date.
2020-12-22 35714, 2020
yvanzo
zas: thanks
2020-12-22 35701, 2020
yvanzo
zas: upgrade to py3 is stalling but a py2 upgrade is planned
2020-12-22 35712, 2020
ballin
"Name or service not known" off to a good start :p
