14:27 PM
alastairp
đź‘Ť modifications to that file look fine to me, then. and we know that it generates valid python because we've already released in test
2020-12-23 35825, 2020
14:27 PM
ruaok
ok, then merge into prod again.
2020-12-23 35824, 2020
14:28 PM
alastairp
waiting for tests
2020-12-23 35834, 2020
14:28 PM
ruaok
2020-12-23 35853, 2020
14:28 PM
ruaok
should I run the update script against TS?
2020-12-23 35805, 2020
14:29 PM
alastairp
yes please
2020-12-23 35807, 2020
14:29 PM
ruaok
k
2020-12-23 35831, 2020
14:31 PM
alastairp
seeing sporadic test failures, but they've not happened before so I'm tempted to go on without them
2020-12-23 35837, 2020
14:31 PM
ruaok
> psql -U listenbrainz_ts listenbrainz_ts < /tmp/2020-11-21-playlists.sql
2020-12-23 35846, 2020
14:31 PM
ruaok
inside the timescale container. that look sane?
2020-12-23 35802, 2020
14:32 PM
ruaok
the sql file was taken from master just now.
2020-12-23 35829, 2020
14:32 PM
alastairp
Mr_Monkey: one thing if you have time - would be nice for you to verify that the ci js failure isn't urgent:
2020-12-23 35832, 2020
14:32 PM
alastairp
2020-12-23 35846, 2020
14:32 PM
alastairp
ruaok: fine
2020-12-23 35857, 2020
14:32 PM
ruaok
executed without errors.
2020-12-23 35851, 2020
14:33 PM
ruaok
2020-12-23 35825, 2020
14:34 PM
alastairp
I don't know if iliekcomputer normally added lineitems for all PRs to the release notes, or if he just copied big features
2020-12-23 35838, 2020
14:34 PM
ruaok
not sure.
2020-12-23 35802, 2020
14:35 PM
alastairp
I'm going to add a top section with some interesting new features, and then just leave everything else in-place
2020-12-23 35809, 2020
14:35 PM
ruaok
k
2020-12-23 35850, 2020
14:35 PM
alastairp
merging
2020-12-23 35856, 2020
14:35 PM
ruaok
should we update all prod containers?
2020-12-23 35811, 2020
14:36 PM
ruaok
or just -web?
2020-12-23 35813, 2020
14:36 PM
alastairp
what do you mean?
2020-12-23 35820, 2020
14:36 PM
ruaok
which containers do we restart today?
2020-12-23 35823, 2020
14:36 PM
alastairp
they're all based on the same container, right? I'd do all of them
2020-12-23 35829, 2020
14:36 PM
ruaok
2020-12-23 35829, 2020
14:36 PM
alastairp
urg, based on the same image
2020-12-23 35832, 2020
14:36 PM
ruaok
ok.
2020-12-23 35857, 2020
14:36 PM
alastairp
I don't know why there are different versions here
2020-12-23 35814, 2020
14:37 PM
ruaok
because not all containers are always updated.
2020-12-23 35824, 2020
14:37 PM
ruaok
but I feel you, lets update all.
2020-12-23 35808, 2020
14:38 PM
alastairp
alternatively, if you want to do it in stages upgrade all there to the current most recent push (v-2020-11-20.0 ?) , and then another one with today
2020-12-23 35836, 2020
14:38 PM
alastairp
how are you time-wise? I don't want to release now only to have things fall apart with 5 minutes before you have to walk out the door
2020-12-23 35857, 2020
14:38 PM
ruaok
we're at exactly that point, sadly.
2020-12-23 35843, 2020
14:39 PM
ruaok
not wise, but the limited time I have remaining past curfew today is to run troi and to announce the playlists tomorrow.
2020-12-23 35859, 2020
14:39 PM
ruaok
I think we'll be fine. <famous last words>
2020-12-23 35804, 2020
14:40 PM
alastairp
OK. going ahead with merge
2020-12-23 35828, 2020
14:40 PM
BrainzGit
2020-12-23 35852, 2020
14:40 PM
ruaok
actually to minimize possible screw ups, lets just update -web container.
2020-12-23 35857, 2020
14:40 PM
alastairp
k
2020-12-23 35800, 2020
14:41 PM
ruaok
I dont think we have changes for other containers.
2020-12-23 35811, 2020
14:41 PM
alastairp
tagging v-2020-12-23.0
2020-12-23 35820, 2020
14:41 PM
ruaok
perfect.
2020-12-23 35824, 2020
14:41 PM
ruaok
is it pushed?
2020-12-23 35831, 2020
14:41 PM
alastairp
tag pushed, building image
2020-12-23 35853, 2020
14:43 PM
ruaok
reviewing the changelog, just updating -web makes sense to me.
2020-12-23 35839, 2020
14:44 PM
alastairp
publishing release on github
2020-12-23 35844, 2020
14:44 PM
BrainzGit
2020-12-23 35836, 2020
14:47 PM
ruaok
how goes the build?
2020-12-23 35810, 2020
14:48 PM
alastairp
metabrainz/listenbrainz:v-2020-12-23.0 pushed
2020-12-23 35820, 2020
14:48 PM
ruaok
here goes nothing.
2020-12-23 35855, 2020
14:48 PM
ruaok
pulling services.
2020-12-23 35816, 2020
14:50 PM
ruaok
stopping prod
2020-12-23 35838, 2020
14:51 PM
ruaok
done
2020-12-23 35850, 2020
14:51 PM
alastairp
2020-12-23 35804, 2020
14:52 PM
ruaok
woo!
2020-12-23 35813, 2020
14:52 PM
alastairp
2020-12-23 35815, 2020
14:52 PM
alastairp
fuck yeah
2020-12-23 35821, 2020
14:52 PM
alastairp
why did we ever doubt ourselves?
2020-12-23 35832, 2020
14:52 PM
ruaok
because we fuck up at times.
2020-12-23 35835, 2020
14:52 PM
ruaok
well done, alastairp!
2020-12-23 35839, 2020
14:52 PM
ruaok
well done Mr_Monkey!
2020-12-23 35845, 2020
14:52 PM
ruaok
well done shivam-kapila !
2020-12-23 35852, 2020
14:52 PM
ruaok
well done _lucifer
2020-12-23 35814, 2020
14:53 PM
ruaok
right, thanks for this, alastairp. I'm out.
2020-12-23 35825, 2020
14:53 PM
ruaok
I'll push the recommendations starting tonight.
2020-12-23 35833, 2020
14:53 PM
alastairp
I'm here all day
2020-12-23 35839, 2020
14:53 PM
alastairp
you'll be at monkey house?
2020-12-23 35846, 2020
14:53 PM
ruaok
yeah. you?
2020-12-23 35847, 2020
14:53 PM
alastairp
whatsapp me if there's a problem
2020-12-23 35854, 2020
14:53 PM
ruaok
ok.
2020-12-23 35800, 2020
14:54 PM
alastairp
he's got my number
2020-12-23 35825, 2020
14:54 PM
alastairp
L is finally off school / work for the year, so we're taking it easy
2020-12-23 35828, 2020
14:54 PM
alastairp
have a good night!
2020-12-23 35841, 2020
14:54 PM
ruaok
thanks much. ttfn!
2020-12-23 35847, 2020
14:55 PM
_lucifer
!m The MetaBrainz Team :D
2020-12-23 35847, 2020
14:55 PM
BrainzBot
You're doing good work, The MetaBrainz Team :D!
2020-12-23 35811, 2020
14:56 PM
alastairp
ruaok: I have your number too. I didn't know if you still used WA :)
2020-12-23 35836, 2020
14:56 PM
ballin joined the channel
2020-12-23 35858, 2020
14:57 PM
ruaok
I do. Signal, telegram as well.
2020-12-23 35825, 2020
15:00 PM
alastairp
i'll draft a blog post for playlists + recommendations
2020-12-23 35826, 2020
15:04 PM
_lucifer
has anyone tried creating a playlist using the website UI. I am unable to add any tracks. It also shows a HTTP Error at the bottom of the page.
2020-12-23 35806, 2020
15:05 PM
alastairp
I made a playlist but didn't try and add a track
2020-12-23 35816, 2020
15:05 PM
_lucifer
2020-12-23 35823, 2020
15:05 PM
_lucifer
This is the response I get.
2020-12-23 35826, 2020
15:05 PM
alastairp
ah, right
2020-12-23 35837, 2020
15:05 PM
alastairp
ruaok and I made some changes to the API, and I bet we didn't tell Mr_Monkey about it
2020-12-23 35851, 2020
15:05 PM
alastairp
I'll fix it this afternoon
2020-12-23 35859, 2020
15:05 PM
alastairp
thanks for reporting
2020-12-23 35800, 2020
15:50 PM
sumedh joined the channel
2020-12-23 35847, 2020
15:59 PM
_lucifer
alastairp: i looked around the code a bit. Should adding a track require the public field?
2020-12-23 35809, 2020
16:00 PM
_lucifer
That data is probably only required in creating a playlist.
2020-12-23 35816, 2020
16:09 PM
_lucifer
2020-12-23 35841, 2020
16:13 PM
alastairp
_lucifer: yes, right. we need to remove the check when editing a playlist
2020-12-23 35845, 2020
16:13 PM
alastairp
I'm in the middle of this fix now
2020-12-23 35805, 2020
16:14 PM
_lucifer
alastairp: oh, i have the fix ready. just running the tests.
2020-12-23 35816, 2020
16:14 PM
alastairp
how did you do it?
2020-12-23 35838, 2020
16:14 PM
_lucifer
added a `require_public` arg to `validate_playlist`
2020-12-23 35859, 2020
16:14 PM
alastairp
yeah, I thought about that, but I don't think it's a good solution
2020-12-23 35845, 2020
16:16 PM
alastairp
instead we should have 2 types of validators, one which validates the _types_ of parameters if they're set (e.g. checks that public is boolean if it it exists, or checks that title is non-empty if it's set), and a second set of validators for the actual content - e.g. one that checks the required fields for new playlist, and one that checks required fields for editing/adding
2020-12-23 35801, 2020
16:17 PM
alastairp
this will make it easier to modify in the future without adding more parameters
2020-12-23 35831, 2020
16:17 PM
_lucifer
yeah right, that's better.
2020-12-23 35825, 2020
16:18 PM
alastairp
do you want to make those changes?
2020-12-23 35808, 2020
16:19 PM
_lucifer
sure, if you haven't started yet i'll be happy to take that up
2020-12-23 35816, 2020
16:19 PM
alastairp
go for it, thanks!
2020-12-23 35824, 2020
16:20 PM
_lucifer
đź‘Ť
2020-12-23 35848, 2020
17:04 PM
BrainzGit
2020-12-23 35847, 2020
17:05 PM
_lucifer
looks like there is a bug in brainzbot on github, commented the same message 4 times
2020-12-23 35807, 2020
17:06 PM
_lucifer
alastairp: can you check the PR and verify the patch so that the CI can run
2020-12-23 35844, 2020
17:06 PM
alastairp
I approved
2020-12-23 35849, 2020
17:06 PM
_lucifer
I had a few failing tests locally but those seem to be unrelated to changes. probably because my env is not properly set up for the playlist stuff
2020-12-23 35807, 2020
17:07 PM
alastairp
it's not a bug, it's because there are 4 tests, and the bot asks for each of them
2020-12-23 35818, 2020
17:07 PM
alastairp
it's a bit annoying, but I don't think there's much we can do about it
2020-12-23 35833, 2020
17:07 PM
_lucifer
oh ok!
2020-12-23 35827, 2020
17:34 PM
_lucifer
2020-12-23 35853, 2020
17:34 PM
_lucifer
i see that has been the case for earlier builds as well!
2020-12-23 35827, 2020
18:00 PM
BrainzGit
2020-12-23 35829, 2020
18:00 PM
alastairp
yes, I've seen those before. They all appear to be to an external domain, i wonder if it's related to the docker network setup where the tests run, it's something we need to look into
2020-12-23 35829, 2020
18:07 PM
BrainzGit
2020-12-23 35825, 2020
18:15 PM
BrainzGit
2020-12-23 35847, 2020
18:17 PM
v6lur joined the channel
2020-12-23 35817, 2020
19:02 PM
ballin has quit
2020-12-23 35856, 2020
19:16 PM
yef has quit
2020-12-23 35824, 2020
19:50 PM
sumedh has quit
2020-12-23 35805, 2020
19:51 PM
davic joined the channel
2020-12-23 35802, 2020
20:05 PM
Gazooo79494 has quit
2020-12-23 35844, 2020
20:06 PM
Gazooo79494 joined the channel
2020-12-23 35818, 2020
21:37 PM
Nyanko-sensei joined the channel
2020-12-23 35827, 2020
21:41 PM
D4RK-PH0ENiX has quit
2020-12-23 35844, 2020
23:15 PM
v6lur has quit
2020-12-23 35844, 2020
23:20 PM
ruaok
2020-12-23 35820, 2020
23:24 PM
shivam-kapila
Wow playlists feature released
2020-12-23 35835, 2020
23:24 PM
shivam-kapila
A perfect 4 am news :p
2020-12-23 35851, 2020
23:24 PM
shivam-kapila
Congratulations LN team
2020-12-23 35855, 2020
23:24 PM
shivam-kapila
LB*
2020-12-23 35805, 2020
23:25 PM
ruaok
there are still some bugs, but we wanted to get some playlists made for the holidays.
2020-12-23 35814, 2020
23:25 PM
ruaok
(with zero holiday music)
2020-12-23 35837, 2020
23:25 PM
shivam-kapila
But this is a good christmas gift
2020-12-23 35853, 2020
23:25 PM
ruaok
let see what people say.
2020-12-23 35809, 2020
23:26 PM
ruaok
the script to generates playlists is runing now. will run all night I think.
2020-12-23 35804, 2020
23:27 PM
shivam-kapila
Lets see what it gets for us on christmas eve 🤞
