#metabrainz

/

      • SothoTalKer has quit
      • 2021-01-15 01513, 2021

      • iliekcomputers
        IOT chastity belt
      • 2021-01-15 01514, 2021

      • iliekcomputers
        oh boy
      • 2021-01-15 01517, 2021

      • iliekcomputers
        why
      • 2021-01-15 01543, 2021

      • Roan has quit
      • 2021-01-15 01555, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1233 (master…ci-prettier-warn): CI: Make 'prettier' linting warnings instead of error https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-15 01518, 2021

      • devorizon joined the channel
      • 2021-01-15 01555, 2021

      • reosarevok
        I'm still not sure why IOT most things, but this at least I get in theory
      • 2021-01-15 01504, 2021

      • reosarevok
        Although it seems just easier to give the other person the key :p
      • 2021-01-15 01501, 2021

      • devorizon
        hi everyone, i was thinking of now working on the issue lb-535 , is their any other issue you guys want me to work on i would be happy to help.
      • 2021-01-15 01535, 2021

      • devorizon
      • 2021-01-15 01536, 2021

      • BrainzBot
        LB-535: Split the RecentListens component into smaller components
      • 2021-01-15 01559, 2021

      • iliekcomputers
        devorizon: that ticket should be nice to get to. feel free to ping me if you have any questions.
      • 2021-01-15 01545, 2021

      • devorizon
        ok
      • 2021-01-15 01540, 2021

      • v6lur joined the channel
      • 2021-01-15 01536, 2021

      • SothoTalKer joined the channel
      • 2021-01-15 01503, 2021

      • SothoTalKer_ has quit
      • 2021-01-15 01504, 2021

      • sumedh has quit
      • 2021-01-15 01527, 2021

      • Mineo has quit
      • 2021-01-15 01539, 2021

      • Roan joined the channel
      • 2021-01-15 01512, 2021

      • ruaok
        alastairp: you about?
      • 2021-01-15 01532, 2021

      • ruaok
        oh, never mind, I found the correct solution, brainstorming required.
      • 2021-01-15 01518, 2021

      • Mineo joined the channel
      • 2021-01-15 01523, 2021

      • v6lur has quit
      • 2021-01-15 01527, 2021

      • v6lur joined the channel
      • 2021-01-15 01551, 2021

      • travis-ci joined the channel
      • 2021-01-15 01551, 2021

      • travis-ci
        Project bookbrainz-site build #3600: passed in 4 min 27 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-01-15 01552, 2021

      • travis-ci has left the channel
      • 2021-01-15 01526, 2021

      • Roan has quit
      • 2021-01-15 01554, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-15 01505, 2021

      • sumedh joined the channel
      • 2021-01-15 01557, 2021

      • SothoTalKer_ joined the channel
      • 2021-01-15 01556, 2021

      • SothoTalKer has quit
      • 2021-01-15 01504, 2021

      • Rohan_Pillai has quit
      • 2021-01-15 01544, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-15 01552, 2021

      • sumedh has quit
      • 2021-01-15 01500, 2021

      • sumedh joined the channel
      • 2021-01-15 01514, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok closed pull request #1513 (master…MBS-10187): MBS-10187: Fail edits that would result in a gendered group https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-15 01500, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1866 (master…MBS-11327): MBS-11327: Show CAA icons on release search results https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-15 01536, 2021

      • v6lur has quit
      • 2021-01-15 01545, 2021

      • SothoTalKer joined the channel
      • 2021-01-15 01534, 2021

      • SothoTalKer_ has quit
      • 2021-01-15 01516, 2021

      • flamingspinach is now known as fs
      • 2021-01-15 01522, 2021

      • sumedh has quit
      • 2021-01-15 01546, 2021

      • Rohan_Pillai has quit
      • 2021-01-15 01505, 2021

      • v6lur joined the channel
      • 2021-01-15 01525, 2021

      • _lucifer
        alastairp: iirc, docker-compose is not used in production in cb. what's this file for then https://github.com/metabrainz/critiquebrainz/blob… ?
      • 2021-01-15 01551, 2021

      • SothoTalKer_ joined the channel
      • 2021-01-15 01556, 2021

      • SothoTalKer has quit
      • 2021-01-15 01527, 2021

      • alastairp
        _lucifer: at a guess it looks like it runs CB along with a consul server locally to test the consul setup during local development
      • 2021-01-15 01526, 2021

      • alastairp
        we can probably get rid of that stuff, I've never used it and it looks like it's out of date compared to current CB setup anyway
      • 2021-01-15 01538, 2021

      • _lucifer
        makes sense, thanks
      • 2021-01-15 01539, 2021

      • alastairp
        though having said that, it'd be nice to have a setup where we can run the whole prod infrastructure locally for testing. this probably isn't the place to put it though
      • 2021-01-15 01554, 2021

      • v6lur has quit
      • 2021-01-15 01501, 2021

      • Gazooo79494 has quit
      • 2021-01-15 01543, 2021

      • Gazooo79494 joined the channel
      • 2021-01-15 01542, 2021

      • adhi001 has quit
      • 2021-01-15 01516, 2021

      • devorizon has quit
      • 2021-01-15 01532, 2021

      • SothoTalKer joined the channel
      • 2021-01-15 01530, 2021

      • SothoTalKer_ has quit
      • 2021-01-15 01530, 2021

      • zas
        bitmap: around?
      • 2021-01-15 01538, 2021

      • bitmap
        yeah
      • 2021-01-15 01558, 2021

      • zas
        I had a deeper look about registrator and potential alternatives
      • 2021-01-15 01543, 2021

      • zas
        for our use, we could easily use a simple python program to replace it: using existing docker and consul modules, we just need to listen to docker events, parse container's metadata and write proper configs to consul
      • 2021-01-15 01534, 2021

      • zas
        https://github.com/hampsterx/ecs-consul-reg does this (but it doesn't parse env vars SERVICE_*)
      • 2021-01-15 01525, 2021

      • bitmap
        cool. that doesn't look very complex to maintain
      • 2021-01-15 01538, 2021

      • bitmap
        are we going to fork that then?
      • 2021-01-15 01551, 2021

      • zas
      • 2021-01-15 01517, 2021

      • zas
        we could use it as basis, or just start over because actual code is very small
      • 2021-01-15 01525, 2021

      • zas
        it uses docker health checks too
      • 2021-01-15 01556, 2021

      • zas
        but was made specifically for ecs
      • 2021-01-15 01529, 2021

      • zas
      • 2021-01-15 01546, 2021

      • zas
        we don't even use all of registrator features
      • 2021-01-15 01501, 2021

      • zas
        if you look at ecs-consul-reg code, you'll notice it just connect through docker api on one side, and to consul api on the other side
      • 2021-01-15 01508, 2021

      • bitmap
        yeah, our use case is much simpler
      • 2021-01-15 01543, 2021

      • bitmap
        I just didn't know there was an easy way to listen for docker events, that helps a lot
      • 2021-01-15 01516, 2021

      • zas
        yes :)
      • 2021-01-15 01544, 2021

      • zas
        so, what I suggest: we write our own tools to replace git2consul and registrator
      • 2021-01-15 01505, 2021

      • zas
        since both (in our use cases) are pretty simple
      • 2021-01-15 01537, 2021

      • zas
        we'll be still dependent on third-party code (docker/consul modules)
      • 2021-01-15 01552, 2021

      • zas
        but those are more likely to be maintained over the time
      • 2021-01-15 01514, 2021

      • zas
        what do you think?
      • 2021-01-15 01544, 2021

      • bitmap
        that sounds good to me, honestly this will make debugging stuff a lot easier
      • 2021-01-15 01552, 2021

      • zas
        exactly
      • 2021-01-15 01515, 2021

      • zas
        ok, I'll start something soon
      • 2021-01-15 01525, 2021

      • bitmap
        right now I just blame everything on git2consul 'cause it's written in node :P
      • 2021-01-15 01508, 2021

      • bitmap
        great, I can help test them at least
      • 2021-01-15 01533, 2021

      • zas
        ahah ;) nodejs is an easy scapegoat
      • 2021-01-15 01516, 2021

      • zas
      • 2021-01-15 01516, 2021

      • Mineo has quit
      • 2021-01-15 01533, 2021

      • SothoTalKer_ joined the channel
      • 2021-01-15 01536, 2021

      • SothoTalKer has quit
      • 2021-01-15 01515, 2021

      • reg[m] has quit
      • 2021-01-15 01557, 2021

      • MagnusSvensson[m has quit
      • 2021-01-15 01517, 2021

      • reg[m] joined the channel
      • 2021-01-15 01558, 2021

      • zas has quit
      • 2021-01-15 01546, 2021

      • zas joined the channel
      • 2021-01-15 01502, 2021

      • leonh has quit
      • 2021-01-15 01517, 2021

      • MagnusSvensson[m joined the channel
      • 2021-01-15 01510, 2021

      • leonh joined the channel
      • 2021-01-15 01556, 2021

      • reg[m] has quit
      • 2021-01-15 01556, 2021

      • nobodyrocks[m] has quit
      • 2021-01-15 01556, 2021

      • joshuaboniface has quit
      • 2021-01-15 01557, 2021

      • SamThursfield[m] has quit
      • 2021-01-15 01546, 2021

      • Hobbyboy has quit
      • 2021-01-15 01545, 2021

      • kepstin has quit
      • 2021-01-15 01506, 2021

      • Hobbyboy joined the channel
      • 2021-01-15 01526, 2021

      • SamThursfield[m] joined the channel
      • 2021-01-15 01521, 2021

      • nobodyrocks[m] joined the channel
      • 2021-01-15 01553, 2021

      • reg[m] joined the channel
      • 2021-01-15 01501, 2021

      • joshuaboniface joined the channel
      • 2021-01-15 01545, 2021

      • ljunkie has quit
      • 2021-01-15 01552, 2021

      • heyoni_ has quit
      • 2021-01-15 01552, 2021

      • lks_ has quit
      • 2021-01-15 01552, 2021

      • ^arcade_droid has quit
      • 2021-01-15 01500, 2021

      • lks joined the channel
      • 2021-01-15 01516, 2021

      • arcade_droid joined the channel
      • 2021-01-15 01519, 2021

      • kepstin joined the channel
      • 2021-01-15 01509, 2021

      • heyoni joined the channel
      • 2021-01-15 01551, 2021

      • ljunkie joined the channel
      • 2021-01-15 01546, 2021

      • SothoTalKer joined the channel
      • 2021-01-15 01537, 2021

      • SothoTalKer_ has quit