#metabrainz

/

      • grimler32 has quit
      • 2021-01-19 01947, 2021

      • D4RK-PH0_ has quit
      • 2021-01-19 01929, 2021

      • Nyanko-sensei joined the channel
      • 2021-01-19 01915, 2021

      • Chinmay3199 has quit
      • 2021-01-19 01926, 2021

      • BrainzGit
        [musicbrainz-android] akshaaatt closed pull request #63 (master…dev): Fixed: API Level 30 Migrations https://github.com/metabrainz/musicbrainz-android…
      • 2021-01-19 01933, 2021

      • BrainzGit
        [musicbrainz-android] akshaaatt reopened pull request #63 (master…dev): Fixed: API Level 30 Migrations https://github.com/metabrainz/musicbrainz-android…
      • 2021-01-19 01954, 2021

      • devorizon[m] joined the channel
      • 2021-01-19 01912, 2021

      • BrainzGit
        [listenbrainz-server] jdaok opened pull request #1242 (master…iterativeAPIService): [LB-516] Rewrite the APIService retries to be iterative https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01902, 2021

      • diru1100 has quit
      • 2021-01-19 01945, 2021

      • sumedh joined the channel
      • 2021-01-19 01935, 2021

      • CatQuest
        hope that time travler dude fond what he was looking for
      • 2021-01-19 01940, 2021

      • CatQuest
        found*
      • 2021-01-19 01947, 2021

      • CatQuest
        whatever it was
      • 2021-01-19 01930, 2021

      • D4RK-PH0_ joined the channel
      • 2021-01-19 01919, 2021

      • d4rkie has quit
      • 2021-01-19 01932, 2021

      • diru1100 joined the channel
      • 2021-01-19 01952, 2021

      • diru1100
        Afternoon!!
      • 2021-01-19 01912, 2021

      • yvanzo
        Good afternoon diru1100!
      • 2021-01-19 01901, 2021

      • CatQuest
        good after nood from morning norway :D
      • 2021-01-19 01939, 2021

      • shivam-kapila
        Good afternoon
      • 2021-01-19 01921, 2021

      • antlarr2 is now known as antlarr
      • 2021-01-19 01948, 2021

      • culinko joined the channel
      • 2021-01-19 01939, 2021

      • Darkloke joined the channel
      • 2021-01-19 01910, 2021

      • Chinmay3199 joined the channel
      • 2021-01-19 01902, 2021

      • Gazooo79494 has quit
      • 2021-01-19 01949, 2021

      • Gazooo79494 joined the channel
      • 2021-01-19 01925, 2021

      • sumedh has quit
      • 2021-01-19 01958, 2021

      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1243 (master…remove-unused-nginx): Remove unused nginx docker configuration https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01905, 2021

      • sumedh joined the channel
      • 2021-01-19 01914, 2021

      • BrainzGit
        [listenbrainz-server] r0han22 opened pull request #1244 (master…master): LB-509: Instructions to run on port other than 80 https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01951, 2021

      • sumedh has quit
      • 2021-01-19 01930, 2021

      • alastairp
        hello
      • 2021-01-19 01954, 2021

      • alastairp
        ruaok: mmm, you might be right about twitter emails. It seems that you can configure _push_ notifications to choose that you only want to receive notifications for certain actions (mention, reply, like), but for emails it seems like it's all or nothing (including things like 'new user followed you')
      • 2021-01-19 01915, 2021

      • alastairp
        I turned off as many items as I can. maybe we just turn it on for a week or so and see what happens?
      • 2021-01-19 01956, 2021

      • sumedh joined the channel
      • 2021-01-19 01916, 2021

      • Etua joined the channel
      • 2021-01-19 01952, 2021

      • ruaok
        or we build a twitter account filter, where all the messages are sent to, then filtered and sent to a google group where everything who wants to be in the known can sub.
      • 2021-01-19 01905, 2021

      • sumedh has quit
      • 2021-01-19 01926, 2021

      • sumedh joined the channel
      • 2021-01-19 01946, 2021

      • sumedh has quit
      • 2021-01-19 01946, 2021

      • ljunkie has quit
      • 2021-01-19 01947, 2021

      • ephemer0l_ has quit
      • 2021-01-19 01922, 2021

      • ljunkie joined the channel
      • 2021-01-19 01929, 2021

      • sumedh joined the channel
      • 2021-01-19 01941, 2021

      • ephemer0l_ joined the channel
      • 2021-01-19 01924, 2021

      • Darkloke has quit
      • 2021-01-19 01903, 2021

      • BestSteve has quit
      • 2021-01-19 01933, 2021

      • BestSteve joined the channel
      • 2021-01-19 01939, 2021

      • culinko_ joined the channel
      • 2021-01-19 01916, 2021

      • culinko has quit
      • 2021-01-19 01903, 2021

      • Mr_Monkey
        ruaok: Hi! I'm looking at LB playlists, specifically LB-787.
      • 2021-01-19 01903, 2021

      • Mr_Monkey
        My gut instinct is that a playlist's collaborators shouldn't be copied at all when copying a playlist. Can you think of a reason why we would want to keep the collaborators as-is when copying?
      • 2021-01-19 01904, 2021

      • BrainzBot
        LB-787: Duplicating a playlist also copies collaborators https://tickets.metabrainz.org/browse/LB-787
      • 2021-01-19 01933, 2021

      • ruaok
        not really.
      • 2021-01-19 01955, 2021

      • ruaok
        google docs has a "share with the same people" options for cloning docs.
      • 2021-01-19 01908, 2021

      • ruaok
        that is one way to do it, but I dont see it as necessary
      • 2021-01-19 01946, 2021

      • Mr_Monkey
        I don't either. Perhaps we can implement that mechanism if we get user requests or we find a good reason to.
      • 2021-01-19 01954, 2021

      • ruaok
        +1
      • 2021-01-19 01928, 2021

      • Mr_Monkey
        Thanks !
      • 2021-01-19 01901, 2021

      • Mr_Monkey
        (Much easier for my python level too :p )
      • 2021-01-19 01945, 2021

      • ruaok
        heh. ;)
      • 2021-01-19 01921, 2021

      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1245 (master…skip-test): Skip randomly failing test until we can fix it https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01919, 2021

      • BrainzGit
        [metabrainz.org] mayhem opened pull request #349 (master…baseimage-upgrade): Upgrade base image, thus python and therefor a bunch of dependencies.… https://github.com/metabrainz/metabrainz.org/pull…
      • 2021-01-19 01950, 2021

      • ruaok
        alastairp: shall we do a quick counter-review on these PRs?
      • 2021-01-19 01956, 2021

      • alastairp
        sure thing
      • 2021-01-19 01950, 2021

      • ruaok
        alastairp: no tags. I'll pin to a commit.
      • 2021-01-19 01917, 2021

      • alastairp
        that's fine
      • 2021-01-19 01944, 2021

      • alastairp
        would you like me to build and test the site? I assume that you got it building, and you got it running
      • 2021-01-19 01926, 2021

      • ruaok
        shouldn't be needed -- I do have it running. I'll test deploy to test.mb.org before pushing to prod
      • 2021-01-19 01919, 2021

      • ruaok
        pinned version pushed.
      • 2021-01-19 01919, 2021

      • alastairp
        when I run develop.sh I get an error
      • 2021-01-19 01926, 2021

      • alastairp
        > ModuleNotFoundError: No module named 'flask_uploads'
      • 2021-01-19 01938, 2021

      • alastairp
        not sure if something is a bit different here? Shouldn't be
      • 2021-01-19 01921, 2021

      • ruaok
        https://test.metabrainz.org runs fine and uploads logos fine.
      • 2021-01-19 01942, 2021

      • alastairp
        weiiird
      • 2021-01-19 01952, 2021

      • BrainzGit
        [metabrainz.org] mayhem merged pull request #349 (master…baseimage-upgrade): Upgrade base image, thus python and therefor a bunch of dependencies.… https://github.com/metabrainz/metabrainz.org/pull…
      • 2021-01-19 01933, 2021

      • ruaok
        deployed.
      • 2021-01-19 01918, 2021

      • alastairp
        sweet, so now we can stop maintaining the 3.6-1 python image. that's great
      • 2021-01-19 01940, 2021

      • alastairp
        in fact, LB is on 3.8 and CB is on 3.8, so we might even have migrated off 3.6 completely
      • 2021-01-19 01948, 2021

      • alastairp
        LB is on 3.7
      • 2021-01-19 01914, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01939, 2021

      • Rohan_Pillai has quit
      • 2021-01-19 01918, 2021

      • Etua has quit
      • 2021-01-19 01916, 2021

      • v6lur_ joined the channel
      • 2021-01-19 01945, 2021

      • Sophist-UK has quit
      • 2021-01-19 01946, 2021

      • Sophist_UK joined the channel
      • 2021-01-19 01936, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1869 (master…MBS-11337): MBS-11337: Prioritize link to URL page on URL reports https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-19 01955, 2021

      • alastairp
        Mr_Monkey: even after airing the kitchen all morning it still smells of citra
      • 2021-01-19 01904, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01939, 2021

      • v6lur_ has quit
      • 2021-01-19 01929, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1870 (master…MBS-11336): MBS-11336: Don't show ended rels in DeprecatedRelationshipURL https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-19 01901, 2021

      • Mr_Monkey
        alastairp: Yum! :p
      • 2021-01-19 01919, 2021

      • d4rkie joined the channel
      • 2021-01-19 01926, 2021

      • D4RK-PH0_ has quit
      • 2021-01-19 01917, 2021

      • Rohan_Pillai has quit
      • 2021-01-19 01926, 2021

      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1246 (master…cron-user): Add username to system crontab files https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01919, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1243 (master…remove-unused-nginx): Remove unused nginx docker configuration https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01946, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1247 (master…playlist-copy-fixes): Don't allow playlist owner to be collaborator https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01946, 2021

      • alastairp
        github is having some problems at the moment, PRs are taking ~5 minutes to close after merging
      • 2021-01-19 01932, 2021

      • Chinmay3199 has quit
      • 2021-01-19 01902, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1871 (master…MBS-11335): MBS-11335: Report for reused Wikidata items https://github.com/metabrainz/musicbrainz-server/…
      • 2021-01-19 01933, 2021

      • ruaok
        alastairp: https://github.com/metabrainz/listenbrainz-server… is nothing more than adding usernames, right? no need to examine the PR more closely than that?
      • 2021-01-19 01905, 2021

      • alastairp
        ruaok: yes, it only added the extra column
      • 2021-01-19 01911, 2021

      • ruaok
        k
      • 2021-01-19 01930, 2021

      • alastairp
        however, it'd be good to have someone else look over it to make sure I didn't miss a line, or miss a space between columns
      • 2021-01-19 01954, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1245 (master…skip-test): Skip randomly failing test until we can fix it https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01926, 2021

      • ruaok
        I see no problems.
      • 2021-01-19 01903, 2021

      • alastairp
        nice
      • 2021-01-19 01957, 2021

      • BrainzGit
        [listenbrainz-server] alastair opened pull request #1248 (master…coverage-on-failure): Don't run coverage if tests fail https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01939, 2021

      • alastairp
        OK, that wasn't in my plan for today, but every time I tried to add a new function to the consul PR I saw another small niggle
      • 2021-01-19 01957, 2021

      • alastairp
        lots of small improvements here
      • 2021-01-19 01902, 2021

      • alastairp
        one more thing that I'd like to do is combine all of the spark-specific scripts and configs in ./docker into a `spark` subfolder, but I'm not sure exactly what each one is used for and it's possible that some can be removed. Maybe someone else can take a look at that.
      • 2021-01-19 01935, 2021

      • ruaok
        gah. I've been trying to get started on my own work since 11am.
      • 2021-01-19 01904, 2021

      • ruaok
        but I keep getting interrupted all the time. sigh.
      • 2021-01-19 01954, 2021

      • alastairp
        yep, I know that feeling
      • 2021-01-19 01931, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1248 (master…coverage-on-failure): Don't run coverage if tests fail https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01932, 2021

      • BrainzGit
        [listenbrainz-server] alastair merged pull request #1246 (master…cron-user): Add username to system crontab files https://github.com/metabrainz/listenbrainz-server…
      • 2021-01-19 01932, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01955, 2021

      • CatQuest
      • 2021-01-19 01924, 2021

      • sumedh has quit
      • 2021-01-19 01915, 2021

      • Sophist_UK
        Done.
      • 2021-01-19 01914, 2021

      • sumedh joined the channel
      • 2021-01-19 01901, 2021

      • yvanzo
        bitmap, reosarevok: when you have a bit of time, can you please review the new search dev doc page?
      • 2021-01-19 01931, 2021

      • Rohan_Pillai has quit
      • 2021-01-19 01958, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01910, 2021

      • culinko joined the channel
      • 2021-01-19 01929, 2021

      • culinko_ has quit
      • 2021-01-19 01934, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo opened pull request #183 (master…drop-default-port): MBVM-65: Drop port numbers 80 and 443 from base URL https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-01-19 01945, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #546 (master…webpack5): Migrate to Webpack 5 and improve bundle size https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-01-19 01947, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #547 (master…show-new-entity-name-in-relationships): feat(relationships): Show new entity name in relationship editor https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-01-19 01911, 2021

      • Rohan_Pillai has quit
      • 2021-01-19 01938, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01935, 2021

      • Etua joined the channel
      • 2021-01-19 01900, 2021

      • sumedh has quit
      • 2021-01-19 01933, 2021

      • travis-ci joined the channel
      • 2021-01-19 01934, 2021

      • travis-ci
        Project bookbrainz-site build #3606: passed in 5 min 10 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-01-19 01934, 2021

      • travis-ci has left the channel
      • 2021-01-19 01916, 2021

      • Rohan_Pillai has quit
      • 2021-01-19 01958, 2021

      • sumedh joined the channel
      • 2021-01-19 01929, 2021

      • reosarevok
        yvanzo: for https://github.com/metabrainz/musicbrainz-server/… - are you thinking of just having a separate check in cleanURL for decoda or something? Or have a separate list in the same file as URL_SHORTENERS for blacklisted domains?
      • 2021-01-19 01938, 2021

      • Rohan_Pillai joined the channel
      • 2021-01-19 01913, 2021

      • reosarevok
      • 2021-01-19 01914, 2021

      • reosarevok
        ?
      • 2021-01-19 01928, 2021

      • reosarevok
        Seems sensible enough to me, but do confirm
      • 2021-01-19 01947, 2021

      • yvanzo
        reosarevok: cleanURL should probably do? there already are rules for some unwanted links IIRC.
      • 2021-01-19 01930, 2021

      • reosarevok
        Not that I can see. Not site-wide anyway
      • 2021-01-19 01955, 2021

      • reosarevok
        The closest I can see is the URL shortener code
      • 2021-01-19 01924, 2021

      • BrainzGit
        [musicbrainz-docker] yvanzo merged pull request #183 (master…drop-default-port): MBVM-65: Drop port numbers 80 and 443 from base URL https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-01-19 01944, 2021

      • reosarevok
        yvanzo: Also, https://github.com/metabrainz/musicbrainz-server/… is not really what causes a difference, right? What you want me to not change is actually https://github.com/metabrainz/musicbrainz-server/… right?
      • 2021-01-19 01937, 2021

      • yvanzo
        reosarevok: yes but then you should probably remove lib/MusicBrainz/Server/Entity/URL/Decoda.pm too.