[listenbrainz-server] mayhem merged pull request #1086 (master…LB-686-user-information-cleanup): LB-686 Cleaned up a variety of user information pages https://github.com/metabrainz/listenbrainz-server…
2021-01-20 02037, 2021
iliekcomputers
nope, nothing else.
2021-01-20 02058, 2021
ruaok
pristine___: remind me, for the rec-component PR that was just merged, were there DB changes that needed to go with the release?
2021-01-20 02004, 2021
ruaok
or are those already in place?
2021-01-20 02029, 2021
ruaok
zas: your comment on the PR raises an issue I don't really like about this solution.
2021-01-20 02058, 2021
ruaok
the services that run on gaga are not somewhat dependent on or possibly slowed down by consul being up and responding.
2021-01-20 02034, 2021
ruaok
can we imagine a case where consul might not be up, but we want to start services anyway? perhaps so they become ready when consul comes up?
2021-01-20 02051, 2021
ruaok
I just don't really like how to handle this stuff. its not very nice at all. :(
2021-01-20 02008, 2021
zas
I'd say if consul is down, something very bad is happening, and starting services will not be our priority
2021-01-20 02021, 2021
zas
consul is a cluster, and almost all services depends on it
2021-01-20 02040, 2021
ruaok
yeah, I just feels like we're opening the door for another failure mode.
2021-01-20 02050, 2021
ruaok
what other options do we have for solving this?
2021-01-20 02057, 2021
zas
solve what?
2021-01-20 02000, 2021
ruaok
I mean, I don't care about the key. really, I don't.
2021-01-20 02025, 2021
zas
but this solution is ok, just be sure curl doesn't fail
2021-01-20 02026, 2021
devorizon[m]
hi iliekcomputers: this is about PR #1238 about lb-535, i want to disscuss about this issue, about what changes we can do here?
2021-01-20 02048, 2021
ruaok
and what do I do if it does fail?
2021-01-20 02007, 2021
zas
just bail out, as you expect a key you didn't get
2021-01-20 02016, 2021
ruaok
and not start the other services?
2021-01-20 02031, 2021
ruaok
or don't start typesense and start everything else?
2021-01-20 02033, 2021
zas
well, if this command fails ... something is wrong
2021-01-20 02058, 2021
ruaok
I think I will make it so that everything but typesense starts.
2021-01-20 02016, 2021
ruaok
if the key cannot be fetched from consul.
2021-01-20 02016, 2021
zas
yes, makes sense since only typesense depends on this key
2021-01-20 02024, 2021
ruaok
k
2021-01-20 02024, 2021
Mr_Monkey
ruaok: about that javascript test suite, looks like all the tests pass but the linting step that runs afterwards is shitting itself and erroring. I'll look into it.
2021-01-20 02054, 2021
ruaok
thanks, Mr_Monkey
2021-01-20 02022, 2021
zas
bitmap: ping me when you're around, I need a second sight on serviceregistrator stuff
2021-01-20 02021, 2021
ruaok
wow, its been over 4 years since we moved to hetzner. I'm happy with our decisions.
zas: hey, I had a look at barman williams, don't think I see any issue with the backups
2021-01-20 02046, 2021
shivam-kapila
25. Like we do for listens
2021-01-20 02003, 2021
bitmap
there's one from jan 10 & one from jan 17, both take up around ~200 gb
2021-01-20 02021, 2021
bitmap
we could reduce the retention duration or limit it to 1 backup if you think that's fine
2021-01-20 02052, 2021
zas
well, I think a better approach would be to move ftp storage elsewhere as discussed previously
2021-01-20 02047, 2021
zas
I'll see how we can use a storage box and a mounted volume
2021-01-20 02005, 2021
zas
I made progress on serviceregistrator, not yet happy with code, but features are there, and everything is reading for using consul api
2021-01-20 02048, 2021
zas
s/reading/ready/
2021-01-20 02042, 2021
reosarevok
bitmap, yvanzo: anything you wanna check in an hourish?
2021-01-20 02026, 2021
reosarevok
We could check yvanzo's new search docs together, if you want :)
2021-01-20 02054, 2021
Shivam joined the channel
2021-01-20 02017, 2021
yvanzo
+1
2021-01-20 02015, 2021
bitmap
sounds good, I was reading it yseterday but only got halfway
2021-01-20 02026, 2021
bitmap
there are probably some PRs I can look at too
2021-01-20 02024, 2021
yvanzo
yup, would be nice to be able to update beta after that.
2021-01-20 02005, 2021
yvanzo
reosarevok, bitmap: does moving /artist-credit/… to /artist/…/credit/… makes sense for you?
2021-01-20 02033, 2021
reosarevok
I personally don't like it because it makes it seem like the artist is more relevant to the credit than others
2021-01-20 02044, 2021
reosarevok
(while in reality all artists are equally important)
2021-01-20 02008, 2021
reosarevok
But if it's important to avoid pointing to artist-credit/rowid, then we could
2021-01-20 02018, 2021
yvanzo
Of course, there will be more than one URL to access an artist-credit shared by more than one artist.
2021-01-20 02038, 2021
bitmap
what are the … in /artist/…/credit/… ?
2021-01-20 02050, 2021
yvanzo
But the main issue it would address it to not create dead links.
2021-01-20 02052, 2021
bitmap
artist mbid and artist credit id?
2021-01-20 02055, 2021
yvanzo
yes
2021-01-20 02035, 2021
yvanzo
the new page /artist-credit/<id> is merged but still in master
2021-01-20 02052, 2021
yvanzo
the editing page /artist/<mbid>/credit/<id/edit already exists
2021-01-20 02023, 2021
bitmap
/artist-credit/ makes more sense to me but yeah, the editing page is inconsistent
2021-01-20 02035, 2021
reosarevok
I'm just not sure if redirecting someone to artist X if they try to reach artist credit Y is right
2021-01-20 02054, 2021
reosarevok
If we remove one recording for an artist, we don't redirect to the artist
2021-01-20 02054, 2021
yvanzo
Artist-credits are volatile, having public URLs based on their IDs will quickly create a bunch of dead links.
2021-01-20 02042, 2021
bitmap
I agree I wouldn't expect a dead AC link to redirect to an artist though. maybe if it was a single artist AC, but even then
2021-01-20 02056, 2021
yvanzo
reosarevok: If we merge the recording, it redirects to the target recording. We don’t have merge/redirect for artist credits.
2021-01-20 02000, 2021
reosarevok
Do we remove unused ACs from the table?
2021-01-20 02022, 2021
reosarevok
Or do they stay behind without uses and get picked up again if the same credits are used?
2021-01-20 02027, 2021
yvanzo
Good question, not sure.
2021-01-20 02048, 2021
bitmap
yes
2021-01-20 02011, 2021
bitmap
(yes they're removed)
2021-01-20 02043, 2021
reosarevok
Ok
2021-01-20 02001, 2021
reosarevok
"This artist credit no longer exists" is a perfectly legitimate answer to an old link IMO
2021-01-20 02006, 2021
reosarevok
But YMMV
2021-01-20 02017, 2021
reosarevok busy for a bit, back in 30 min or so
2021-01-20 02021, 2021
yvanzo
Redirecting to one of the credited artists’s aliases page isn't ideal, but it's better than just not found.
2021-01-20 02046, 2021
kepstin
i didn't even know you could link to an artist credit
2021-01-20 02057, 2021
yvanzo
It's not available in beta yet.
2021-01-20 02021, 2021
kepstin
are artist credits getting mbids?
2021-01-20 02057, 2021
yvanzo
no
2021-01-20 02030, 2021
kepstin
in general, it seems like anything that we expect to be maintaining "permanent" links for should have mbids, and things that are more ethereal don't get them.
2021-01-20 02044, 2021
yvanzo
just dedicated pages so that one can see all usages about it, see MBS-4548
(actually, the ticket is not up-to-date and does not explain how it is implemented.
2021-01-20 02007, 2021
yvanzo
kepstin: yes and no, edits for example.
2021-01-20 02027, 2021
Shivam
Hello everyone! I am Shivam Awasthi, second year EE Undergrad at IIT BHU, India.
2021-01-20 02028, 2021
Shivam
I overviewed the project ideas list for BookBrainz and ‘Designing and implementing a unified creation form’ looks pretty interesting to me.
2021-01-20 02028, 2021
Shivam
I am familiar with React, NodeJS and am looking forward to try my hands on this project.
2021-01-20 02029, 2021
Shivam
I look forward to guidance on what can I potentially learn and contribute to .
2021-01-20 02038, 2021
sumedh has quit
2021-01-20 02043, 2021
bitmap
kepstin: +1 though, ultimately I'd prefer adding mbids + merging to artist credits
2021-01-20 02000, 2021
Mr_Monkey
Welcome Shivam !
2021-01-20 02028, 2021
yvanzo
If I’m not missing something, here is currently no URL with non-permanent ID available from MB website.
2021-01-20 02012, 2021
yvanzo
bitmap: that could be interesting but it probably requires a schema change.
2021-01-20 02014, 2021
kepstin
it might make sense to put the artist credit viewing page under /artist/{mbid}/credit/{id} just so that it has a permanent id in the url that could be used in an error page or redirect even if the ac goes missing.
2021-01-20 02043, 2021
kepstin
obviously if there's multiple artists in an ac, the same ac will appear in multiple artist pages, but that might be ok?
